On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator <revi...@reviews.llvm.org> wrote: > > dblaikie added a comment. > > In D89500#2344234 <https://reviews.llvm.org/D89500#2344234>, @davezarzycki > wrote: > > > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > > <https://reviews.llvm.org/rG87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9> > > Thanks - if that's unblocked you, great! > > @tmsriram could you check on this? I'm surprised this test isn't failing - I > can't see any CHECK lines for the "ERROR" prefix used by the error test (& > FileCheck usually fails if it finds no relevant CHECK lines... so I'm not > sure what's happening there). > > Also: I'd expect a failing compilation not to write the file out? (I'd expect > it to be writing to a temporary file, then moving the file into position once > the compilation has finished successfully, so there's never a half-written > file, etc - in case the compiler crashes) so I wonder what's going on here. > Could you check what the behavior is/why it's trying to write a file even > when there's an error? (I could be wrong on my assumptions/understanding here > - perhaps this is true of other error paths too, that they do try to write > the output file and maybe delete it after instead (though that wouldn't be > crash-resilient))
Taking a look right now. > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D89500/new/ > > https://reviews.llvm.org/D89500 > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
