akyrtzi added inline comments.
Herald added a subscriber: dexonsmith.

================
Comment at: clang/include/clang-c/Index.h:2057
+   */
+  CXCursor_CXXAddrspaceCastExpr = 129,
+
----------------
Hi Anastasia, apologies for not catching this earlier, but libclang is intended 
to keep a stable ABI and changing the enumerator values breaks libclang's ABI 
compatibility.

Would you be able to make a follow-up commit and restore the enumerator values 
to their original values? I would suggest to add 
`CXCursor_CXXAddrspaceCastExpr` at the end and assign to it the next available 
value that is not already taken.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60193/new/

https://reviews.llvm.org/D60193

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to