[Differential] [Request, 1,012 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek created this revision. staniek added a subscriber: Calligra-Devel-list. TEST PLAN build REPOSITORY rCALLIGRA Calligra BRANCH master REVISION DETAIL https://phabricator.kde.org/D360 AFFECTED FILES libs/widgets/CMakeLists.txt libs/widgets/KoFileDialog.cpp libs/widgets/KoFil

[Differential] [Updated] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek updated the summary for this revision. staniek added reviewers: kossebau, rempt. staniek added a project: Calligra: 3.0. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Request, 301 lines] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods

staniek created this revision. staniek added a reviewer: rempt. staniek added a subscriber: Calligra-Devel-list. REVISION SUMMARY It's the same code performance-wise TEST PLAN build REPOSITORY rCALLIGRA Calligra BRANCH master REVISION DETAIL https://phabricator.kde.org/D361 AFFECTED

[Differential] [Updated] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods

staniek added a reviewer: kossebau. staniek added projects: Krita: Next, Calligra: 3.0. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D361 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, rempt, kossebau Cc: Calligra-D

[Differential] [Request, 162 lines] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek created this revision. staniek added reviewers: kossebau, rempt. staniek added a subscriber: Calligra-Devel-list. REVISION SUMMARY This helps to build single apps without having full KF5, e.g. Windows * X11 -> only try to find on !win32 and !mac * Qt5: ** Sql -> sheets ** X

[Differential] [Updated] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek added projects: Calligra: 3.0, Kexi: Porting to Qt 5, Krita: Next. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D362 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt Cc: Calligra-Devel-list, wi

[Differential] [Updated] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods

staniek added a reviewer: abrahams. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D361 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt, abrahams Cc: Calligra-Devel-list

[Differential] [Commented On] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek added a comment. In https://phabricator.kde.org/D362#7062, @kossebau wrote: > Hm, moving checking for required packages into the subdirs and thus after > calculating which products can be built or, if internal dep, should be built > breaks the concept of the current productset system. S

[Differential] [Commented On] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek added a comment. In https://phabricator.kde.org/D360#7068, @kossebau wrote: > Issue in any case: this patch misses to also move the test app, > filedialogtester. > > Then I wonder if we could first come up with a definition what the purpose of > kowidgets and kowidgetutils is. And if pe

[Differential] [Accepted] D364: Move KoFindToolbar to Words, it's only user

staniek accepted this revision. staniek added a reviewer: staniek. This revision is now accepted and ready to land. REPOSITORY rCALLIGRA Calligra BRANCH moveKoFindToolbar REVISION DETAIL https://phabricator.kde.org/D364 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Updated, 463 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek updated this revision to Diff 896. staniek added a comment. - KoFileDialog rather belongs to kowidgetutils than kowidgets Updating D360: KoFileDialog rather belongs to kowidgetutils than kowidgets == This way apps ca

[Differential] [Updated, 2,557 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek updated the summary for this revision. staniek removed rCALLIGRA Calligra as the repository for this revision. staniek updated this revision to Diff 897. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D360?vs=896&id=897 REVISION DETAIL https://phabricator.kde.org/D360 AFFECTED

[Differential] [Commented On] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek added a comment. In https://phabricator.kde.org/D360#7104, @kossebau wrote: > While moving filedialogtester, could you please move it into the subdir > tests/, so the normal dir only contains product code? OK, I wanted to propose that. > As you just moved the KoFileDialog class files

[Differential] [Updated, 2,557 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek updated the summary for this revision. staniek set the repository for this revision to rCALLIGRA Calligra. staniek updated this revision to Diff 900. staniek added a comment. - move to tests/ subdir - remove main.cpp which is too general file, place main() in KoFileDialogTester.cpp - by t

[Differential] [Updated, 2,548 lines] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek removed rCALLIGRA Calligra as the repository for this revision. staniek updated this revision to Diff 901. staniek added a comment. proper final (?) patch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D360?vs=900&id=901 REVISION DETAIL https://phabricator.kde.org/D360 AFFEC

[Differential] [Updated] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek marked an inline comment as done. staniek added a comment. In https://phabricator.kde.org/D360#7130, @kossebau wrote: > Not sure I would have moved the main.cpp into the other file, but there is no > policy in Calligra about such utils apps, so if you prefer it like that, keep > it as y

[Differential] [Closed] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRA33aa31e168de: KoFileDialog rather belongs to kowidgetutils than kowidgets (authored by staniek). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D360?vs=901&id=908#toc REPOSITORY rCALLIGRA

[Differential] [Closed] D361: KoColorConversionTransformation: msvc can't export static data, change it to inline static methods

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRAa6a6bd25f3ae: KoColorConversionTransformation: msvc can't export static data, change it to… (authored by staniek). REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Commented On] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek added a comment. So I am keeping this privately for now. @kossebau I am wondering if we can we have equivalent behaviour on top level using calligra_drop_product_on_bad_condition(). REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D362 EMAIL PREFERENCES

Re: Review Request 125649: [OS X] install icon resources in app bundles where this doesn't happen automatically

x27;s ported to calligra master (3.0)? Otherwise we'd loose the fixes. - Jarosław Staniek On Oct. 15, 2015, 10:55 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To re

[Differential] [Abandoned] D362: Modularity++: Move find_package() to places where they belong, make other optional

staniek abandoned this revision. staniek added a comment. Abandoning: Kexi moved to kexi.git REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D362 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt Cc: and

Re: Review Request 123941: Get the example to show data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123941/#review91126 --- Ship it! I think it's pushed already? - Jarosław St

Re: Review Request 117035: Kexi quickform QML plugin

and keep the idea and old code around. QQ1 is dead... - Jarosław Staniek On March 24, 2014, 10:44 p.m., Adam Pigg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117035: Kexi quickform QML plugin

> On Jan. 15, 2016, 8:59 a.m., Jarosław Staniek wrote: > > The idea is great and valid. > > > > I propose to drop this patch and keep the idea and old code around. QQ1 is > > dead... > > Adam Pigg wrote: > a rewrite is partf my sailfish master plan T

Re: Review Request 123699: Changed a few labels in kexi's forms and reports designers

> On May 9, 2015, 8:29 p.m., Jarosław Staniek wrote: > > kexi/plugins/forms/kexiformmanager.cpp, line 394 > > <https://git.reviewboard.kde.org/r/123699/diff/1/?file=367937#file367937line394> > > > > While we're at this, I also recommend to change \"

Re: Review Request 123699: Changed a few labels in kexi's forms and reports designers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123699/#review91165 --- Ship it! Ship It! - Jarosław Staniek On May 9, 2015, 1

Re: Review Request 123659: Align lines in tabular view

> On May 7, 2015, 9:51 p.m., Jarosław Staniek wrote: > > Nice, what's this stype? > > Tested this: > > Breeze: off by 1 pixel http://i.imgur.com/NVNExKS.png > > Oxygen: off by 2 pixels > > Cleanlooks, Windows, GTK+: off by 1 pixel > > Bespin: pe

Re: Review Request 123659: Align lines in tabular view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123659/#review91167 --- Pushed to 3.0, let's not push to 2.9. - Jarosław St

Re: Review Request 122153: KD Chart

? - Jarosław Staniek On Dec. 3, 2015, 8:58 a.m., Stephen Leibowitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Maniphest] [Changed Subscribers] T665: Show default (empty) document on startup in document-based Calligra apps

staniek added a subscriber: Calligra-Devel-list. TASK DETAIL https://phabricator.kde.org/T665 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek Cc: Calligra-Devel-list, staniek ___ calligra-devel mailing lis

Re: Review Request 126797: Add kexi.git build with deps

26797/diff/ Testing --- no Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 126797: Add kexi.git build with deps

x27;s deps Diffs - dependency-data-kf5-minimum 95dad0d dependency-data-kf5-qt5 3856fe3 logical-module-structure 061ca5f Diff: https://git.reviewboard.kde.org/r/126797/diff/ Testing --- no Thanks, Jarosław Staniek ___ calligra-

[Maniphest] [Commented On] T665: Show default (empty) document on startup in document-based Calligra apps

staniek added a comment. In https://phabricator.kde.org/T665#15282, @kossebau wrote: > Would it be a good idea to have UI/UX experts look at this as well? Yes, though it would be unfortunate to repeat this -- "they" apparently did: ​ ​for StarOffice, OO.org, LO , and MS Office at least :) > B

[Maniphest] [Commented On] T665: Show default (empty) document on startup in document-based Calligra apps

staniek added a comment. I imagine this motto: **Make simple, familiar things easy, awesome complicated things -- possible.** In my opinion for now we're more heading towards the latter what is a major mistake. We have the code, design and all toys. The latter part is possible to have to meet

[Differential] [Updated] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

staniek added reviewers: kossebau, rempt, boemann, aspotashev. staniek added a subscriber: Calligra-Devel-list. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D1032 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kosse

Re: Review Request 127347: Fix build with glibc >= 2.23 by using std namespace

tps://git.reviewboard.kde.org/r/127347/#comment63684> I propose that you remove the ifdef completely and also don't use cmath; instead use qIsNaN(). We use it in a few places already. - Jarosław Staniek On March 11, 2016, 10:05 p.m., Heiko B

Re: Review Request 127347: Fix build with glibc >= 2.23 by using qIsNaN

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127347/#review93426 --- Ship it! Ship It! - Jarosław Staniek On March 12, 2016

[Differential] [Closed] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRA68ac8207a9cf: Make KUndo2Stack::push return false if the command was merged (and deleted)… (authored by staniek). REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kd

[Differential] [Commented On] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

staniek added a comment. In https://phabricator.kde.org/D1032#23331, @aspotashev wrote: > Looks good to me. > > P.S. We probably need to share the kundo2 library between Kexi, Krita and Calligra. Thanks Alexander. Yes, this, or we would replace with Qt5 if there's equivalent

[Differential] [Updated] D2577: KoResourcePaths: Fix handling of wildcards in directories and files

staniek added a reviewer: Calligra-Devel-list. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D2577 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: danders, #calligra:_3.0, Calligra-Devel-list Cc: staniek

[Differential] [Requested Changes To] D2577: KoResourcePaths: Fix handling of wildcards in directories and files

staniek requested changes to this revision. staniek added a reviewer: staniek. This revision now requires changes to proceed. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D2577 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D2577: KoResourcePaths: Fix handling of wildcards in directories and files

staniek added a comment. Nice, some early notes. INLINE COMMENTS > KoResourcePaths.cpp:43 > +{ > +static const QLoggingCategory > category("calligra.lib.widgets.koresourcepaths"); > +return category; Can we drop the "ko" legacy here? Or even: do we really need a category per class/

[Maniphest] [Updated] T3755: Kexi API docs missing in the calligra section

staniek added projects: Calligra: 3.0, Kexi, Kexi: Porting to Qt 5. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek Cc: Calligra-Devel-list, bcooksley, ochurlaud, sysadmin, staniek, blazquez

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. > there is not much content right now on the kexi pages Right if you mean 'special pages' with prose. But there's plenty of doxygen API docs in the context of classes and functions. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phab

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. > A fix would be to remove widget/undo/Mainpage.dox Done, thanks Friedrich. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek Cc: kossebau, Calligra-Devel-list, bcooksley,

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. > No idea about Kexi, does kexi itself install libs with a public API? Nope, everything in this category has been moved to KDb/KProperty/KReport. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. In https://phabricator.kde.org/T3755#55367, @kossebau wrote: > In https://phabricator.kde.org/T3755#55355, @staniek wrote: > > > > there is not much content right now on the kexi pages > > > > Right if you mean 'special pages' with prose. But there's plenty

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. Are we sure? For example KDevelop has kdevplatform https://api.kde.org/extragear-api/kdevelop-apidocs/index.html, just released yesterday, but Calligra does not: https://api.kde.org/bundled-apps-api/calligra-apidocs/ From what I see we're not planning t

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. Very good, either solution that declutters the API pages would work for me. So the question is where to generate project's docs. Generating from within kexi-project.org comes to my mind, what would be feasible as part of a larger challenge: (finally) moving the s

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. The domain name is secured and it's KDE's already. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek Cc: kossebau, Calligra-Devel-list, bcooksley, ochurlaud, sysadmin, staniek,

[Maniphest] [Commented On] T3755: Kexi API docs missing in the calligra section

staniek added a comment. In https://phabricator.kde.org/T3755#55509, @kossebau wrote: > > @staniek I would recommend to move src/Mainpage.dox to the toplevel dir (and adopting the EXCLUDE entry). Because right now this results in the additional subsection "Kexi" on https:/

[Maniphest] [Closed] T3755: Kexi API docs missing in the calligra section

staniek closed this task as "Resolved". staniek claimed this task. staniek added a comment. @bcooksley Yep, generalizing the scripts is not practical or safe. Thanks. TASK DETAIL https://phabricator.kde.org/T3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Commented On] D2577: KoResourcePaths: Fix handling of wildcards in directories and files

staniek added inline comments. INLINE COMMENTS > danders wrote in KoResourcePaths.cpp:43 > I did it to be able to filter out all other debug statements, and I can see > where it originates so I find it much easier to use. I did it to be able to filter out all other debug statements, and I can s

D8310: Port Calligra Gemini for 3.x

staniek accepted this revision. staniek added a comment. This revision is now accepted and ready to land. +1 from me, appeciated the port! - have not run it - have not reviewed the QML part INLINE COMMENTS > CMakeLists.txt:3 > > +add_definitions("-DUNICODE -D_UNICODE") > + Conventio

D12839: Get Calligra to compile with Qt 5.11

staniek accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D12839 To: nerdopolist, Calligra-Devel-list, #calligra:_3.0, staniek Cc: #calligra:_3.0, cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

staniek added a comment. tl;dr images designed without regards to physical pixels size look well only for large sizes Are we talking about equivalent of this option of Inkscape? F6223325: image.png The Px unit has wide usage. In the bug des

D15111: [KoUnit] Let's show pixel units

staniek added a comment. In D15111#317263 , @boemann wrote: > we don't store pixel values but rather convert to points the user will not get pixel precise placement anyway Sure we but users who design for pixel size, like me, do that usin

D15111: [KoUnit] Let's show pixel units

staniek added a comment. In D15111#317311 , @anthonyfieroni wrote: > @staniek did you want a DPI config spinbox? As in, e.g. GIMP, whenever we work in export-to-bitmap, and there's size other than in pixels, there's also DPI setting. Tha

D15412: [filters] Extend table lifetime

staniek requested changes to this revision. staniek added a comment. This revision now requires changes to proceed. Thanks, lots of other people also touched this code but I tried this time to review :) I propose to separate the string literal changes. Also I wonder why there's "Context n

D15412: [filters] Extend table lifetime

staniek added inline comments. INLINE COMMENTS > anthonyfieroni wrote in MsooXmlDrawingReaderTableMethods.h:40 > That isn't a problem, it's initialized at constructor time. I know but original code was not called new KoTable for PptxXmlSlideReader, right? > anthonyfieroni wrote in DocxXmlDocum

D15412: [filters] Extend table lifetime

staniek accepted this revision. staniek added a comment. This revision is now accepted and ready to land. Good job! REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15412 To: anthonyfieroni, danders, boemann, #calligra:_3.0, staniek Cc: staniek, Calligra-Devel-list, dc

T10760: Calligra website unwanted blog content

staniek added a comment. Asking Cyrille and Boud... F6754550: image.png TASK DETAIL https://phabricator.kde.org/T10760 To: staniek Cc: staniek, danders, #sysadmin, Calligra-Devel-list, #calligra:_3.0, ongunkanat, sysadmin

Review Request: calligra helper app

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100267/ --- Review request for Calligra. Summary --- Introduce calligra app, help

Review Request: KoAbstraction Library, iteration #3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100304/ --- Review request for Calligra. Summary --- KoAbstraction Library This

Re: Review Request: calligra helper app

---- On 2010-12-29 23:07:12, Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100267/ > -

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/#review745 --- filters/words/msword-odf/texthandler.cpp

Re: Review Request: KoAbstraction Library, iteration #3

---- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100304/#review764 --- On 2011-01-05 00:22:18, Jarosław Staniek wrote: > > --

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/#review781 --- I confirm all the corrections proposed by me are there now. Good

Re: Review Request: KoAbstraction Library, iteration #3

http://git.reviewboard.kde.org/r/100304/#review831 ------- On Jan. 5, 2011, 12:22 a.m., Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 118757: Enable building Kexi in -DKEXI_MOBILE mode

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118757/#review60733 --- Ship it! Ship It! - Jarosław Staniek On June 19, 2014, 8

Re: Review Request 118736: cmake files for odb reader and add odb in a drop down

bool drv_copyTable(const QString& srcTable, KexiDB::Connection *destConn, KexiDB::TableSchema* dstTable) is present. - Jarosław Staniek On June 17, 2014, 6:31 a.m., harshita mistry wrote: > > --- > This is an automatically ge

Review Request 118983: Fix crash and import failures for ODS import to Kexi

e.cpp d9ab7c0168a5fbf96d32017a1c52d78d3fd02faa Diff: https://git.reviewboard.kde.org/r/118983/diff/ Testing --- Importing works for the sample file Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/cal

Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

Diff: https://git.reviewboard.kde.org/r/118984/diff/ Testing --- Builds, nobody is used the argument-less constructor (after https://git.reviewboard.kde.org/r/118983/ is pushed) Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra

Review Request 118986: Show all possible file extensions in the file widget of database importer

/diff/ Testing --- Extenstions show properly Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 119002: Added focusing item after it is added in Kexi's report

oReportItemBase* instead of QObject*. - Jarosław Staniek On June 29, 2014, 4:39 p.m., Wojciech Kosowicz wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

constructor (after https://git.reviewboard.kde.org/r/118983/ is pushed) Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

omewhere despite having it in QList::at() already. - Jarosław --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118984/#review61158 ---------

Re: Review Request 118983: Fix crash and import failures for ODS import to Kexi

ate.h 00da0fab072bc3103a60ccad13d1bb2878ef705b plugins/kexi/spreadsheet/spreadsheetmigrate.cpp d9ab7c0168a5fbf96d32017a1c52d78d3fd02faa Diff: https://git.reviewboard.kde.org/r/118983/diff/ Testing --- Importing works for the sample file Thanks, Jarosław St

Re: Review Request 118986: Show all possible file extensions in the file widget of database importer

ve this outdated comment. - Jarosław --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118986/#review61223 --- On June 27, 20

Re: Review Request 115611: KoFileDialogHelper => KoFileDialog refactor

could follow better those from Qt/KDElibs, e.g. I had no idea what's a dialogName, it's basically KDE's fileClass I think: http://api.kde.org/4.x-api/kdelibs-apidocs/kio/html/namespaceKRecentDirs.html#a1d58a14171d3269ed2c82288b4ca9661 I already pushed a small obvious fix today

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

o extra space kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment42770> no extra spaces append '.' kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.k

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

git.reviewboard.kde.org/r/119075/#comment42775> Typically for PDF: + use QPrinter::HighResolution + use setColorMode(QPrinter::Color) kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment42777> parent can be 'this', right? -

Re: Review Request 115611: KoFileDialogHelper => KoFileDialog refactor

> On July 1, 2014, 9:04 p.m., Jarosław Staniek wrote: > > Hello all, > > It's so late but I just noticed this API could be improved quite a bit and > > I am offering to make the fix/review on time for 2.9. Perhaps also some > > implementation too. > >

Re: Review Request 118986: Show all possible file extensions in the file widget of database importer

t.cpp 86e472b5a7f64ba0aba0a6ea30b80616d2d2b99e Diff: https://git.reviewboard.kde.org/r/118986/diff/ Testing --- Extenstions show properly Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/ma

Re: Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

(after https://git.reviewboard.kde.org/r/118983/ is pushed) Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

master branch only (2.9). - Jarosław Staniek On July 1, 2014, 6:47 p.m., Wojciech Kosowicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

> merge this code with line 230, apdate condition accordingly by removing elses - Jarosław Staniek On July 3, 2014, 9:20 p.m., Wojciech Kosowicz wrote: > > --- > This

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

> On July 1, 2014, 9:42 p.m., Jarosław Staniek wrote: > > kexi/plugins/reports/kexireportview.cpp, line 200 > > <https://git.reviewboard.kde.org/r/119075/diff/1/?file=286489#file286489line200> > > > > Pdf -> PDF > > and use Title Capitalization h

Re: Review Request 119117: KoRuler should have minimum length equal to zero

or to "Kamil Łysik ". Please use exactly when you'll be registering the git account. "Kamil" is not enough. Thanks. - Jarosław Staniek On July 4, 2014, 5:34 p.m., Kamil Łysik wrote: > > --- > This is an a

Re: Review Request 119117: KoRuler should have minimum length equal to zero

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119117/#review61665 --- Ship it! Ship It! - Jarosław Staniek On July 4, 2014, 5

Re: Review Request 119120: Fix Next and Last button in Page selector of Report data view to be disabled on last page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119120/#review61666 --- Ship it! Good job! - Jarosław Staniek On July 4, 2014, 9

Re: Review Request 119120: Fix Next and Last button in Page selector of Report data view to be disabled on last page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119120/#review61667 --- Please push both to 2.8 and master. - Jarosław Staniek On

Review Request 119136: Fix issue with resolving version of plugins (at least) on Linux

/kexidb/drivers/oracle/oracledriver.cpp 64d1efc2d4bc9843949a188453c6c205bf4b7443 kexi/kexidb/drivers/pqxx/pqxxdriver.cpp 2f1ea2bb5bbd180b72eee959d66e82d1e56bb2ad Diff: https://git.reviewboard.kde.org/r/119136/diff/ Testing --- tested every type of plugin affected Thanks, Jarosław

Re: Review Request 119136: Fix issue with resolving version of plugins (at least) on Linux

-- On July 5, 2014, 7:17 p.m., Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119136/ > --

Re: Review Request 118736: cmake files for odb reader and add odb in a drop down

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118736/#review61858 --- Ship it! Ship It! - Jarosław Staniek On June 28, 2014, 5

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

Look at how this message is nicer formatted in slotExportAsTextDocument() and go this way too. kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment43071> Add usage of openExportedDocument() here as in other exports to offer opening

Review Request 119168: cleanup: COMPILING_TESTS is inherited in subdirs so it needs to be set once

d9e24d868daf3fbbfe7c2253d34aef4ed50356ae stage/part/CMakeLists.txt f79eea988d2066d90ebab0dab70f339b4ce6185d Diff: https://git.reviewboard.kde.org/r/119168/diff/ Testing --- tested by building with tests Thanks, Jarosław Staniek

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

x missing default filename for every type of export. Use LastVisited{*}ExportPath names specific for each type of export, e.g. for pdf {*} == PDF. - Jarosław Staniek On July 7, 2014, 11:04 p.m., Wojciech Kosowicz wrote: > > ---

Review Request 119169: Cleanup for report element tag names, use namespaces consistently

/krscriptreport.cpp 7834c7e744ba9e3723fcbb3d3eaf9d9254a56572 Diff: https://git.reviewboard.kde.org/r/119169/diff/ Testing --- tested by working with report elements Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119075/#review61940 --- Please add bug 335150 to this review. - Jarosław Staniek

  1   2   3   4   5   6   7   8   9   10   >