----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119075/#review61652 -----------------------------------------------------------
kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment42906> I forgot, it's good to: -> i18nc("Portable Document Format...", "PDF...") kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment42907> - extra space not needed kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment42908> append a . kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment42910> 1. By report's caption I mean KexiPart::Item::captionOrName() item of report's caption. 2. I forgot: add ".pdf" as a filename 3. Missing '/' before caption. The result should be: the caption-or-name should show up as the default filename. kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment42909> merge this code with line 230, apdate condition accordingly by removing elses - Jarosław Staniek On July 3, 2014, 9:20 p.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119075/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 9:20 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > Added button to report data view that prints report directly to pdf after > selecting location > > > Diffs > ----- > > kexi/plugins/reports/kexireportview.h 4d7d017 > kexi/plugins/reports/kexireportview.cpp e69d9c3 > > Diff: https://git.reviewboard.kde.org/r/119075/diff/ > > > Testing > ------- > > After clicking and selecting save location pdf document with report data view > content is created > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
