-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119120/#review61667
-----------------------------------------------------------


Please push both to 2.8 and master.

- Jarosław Staniek


On July 4, 2014, 9:52 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119120/
> -----------------------------------------------------------
> 
> (Updated July 4, 2014, 9:52 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The Next and Last button in the Page selector of the Report data view are 
> always enabled, even if there is only one page or if one is already on the 
> last page.
> 
> This was because the logic for enabling/disabling the next and last button in 
> KexiRecordNavigator::updateButtons(uint recCnt) is also respecting the 
> "isInsertingEnabled" flag, which was not set to "false" for the use with the 
> data view of KexiReportView.
> 
> Setting it explicitely to "false" fixes this for me.
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/kexireportview.cpp 9a21d7a 
>   kexi/widget/utils/kexirecordnavigator.cpp 2f0a8b7 
> 
> Diff: https://git.reviewboard.kde.org/r/119120/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to