Re: Review Request 108420: "Fit Text Width" zoom mode

2013-01-15 Thread Dmitry Kazakov
> On Jan. 15, 2013, 5:06 a.m., C. Boemann wrote: > > I should mention that the difference in how other fit modes work only > > applies to Words/Author > > > > I don't intend for other applications to experience any changes Tested with Krita. No changes or regressions =) - Dmitry --

Re: Review Request 108420: "Fit Text Width" zoom mode

2013-01-18 Thread Dmitry Kazakov
Could you check whether it works without these lines? The rest is ok to commit. - Dmitry Kazakov On Jan. 15, 2013, 5:04 a.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 108420: "Fit Text Width" zoom mode

2013-01-18 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108420/#review25773 --- Ship it! Ship It! - Dmitry Kazakov On Jan. 15, 2013, 5:04

Re: Review Request 108651: Nicer appearance of image after cropping.

2013-01-29 Thread Dmitry Kazakov
e.org/r/108651/#comment20088> Probably, some other name without 'set' prefix would be better? One might thing this "setter"-method accepts a value... - Dmitry Kazakov On Jan. 29, 2013, 7:06 a.m., Sven Langkamp wrote: > > -

Re: Review Request 109649: Make two methods of KoToolManager public

2013-03-25 Thread Dmitry Kazakov
/KoToolManager.h 929f127 libs/flake/KoToolManager.cpp d2db044 Diff: http://git.reviewboard.kde.org/r/109649/diff/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra

Re: Idea for alternative Calligra deployment option

2013-04-10 Thread Dmitry Kazakov
t=&post=-38024296_171> After importing to the VirtualBox it will unpack to 10GiB. *Current Results* I have no results so far since I published the image only last Saturday and my friends didn't have time to play with it yet :) -- Dmitry Kazakov ___ cal

Review Request 110087: Make the use of Rendering Intents consistent

2013-04-19 Thread Dmitry Kazakov
://git.reviewboard.kde.org/r/110087/diff/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110087: Make the use of Rendering Intents consistent

2013-04-19 Thread Dmitry Kazakov
85eeaa6 libs/pigment/colorspaces/KoSimpleColorSpaceEngine.cpp 0566475 plugins/colorengines/lcms2/LcmsColorSpace.h ac88351 plugins/colorengines/lcms2/tests/TestKoCompositeOps.cpp 1dee8af Diff: http://git.reviewboard.kde.org/r/110087/diff/ Testing --- Thanks, Dmitry Kazakov

Re: Review Request 110087: Make the use of Rendering Intents consistent

2013-04-21 Thread Dmitry Kazakov
/KoSimpleColorSpace.h 85eeaa6 libs/pigment/colorspaces/KoSimpleColorSpaceEngine.cpp 0566475 plugins/colorengines/lcms2/LcmsColorSpace.h ac88351 plugins/colorengines/lcms2/tests/TestKoCompositeOps.cpp 1dee8af Diff: http://git.reviewboard.kde.org/r/110087/diff/ Testing --- Thanks, Dmitry

Re: Review Request 110087: Make the use of Rendering Intents consistent

2013-04-21 Thread Dmitry Kazakov
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110087/#review31360 ------- On April 21, 2013, 8:47 a.m., Dmitry Kazakov wrote: > > ---

Re: Review Request 108651: Nicer appearance of image after cropping.

2013-05-01 Thread Dmitry Kazakov
> On May 1, 2013, 7:58 a.m., Boudewijn Rempt wrote: > > I guess this can be closed after commit > > dfae0ee3d742457cba428fb7b9b4a7588dd31ffc ? I guess, yes. - Dmitry --- This is an automatically generated e-mail. To reply, visit: http:

Review Request 110333: Fix cross-process Drag&Drop in KoDocumentSectionView

2013-05-06 Thread Dmitry Kazakov
c9bb21 libs/main/KoDocumentSectionView.h 7a535cb libs/main/KoDocumentSectionView.cpp 768c671 Diff: http://git.reviewboard.kde.org/r/110333/diff/ Testing --- Tested vastly on the Layer Box in Krita. Thanks, Dmitry Kazakov ___ calligra-devel ma

Re: Review Request 110333: Fix cross-process Drag&Drop in KoDocumentSectionView

2013-05-07 Thread Dmitry Kazakov
viewboard.kde.org/r/110333/#review32179 ------- On May 6, 2013, 4:30 p.m., Dmitry Kazakov wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 110333: Fix cross-process Drag&Drop in KoDocumentSectionView

2013-05-18 Thread Dmitry Kazakov
a krita/ui/tests/kis_model_index_converter_test.cpp 80a3117 krita/ui/tests/kis_node_model_test.cpp 1c9bb21 libs/main/KoDocumentSectionView.h 7a535cb libs/main/KoDocumentSectionView.cpp 768c671 Diff: http://git.reviewboard.kde.org/r/110333/diff/ Testing --- Tested vastly on the Layer Box in Krita

Re: Calligra 2.7 release blockers

2013-06-09 Thread Dmitry Kazakov
only in case the crash happened there? Like we do for openGL activation? -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Three new strings for Calligra 2.7 Beta 2. Is it possible?

2013-06-24 Thread Dmitry Kazakov
them? I think we have at least one Release Candidate in store... [0] - https://bugs.kde.org/show_bug.cgi?id=312437 PS: Please add me to CC, because I'm not subscribed to kde-i18n-doc list. -- Dmitry Kazakov ___ calligra-devel mailing list calligra-

Re: Review Request 111222: Zoom canvas in smaller steps with mousewheel and control key

2013-06-24 Thread Dmitry Kazakov
think, you need consider moving this code to the KisZoomAction. The action framework supports different modes of working, so you'll just need to implement a new mode and register a shortcut in the KisInputManager. - Dmitry Kazakov On June 24, 2013, 4:52 p.m., Sascha Sue

Re: Calligra 2.7 final

2013-07-11 Thread Dmitry Kazakov
**_ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/**listinfo/calligra-devel<https://mail.kde.org/mailman/listinfo/calligra-devel> > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
Or at least make it configurable by cmake. -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
ell, the problem is that you needn't D&D a http-based URL for that. You just drag an *image* and it is passed as an URL. Chromium works a bit differently and it passes an image as a real image, which is handled without KIO. -- Dmitry Kazakov ___ cal

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
> > > Btw, do the File Layers in Krita check that the file is changed on disk? > Do > > they use some KIO thing for that? > > kdirnotify, as fast as I remember -- it's in kio: > ./staging/kio/src/core/kdirnotify.cpp > What is the difference with QFil

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
t of them are not ready for switching to Linux just because of a single application. They have too much to lose in the Windows world. Although I agree that we should at least try to keep some of the KDE capabilities/integration when working on Linux and disable it on Windows. But we need working power t

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
ble to release bugfixes for Qt4 version this way. -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 112405: Added three protected methods to KoCreatePathTool

2013-08-31 Thread Dmitry Kazakov
/basicflakes/tools/KoCreatePathTool_p.h 51f4a8f Diff: http://git.reviewboard.kde.org/r/112405/diff/ Testing --- Tested in Krita Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 112405: Added three protected methods to KoCreatePathTool

2013-08-31 Thread Dmitry Kazakov
51f4a8f Diff: http://git.reviewboard.kde.org/r/112405/diff/ Testing --- Tested in Krita Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 112405: Added three protected methods to KoCreatePathTool

2013-08-31 Thread Dmitry Kazakov
ttp://git.reviewboard.kde.org/r/112405/#comment28788> addPathShape() now has its own check for the existence of 'shape' (see line KoCreatePathTool_p.h:386). This check is added to the method directly, because there are a few places where it is called from. It it ok? - Dmitry Kaza

Re: How to merge rebased branch properly?

2013-09-08 Thread Dmitry Kazakov
devel mailing list >> calligra-devel@kde.org >> https://mail.kde.org/mailman/**listinfo/calligra-devel<https://mail.kde.org/mailman/listinfo/calligra-devel> >> > > > ___ > calligra-

Re: Review Request 112883: Workaround for flickering in OpenGL 2 canvas on AMD graphic cards

2013-09-22 Thread Dmitry Kazakov
no regressions. Although I thing the patch really needs an extended comment in the code, explaining why this workaround was added. - Dmitry Kazakov On Sept. 22, 2013, 11:01 a.m., Sven Langkamp wrote: > > --- > This is an auto

[calligra] plugins/textshape: Fix a crash in Krita due to accessing to an unsupported action in TextTool

2013-12-07 Thread Dmitry Kazakov
Git commit fad45bd4002c1417f8b9f0e9fc0743812a2ff787 by Dmitry Kazakov. Committed on 07/12/2013 at 07:23. Pushed by dkazakov into branch 'master'. Fix a crash in Krita due to accessing to an unsupported action in TextTool The action "insert_table" (as well as other table-relat

[calligra/calligra/2.8] plugins/textshape: Fix a crash in Krita due to accessing to an unsupported action in TextTool

2013-12-07 Thread Dmitry Kazakov
Git commit a957d083cdc1d586ccbd2ba4a972c7eac3dd1e11 by Dmitry Kazakov. Committed on 07/12/2013 at 07:23. Pushed by dkazakov into branch 'calligra/2.8'. Fix a crash in Krita due to accessing to an unsupported action in TextTool The action "insert_table" (as well as other table

Re: Review Request 114468: fix linking error on FillProcessingVisitorTest

2013-12-17 Thread Dmitry Kazakov
in the test, because it is not needed anymore :) It was just a copy-paste error I guess. - Dmitry Kazakov On Dec. 14, 2013, 9:19 p.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 114890: Fix calculation of the shape's insets when it has Miter joining

2014-01-06 Thread Dmitry Kazakov
--- The insets should be not smaller than the limit of the Miter joining. This patch fixes the update bug. Tested in Krita and Karbon with Arrow shapes. Diffs - libs/flake/KoShapeStroke.cpp 6edcc26 Diff: https://git.reviewboard.kde.org/r/114890/diff/ Testing --- Thanks, Dmitry

Re: Review Request 114890: Fix calculation of the shape's insets when it has Miter joining

2014-01-06 Thread Dmitry Kazakov
/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 114890: Fix calculation of the shape's insets when it has Miter joining

2014-01-06 Thread Dmitry Kazakov
Diff: https://git.reviewboard.kde.org/r/114890/diff/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 115149: Quick fix of BUG:322951

2014-01-20 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115149/#review47798 --- Ship it! Ship It! - Dmitry Kazakov On Jan. 20, 2014, 3:13

Release Blockers for Krita 2.8

2014-01-28 Thread Dmitry Kazakov
iate krita sketch with .kra files" Bug 301443 <https://bugs.kde.org/show_bug.cgi?id=301443> - CandleGlass.exr is not loaded correctly Bug 325423 <https://bugs.kde.org/show_bug.cgi?id=325423> - speed dynamic doesn't work -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 115352: Fix the Stroke and Shape Id of the Pencil Tool

2014-01-28 Thread Dmitry Kazakov
in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 115352: Fix the Stroke and Shape Id of the Pencil Tool

2014-01-28 Thread Dmitry Kazakov
/KoStrokeConfigWidget.cpp 3a0dc84 Diff: https://git.reviewboard.kde.org/r/115352/diff/ Testing --- Tested in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Release Blockers for Krita 2.8

2014-01-28 Thread Dmitry Kazakov
d=329026 >> Bug 313494 " [ sensor / dynamics ] Hue / Saturation / Value sensors are >> broken " https://bugs.kde.org/show_bug.cgi?id=313494 >> >> Good luck ! >> -David >> >> _ >> http://www.davidrevoy.com >>

[calligra] libs/main: Add a warning about weird shortcut context initialization in the KoView

2014-01-30 Thread Dmitry Kazakov
Git commit 818245e7f0b387abe0244a2d65017914ee75fc8c by Dmitry Kazakov. Committed on 31/01/2014 at 07:12. Pushed by dkazakov into branch 'master'. Add a warning about weird shortcut context initialization in the KoView I don't know why this is done, this code was added back in 20

Review Request 115529: Allow the user not to merge the last point in KoCreatePathTool

2014-02-07 Thread Dmitry Kazakov
/basicflakes/tools/KoCreatePathTool.cpp fbda308 libs/basicflakes/tools/KoCreatePathTool_p.h ee94c4f Diff: https://git.reviewboard.kde.org/r/115529/diff/ Testing --- Tested in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list

Re: Review Request 115529: Allow the user not to merge the last point in KoCreatePathTool

2014-02-07 Thread Dmitry Kazakov
--- Tested in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 115529: Allow the user not to merge the last point in KoCreatePathTool

2014-02-07 Thread Dmitry Kazakov
/tools/KoCreatePathTool_p.h ee94c4f libs/basicflakes/tools/KoCreatePathTool.cpp fbda308 Diff: https://git.reviewboard.kde.org/r/115529/diff/ Testing --- Tested in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list

Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Dmitry Kazakov
________ > Kde-soc-mentor mailing list > kde-soc-men...@kde.org > https://mail.kde.org/mailman/listinfo/kde-soc-mentor > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Final release date?

2014-02-27 Thread Dmitry Kazakov
t? > > > > > > -- > Boudewijn Rempt > http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: A hint: commits that are not cherry-picked between branches

2014-03-04 Thread Dmitry Kazakov
dev/null; then mv $TMP $TMP.diff; TMP=$TMP.diff; fi emacs-x11 $TMP rm $TMP On Tue, Mar 4, 2014 at 1:43 AM, Jaroslaw Staniek wrote: > And the script... > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https

Re: Review Request 115529: Allow the user not to merge the last point in KoCreatePathTool

2014-03-15 Thread Dmitry Kazakov
, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2.8.1 Changelogs

2014-03-27 Thread Dmitry Kazakov
el mailing list > > calligra-devel@kde.org > > https://mail.kde.org/mailman/listinfo/calligra-devel > > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov _

Re: Review Request 118517: New brush stabilizer

2014-06-04 Thread Dmitry Kazakov
. You can also see it in the attached screenshot. - Dmitry Kazakov On June 4, 2014, 11:13 a.m., Juan Luis Boya García wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 118517: New brush stabilizer

2014-06-04 Thread Dmitry Kazakov
-- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118517/ > --- > > (Updated June 4, 2014, 11:13 a.m.) > > > Review request for Calligra, Dmitry Kazakov, Sven Langkamp, and Boudewi

Last call for reviewers of "Typesafe strings for KUndo2Command" review request

2014-06-06 Thread Dmitry Kazakov
ere anyone else planning to make a review or I can already push it to calligra-master? -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 118517: New brush stabilizer

2014-06-15 Thread Dmitry Kazakov
aster! http://commits.kde.org/calligra/58e452c466505aa44c0208bd649d0c8facf0194f - Dmitry Kazakov On June 9, 2014, 10:22 a.m., Juan Luis Boya García wrote: > > --- > This is an automatically generated e-mail. To reply,

[Differential] [Updated, 97 lines] D125: Implement a relative zooming shortcuts

2016-07-18 Thread dkazakov (Dmitry Kazakov)
dkazakov updated this revision to Diff 5256. dkazakov updated the summary for this revision. dkazakov added a comment. Fixed wheel-zoom and changed the shortcut to Ctrl+Middle-button REPOSITORY rKRITA Krita CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D125?vs=276&id=5256 BRANCH

[Differential] [Closed] D125: Implement a relative zooming shortcuts

2016-07-18 Thread dkazakov (Dmitry Kazakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rKRITAf42833ca9774: Implement relative zooming shortcuts (authored by dkazakov). REPOSITORY rKRITA Krita CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D125?vs=5256&id=5257 REVISION DETAIL ht

[Differential] [Request, 81 lines] D125: Implement a relative zooming shortcuts

2015-06-21 Thread dkazakov (Dmitry Kazakov)
dkazakov created this revision. dkazakov added reviewers: Calligra-Devel-list, woltherav, timotheegiet, Deevad. dkazakov set the repository for this revision to rCALLIGRA Calligra. dkazakov added a project: Krita: PSD layer styles. REVISION SUMMARY This patch needs testing. # Go to Settin

[Differential] [Updated, 103 lines] D125: Implement a relative zooming shortcuts

2015-06-21 Thread dkazakov (Dmitry Kazakov)
dkazakov updated the summary for this revision. dkazakov updated this revision to Diff 276. dkazakov added a comment. Updated the patch. Now there is a default shortcuts set to the right mouse/stylus button. REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.or

<    1   2