----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108651/#review26349 -----------------------------------------------------------
HI, Sven! I have a concern about resetting the canvas transformations. The deevad's illustration suggests that the cropped area should not move on screen after the crop. To achieve this you even change the zoom mode, I agree with this. But why do you reset rotations? I think this might be really not what the user expects. krita/plugins/tools/tool_crop/kis_tool_crop.cc <http://git.reviewboard.kde.org/r/108651/#comment20087> The new code should use KisCoordinatesConverter in Krita, because it has a bit different coordinate systems naming. We need to try not to mix them. libs/widgets/KoZoomController.h <http://git.reviewboard.kde.org/r/108651/#comment20088> Probably, some other name without 'set' prefix would be better? One might thing this "setter"-method accepts a value... - Dmitry Kazakov On Jan. 29, 2013, 7:06 a.m., Sven Langkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108651/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 7:06 a.m.) > > > Review request for Calligra. > > > Description > ------- > > As described in bug 313489, the image is currently placed at the wrong area > after crop. The patch does three things: reset the transformation, change the > zoom mode while keeping the zoom level constant (so there is no fit to page) > and pan the canvas. If there was no transformation of the canvas, the result > image will be exactly at the position where the crop rect was. > > > This addresses bug 313489. > http://bugs.kde.org/show_bug.cgi?id=313489 > > > Diffs > ----- > > krita/plugins/tools/tool_crop/kis_tool_crop.cc 65c9458 > libs/widgets/KoZoomController.h 0ce6d77 > libs/widgets/KoZoomController.cpp 4973ef3 > > Diff: http://git.reviewboard.kde.org/r/108651/diff/ > > > Testing > ------- > > Tested with normal and transformed images. > > > Thanks, > > Sven Langkamp > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
