----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111222/#review34999 -----------------------------------------------------------
Hi, Sascha! The point is, we have recently moved our zooming code from KoCanvasControllerWidget code to KisZoomAction and KisInputManager classes. There were several reasons for it: it makes the shortcut configurable and it doesn't conflict with any other shortcuts (which is not the case when we handle this event in the wheelEvent directly). So, I think, you need consider moving this code to the KisZoomAction. The action framework supports different modes of working, so you'll just need to implement a new mode and register a shortcut in the KisInputManager. - Dmitry Kazakov On June 24, 2013, 4:52 p.m., Sascha Suelzer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111222/ > ----------------------------------------------------------- > > (Updated June 24, 2013, 4:52 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Small patch that zooms the canvas in smaller steps when the control key is > held while turning the mousewheel. > Before the patch, in Krita, holding control while turning the wheel scrolled > the canvas up and down, now it zooms in small increments. > > > Diffs > ----- > > libs/flake/KoCanvasControllerWidget.cpp db7ded4 > > Diff: http://git.reviewboard.kde.org/r/111222/diff/ > > > Testing > ------- > > Only tested for Krita. Only did superficial testing, as in holding the > control key down and turning the wheel. > > > Thanks, > > Sascha Suelzer > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
