----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110333/ -----------------------------------------------------------
Review request for Calligra. Description ------- It happens so, that when the cross-process Drag is dropped to the KoDocumentSectionView, some spurious MouseMove event come and start another Drag (effectively, cancelling the current one). I guess, that happens due to some weird order of setting up of event filters (in QWidget and in QDragManager), so that the QWidget's filter gets the MouseMove events before the QDragManager's one. Actually, QWidget should not get any MouseMove events during Dragiing. It should get DragMoveEvents instead. This patch workarounds this problem (i guess, Qt is the cause) and drops all the MouseMove events when they come while the Dragging operation. I activate the workaround on X11 only, because, most probably, Qt's D&D works differently on Windows. This patch fixed bug: https://bugs.kde.org/show_bug.cgi?id=319334 Diffs ----- krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 12689ed krita/ui/kis_mimedata.h 7055043 krita/ui/kis_mimedata.cpp 64af6b3 krita/ui/kis_node_model.h c1854a0 krita/ui/kis_node_model.cpp 3a21127 krita/ui/kis_view2.cpp 7d4c6da krita/ui/tests/kis_model_index_converter_test.cpp 80a3117 krita/ui/tests/kis_node_model_test.cpp 1c9bb21 libs/main/KoDocumentSectionView.h 7a535cb libs/main/KoDocumentSectionView.cpp 768c671 Diff: http://git.reviewboard.kde.org/r/110333/diff/ Testing ------- Tested vastly on the Layer Box in Krita. Thanks, Dmitry Kazakov
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
