Re: a new library for traversing odf files and a new export filter

2013-03-26 Thread matus . uzak
> > See also somewhat related XmlWriteBuffer in > filters/libmsooxml/MsooXmlUtils.h which is used "when information that has > to be written in advance is based on XML elements parsed later. In such > case the information cannot be saved in one pass" for OOXML=>ODF. > The worst thing is relative l

Re: a new library for traversing odf files and a new export filter

2013-03-26 Thread matus . uzak
Hi, I would like to add that Theme Colors from MSOOXML are causing us big problems (invisible text mostly) because named styles and MasterSlide/SlideLayout styles (PPTX) are based on them. The color map might change with each slide/section of a document. At the moment we calculate the color for

Re: a new library for traversing odf files and a new export filter

2013-03-26 Thread Sebastian Sauer
On 03/26/2013 04:32 PM, Sebastian Sauer wrote: On 03/26/2013 02:51 PM, Lassi Nieminen wrote: Hola, On Mon, Mar 25, 2013 at 8:12 PM, Inge Wallin > wrote: On Monday, March 25, 2013 17:54:53 matus.u...@gmail.com wrote: > Hi,

Re: a new library for traversing odf files and a new export filter

2013-03-26 Thread Sebastian Sauer
On 03/26/2013 02:51 PM, Lassi Nieminen wrote: Hola, On Mon, Mar 25, 2013 at 8:12 PM, Inge Wallin > wrote: On Monday, March 25, 2013 17:54:53 matus.u...@gmail.com wrote: > Hi, > > sorry for not discussing earlier, but

Re: a new library for traversing odf files and a new export filter

2013-03-26 Thread Lassi Nieminen
Hola, On Mon, Mar 25, 2013 at 8:12 PM, Inge Wallin wrote: > On Monday, March 25, 2013 17:54:53 matus.u...@gmail.com wrote: > > Hi, > > > > sorry for not discussing earlier, but I did not have much free time last > > two weeks. > > > > I think we should continue the parser type discussion in orde

Re: a new library for traversing odf files and a new export filter

2013-03-25 Thread Inge Wallin
On Monday, March 25, 2013 17:54:53 matus.u...@gmail.com wrote: > Hi, > > sorry for not discussing earlier, but I did not have much free time last > two weeks. > > I think we should continue the parser type discussion in order to also > improve state of things in libmsooxml. What we have there is

Re: a new library for traversing odf files and a new export filter

2013-03-25 Thread matus . uzak
Hi, sorry for not discussing earlier, but I did not have much free time last two weeks. I think we should continue the parser type discussion in order to also improve state of things in libmsooxml. What we have there is a PULL parser. And I identified the following problems (Would be cool is Las

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-23 Thread Commit Hook
marked as submitted. Review request for Calligra. Description --- This patch creates a new library in filters/odftraverse. The purpose of this library is to create classes to make it easier to create export filters for ODF files. What you do to use this library is that you inherit a base

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-23 Thread Commit Hook
org/r/109393/ > --- > > (Updated March 20, 2013, 8:35 p.m.) > > > Review request for Calligra. > > > Description > --- > > This patch creates a new library in filters/odftraverse. The purpose of this >

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-23 Thread Arjen Hiemstra
board.kde.org/r/109393/ > --- > > (Updated March 20, 2013, 8:35 p.m.) > > > Review request for Calligra. > > > Description > --- > > This patch creates a new library in filters/odftraverse. The purpose of this > library is to create classe

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-22 Thread Inge Wallin
This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109393/ > --- > > (Updated March 20, 2013, 8:35 p.m.) > > > Review request for Calligra. > > > Description > -

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-20 Thread Jos van den Oever
> > Review request for Calligra. > > > Description > --- > > This patch creates a new library in filters/odftraverse. The purpose of this > library is to create classes to make it easier to create export filters for > ODF files. What you do to use this libra

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-20 Thread Inge Wallin
. Changes --- Revision 5. Short description: All issues fixed. Description --- This patch creates a new library in filters/odftraverse. The purpose of this library is to create classes to make it easier to create export filters for ODF files. What you do to use this library is that you

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-18 Thread Jarosław Staniek
--- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109393/ > --- > > (Updated March 18, 2013, 6:39 p.m.) > > > Review request for Callig

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-18 Thread Inge Wallin
This patch creates a new library in filters/odftraverse. The purpose of this library is to create classes to make it easier to create export filters for ODF files. What you do to use this library is that you inherit a base class for backends to this parser / traverser and in the many callbacks y

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-14 Thread Inge Wallin
To reply, visit: > http://git.reviewboard.kde.org/r/109393/ > --- > > (Updated March 13, 2013, 7:24 p.m.) > > > Review request for Calligra. > > > Description > --- > > This patch creates a new library in filters/odftraverse. The purp

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-13 Thread Jarosław Staniek
- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109393/ > --- > > (Updated March 13, 2013, 7:24 p.m.) > > > Review request for Calligra. > > > Description > --- > > This patch create

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-13 Thread Inge Wallin
simple formatting. As a proof of concept I also add a super simple text export filter. Description --- This patch creates a new library in filters/odftraverse. The purpose of this library is to create classes to make it easier to create export filters for ODF files. What you do to use

Re: Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-10 Thread Inge Wallin
. Changes --- This second version is a major cleanup. Not everything is implemented yet, but at least what's enabled looks better. Description --- This patch creates a new library in filters/odftraverse. The purpose of this library is to create classes to make it easier to create e

Review Request 109393: a new library for traversing odf files and a new export filter

2013-03-10 Thread Inge Wallin
new library in filters/odftraverse. The purpose of this library is to create classes to make it easier to create export filters for ODF files. What you do to use this library is that you inherit a base class for backends to this parser / traverser and in the many callbacks you write the output

Re: a new library

2012-12-20 Thread Sven Langkamp
want to move the tools into libs/widgets we need to move the tool > to somewhere else. > > It can't be moved to a plugin as krita has some tools that inherit from > KoCreatePathTool. > > My suggestion is thus that we make a new library, which I call alpine as it's > a s

Re: a new library

2012-12-20 Thread Jaroslaw Staniek
On 20 December 2012 13:14, Cyrille Berger Skott wrote: > On Wednesday 19 Dec 2012, Jaroslaw Staniek wrote: >> -- it's in KDElibs so for Qt-only libs we'd need a copy anyway > And now you see the problem of extremist position of "Qt-only" :) KDElibs > Framework 5 is designed on the idea of being ex

Re: a new library

2012-12-20 Thread Cyrille Berger Skott
On Wednesday 19 Dec 2012, Jaroslaw Staniek wrote: > -- it's in KDElibs so for Qt-only libs we'd need a copy anyway And now you see the problem of extremist position of "Qt-only" :) KDElibs Framework 5 is designed on the idea of being extensions to Qt, copying those extensions inside our own libra

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 20:14, Boudewijn Rempt wrote: > On Wed, 19 Dec 2012, Jaroslaw Staniek wrote: > >> I propose to move to QAbstractMessageHandler. I use this pattern in >> Kexi as well. > > > Well, this is kdelibs stuff -- not our own messageboxes, but in general, > yes, I think we should activel

Re: a new library

2012-12-19 Thread Boudewijn Rempt
On Wed, 19 Dec 2012, Jaroslaw Staniek wrote: I propose to move to QAbstractMessageHandler. I use this pattern in Kexi as well. Well, this is kdelibs stuff -- not our own messageboxes, but in general, yes, I think we should actively refactor to make sure QAbstractMessageHandler is used. Bou

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 19:21, Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, Inge Wallin wrote: > >> Whatever happens I would be very against "contaminating" koodf with UI stuff. >> :) >> >> I don't know if it's formally defined anywhere, but for me koodf is classes >> that represent var

Re: a new library

2012-12-19 Thread Boudewijn Rempt
On Wednesday 19 December 2012 Dec, Inge Wallin wrote: > Whatever happens I would be very against "contaminating" koodf with UI stuff. > :) > > I don't know if it's formally defined anywhere, but for me koodf is classes > that represent various entities inside an ODF file and classes that help l

Re: a new library

2012-12-19 Thread Inge Wallin
On Wednesday, December 19, 2012 15:10:27 Inge Wallin wrote: > On Wednesday, December 19, 2012 15:01:50 C. Boemann wrote: > > Yes, I don't disagree that this is the goal we want in the end, but I'm > > not willing to spend time implementing that now. It's too huge a task. > > however it would be ni

Re: a new library

2012-12-19 Thread Inge Wallin
On Wednesday, December 19, 2012 14:42:33 Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > > On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > > > On 19 December 2012 13:19, C. Boemann wrote: > > > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Stani

Re: a new library

2012-12-19 Thread Inge Wallin
> the tool to somewhere else. > > > > > > It can't be moved to a plugin as krita has some tools that inherit from > > > KoCreatePathTool. > > > > > > My suggestion is thus that we make a new library, which I call alpine > > > as it'

Re: a new library

2012-12-19 Thread C. Boemann
inherit from > > KoCreatePathTool. > > > > My suggestion is thus that we make a new library, which I call alpine as > > it's a superstructure to flake. This alpine library will depend on > > libs/widgets and contain basically tools, shapes and dockers that are too &g

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 14:42:33 Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > > On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > > > On 19 December 2012 13:19, C. Boemann wrote: > > > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek

Re: a new library

2012-12-19 Thread Boudewijn Rempt
On Wednesday 19 December 2012 Dec, C. Boemann wrote: > On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > > On 19 December 2012 13:19, C. Boemann wrote: > > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > > >> On 19 December 2012 12:59, C. Boemann wrote: > > >> >

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 13:40:46 Pierre Stirnweiss wrote: > On Wed, Dec 19, 2012 at 1:19 PM, C. Boemann wrote: > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > > > On 19 December 2012 12:59, C. Boemann wrote: > > > > Yes i'm not attached to alpine in any way. I couldn't

Re: a new library

2012-12-19 Thread Pierre Stirnweiss
On Wed, Dec 19, 2012 at 1:19 PM, C. Boemann wrote: > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > > On 19 December 2012 12:59, C. Boemann wrote: > > > Yes i'm not attached to alpine in any way. I couldn't come up with a > > > generic name that describes the library very well

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > On 19 December 2012 13:19, C. Boemann wrote: > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > >> On 19 December 2012 12:59, C. Boemann wrote: > >> > Yes i'm not attached to alpine in any way. I couldn't come up w

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 13:19, C. Boemann wrote: > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: >> On 19 December 2012 12:59, C. Boemann wrote: >> > Yes i'm not attached to alpine in any way. I couldn't come up with a >> > generic name that describes the library very well ( and no f

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > On 19 December 2012 12:59, C. Boemann wrote: > > Yes i'm not attached to alpine in any way. I couldn't come up with a > > generic name that describes the library very well ( and no flaketools > > doesn't unless we wan to have many su

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 12:59, C. Boemann wrote: > Yes i'm not attached to alpine in any way. I couldn't come up with a generic > name that describes the library very well ( and no flaketools doesn't unless > we > wan to have many such similarly named libraries) and so when i wrote the mail > that w

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 11:36:36 Jaroslaw Staniek wrote: > On 19 December 2012 10:41, Inge Wallin wrote: > > All this said, I think a refactor could be a good idea. But why not make > > a meaningful name? libflaketools should be obvious enough; alpine is > > justa bit too clever for me. >

Re: a new library

2012-12-19 Thread C. Boemann
libs/widgets > > > > however the dependency is in the opposite direction > > > > So unless we want to move the tools into libs/widgets we need to move the > > tool to somewhere else. > > > > It can't be moved to a plugin as krita has some tools that inhe

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 10:41, Inge Wallin wrote: > All this said, I think a refactor could be a good idea. But why not make a > meaningful name? libflaketools should be obvious enough; alpine is justa bit > too clever for me. +1 for any obvious name please note the case of libprison - a barcode l

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
om libs/widgets > >> > >> however the dependency is in the opposite direction > >> > >> So unless we want to move the tools into libs/widgets we need to move the >> tool > >> to somewhere else. > >> > >> It can't be moved to a

Re: a new library

2012-12-19 Thread Pierre Stirnweiss
> > It can't be moved to a plugin as krita has some tools that inherit from > > > KoCreatePathTool. > > > > > > My suggestion is thus that we make a new library, which I call alpine as > it's > > > a superstructure to flake. This alpine library will de

Re: a new library

2012-12-19 Thread Inge Wallin
unless we want to move the tools into libs/widgets we need to move the > tool to somewhere else. > > It can't be moved to a plugin as krita has some tools that inherit from > KoCreatePathTool. > > My suggestion is thus that we make a new library, which I call alpine as >

Re: a new library

2012-12-19 Thread Boudewijn Rempt
s we want to move the tools into libs/widgets we need to move the > tool > to somewhere else. > > It can't be moved to a plugin as krita has some tools that inherit from > KoCreatePathTool. > > My suggestion is thus that we make a new library, which I call alpine as i

Re: a new library

2012-12-18 Thread Thorsten Zachmann
Hello, On Wednesday 19 December 2012 01:55:38 C. Boemann wrote: > My suggestion is thus that we make a new library, which I call alpine as > it's a superstructure to flake. This alpine library will depend on > libs/widgets and contain basically tools, shapes and dockers that are t

a new library

2012-12-18 Thread C. Boemann
x27;t be moved to a plugin as krita has some tools that inherit from KoCreatePathTool. My suggestion is thus that we make a new library, which I call alpine as it's a superstructure to flake. This alpine library will depend on libs/widgets and contain basically tools, shapes and dockers th