----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109393/#review29475 -----------------------------------------------------------
filters/libodftraverse/OdtTraverserBackend.h <http://git.reviewboard.kde.org/r/109393/#comment21989> +explicit filters/libodftraverse/OdtTraverserBackend.cpp <http://git.reviewboard.kde.org/r/109393/#comment21991> missing 'delete d;' filters/words/ascii/OdtTraverserAsciiBackend.h <http://git.reviewboard.kde.org/r/109393/#comment21992> -> QFile* (and in fact perhaps we'd like to replace with more generic QIODevice*) filters/words/ascii/OdtTraverserAsciiBackend.h <http://git.reviewboard.kde.org/r/109393/#comment21993> +explicit filters/words/ascii/OdtTraverserAsciiBackend.h <http://git.reviewboard.kde.org/r/109393/#comment21994> I propose to use cleaner 'Position position'. filters/words/ascii/OdtTraverserAsciiBackend.cpp <http://git.reviewboard.kde.org/r/109393/#comment21995> if the above change was performed, this condition would be as clean as: if (position != EndTag) filters/libodftraverse/OdfTraverserContext.h <http://git.reviewboard.kde.org/r/109393/#comment21987> still missing doxygen comments :) filters/libodftraverse/OdfTraverserContext.cpp <http://git.reviewboard.kde.org/r/109393/#comment21988> missing 'delete d;' filters/libodftraverse/OdtTraverserBackend.cpp <http://git.reviewboard.kde.org/r/109393/#comment21996> missing 'delete d;' - Jarosław Staniek On March 18, 2013, 6:39 p.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109393/ > ----------------------------------------------------------- > > (Updated March 18, 2013, 6:39 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This patch creates a new library in filters/odftraverse. The purpose of this > library is to create classes to make it easier to create export filters for > ODF files. What you do to use this library is that you inherit a base class > for backends to this parser / traverser and in the many callbacks you write > the output that is relevant for your output format. > > To show how it can be used I have also created a very simple proof of concept > filter that exports to text format, something Calligra actually lacked before. > > The current implementation traverses only ODT files and there are still a > number of NYI functions that I want to finish before the actual merge. But I > thought I'd get some opinions early. In other words, I expect at least one, > maybe two iterations before this branch can be merged. > > > Diffs > ----- > > filters/CMakeLists.txt 8bcd640 > filters/libodftraverse/CMakeLists.txt PRE-CREATION > filters/libodftraverse/OdfParser.h PRE-CREATION > filters/libodftraverse/OdfParser.cpp PRE-CREATION > filters/libodftraverse/OdfTraverserContext.h PRE-CREATION > filters/libodftraverse/OdfTraverserContext.cpp PRE-CREATION > filters/libodftraverse/OdtTraverser.h PRE-CREATION > filters/libodftraverse/OdtTraverser.cpp PRE-CREATION > filters/libodftraverse/OdtTraverserBackend.h PRE-CREATION > filters/libodftraverse/OdtTraverserBackend.cpp PRE-CREATION > filters/libodftraverse/odftraverse_export.h PRE-CREATION > filters/words/ascii/AsciiExport.h PRE-CREATION > filters/words/ascii/AsciiExport.cpp PRE-CREATION > filters/words/ascii/CMakeLists.txt d36de47 > filters/words/ascii/OdtTraverserAsciiBackend.h PRE-CREATION > filters/words/ascii/OdtTraverserAsciiBackend.cpp PRE-CREATION > filters/words/ascii/TODO ceb1a24 > filters/words/ascii/words_ascii_export.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109393/diff/ > > > Testing > ------- > > Tested with a lengthy text file. > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
