Re: Deprecation of QtScript

nt including more porting documentation. But don't expect active development of the module to happen either. For many simple use cases, QJSEngine can act as drop in replacement by the way, so we do care about the migration path and try to keep API compatible whe

Re: Bug 184325 - amarok wish: fetch lyrics from the ID3 lyrics tag

On Feb 1, 2015 5:20 AM, "Be" wrote: > > Nice, it works now. I think this implementation is awkward though. I > don't think this should be left to each individual lyrics script to > implement. Rather, Amarok should check if the file has lyrics in the > tags first, then only run a lyrics script if t

Re: Bug 184325 - amarok wish: fetch lyrics from the ID3 lyrics tag

On Wed, Jan 28, 2015 at 5:13 PM, Myriam Schweingruber wrote: > Anmol, if you talk about "current git", I presume you mean your repo, right? > IIRC this was not merged to git master yet. Nope, it is already committed. -- Regards, Anmol Ahuja __

Re: Bug 184325 - amarok wish: fetch lyrics from the ID3 lyrics tag

solved asynchronously, you should check if it has loaded before using it (unneeded for the currently playing one): if( !track.isLoaded ) track.loaded.connect( ); else ( track ); -- Regards, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Bug 184325 - amarok wish: fetch lyrics from the ID3 lyrics tag

f showing only one of them." The current developers decided multi lyrics are too niche a feature to bother implementing. So instead, you could work on making the rest of Amarok aware of the lyrics tags. -- Regards, Anmol Ahuja ___ Amarok-devel mailing

Re: Hello and proposal/brainstorming for SoundCloud service

res would be awesome: > https://bugs.kde.org/show_bug.cgi?id=342089 > https://bugs.kde.org/show_bug.cgi?id=342096 > https://bugs.kde.org/show_bug.cgi?id=342090 I am currently in the midst of my end term exams, so I'll be unable to help until January

Re: Hello and proposal/brainstorming for SoundCloud service

object. (line: 221)" Are you using the latest git build? -- Regards, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Hello and proposal/brainstorming for SoundCloud service

the bugtracker for anything necessary you think is missing, though again, I won't be able to do much until January. You can, of course, contribute if you like. -- Regards, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: calling external program via QtScript

You can invoke external programs using a QProcess, though directly calling the API in QtScript is obviously better. -- Regards, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: GMock

ago. I'll drop him another mail. -- Regards, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: GSoC Idea: better lyrics display and fetching

s. If no results are found I can couple this the better tagguessing feature (and even if the tags are not saved), the the lyrics providers can be searched with these guessed tags. Why not write a script for this? -- Regards, Anmol Ahuja ___ Amarok-devel

GMock

I'm having trouble getting gmock to build. Could you please update the wiki with instructions on how you got it to work? -- Regards, Anmol ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

/tag_helpers/ID3v2TagHelper.cpp 03a3836 shared/tag_helpers/MP4TagHelper.cpp 23d8879 shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5 Diff: http://git.reviewboard.kde.org/r/113389/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing

Re: Review Request 113777: Lazy load scriptable service tracks

/scriptable/ScriptableServiceMeta.h 2db3951 src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp 75f4d01 Diff: http://git.reviewboard.kde.org/r/113777/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel

Re: Review Request 113387: GSoC 2013 Revamping Scripting - Part 4/6 : Script Console

Diff: http://git.reviewboard.kde.org/r/113387/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113385: GSoC 2013 Revamping Scripting - Part 2/6 : Script Manager

--- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113384: GSoC 2013 Revamping Scripting - Part 1/6 : Scripting wrappers

/exporters/QueryMakerExporter.cpp PRE-CREATION src/scriptengine/exporters/ScriptableBiasExporter.h PRE-CREATION src/scriptengine/exporters/ScriptableBiasExporter.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113384/diff/ Testing --- Thanks, Anmol Ahuja

Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

s weekend. - Anmol --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113389/#review44045 --- On Nov. 19, 2013, 11:57 p.m

Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

/tag_helpers/ID3v2TagHelper.cpp 03a3836 shared/tag_helpers/MP4TagHelper.cpp 23d8879 shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5 Diff: http://git.reviewboard.kde.org/r/113389/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing

Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

://git.reviewboard.kde.org/r/113389/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113390: GSoC 2013 Revamping Scripting - Part 6/6 : Misc src/

> On Nov. 16, 2013, 7:55 p.m., Mark Kretschmann wrote: > > src/configdialog/dialogs/ScriptsConfig.cpp, line 289 > > <http://git.reviewboard.kde.org/r/113390/diff/1/?file=204552#file204552line289> > > > > Can be changed to: > > > > return

Re: Review Request 113390: GSoC 2013 Revamping Scripting - Part 6/6 : Misc src/

; So where should it be? :) I'm not sure. The script is generating autocomplete strings for the script console, which could remain in cmake, and also generating a pseudo header for doxygen, which should probably be done on the server where doxygen is run. I'll separate em. - Anm

Re: Review Request 113384: GSoC 2013 Revamping Scripting - Part 1/6 : Scripting wrappers

p://git.reviewboard.kde.org/r/113384/#review43805 ------- On Oct. 22, 2013, 9:37 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 113777: Lazy load scriptable service tracks

> On Nov. 10, 2013, 3:24 p.m., Matěj Laitl wrote: > > Looks good to me, but please test that scriptable service tracks that are > > (remote) playlists do play right away when you double-click on them. (with > > play on double-click enabled) > > Anmol Ahuja wrote:

Re: Review Request 113777: Lazy load scriptable service tracks

------- On Nov. 10, 2013, 2:51 a.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113777/ >

Review Request 113777: Lazy load scriptable service tracks

--- Prevent all the scriptable services from loading playlists at Amarok launch. Diffs - src/services/scriptable/ScriptableServiceMeta.h 2db3951 src/services/scriptable/ScriptableServiceMeta.cpp 8e96785 Diff: http://git.reviewboard.kde.org/r/113777/diff/ Testing --- Thanks, Anmol

Re: Handling of lyrics for tracks not in the Local Collection

> Then we should implement to save the lyrics to the id3 tag, that would > be this feature request: https://bugs.kde.org/show_bug.cgi?id=291727 Maybe you could work on my branch- it has the lyrics tags handled in taglib. I did mod the bundled lyrics script to optionally allow embedding lyrics, b

Re: Review Request 111449: Week 3: Revamping Amarok's Scripting Interface

ee8bdfa src/services/scriptable/ScriptableServiceInfoParser.cpp 998135b src/services/scriptable/ScriptableServiceManager.cpp aa28a6c src/services/scriptable/ScriptableServiceQueryMaker.cpp 8a6d536 Diff: http://git.reviewboard.kde.org/r/111449/diff/ Testing --- Thanks, Anmol

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

-CREATION src/scriptengine/exporters/QueryMakerExporter.h PRE-CREATION src/scriptengine/exporters/QueryMakerExporter.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111343/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing

Re: Review Request 111212: Kill long running scripts

: http://git.reviewboard.kde.org/r/111212/diff/ Testing --- File Attachments script http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/benchmark.zip Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel

Re: Review Request 111552: Week 4 : Revamping Amarok's Scripting Interface

/111552/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113356: GSoC 2013: Revamping Amarok's Scripting Interface

/ScriptableServiceQueryMaker.cpp 07233dd Diff: http://git.reviewboard.kde.org/r/113356/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113356: GSoC 2013: Revamping Amarok's Scripting Interface

---- On Oct. 20, 2013, 6:43 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113356/ > -

Review Request 113384: GSoC 2013 Revamping Scripting - Part 1/6 : Scripting wrappers

/scriptengine/exporters/ScriptableBiasExporter.h PRE-CREATION src/scriptengine/exporters/ScriptableBiasExporter.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113384/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list

Review Request 113387: GSoC 2013 Revamping Scripting - Part 4/6 : Script Console

/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 113390: GSoC 2013 Revamping Scripting - Part 6/6 : Misc src/

/ScriptableServiceQueryMaker.cpp 07233dd Diff: http://git.reviewboard.kde.org/r/113390/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 113386: GSoC 2013 Revamping Scripting - Part 3/6 : Scripts

/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 113385: GSoC 2013 Revamping Scripting - Part 2/6 : Script Manager

/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

shared/tag_helpers/ID3v2TagHelper.cpp 03a3836 shared/tag_helpers/MP4TagHelper.cpp 23d8879 shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5 Diff: http://git.reviewboard.kde.org/r/113389/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok

Review Request 113356: GSoC 2013: Revamping Amarok's Scripting Interface

/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Amarok Scripting API

> like maybe the ContextView, and perhaps tagging. > Sounds good. I seem to have skipped podcasts too. --- Anmol ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Amarok Scripting API

Amarok Scripting API Status 2.0 Existing: Amarok.Lyrics public slots: void showLyrics( const QString& lyrics ) const; void showLyricsHtml( const QString& lyrics ) const; void showLyricsError( const QString& error ) const; void showLyricsNotFound( co

Re: Amarok Scripting API

> Right, but I see three different colors. Grey, a very light grey, and black. That particular variation is unintentional. ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Amarok Scripting API

> I think he means that the grey ones existed from before and the black ones were added by him. Yep, that's it. I'm sorry, I should've clarified. ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Amarok Scripting API

Here's the current state of the Amarok Scripting API. : Amarok.Lyrics public slots: void showLyrics( const QString& lyrics ) const; void showLyricsHtml( const QString& lyrics ) const; void showLyricsError( const QString& error ) const; void showLyric

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109369/#review38520 --- On March 12, 2013, 11:57 p.m., Anmol Ahuja wrote: > > -

[no subject]

I'm been working on Amarok's scripting interface as part of my GSoC project, and Mark and I were wondering about making the UI scriptable to some extent. But the question is, how much can [and should] we expose? --- Anmol Ahuja ___ Amarok-dev

Re: Feature Request: Multithreaded transcoding [Bug 317093]

On Wed, Jul 24, 2013 at 3:31 AM, vedant agarwala wrote: > Hey Anmol are working on this bug? If not, I would take want to take it up. > No, I'm not working on this. Feel free to take it up. :) --- Anmol ___ Amarok-devel mailing list Amarok-devel@kde.or

Review Request 111552: Week 4 : Revamping Amarok's Scripting Interface

ATION src/scriptmanager/ScriptItem.cpp PRE-CREATION src/scriptmanager/ScriptManager.h PRE-CREATION src/scriptmanager/ScriptManager.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111552/diff/ Testing --- Thanks, Anmol Ahuja ___ A

Re: Review Request 111552: Week 4 : Revamping Amarok's Scripting Interface

src/scriptmanager/ScriptItem.h PRE-CREATION src/scriptmanager/ScriptItem.cpp PRE-CREATION src/scriptmanager/ScriptManager.h PRE-CREATION src/scriptmanager/ScriptManager.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111552/diff/ Testing --- Thanks, Anmol Ahuja

Review Request 111449: Week 3: Revamping Amarok's Scripting Interface

/ScriptableServiceManager.cpp aa28a6c src/services/scriptable/ScriptableServiceQueryMaker.cpp 8a6d536 Diff: http://git.reviewboard.kde.org/r/111449/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

ard.kde.org/r/111343/#review35427 --- On July 2, 2013, 5:53 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

-CREATION src/scriptengine/exporters/QueryMakerExporter.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111343/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

://git.reviewboard.kde.org/r/111343/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 111212: Kill long running scripts

o. I'm sorry, I don't know how I could've left them. - Anmol --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111212/#review35095 ------

Re: Review Request 111212: Kill long running scripts

://git.reviewboard.kde.org/r/111212/diff/ Testing --- File Attachments script http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/benchmark.zip Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https

Re: Review Request 111212: Kill long running scripts

/AmarokScriptableServiceScript.cpp a312671 Diff: http://git.reviewboard.kde.org/r/111212/diff/ Testing --- File Attachments (updated) script http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/benchmark.zip Thanks, Anmol Ahuja ___ Amarok

Re: Review Request 111212: Kill long running scripts

cally generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111212/#review35037 ------- On June 24, 2013, 4:10 p.m., Anmol Ahuja wrote: > > --- >

Re: Review Request 111212: Kill long running scripts

/AmarokScriptableServiceScript.cpp a312671 Diff: http://git.reviewboard.kde.org/r/111212/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 111212: Kill long running scripts

://git.reviewboard.kde.org/r/111212/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 110362: BR 317385 - Command line options like --queue and --append do not work

ents in the report. I'm debugging this currently. > > Anmol Ahuja wrote: > I'm sorry, it doesn't solve the complete problem. > > According to the bug report: > "Expected Results: > 1) look for the actual song/url on the current playlist,

Re: GSoC Application Review

On Thu, May 2, 2013 at 6:59 AM, Matěj Laitl wrote: > On 2. 5. 2013 Anmol Ahuja wrote: > > Short description: My > > proposal aims at revamping the Amarok scripting interface, and adding an > > intuitive Script Creator graphical application allowing easy script > >

Re: GSoC Application Review

On Thu, May 2, 2013 at 6:32 AM, Matěj Laitl wrote: > On 30. 4. 2013 Anmol Ahuja wrote: > > On Tue, Apr 30, 2013 at 3:56 AM, Matěj Laitl wrote: > > > Right, although I'd remove the "porting popular A 1.4 scripts" - there > are > > > more useful thing

Re: GSoC Application Review

On Thu, May 2, 2013 at 3:09 AM, Matěj Laitl wrote: > On 2. 5. 2013 Anmol Ahuja wrote: > > Here's a new version of the proposal. Some things like suspend inhibition > > and transcoding are still tentative, since I am awaiting a response to my > > previous email. > &

Re: GSoC Application Review

On Tue, Apr 30, 2013 at 7:20 PM, Anmol Ahuja wrote: > > >> > - Synchronization Job >> >> Do you mean statistics synchronization? Perhaps even more useful would be >> to >> expose "Track matching job" is some way. > > Okay, I&

Re: GSoC Application Review

It wasn't supposed to be private, that was accidental. Resending it to the amarok-devel mailing list. Thanks for the thorough review :) On Tue, Apr 30, 2013 at 3:56 AM, Matěj Laitl wrote: > On 30. 4. 2013 Anmol Ahuja wrote: > > And for classes like CollectionLocation, should I c

Re: GSoC Application Review

> Just one remark about your availability: June 4 to June 17 is almost 2 > weeks you will not be available, and according to your time-line you > have quite some stuff planed for that time: > > June 31 - July 6 : Write QtScriptObject for Querymaker and > Bookmarks. Add accessor for QueryMaker to

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

as expected All build tests passed File Attachments TranscodingAssistantDialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png Thanks, Anmol Ahuja ___ Amarok-devel mail

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

as expected All build tests passed File Attachments TranscodingAssistantDialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png Thanks, Anmol Ahuja ___ Amarok-devel mail

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

as expected All build tests passed File Attachments TranscodingAssistantDialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png Thanks, Anmol Ahuja ___ Amarok-devel mail

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

as expected All build tests passed File Attachments TranscodingAssistantDialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png Thanks, Anmol Ahuja ___ Amarok-devel mail

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

re. (there's a switch > > case for it, but it now newer fires AFAICS) > > Anmol Ahuja wrote: > It is, when the save configuration isJustCopy() and when it's invalid. > > Either of those cases can be replaced by the three newly added enums, > s

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

re. (there's a switch > > case for it, but it now newer fires AFAICS) > > Anmol Ahuja wrote: > It is, when the save configuration isJustCopy() and when it's invalid. > > Either of those cases can be replaced by the three newly added enums, > s

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

: http://git.reviewboard.kde.org/r/109781/#review31374 ------- On April 19, 2013, 1:47 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-m

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

) - Anmol --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109817/#review31274 --- On April 19, 2013, 6:12 p.m., Anmol Ahuja wrote: > &

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

://git.reviewboard.kde.org/r/109817/diff/ Testing (updated) --- Works as expected Build tests passed Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

rd.kde.org/r/109781/diff/ Testing --- Works as expected All build tests passed File Attachments TranscodingAssistantDialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png Thanks, Anmol Ahuja __

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

me() semantics and to > > show also all other TrackSelection choices for given encoder and parameters. > > Anmol Ahuja wrote: > I can't seem to be able to mark those issues on the screenshot as fixed, > or even comment on them! "Also please adapt Transcoding::Sele

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

cally generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/#review30949 --- On April 18, 2013, 10:35 p.m., Anmol Ahuja wrote: > > --- > This is an automa

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

t be okay? I haven't changed this yet. - Anmol --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/#review30949 ------- On April 18, 2013, 10:35 p.m., Anmol Ahuja wrote: > > -

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

ttp://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

viewboard.kde.org/r/109817/#review31014 --- On April 18, 2013, 8:48 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

://git.reviewboard.kde.org/r/109817/diff/ Testing --- Works as expected Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

---- On April 13, 2013, 7:08 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109817/ > --

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109817/#review30947 --- On April 13, 2013, 7:08 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://gi

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

/AmpacheMeta.cpp b59715c src/services/lastfm/meta/LastFmMeta.h 9c54a10 src/services/lastfm/meta/LastFmMeta.cpp 424d136 Diff: http://git.reviewboard.kde.org/r/109817/diff/ Testing --- Works as expected Thanks, Anmol Ahuja ___ Amarok-devel

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

/ampache/AmpacheMeta.h 934fe75 src/services/ampache/AmpacheMeta.cpp b59715c src/services/lastfm/meta/LastFmMeta.h 9c54a10 src/services/lastfm/meta/LastFmMeta.cpp 424d136 Diff: http://git.reviewboard.kde.org/r/109817/diff/ Testing --- Works as expected Thanks, Anmol Ahuja

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

expected Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

a.cpp b59715c src/services/lastfm/meta/LastFmMeta.h 9c54a10 src/services/lastfm/meta/LastFmMeta.cpp 424d136 Diff: http://git.reviewboard.kde.org/r/109817/diff/ Testing --- Works as expected Thanks, Anmol Ahuja ___ Amarok-devel mailing list

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

as expected All build tests passed File Attachments Transcoding-Assistant Dialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/snapshot12.png Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@k

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

passed File Attachments (updated) Transcoding-Assistant Dialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/snapshot12.png Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

t? Also please > > rename transConfig to trackSelection and don't provide default value for it. > > Anmol Ahuja wrote: > But with the default value, don't calls like: > Transcoding::Configuration configuration( Transcoding::JUST_COPY ); > seem be

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

::JUST_COPY, Transcoding::Configuration::TranscodeAll ); - Anmol --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/#review30336 ------

Re: Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing

rd.kde.org/media/uploaded/files/2013/04/03/snapshot11.png Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Modify build-test CMake?

In this patch here, BR 259862,222571: Add options to pause playback on suspend and inhibit automatic suspend if playing should I modify the tests/ cmake files [tests/core-impl/meta/multi/CMakeLists.txt] and [tests/playlist/CMakeLists.txt] so as not to

Re: Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing

backConfig Dialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

uot;. > > > > Maybe it has sense to intoduce virutal > > Meta::Track::notPlayableReason(), but that would require acknowledge from > > other developers. > > Anmol Ahuja wrote: > But the problem is specific to only local files. > And I'm not ch

Re: Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing

og/dialogs/PlaybackConfig.ui 3a79e43 Diff: http://git.reviewboard.kde.org/r/109846/diff/ Testing --- Works as expected File Attachments PlaybackConfig Dialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png Thanks, A

Re: Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing

fig Dialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Amarok and system suspend behaviour

y, I'll change the defaults. Also please test whether the Sleep button works if the first checkbox is > checked and Amarok is playing. The sleep button works as usual, it counts as manual sleep. I did try it myself, and confirmed on #solid. --- Anmol Ahuja

  1   2   >