> On June 26, 2013, 1:42 p.m., Mark Kretschmann wrote: > > src/amarokconfig.kcfg, line 583 > > <http://git.reviewboard.kde.org/r/111212/diff/3/?file=165737#file165737line583> > > > > Please do actually remove the options, including the GUI for them too.
I'm sorry, I don't know how I could've left them. - Anmol ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111212/#review35095 ----------------------------------------------------------- On June 26, 2013, 5:23 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111212/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 5:23 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Added the ability to kill a long running script. > Refactored a bit. > > > Diffs > ----- > > src/scriptengine/AmarokScriptableServiceScript.cpp a312671 > src/ScriptManager.cpp ab09fcf > src/ScriptManager.h afaa832 > > Diff: http://git.reviewboard.kde.org/r/111212/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > script > http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/benchmark.zip > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel