> On July 2, 2013, 3:03 p.m., Mark Kretschmann wrote: > > src/scriptengine/AmarokCollectionScript.cpp, line 39 > > <http://git.reviewboard.kde.org/r/111343/diff/2/?file=166943#file166943line39> > > > > Use the KDE_DEPRECATED macro
I was intending the deprecation notification to be more for the users than us, so they can bug script writers to updating their scripts. - Anmol ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111343/#review35427 ----------------------------------------------------------- On July 2, 2013, 5:53 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111343/ > ----------------------------------------------------------- > > (Updated July 2, 2013, 5:53 p.m.) > > > Review request for Amarok and Mark Kretschmann. > > > Description > ------- > > Week 2: Added scripting interface for the collection management. > > > Diffs > ----- > > src/CMakeLists.txt 69a8ff4 > src/ScriptManager.h afaa832 > src/ScriptManager.cpp b7f0a5c > src/core/collections/Collection.h 7e2957d > src/core/collections/QueryMaker.h 92b6a65 > src/scriptengine/AmarokCollectionScript.h 5733947 > src/scriptengine/AmarokCollectionScript.cpp 3fcda84 > src/scriptengine/AmarokEngineScript.h aa2b112 > src/scriptengine/AmarokEngineScript.cpp 5471838 > src/scriptengine/AmarokPlaylistScript.h 28f9d7e > src/scriptengine/AmarokPlaylistScript.cpp 2dde634 > src/scriptengine/AmarokScriptableServiceScript.cpp a312671 > src/scriptengine/AmarokWindowScript.cpp c9a65ee > src/scriptengine/MetaTypeExporter.h 031e52b > src/scriptengine/MetaTypeExporter.cpp 5a515a6 > src/scriptengine/ScriptingDefines.h PRE-CREATION > src/scriptengine/exporters/CollectionTypeExporter.h PRE-CREATION > src/scriptengine/exporters/CollectionTypeExporter.cpp PRE-CREATION > src/scriptengine/exporters/MetaTypeExporter.h PRE-CREATION > src/scriptengine/exporters/MetaTypeExporter.cpp PRE-CREATION > src/scriptengine/exporters/QueryMakerExporter.h PRE-CREATION > src/scriptengine/exporters/QueryMakerExporter.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111343/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
