> On Nov. 10, 2013, 3:24 p.m., Matěj Laitl wrote: > > Looks good to me, but please test that scriptable service tracks that are > > (remote) playlists do play right away when you double-click on them. (with > > play on double-click enabled)
Okay > On Nov. 10, 2013, 3:24 p.m., Matěj Laitl wrote: > > src/services/scriptable/ScriptableServiceMeta.h, line 96 > > <http://git.reviewboard.kde.org/r/113777/diff/1/?file=212341#file212341line96> > > > > Please initialize (to false, probably) this basic type in constructor > > as it is random otherwise. It's set in the setUidUrl method, but I'll move it to the constructor. - Anmol ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113777/#review43325 ----------------------------------------------------------- On Nov. 10, 2013, 2:51 a.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113777/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2013, 2:51 a.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > Prevent all the scriptable services from loading playlists at Amarok launch. > > > Diffs > ----- > > src/services/scriptable/ScriptableServiceMeta.h 2db3951 > src/services/scriptable/ScriptableServiceMeta.cpp 8e96785 > > Diff: http://git.reviewboard.kde.org/r/113777/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
