> On Nov. 16, 2013, 5:54 p.m., Mark Kretschmann wrote: > > src/scriptengine/AmarokBookmarkScript.h, line 44 > > <http://git.reviewboard.kde.org/r/113384/diff/1/?file=204397#file204397line44> > > > > I think it is confusing to abuse the "slots" keyword like this. Is > > there an alternative? Or at least a comment should be added.
There is an alternative: usign the Q_INVOKABLE macro. - Anmol ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113384/#review43805 ----------------------------------------------------------- On Oct. 22, 2013, 9:37 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113384/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2013, 9:37 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > The scripting wrappers written as part of my project. > > > Diffs > ----- > > src/scriptengine/AmarokPlaylistManagerScript.h PRE-CREATION > src/scriptengine/AmarokOSDScript.cpp 659cd68 > src/scriptengine/AmarokOSDScript.h 992fcee > src/scriptengine/AmarokNetworkScript.cpp 0eaa440 > src/scriptengine/AmarokLyricsScript.cpp b1972fa > src/scriptengine/AmarokNetworkScript.h 785a645 > src/scriptengine/AmarokLyricsScript.h a47c609 > src/scriptengine/AmarokKNotifyScript.cpp b98efed > src/scriptengine/AmarokKNotifyScript.h 720f9f6 > src/scriptengine/AmarokInfoScript.cpp 4d06568 > src/scriptengine/AmarokEqualizerScript.cpp PRE-CREATION > src/scriptengine/AmarokInfoScript.h 754498e > src/scriptengine/AmarokEqualizerScript.h PRE-CREATION > src/scriptengine/AmarokEngineScript.cpp 5471838 > src/scriptengine/AmarokEngineScript.h aa2b112 > src/scriptengine/AmarokCollectionViewScript.cpp PRE-CREATION > src/scriptengine/AmarokCollectionViewScript.h PRE-CREATION > src/scriptengine/AmarokCollectionScript.cpp 3fcda84 > src/scriptengine/AmarokBookmarkScript.cpp PRE-CREATION > src/scriptengine/AmarokCollectionScript.h 224bd54 > src/scriptengine/AmarokBookmarkScript.h PRE-CREATION > src/scriptengine/AmarokPlaylistManagerScript.cpp PRE-CREATION > src/scriptengine/AmarokPlaylistScript.h a9df74e > src/scriptengine/AmarokPlaylistScript.cpp 2dde634 > src/scriptengine/AmarokScript.h 4ec6d8f > src/scriptengine/AmarokScript.cpp b21a2ec > src/scriptengine/AmarokScriptConfig.h a77418f > src/scriptengine/AmarokScriptConfig.cpp 457104a > src/scriptengine/AmarokScriptableServiceScript.h 6afacfa > src/scriptengine/AmarokScriptableServiceScript.cpp a312671 > src/scriptengine/AmarokServicePluginManagerScript.h ed7f307 > src/scriptengine/AmarokServicePluginManagerScript.cpp 86f841c > src/scriptengine/AmarokStatusbarScript.h c871213 > src/scriptengine/AmarokStatusbarScript.cpp 6efbb38 > src/scriptengine/AmarokStreamItemScript.h PRE-CREATION > src/scriptengine/AmarokStreamItemScript.cpp PRE-CREATION > src/scriptengine/AmarokWindowScript.h 5b18e18 > src/scriptengine/AmarokWindowScript.cpp c9a65ee > src/scriptengine/MetaTypeExporter.h ec961e8 > src/scriptengine/MetaTypeExporter.cpp d832181 > src/scriptengine/PHAACG2.py PRE-CREATION > src/scriptengine/ScriptImporter.h 7ae9155 > src/scriptengine/ScriptImporter.cpp 672cd24 > src/scriptengine/ScriptingDefines.h PRE-CREATION > src/scriptengine/ScriptingDefines.cpp PRE-CREATION > src/scriptengine/exporters/CollectionTypeExporter.h PRE-CREATION > src/scriptengine/exporters/CollectionTypeExporter.cpp PRE-CREATION > src/scriptengine/exporters/PlaylistExporter.h PRE-CREATION > src/scriptengine/exporters/PlaylistExporter.cpp PRE-CREATION > src/scriptengine/exporters/PlaylistProviderExporter.h PRE-CREATION > src/scriptengine/exporters/PlaylistProviderExporter.cpp PRE-CREATION > src/scriptengine/exporters/QueryMakerExporter.h PRE-CREATION > src/scriptengine/exporters/QueryMakerExporter.cpp PRE-CREATION > src/scriptengine/exporters/ScriptableBiasExporter.h PRE-CREATION > src/scriptengine/exporters/ScriptableBiasExporter.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113384/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
