from:"christian\-david"

[Kmymoney-devel] [kmymoney4] [Bug 327374] problems while getting bank details by HBCI

2013-11-11 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=327374

Christian David  changed:

   What|Removed |Added

 CC||christian-da...@web.de

--- Comment #1 from Christian David  ---
To my knowledge aqbanking, the library behind updating accounts via FinTS/HBCI,
does not support the update of investment-accounts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 313237] No payee matching with aqbanking import (HBCI)

2013-12-07 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=313237

--- Comment #10 from Christian David  ---
Git commit c836c3dec4509fb229cf2f71e31afe23512dac4e by Christian Dávid.
Committed on 07/12/2013 at 17:02.
Pushed by christiand into branch 'add-onlinebanking'.

Started adding onlinebanking including sending credit transfers

Started to add a system for creating jobs which can be executed by a
plugin.

Tasks for german and sepa credit transfers were ceated including ui.
KBanking (aqbanking) can use them to create credit transfers.

This is work in progress.
Related: bug 238105

M  +3-0.gitignore
M  +3-1CMakeLists.txt
M  +6-5kmymoney.doxygen.in
M  +5-3kmymoney/CMakeLists.txt
M  +6-0kmymoney/dialogs/CMakeLists.txt
A  +198  -0kmymoney/dialogs/konlinetransferform.cpp [License: GPL
(v2+)]
A  +120  -0kmymoney/dialogs/konlinetransferform.h [License: GPL (v2+)]
A  +254  -0kmymoney/dialogs/konlinetransferformdecl.ui
M  +131  -2kmymoney/kmymoney.cpp
M  +40   -0kmymoney/kmymoney.h
M  +5-0kmymoney/models/CMakeLists.txt
M  +1-1kmymoney/models/accountsmodel.cpp
M  +15   -1kmymoney/models/models.cpp
M  +2-0kmymoney/models/models.h
A  +139  -0kmymoney/models/onlinejobmodel.cpp [License: UNKNOWN]  *
A  +49   -0kmymoney/models/onlinejobmodel.h [License: UNKNOWN]  *
M  +64   -7kmymoney/mymoney/CMakeLists.txt
A  +21   -0kmymoney/mymoney/accountidentifier.cpp [License: GPL (v2+)]
A  +65   -0kmymoney/mymoney/accountidentifier.h [License: GPL (v2+)]
A  +1-0kmymoney/mymoney/bankaccountidentifier.cpp [License: Trivial
file]
A  +53   -0kmymoney/mymoney/bankaccountidentifier.h [License: UNKNOWN] 
*
A  +114  -0kmymoney/mymoney/germanaccountidentifier.cpp [License:
UNKNOWN]  *
A  +61   -0kmymoney/mymoney/germanaccountidentifier.h [License:
UNKNOWN]  *
A  +161  -0kmymoney/mymoney/germanonlinetransfer.cpp [License: GPL
(v2+)]
A  +154  -0kmymoney/mymoney/germanonlinetransfer.h [License: GPL (v2+)]
M  +69   -0kmymoney/mymoney/mymoneyfile.cpp
M  +47   -1kmymoney/mymoney/mymoneyfile.h
M  +156  -0kmymoney/mymoney/mymoneyfiletest.cpp
M  +7-0kmymoney/mymoney/mymoneyfiletest.h
M  +8-0kmymoney/mymoney/mymoneyobjectcontainer.cpp
M  +4-0kmymoney/mymoney/mymoneyobjectcontainer.h
A  +174  -0kmymoney/mymoney/onlinejob.cpp [License: GPL (v2+)]
A  +289  -0kmymoney/mymoney/onlinejob.h [License: GPL (v2+)]
A  +213  -0kmymoney/mymoney/onlinejobadministration.cpp [License:
UNKNOWN]  *
A  +134  -0kmymoney/mymoney/onlinejobadministration.h [License:
UNKNOWN]  *
A  +50   -0kmymoney/mymoney/onlinejobadministrationtest.cpp [License:
UNKNOWN]  *
A  +24   -0kmymoney/mymoney/onlinejobadministrationtest.h [License:
UNKNOWN]  *
A  +5-0kmymoney/mymoney/onlinejobfolder.cpp [License: UNKNOWN]  *
A  +42   -0kmymoney/mymoney/onlinejobfolder.h [License: UNKNOWN]  *
A  +113  -0kmymoney/mymoney/onlinejobknowntask.h [License: UNKNOWN]  *
A  +49   -0kmymoney/mymoney/onlinejobknowntasktest.cpp [License:
UNKNOWN]  *
A  +20   -0kmymoney/mymoney/onlinejobknowntasktest.h [License: UNKNOWN]
 *
A  +9-0kmymoney/mymoney/onlinejobmessage.cpp [License: UNKNOWN]  *
A  +73   -0kmymoney/mymoney/onlinejobmessage.h [License: UNKNOWN]  *
A  +57   -0kmymoney/mymoney/onlinejobtest.cpp [License: UNKNOWN]  *
A  +21   -0kmymoney/mymoney/onlinejobtest.h [License: UNKNOWN]  *
A  +28   -0kmymoney/mymoney/onlinetask.cpp [License: UNKNOWN]  *
A  +240  -0kmymoney/mymoney/onlinetask.h [License: UNKNOWN]  *
A  +32   -0kmymoney/mymoney/onlinetransfer.cpp [License: GPL (v2+)]
A  +71   -0kmymoney/mymoney/onlinetransfer.h [License: GPL (v2+)]
A  +116  -0kmymoney/mymoney/sepaonlinetransfer.cpp [License: UNKNOWN] 
*
A  +96   -0kmymoney/mymoney/sepaonlinetransfer.h [License: UNKNOWN]  *
M  +2-1kmymoney/mymoney/storage/CMakeLists.txt
M  +3-0kmymoney/mymoney/storage/imymoneyserialize.h
M  +34   -0kmymoney/mymoney/storage/imymoneystorage.h
M  +10   -0kmymoney/mymoney/storage/mymoneydatabasemgr.h
M  +60   -0kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp
M  +38   -0kmymoney/mymoney/storage/mymoneyseqaccessmgr.h
M  +21   -0kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp
M  +1-0kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.h
A  +2-0kmymoney/mymoney/swiftaccountidentifier.cpp [License:
UNKNOWN]  *
A  +39   -0kmymoney/mymoney/swiftaccountidentifier.h [License: UNKNOWN]
 *
M  +16   -5kmymoney/plugins/CMakeLists.txt
M  +9-0kmymoney/plugins/kbanking/CMakeLists.txt
A  +52   -0kmymoney/plugins/kbanking/aqbankingkmmoperators.cpp
[License: UNKNOWN]  *
A  +44   -0kmymoney/plugins/kbanking/aqbankingkmmoperators.h [License:
UNKNOWN]  *
A

[Kmymoney-devel] [kmymoney4] [Bug 238105] Support for money transfers and chip card readers for authentication

2013-12-07 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=238105

--- Comment #8 from Christian David  ---
Git commit c836c3dec4509fb229cf2f71e31afe23512dac4e by Christian Dávid.
Committed on 07/12/2013 at 17:02.
Pushed by christiand into branch 'add-onlinebanking'.

Started adding onlinebanking including sending credit transfers

Started to add a system for creating jobs which can be executed by a
plugin.

Tasks for german and sepa credit transfers were ceated including ui.
KBanking (aqbanking) can use them to create credit transfers.

This is work in progress.
Related: bug 313237

M  +3-0.gitignore
M  +3-1CMakeLists.txt
M  +6-5kmymoney.doxygen.in
M  +5-3kmymoney/CMakeLists.txt
M  +6-0kmymoney/dialogs/CMakeLists.txt
A  +198  -0kmymoney/dialogs/konlinetransferform.cpp [License: GPL
(v2+)]
A  +120  -0kmymoney/dialogs/konlinetransferform.h [License: GPL (v2+)]
A  +254  -0kmymoney/dialogs/konlinetransferformdecl.ui
M  +131  -2kmymoney/kmymoney.cpp
M  +40   -0kmymoney/kmymoney.h
M  +5-0kmymoney/models/CMakeLists.txt
M  +1-1kmymoney/models/accountsmodel.cpp
M  +15   -1kmymoney/models/models.cpp
M  +2-0kmymoney/models/models.h
A  +139  -0kmymoney/models/onlinejobmodel.cpp [License: UNKNOWN]  *
A  +49   -0kmymoney/models/onlinejobmodel.h [License: UNKNOWN]  *
M  +64   -7kmymoney/mymoney/CMakeLists.txt
A  +21   -0kmymoney/mymoney/accountidentifier.cpp [License: GPL (v2+)]
A  +65   -0kmymoney/mymoney/accountidentifier.h [License: GPL (v2+)]
A  +1-0kmymoney/mymoney/bankaccountidentifier.cpp [License: Trivial
file]
A  +53   -0kmymoney/mymoney/bankaccountidentifier.h [License: UNKNOWN] 
*
A  +114  -0kmymoney/mymoney/germanaccountidentifier.cpp [License:
UNKNOWN]  *
A  +61   -0kmymoney/mymoney/germanaccountidentifier.h [License:
UNKNOWN]  *
A  +161  -0kmymoney/mymoney/germanonlinetransfer.cpp [License: GPL
(v2+)]
A  +154  -0kmymoney/mymoney/germanonlinetransfer.h [License: GPL (v2+)]
M  +69   -0kmymoney/mymoney/mymoneyfile.cpp
M  +47   -1kmymoney/mymoney/mymoneyfile.h
M  +156  -0kmymoney/mymoney/mymoneyfiletest.cpp
M  +7-0kmymoney/mymoney/mymoneyfiletest.h
M  +8-0kmymoney/mymoney/mymoneyobjectcontainer.cpp
M  +4-0kmymoney/mymoney/mymoneyobjectcontainer.h
A  +174  -0kmymoney/mymoney/onlinejob.cpp [License: GPL (v2+)]
A  +289  -0kmymoney/mymoney/onlinejob.h [License: GPL (v2+)]
A  +213  -0kmymoney/mymoney/onlinejobadministration.cpp [License:
UNKNOWN]  *
A  +134  -0kmymoney/mymoney/onlinejobadministration.h [License:
UNKNOWN]  *
A  +50   -0kmymoney/mymoney/onlinejobadministrationtest.cpp [License:
UNKNOWN]  *
A  +24   -0kmymoney/mymoney/onlinejobadministrationtest.h [License:
UNKNOWN]  *
A  +5-0kmymoney/mymoney/onlinejobfolder.cpp [License: UNKNOWN]  *
A  +42   -0kmymoney/mymoney/onlinejobfolder.h [License: UNKNOWN]  *
A  +113  -0kmymoney/mymoney/onlinejobknowntask.h [License: UNKNOWN]  *
A  +49   -0kmymoney/mymoney/onlinejobknowntasktest.cpp [License:
UNKNOWN]  *
A  +20   -0kmymoney/mymoney/onlinejobknowntasktest.h [License: UNKNOWN]
 *
A  +9-0kmymoney/mymoney/onlinejobmessage.cpp [License: UNKNOWN]  *
A  +73   -0kmymoney/mymoney/onlinejobmessage.h [License: UNKNOWN]  *
A  +57   -0kmymoney/mymoney/onlinejobtest.cpp [License: UNKNOWN]  *
A  +21   -0kmymoney/mymoney/onlinejobtest.h [License: UNKNOWN]  *
A  +28   -0kmymoney/mymoney/onlinetask.cpp [License: UNKNOWN]  *
A  +240  -0kmymoney/mymoney/onlinetask.h [License: UNKNOWN]  *
A  +32   -0kmymoney/mymoney/onlinetransfer.cpp [License: GPL (v2+)]
A  +71   -0kmymoney/mymoney/onlinetransfer.h [License: GPL (v2+)]
A  +116  -0kmymoney/mymoney/sepaonlinetransfer.cpp [License: UNKNOWN] 
*
A  +96   -0kmymoney/mymoney/sepaonlinetransfer.h [License: UNKNOWN]  *
M  +2-1kmymoney/mymoney/storage/CMakeLists.txt
M  +3-0kmymoney/mymoney/storage/imymoneyserialize.h
M  +34   -0kmymoney/mymoney/storage/imymoneystorage.h
M  +10   -0kmymoney/mymoney/storage/mymoneydatabasemgr.h
M  +60   -0kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp
M  +38   -0kmymoney/mymoney/storage/mymoneyseqaccessmgr.h
M  +21   -0kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp
M  +1-0kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.h
A  +2-0kmymoney/mymoney/swiftaccountidentifier.cpp [License:
UNKNOWN]  *
A  +39   -0kmymoney/mymoney/swiftaccountidentifier.h [License: UNKNOWN]
 *
M  +16   -5kmymoney/plugins/CMakeLists.txt
M  +9-0kmymoney/plugins/kbanking/CMakeLists.txt
A  +52   -0kmymoney/plugins/kbanking/aqbankingkmmoperators.cpp
[License: UNKNOWN]  *
A  +44   -0kmymoney/plugins/kbanking/aqbankingkmmoperators.h [License:
UNKNOWN]  *
A

[Kmymoney-devel] [kmymoney4] [Bug 328967] New: An exception in a slot called by a signal emitted in MyMoneyFile::commitTransaction() causes a crash with useless error message

2013-12-18 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=328967

Bug ID: 328967
   Summary: An exception in a slot called by a signal emitted in
MyMoneyFile::commitTransaction() causes a crash with
useless error message
Classification: Unclassified
   Product: kmymoney4
   Version: git master
  Platform: Compiled Sources
OS: All
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: christian-da...@web.de

An exception in a slot called by a signal emitted in
MyMoneyFile::commitTransaction() causes a crash in a way that it is really hard
for a developer to find the root of all evil.

The reason is that the MyMoneyFileTransaction can have m_needRollback == true
even if the commit was finished and MyMoneyFile::d->m_inTransaction was set
false already.

An uncaught exception causes the MyMoneyFileTransaction to be destructed which
starts a rollback then. MyMoneyFile::rollbackTransaction() detects that no
transaction was started (because it is finished already). This leads to another
exception which makes it really hard to find the bug.

During normal usage this should not happen anyway and the data is as save as in
any other uncaught exception. It is unlikly that this leads to other bugs. Just
reported it here because a bug based on this is really hard to find and share
my experience. A fix is not urgent nor necessary.

Reproducible: Always

Steps to Reproduce:
1. connect a slot to any signal of MyMoneyFile (which is emitted during
commitTransaction())
2. throw an exception in this slot
3. change data & commit a transaction in a way that your slot called
Actual Results:  
KMyMoney crashes with unusable error message.

Expected Results:  
Crash with usable error message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 249403] new payee fields: bank code number and account number

2013-12-27 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=249403

Christian David  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 CC||christian-da...@web.de
   Assignee|kmymoney-devel@kde.org  |christian-da...@web.de
 Ever confirmed|0   |1

--- Comment #3 from Christian David  ---
Stephan (not active on the mailing list) and I are working on this with support
of Thomas (assigend to me).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 115377: Added kconf_update file for listErroneousTransactionColor conf-key

2014-01-29 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115377/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

Added kconf_update file to automatically update configure-key 
listErronousTransactionColor to listErroneousTransactionColor

Changes were done in commit 65862e4e344490b781236062bb6876d2782e4def by Allen.

This is not really needed but shows how much we care about compatibility (also 
good for me to try review board).


Diffs
-

  kmymoney/CMakeLists.txt 593cda9 
  kmymoney/kmymoney.upd PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115377/diff/


Testing
---

Set listErronousTransactionColor in kmymoneyrc
kwriteconfig --file kmymoneyrc --group "List Options" --key 
"listErronousTransactionColor" --type color "#00ff00"

Moved kmymoney.upd to kconfig_update folder. And checked kmymoneyrc file and 
kconf_update logs => kmymoney.upd works

Installed kmymoney in test environment. kmymoney.upd file was moved to correct 
folder => CMakeLists.txt works


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 115377: Added kconf_update file for listErroneousTransactionColor conf-key

2014-01-31 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115377/
---

(Updated Jan. 31, 2014, 12:59 p.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
---

Added kconf_update file to automatically update configure-key 
listErronousTransactionColor to listErroneousTransactionColor

Changes were done in commit 65862e4e344490b781236062bb6876d2782e4def by Allen.

This is not really needed but shows how much we care about compatibility (also 
good for me to try review board).


Diffs
-

  kmymoney/CMakeLists.txt 593cda9 
  kmymoney/kmymoney.upd PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115377/diff/


Testing
---

Set listErronousTransactionColor in kmymoneyrc
kwriteconfig --file kmymoneyrc --group "List Options" --key 
"listErronousTransactionColor" --type color "#00ff00"

Moved kmymoney.upd to kconfig_update folder. And checked kmymoneyrc file and 
kconf_update logs => kmymoney.upd works

Installed kmymoney in test environment. kmymoney.upd file was moved to correct 
folder => CMakeLists.txt works


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 327374] problems while getting bank details by HBCI

2014-02-06 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=327374

Christian David  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
   Severity|normal  |task

--- Comment #3 from Christian David  ---
I marked this bug as "task". Because we won't be able to fix it without support
for investment accounts in aqBanking (which is not planned as far as I know).

What we can do is prevent aqBanking to map to investment accounts. This will
prevent the user to be confused and does not pretend features which are not
there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 313237] No payee matching with aqbanking import (HBCI)

2014-02-06 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=313237

Christian David  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #11 from Christian David  ---
Shall we mark this bug as "won't fix"? We have no chance to solve this (see
comment 7).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 330946] "Treat text as regular expression" checkbox in text filter of transaction reports loses its state

2014-02-10 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=330946

Christian David  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||christian-da...@web.de
 Ever confirmed|0   |1

--- Comment #2 from Christian David  ---
Your bug report impressed me. Well done, thank you very much!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 330946] "Treat text as regular expression" checkbox in text filter of transaction reports loses its state

2014-02-10 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=330946

Christian David  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kmym
   ||oney/e13f7ddec5ed89a544947f
   ||2d742462aaf782ca02

--- Comment #3 from Christian David  ---
Git commit e13f7ddec5ed89a544947f2d742462aaf782ca02 by Christian Dávid.
Committed on 10/02/2014 at 15:59.
Pushed by christiand into branch 'master'.

Checkbox for regexps in reports configuration was set in a wrong manner

Only a "!" at a wrong place. Tested it with test-file applied with bug-
report.

M  +1-1kmymoney/dialogs/kreportconfigurationfilterdlg.cpp

http://commits.kde.org/kmymoney/e13f7ddec5ed89a544947f2d742462aaf782ca02

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 330946] "Treat text as regular expression" checkbox in text filter of transaction reports loses its state

2014-02-10 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=330946

Christian David  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/e13f7ddec5ed89a544947f |oney/aa9ce81665111774c808bf
   |2d742462aaf782ca02  |4c8b51e0b5c3f26a4a

--- Comment #4 from Christian David  ---
Git commit aa9ce81665111774c808bf4c8b51e0b5c3f26a4a by Christian Dávid.
Committed on 10/02/2014 at 15:59.
Pushed by christiand into branch '4.6'.

Checkbox for regexps in reports configuration was set in a wrong manner

Only a "!" at a wrong place. Tested it with test-file applied with bug-
report.
(cherry picked from commit e13f7ddec5ed89a544947f2d742462aaf782ca02)

M  +1-1kmymoney/dialogs/kreportconfigurationfilterdlg.cpp

http://commits.kde.org/kmymoney/aa9ce81665111774c808bf4c8b51e0b5c3f26a4a

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 115680: Performance optimization of the mymoney object container.

2014-02-11 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115680/#review49606
---



kmymoney/mymoney/mymoneyobjectcontainer.cpp
<https://git.reviewboard.kde.org/r/115680/#comment34944>

Only style: you can use qDeleteAll() for this ( 
http://qt-project.org/doc/qt-4.8/qtalgorithms.html#qDeleteAll-2 , map.clear() 
is still needed then)


- Christian David


On Feb. 11, 2014, 8:55 p.m., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115680/
> ---
> 
> (Updated Feb. 11, 2014, 8:55 p.m.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Performance optimization of the mymoney object container.
> 
> The MyMoneyObjectContainer::account(QString) was the most costly
> method of this class. Mainly due to the calls to dynamic_cast
> needed to obtain the cached MyMoneyObject with it's proper type.
> 
> Improved this by:
> 1. implementing a per object type cache.
> 2. using QHash instead of QMap which provides faster lookups
> 3. replace macro method implementation with template methods
> 
> Thomas again I need your blessing for this :). I removed all method 
> implementations by macros even though I have to admit that the file would be 
> shorter using macros.
> 
> 
> Diffs
> -
> 
>   kmymoney/mymoney/mymoneyobjectcontainer.h 
> 2abc0f06632b4c29f6443ab3ad66cccf6a4ce1d9 
>   kmymoney/mymoney/mymoneyobjectcontainer.cpp 
> 796d9aa8cb44de5a449bb54f1a46e313ff65cf0d 
> 
> Diff: https://git.reviewboard.kde.org/r/115680/diff/
> 
> 
> Testing
> ---
> 
> Ran unit test. Profiled application and observed a performance improvement.
> 
> 
> File Attachments
> 
> 
> File load before optimization
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/02/11/5a184cd9-42d1-4bbf-9fc2-0709b0987d14__file-load-before.png
> File load after optimization
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/02/11/4b430712-a66e-410c-9a1a-15f990370043__file-load-after.png
> Register load before optimization
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/02/11/eaa62d0b-1035-481e-a947-fac60fd6f388__register-load-before.png
> Register load after optimization
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/02/11/55f57547-1b6b-436e-bd23-89c43da23be8__register-load-after.png
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 313237] No payee matching with aqbanking import (HBCI)

2014-02-20 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=313237

Christian David  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #12 from Christian David  ---
Cannot be fixed in KMyMoney as it is an issue of the bank. (see comment #7)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 331636] Net Worth Adding Assets and Liabilities

2014-03-08 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=331636

Christian David  changed:

   What|Removed |Added

 CC||christian-da...@web.de

--- Comment #4 from Christian David  ---
This issue appears quite often. What about making it more clear? Like changing
"Net worth" to "Net worth (you owe)" and "Net worth (your deposit)".
Alternatively a tool-tip "You owe x $." if the value is positive or "Your
deposit is x $" if the value is negative. Of course x must be positive then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 110212: Add Merge Payee Option

2014-03-12 Thread Christian David



> On March 12, 2014, 2:33 p.m., Cristian Oneț wrote:
> > It looks good to me too.

Looks good to me as well.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110212/#review52749
---


On March 11, 2014, 6:18 p.m., Felipe Tonello wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110212/
> ---
> 
> (Updated March 11, 2014, 6:18 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> payee: Does not merge when payees are empty
> 
> When there is no transactions to be merged we don't need to merge. In fact if
> we don't stop there the rest of the code will delete the payees, which is a
> behavior for delete payees functionality.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Show transactions from multiple payees
> 
> This patch allow users to have see all transactions that they
> will merge.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Added Payees Merge KButton
> 
> Adds a button next to the delete payee and enables it only when multiple
> payees are selected.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Added payee_merge KAction
> 
> Added KAction to the context menu and connected to the slotPayeeMerge().
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Added support to Merge Payees
> 
> This patch implements the opeartion to merge payees. This is done by reusing
> the payee delete slot, modifying it to support merge operation and add support
> to it in KPayeeReassignDlg dialog.
> 
> The main difference between delete a payee and merging a payee is that when
> merging the user can merge to a new payee. So the modification was done to
> support this use-case.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: change slotPayeeNew(...) to return boolean value
> 
> This is usefull if the user of that function wants to know if the user created
> a new payee or not.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Make PayeeReassignDlg support other operations then delete
> 
> This is useful so it can be implemented a merge opration and maybe others in
> future as well.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Better explanation when deleting payee
> 
> Signed-off-by: Felipe F. Tonello 
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/kpayeereassigndlg.h 
> a348d2b9fdc68a7c56a616a862a3373ef35aa0ba 
>   kmymoney/dialogs/kpayeereassigndlg.cpp 
> 8bdb25c0b3478c42715fac9f052903ed45b3614c 
>   kmymoney/dialogs/kpayeereassigndlgdecl.ui 
> 2cf563d4ea755e8d89ff2587fa677f14453cbaa5 
>   kmymoney/kmymoney.h 56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca 
>   kmymoney/kmymoney.cpp 6b96b9790d0ee5b5d34e6cfd382b03e9a103c9e6 
>   kmymoney/kmymoneyui.rc 65afc920cef7091e3138c9acf75f73ec96929445 
>   kmymoney/views/kpayeesview.h c747e691f6509c7bf60201dfb3cc77e9f939a7c5 
>   kmymoney/views/kpayeesview.cpp 7252241886e05f00555d16dc1388b9d6ecef36a2 
>   kmymoney/views/kpayeesviewdecl.ui 6efb2ae5f94383851ee2ab15da36187b7079815a 
> 
> Diff: https://git.reviewboard.kde.org/r/110212/diff/
> 
> 
> Testing
> ---
> 
> Normal UI test going trough all the possible options of users input.
> 
> 
> Thanks,
> 
> Felipe Tonello
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 116819: SQLCipher as database driver for encrypted SQLite databeses

2014-03-15 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116819/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

Added support for SQLCipher database driver in KMyMoney

Database backend supports SQLCipher driver. Added a new method to
KMyMoney's SQL driver which stores information if a password is
supported.

Also a new QSQLDriver for SQLCipher was introduced.

This is still work in progress as some features are missing (e.g. encrypt not 
encrypted database and vice versa, change password). But install is hard so 
only sophisticated users and engaged package maintainer can do that. I do not 
think this will be useful in near future. However I wanted to shared my code.

How to install/use this patch:

1) You need SQLCipher, http://sqlcipher.net , build and install it (to my 
knowledge it is not packed in any major distribution).
2) Get the qt source code (or just the one for QSQLiteDriver) and build it 
(needed as this will create the necessary folder hierarchy).

3) If you do not install to default location, enable CMake to find these 
folders (SQLCipher install folders, Qt source folder, Qt build folder).

4) Create KMyMoney with ENABLE_SQLCIPHER=ON (default is off)

(first post by rbt tools was not working as I thought sorry)


Diffs
-

  kmymoney/plugins/sqlcipher/tests/sqlcipherdrivertest.cpp PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/sqlcipherdrivertest.h PRE-CREATION 
  CMakeLists.txt 83a699b960b568f44e04b5801511da91dbda188e 
  kmymoney/dialogs/kgeneratesqldlg.cpp 856b457f3bc862ccd376a0f6bb43f02d92128fc8 
  kmymoney/dialogs/kselectdatabasedlg.cpp 
a43dfc7c2494d025a4c48082cfd30b6394585dd4 
  kmymoney/mymoney/storage/mymoneydbdriver.h 
8c8f84b5dcaca124fd3a59a59ac1e2e9637c6eba 
  kmymoney/mymoney/storage/mymoneydbdriver.cpp 
c2219ef4c239ba350e3e7767c607afc9d7b41254 
  kmymoney/plugins/CMakeLists.txt 4e5e0740d54c8ba8db7587accb2a3c2fe565dc89 
  kmymoney/plugins/sqlcipher/CMakeLists.txt PRE-CREATION 
  kmymoney/plugins/sqlcipher/cmake/modules/FindQSQLiteSource.cmake PRE-CREATION 
  kmymoney/plugins/sqlcipher/cmake/modules/FindSQLCipher.cmake PRE-CREATION 
  kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.h PRE-CREATION 
  kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.cpp PRE-CREATION 
  kmymoney/plugins/sqlcipher/sqlcipherdriver.h PRE-CREATION 
  kmymoney/plugins/sqlcipher/sqlcipherdriver.cpp PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/CMakeLists.txt PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/sqlcipherdriverinstalltest.h PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/sqlcipherdriverinstalltest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116819/diff/


Testing
---

Opened, changed, closed and reopend a (manualy created) encrypted database file.

Performance to be tested...


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 116819: SQLCipher as database driver for encrypted SQLite databeses

2014-03-15 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116819/
---

(Updated March 15, 2014, 7:46 p.m.)


Review request for KMymoney.


Repository: kmymoney


Description (updated)
---

Added support for SQLCipher database driver in KMyMoney

Database backend supports SQLCipher driver. Added a new method to
KMyMoney's SQL driver which stores information if a password is
supported.

Also a new QSQLDriver for SQLCipher was introduced.

This is still work in progress as some features are missing (e.g. encrypt not 
encrypted database and vice versa, change password). But install is hard so 
only sophisticated users and engaged package maintainer can do that. I do not 
think this will be useful in near future. However I wanted to shared my code.

How to install/use this patch:

1) You need SQLCipher, http://sqlcipher.net , build and install it (to my 
knowledge it is not packed in any major distribution).
2) Get the qt source code (or just the one for QSQLiteDriver) and build it 
(needed as this will create the necessary folder hierarchy).

3) If you do not install to default location, enable CMake to find these 
folders (SQLCipher install folders, Qt source folder, Qt build folder).

4) Create KMyMoney with ENABLE_SQLCIPHER=ON (default is off)


Forgot: I have no clue how secure SQLCipher is! Just wanted to see if I can get 
it running.


Diffs
-

  kmymoney/plugins/sqlcipher/tests/sqlcipherdrivertest.cpp PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/sqlcipherdrivertest.h PRE-CREATION 
  CMakeLists.txt 83a699b960b568f44e04b5801511da91dbda188e 
  kmymoney/dialogs/kgeneratesqldlg.cpp 856b457f3bc862ccd376a0f6bb43f02d92128fc8 
  kmymoney/dialogs/kselectdatabasedlg.cpp 
a43dfc7c2494d025a4c48082cfd30b6394585dd4 
  kmymoney/mymoney/storage/mymoneydbdriver.h 
8c8f84b5dcaca124fd3a59a59ac1e2e9637c6eba 
  kmymoney/mymoney/storage/mymoneydbdriver.cpp 
c2219ef4c239ba350e3e7767c607afc9d7b41254 
  kmymoney/plugins/CMakeLists.txt 4e5e0740d54c8ba8db7587accb2a3c2fe565dc89 
  kmymoney/plugins/sqlcipher/CMakeLists.txt PRE-CREATION 
  kmymoney/plugins/sqlcipher/cmake/modules/FindQSQLiteSource.cmake PRE-CREATION 
  kmymoney/plugins/sqlcipher/cmake/modules/FindSQLCipher.cmake PRE-CREATION 
  kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.h PRE-CREATION 
  kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.cpp PRE-CREATION 
  kmymoney/plugins/sqlcipher/sqlcipherdriver.h PRE-CREATION 
  kmymoney/plugins/sqlcipher/sqlcipherdriver.cpp PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/CMakeLists.txt PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/sqlcipherdriverinstalltest.h PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/sqlcipherdriverinstalltest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116819/diff/


Testing
---

Opened, changed, closed and reopend a (manualy created) encrypted database file.

Performance to be tested...


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 110212: Add Merge Payee Option

2014-03-19 Thread Christian David



> On March 19, 2014, 6:38 a.m., Cristian Oneț wrote:
> > I was going to push this but before I did I gave it a try. I have the 
> > following remarks that can be seen in this video 
> > http://kmymoney2.sourceforge.net/screencasts/110212.ogv
> > 
> > If I try to merge two payees why can't I select one of them as the target? 
> > At leas that I what I expected from a merge function. Also the merge action 
> > is missing from the context menu. The merge dialog can be closed with enter 
> > without performing any action by typing a payee's name that is selected for 
> > merge.
> > 
> > Could you please address this issues? At least convince me that this is the 
> > right way it should work.
> >

"If I try to merge two payees why can't I select one of them as the target? At 
leas that I what I expected from a merge function." I think if you merge 
several payees you should be able to select only one of the selected ones to 
merge into.

If you have to select a different payee, it is a delete operation.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110212/#review53385
---


On March 11, 2014, 6:18 p.m., Felipe Tonello wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110212/
> ---
> 
> (Updated March 11, 2014, 6:18 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> payee: Does not merge when payees are empty
> 
> When there is no transactions to be merged we don't need to merge. In fact if
> we don't stop there the rest of the code will delete the payees, which is a
> behavior for delete payees functionality.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Show transactions from multiple payees
> 
> This patch allow users to have see all transactions that they
> will merge.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Added Payees Merge KButton
> 
> Adds a button next to the delete payee and enables it only when multiple
> payees are selected.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Added payee_merge KAction
> 
> Added KAction to the context menu and connected to the slotPayeeMerge().
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Added support to Merge Payees
> 
> This patch implements the opeartion to merge payees. This is done by reusing
> the payee delete slot, modifying it to support merge operation and add support
> to it in KPayeeReassignDlg dialog.
> 
> The main difference between delete a payee and merging a payee is that when
> merging the user can merge to a new payee. So the modification was done to
> support this use-case.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: change slotPayeeNew(...) to return boolean value
> 
> This is usefull if the user of that function wants to know if the user created
> a new payee or not.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Make PayeeReassignDlg support other operations then delete
> 
> This is useful so it can be implemented a merge opration and maybe others in
> future as well.
> 
> Signed-off-by: Felipe F. Tonello 
> 
> payee: Better explanation when deleting payee
> 
> Signed-off-by: Felipe F. Tonello 
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/kpayeereassigndlg.h 
> a348d2b9fdc68a7c56a616a862a3373ef35aa0ba 
>   kmymoney/dialogs/kpayeereassigndlg.cpp 
> 8bdb25c0b3478c42715fac9f052903ed45b3614c 
>   kmymoney/dialogs/kpayeereassigndlgdecl.ui 
> 2cf563d4ea755e8d89ff2587fa677f14453cbaa5 
>   kmymoney/kmymoney.h 56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca 
>   kmymoney/kmymoney.cpp 6b96b9790d0ee5b5d34e6cfd382b03e9a103c9e6 
>   kmymoney/kmymoneyui.rc 65afc920cef7091e3138c9acf75f73ec96929445 
>   kmymoney/views/kpayeesview.h c747e691f6509c7bf60201dfb3cc77e9f939a7c5 
>   kmymoney/views/kpayeesview.cpp 7252241886e05f00555d16dc1388b9d6ecef36a2 
>   kmymoney/views/kpayeesviewdecl.ui 6efb2ae5f94383851ee2ab15da36187b7079815a 
> 
> Diff: https://git.reviewboard.kde.org/r/110212/diff/
> 
> 
> Testing
> ---
> 
> Normal UI test going trough all the possible options of users input.
> 
> 
> Thanks,
> 
> Felipe Tonello
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 117630: Alkimia: Added a cmake package configuration file

2014-04-18 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117630/
---

Review request for KMymoney and Skrooge.


Repository: alkimia


Description
---

Added a cmake package configuration file

This replaces the Findcmake file. A user should not notice any
changes. But:

- CMAKE_PREFIX_PATH is honored now
- Users do not have to find GMP themselves (which was a bug)
- CMake users are not affected by a bug in PKG_CHECK_MODULES anymore
  more info: http://www.cmake.org/Bug/view.php?id=8644

This may not work if your old Find… file is still installed.

Also this should stop messing things up if you have several versions of alkimia 
installed (so annoying!).


Diffs
-

  libalkimia/CMakeLists.txt 7676567 
  libalkimia/FindLibAlkimia.cmake 2c4ce1e 
  libalkimia/LibAlkimiaConfig.cmake.in PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117630/diff/


Testing
---

Removed my systems FindLibAlkimia.cmake
Set CMAKE_PREFIX_PATH
make clean in KMyMoney
Compiled KMyMoney without setting ${GMP_LIBRARIES} anywhere in KMyMoney (=> it 
works)


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 116819: SQLCipher as database driver for encrypted SQLite databeses

2014-05-05 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116819/
---

(Updated May 5, 2014, 2:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
---

Added support for SQLCipher database driver in KMyMoney

Database backend supports SQLCipher driver. Added a new method to
KMyMoney's SQL driver which stores information if a password is
supported.

Also a new QSQLDriver for SQLCipher was introduced.

This is still work in progress as some features are missing (e.g. encrypt not 
encrypted database and vice versa, change password). But install is hard so 
only sophisticated users and engaged package maintainer can do that. I do not 
think this will be useful in near future. However I wanted to shared my code.

How to install/use this patch:

1) You need SQLCipher, http://sqlcipher.net , build and install it (to my 
knowledge it is not packed in any major distribution).
2) Get the qt source code (or just the one for QSQLiteDriver) and build it 
(needed as this will create the necessary folder hierarchy).

3) If you do not install to default location, enable CMake to find these 
folders (SQLCipher install folders, Qt source folder, Qt build folder).

4) Create KMyMoney with ENABLE_SQLCIPHER=ON (default is off)


Forgot: I have no clue how secure SQLCipher is! Just wanted to see if I can get 
it running.


Diffs
-

  kmymoney/plugins/sqlcipher/tests/sqlcipherdrivertest.cpp PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/sqlcipherdrivertest.h PRE-CREATION 
  CMakeLists.txt 83a699b960b568f44e04b5801511da91dbda188e 
  kmymoney/dialogs/kgeneratesqldlg.cpp 856b457f3bc862ccd376a0f6bb43f02d92128fc8 
  kmymoney/dialogs/kselectdatabasedlg.cpp 
a43dfc7c2494d025a4c48082cfd30b6394585dd4 
  kmymoney/mymoney/storage/mymoneydbdriver.h 
8c8f84b5dcaca124fd3a59a59ac1e2e9637c6eba 
  kmymoney/mymoney/storage/mymoneydbdriver.cpp 
c2219ef4c239ba350e3e7767c607afc9d7b41254 
  kmymoney/plugins/CMakeLists.txt 4e5e0740d54c8ba8db7587accb2a3c2fe565dc89 
  kmymoney/plugins/sqlcipher/CMakeLists.txt PRE-CREATION 
  kmymoney/plugins/sqlcipher/cmake/modules/FindQSQLiteSource.cmake PRE-CREATION 
  kmymoney/plugins/sqlcipher/cmake/modules/FindSQLCipher.cmake PRE-CREATION 
  kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.h PRE-CREATION 
  kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.cpp PRE-CREATION 
  kmymoney/plugins/sqlcipher/sqlcipherdriver.h PRE-CREATION 
  kmymoney/plugins/sqlcipher/sqlcipherdriver.cpp PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/CMakeLists.txt PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/sqlcipherdriverinstalltest.h PRE-CREATION 
  kmymoney/plugins/sqlcipher/tests/sqlcipherdriverinstalltest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116819/diff/


Testing
---

Opened, changed, closed and reopend a (manualy created) encrypted database file.

Performance to be tested...


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 334564] small deposits entered in foreign currency are wrongly converted to base currency

2014-05-11 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=334564

Christian David  changed:

   What|Removed |Added

 CC||christian-da...@web.de

--- Comment #1 from Christian David  ---
"Prices are set as follows:
1 IDR = 0,6212 €
1€ = 16097,87508 IDR

deposit IDR 1 returns € 16097,87"

this looks like the prices are set
1 € = 0,6212 IDR and
1 IDR = 16097,87508 €
which is the the other way round than you wrote.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 334564] small deposits entered in foreign currency are wrongly converted to base currency

2014-05-11 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=334564

--- Comment #4 from Christian David  ---
Then this may help to find the bug. As you said and as we can see, the
calculations for 100 IDR and above are correct (100 IDR = 0,006212 € ≈ 0,01 €)
.

But below, somehow the exchange rate is reversed:
1 IDR = 0,6212 € ⇒  1 IDR = 16097,87508 IDR

Here is to note that using the correct exchange rate would lead to 0 € ( 10 IDR
= 0,0006212 € ≈ 0,00 €).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 117630: Alkimia: Added a cmake package configuration file

2014-05-12 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117630/
---

(Updated May 12, 2014, 5:49 p.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney and Skrooge.


Repository: alkimia


Description
---

Added a cmake package configuration file

This replaces the Findcmake file. A user should not notice any
changes. But:

- CMAKE_PREFIX_PATH is honored now
- Users do not have to find GMP themselves (which was a bug)
- CMake users are not affected by a bug in PKG_CHECK_MODULES anymore
  more info: http://www.cmake.org/Bug/view.php?id=8644

This may not work if your old Find… file is still installed.

Also this should stop messing things up if you have several versions of alkimia 
installed (so annoying!).


Diffs
-

  libalkimia/CMakeLists.txt 7676567 
  libalkimia/FindLibAlkimia.cmake 2c4ce1e 
  libalkimia/LibAlkimiaConfig.cmake.in PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117630/diff/


Testing
---

Removed my systems FindLibAlkimia.cmake
Set CMAKE_PREFIX_PATH
make clean in KMyMoney
Compiled KMyMoney without setting ${GMP_LIBRARIES} anywhere in KMyMoney (=> it 
works)


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 118107: Calculate cleared balance in core

2014-05-13 Thread Christian David



> On May 13, 2014, 1:08 a.m., Marko Käning wrote:
> > I'll incorporate it as soon as possible in a updated version of 
> > https://git.reviewboard.kde.org/r/112885/ .
> > 
> > Thanks, Alvaro, for doing this job.
> > 
> > I'll also report back as soon as I can regarding speed.
> 
> Marko Käning wrote:
> Only now I realise that you did not cache the value in any case which 
> lets you re-iterate through all transactions at every call...
> 
> Wasn't there some caching built-in for the corresponding 
> MyMoneyFile::balance()?
> 
> Marko Käning wrote:
> Alvaro, I successfully incorporated your patch using git master and ran 
> my actual kmy with it.
> 
> My account with the most transactions didn't show any significant change 
> of speed (although there's seemingly no caching up to now - but perhaps I am 
> mistaken there?).
> 
> This was measured manually as the time lag until the corresponding ledger 
> appears after clicking the ledger icon - i.e. not applying any debug output - 
> which resulted in a duration of about 1.5s.
> 
> Alvaro Soliverez wrote:
> TBH, at first I thought this feature was only used during reconciliation 
> and not every time the ledger is loaded. 
> In any case, there are still some optimizations to be made (eg. caching, 
> calculating the cleared balance with a different method if the account was 
> never reconciled, etc.), but it only makes sense to optimize once a problem 
> has been detected.

"it only makes sense to optimize once a problem has been detected" +1

I tried this patch with a huge xml test file (about 100 000 transactions and 50 
000 per account). By hand I could not find a difference in speed. This makes 
sense, as the main problem is probably loading and copying the data to and 
within main memory. Compared to that just reading it to calculate a sum should 
be negligible.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118107/#review57833
---


On May 13, 2014, 12:53 a.m., Alvaro Soliverez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118107/
> ---
> 
> (Updated May 13, 2014, 12:53 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> It calculates cleared balance for an account in MyMoneyFile, instead of doing 
> it in the ledger view (kgloballedgerview.cpp)
> 
> I'm posting it here because I'm a bit concerned on the performance it may 
> have for everyday use.
> I'm keen on optimizing, but this kind of code should be removed from the 
> views in the long-term.
> 
> 
> Diffs
> -
> 
>   kmymoney/mymoney/mymoneyfile.h 3a39ba0 
>   kmymoney/mymoney/mymoneyfile.cpp 4f6d277 
>   kmymoney/views/kgloballedgerview.cpp d2d626c 
> 
> Diff: https://git.reviewboard.kde.org/r/118107/diff/
> 
> 
> Testing
> ---
> 
> I tested with a small file. It works ok. I still have to add a unit test for 
> it.
> 
> 
> Thanks,
> 
> Alvaro Soliverez
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-05-16 Thread Christian David



> On April 18, 2014, 1:34 p.m., Allan Anderson wrote:
> > Hi Cristian
> > Many thanks.  It had been starting to dawn on me that, when dealing with 
> > different distros, it shouldn't be necessary to fiddle about with margins
> > to get things to look right.  I'd suspected that I needed to make some 
> > fundamental changes, but wasn't really ready to take the plunge.  Anyway,
> > you've done it for me, so again, thank you.
> > The question now is, where do we go from here?
> > Here, I'd already removed a chunk of code and have been working on details 
> > of the UI appearance.  For instance, I don't like to see the size of the
> > table changing height between the different wizard pages, and I don't like 
> > to see just partial lines displayed.  Obviously, if the user decides to do
> > a resize, then the decision is his, but without that happening, I don't 
> > want to see half lines displayed.  This is mainly to do with whether a
> > horizontal scroll-bar is visible or not.  I have not been able to get that 
> > to work correctly.  Sometimes, it is visible but isVisible() returns
> > false, and vice versa I think.  So I've had to calculate the diplayed width 
> > and adjust the containing rectangle.  A little work is still needed here.
> > In your pruning, I think you have removed some vertical spacers, which is 
> > causing the combo-boxes to shift upwards, leaving a lot of space below.
> > I wish to revert that.  In the separators wizard page, the two combo-boxes 
> > are now different sizes, I think because you've removed the form layout I 
> > was
> > using.  In the banking wizard, the combo-box sizes are significantly 
> > different in width between Linux Mint and Ubuntu.  I don't know about on 
> > Windows.
> > These are very minor points, but I'd like to tweak them.
> > I'd decided on a default window height of 10 rows, which has been changed.  
> > Was there a particular reason for that?
> > Between Mint and Ubuntu, the margin values are still different, but now 
> > that has no effect on the appearance.  The font sizes are differ too, 9 
> > point
> > against 11 point.  That does affect the appearance.  Should I leave that as 
> > is, do you think?  I think probably yes.
> > I can't add a revised patch to your review, but if you agree, I can 
> > describe any proposed changes.  I don't want to stray away from your major 
> > changes,
> > though, obviously.
> 
> Cristian Oneț wrote:
> "where do we go from here?"
> 
> I don't know, it's up to you to decide. If you ask me (after 2 days of 
> going trough csvdialog.cpp) I would suggest to rewrite everything. I know 
> that seems harsh but frankly I didn't see such "tangled up" code in a while. 
> One reading it couldn't quite tell what is essential (necessary) in there and 
> what is trial/error leftover code.
> 
> For the UI I would have the following guide:
> - keep it simple (your layouts were really, really complicated)
> - don't center everything (including messages)
> - don't set fix sizes (fixed size policies are OK in the appropriate 
> place - line edits, combos should have a fixed vertical size hint)
> - try to use the available space as uniformly as possible (1 page with 2 
> combos vs. 1 page with 10 combos)
> - now we have a dialog (QWizard) inside another dialog (CSVDialog - 
> former widget) which seems a bad idea to me
> 
> For the code:
> - don't keep everything together (like a big ball of spaghetti), try to 
> break it up into smaller components
> - only keep the essential code otherwise you won't be able to spot it 
> later from the clutter
> 
> Until the csv importer plugin will not be cleaned up, clean reviewable 
> patches can't be provided because the patches will always look like the code 
> that is patched.
> 
> Cristian Oneț wrote:
> Forgot to mention the fonts: don't set any fonts - let the user choose 
> the fonts he desires using the system settings.
> 
> Allan Anderson wrote:
> I've never made any claim to be a programmer!  This all started off as a 
> script to produce a QIF file, which I was advised to expand, first into
> tabs, and later into a wizard.  It has grown, like Topsy.  I've learned a 
> lot along the way, but I'm still not a programmer.
> In the light of your comments, there seems little point now wasting time 
> tuning what we have, so I'll leave it as is.
> When/if a rewrite occurs will depend upon my available time.
> 
> Cristian Oneț wrote:
> Sorry if I offended you, I know to well how one feels about his work made 
> voluntarily in his free time. I'm just asking that you never stop learning 
> and improving the work you do. I even have the same critical view of my own 
> code that I wrote back when I started contributing to kmymoney. I did ask for 
> a rewrite but didn't say when so whenever you feel like it seems fine. 
> Meanwhile we can leave this patch in "suspension" if it's too much.
> 
> Allan Anderson w

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-05-26 Thread Christian David

e time.
> 
> Cristian Oneț wrote:
> Sorry if I offended you, I know to well how one feels about his work made 
> voluntarily in his free time. I'm just asking that you never stop learning 
> and improving the work you do. I even have the same critical view of my own 
> code that I wrote back when I started contributing to kmymoney. I did ask for 
> a rewrite but didn't say when so whenever you feel like it seems fine. 
> Meanwhile we can leave this patch in "suspension" if it's too much.
> 
> Allan Anderson wrote:
> No, your criticism was valid, if a little brusque.
> The patch is needed, so must go forward.
> 
> > - try to use the available space as uniformly as possible (1 page with 
> 2 combos vs. 1 page with 10 combos)
> I split up the wizard pages by logical function, and obviously some are 
> much simpler than others.  The investment
> page needed a lot of fields, others just a couple.  Are you saying to 
> combine some of the smaller pages, even though
> they may have no logical connection?
> > - now we have a dialog (QWizard) inside another dialog (CSVDialog - 
> former widget) which seems a bad idea to me.
> Can you expand on this?  I'm unclear.
>
> 
> Allan Anderson wrote:
> I've made some small changes to the various UIs, using one or two 
> vertical spacers to avoid having all the widgets in a clump with empty space 
> below.  Also, on the Banking wizard page, I've set a minimum width on all the 
> combos, which allows them to shrink and remain visible, in order to reduce 
> the overall width of the UI, to help on smaller screen displays.  I won't set 
> any fixed sizes.
> 
> Allan Anderson wrote:
> I've reduced the overall width, closer to its original value, in order to 
> allow use on smaller screens.
> I've removed the inheritance from QDialog, replacing it with QWidget.  I 
> hadn't realised QWizard itself inherits
> from QDialog.  I'm suspecting that that was actually the cause of some of 
> the difficulties on different distros.
> 
> One thing I'd like opinions on is the use of resize(int, int).  I'm 
> trying to keep the UI appearance 'tidy',
> avoiding the clipping of row height, athough obviously the user may 
> choose to resize the plugin and please himself
> about the appearance.  Anyway, I start off with a display of ten rows, 
> which looks OK until the user back-tracks
> and loads another file with different column widths.  This can result in 
> the appearance/disappearance of the
> horizontal scroll bar, which in turn disrupts the table height and 
> appearance.  So, I've used a resize() to restore
> the original ten row display.  However, this may not be what the user 
> would want.  Up to now, I've allowed for
> saving many user preferences, but haven't saved window size.  So, I'm 
> thinking to do that, and then the resize
> I've adopted would be of the saved values.
> 
> Any opinions, anyone?
>
> 
> Cristian Oneț wrote:
> Making the window size persistent would be very useful. Of course you 
> would need to check that the saved size matched the available space on the 
> desktop to avoid weird behavior when moving to a different resolution.
> 
> Christian David wrote:
> "...I start off with a display of ten rows..." How about not fixing it to 
> n rows. Instead you could create the window with the default size. Then 
> calculate how many rows are shown and shrink or enlarge the window in a way 
> that no row is shown half. This could avoid some issues which will be 
> introduced by a fixed number.
> 
> Also keep in mind that in near future high dpi displays will be common 
> which will make the unit "pixel" useless for sizes.
> 
> In my opinion it has no benefit not to show rows partly. This can 
> actually clarify that there is more in the view than you can see directly 
> (e.g. Mac OS X has no scroll bars anymore to indicate that).
> 
> Allan Anderson wrote:
> Christian David 2 hours, 6 minutes ago (May 16, 2014, 7:39 p.m.)
> 
> > "...I start off with a display of ten rows..." How about not fixing 
> it to n rows. Instead you could create the window with the 
> > default size. Then calculate how many rows are shown and shrink or 
> enlarge the window in a way that no row is shown half. This could 
> > avoid some issues which will be introduced by a fixed number.
> 
> Allan Anderson
> Well, that is actually the process I'm using, albeit for a fixed number 
> of rows, rather than for a varia

[Kmymoney-devel] [kmymoney4] [Bug 332436] Fees not saved in dividend transaction

2014-05-28 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=332436

Christian David  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||christian-da...@web.de
   Version Fixed In||4.8
 Resolution|--- |FIXED

--- Comment #3 from Christian David  ---
Based on Allan's comment I marked this bug as fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-05-28 Thread Christian David

e time.
> 
> Cristian Oneț wrote:
> Sorry if I offended you, I know to well how one feels about his work made 
> voluntarily in his free time. I'm just asking that you never stop learning 
> and improving the work you do. I even have the same critical view of my own 
> code that I wrote back when I started contributing to kmymoney. I did ask for 
> a rewrite but didn't say when so whenever you feel like it seems fine. 
> Meanwhile we can leave this patch in "suspension" if it's too much.
> 
> Allan Anderson wrote:
> No, your criticism was valid, if a little brusque.
> The patch is needed, so must go forward.
> 
> > - try to use the available space as uniformly as possible (1 page with 
> 2 combos vs. 1 page with 10 combos)
> I split up the wizard pages by logical function, and obviously some are 
> much simpler than others.  The investment
> page needed a lot of fields, others just a couple.  Are you saying to 
> combine some of the smaller pages, even though
> they may have no logical connection?
> > - now we have a dialog (QWizard) inside another dialog (CSVDialog - 
> former widget) which seems a bad idea to me.
> Can you expand on this?  I'm unclear.
>
> 
> Allan Anderson wrote:
> I've made some small changes to the various UIs, using one or two 
> vertical spacers to avoid having all the widgets in a clump with empty space 
> below.  Also, on the Banking wizard page, I've set a minimum width on all the 
> combos, which allows them to shrink and remain visible, in order to reduce 
> the overall width of the UI, to help on smaller screen displays.  I won't set 
> any fixed sizes.
> 
> Allan Anderson wrote:
> I've reduced the overall width, closer to its original value, in order to 
> allow use on smaller screens.
> I've removed the inheritance from QDialog, replacing it with QWidget.  I 
> hadn't realised QWizard itself inherits
> from QDialog.  I'm suspecting that that was actually the cause of some of 
> the difficulties on different distros.
> 
> One thing I'd like opinions on is the use of resize(int, int).  I'm 
> trying to keep the UI appearance 'tidy',
> avoiding the clipping of row height, athough obviously the user may 
> choose to resize the plugin and please himself
> about the appearance.  Anyway, I start off with a display of ten rows, 
> which looks OK until the user back-tracks
> and loads another file with different column widths.  This can result in 
> the appearance/disappearance of the
> horizontal scroll bar, which in turn disrupts the table height and 
> appearance.  So, I've used a resize() to restore
> the original ten row display.  However, this may not be what the user 
> would want.  Up to now, I've allowed for
> saving many user preferences, but haven't saved window size.  So, I'm 
> thinking to do that, and then the resize
> I've adopted would be of the saved values.
> 
> Any opinions, anyone?
>
> 
> Cristian Oneț wrote:
> Making the window size persistent would be very useful. Of course you 
> would need to check that the saved size matched the available space on the 
> desktop to avoid weird behavior when moving to a different resolution.
> 
> Christian David wrote:
> "...I start off with a display of ten rows..." How about not fixing it to 
> n rows. Instead you could create the window with the default size. Then 
> calculate how many rows are shown and shrink or enlarge the window in a way 
> that no row is shown half. This could avoid some issues which will be 
> introduced by a fixed number.
> 
> Also keep in mind that in near future high dpi displays will be common 
> which will make the unit "pixel" useless for sizes.
> 
> In my opinion it has no benefit not to show rows partly. This can 
> actually clarify that there is more in the view than you can see directly 
> (e.g. Mac OS X has no scroll bars anymore to indicate that).
> 
> Allan Anderson wrote:
> Christian David 2 hours, 6 minutes ago (May 16, 2014, 7:39 p.m.)
> 
> > "...I start off with a display of ten rows..." How about not fixing 
> it to n rows. Instead you could create the window with the 
> > default size. Then calculate how many rows are shown and shrink or 
> enlarge the window in a way that no row is shown half. This could 
> > avoid some issues which will be introduced by a fixed number.
> 
> Allan Anderson
> Well, that is actually the process I'm using, albeit for a fixed number 
> of rows, rather than for a varia

[Kmymoney-devel] [kmymoney4] [Bug 335129] Wrong account ordering at home page

2014-05-29 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=335129

Christian David  changed:

   What|Removed |Added

 CC||christian-da...@web.de

--- Comment #6 from Christian David  ---
(In reply to comment #5)
> I was about to file a similar bug based on a mailing list request some weeks
> ago, but I'm not sure if it's the same issue.  This bug referred to usign
> non-ASCII characters, but my case is completely within US English, so locale
> should not be an issue.  On the accounts page, the order is "Checking One"
> "CHECKING ONE" "CHECKING TWO" but on the home page, it is "CHECKING ONE"
> "CHECKING TWO" "Checking One".
your problem should be caused by the compare method as well. As in non-local
aware comparison only the ASCII (or UTF-8) values are compared and so any
lowercase letter is behind all uppercase letters ( ddg.gg/?q=ascii+table ).

Btw: you should always use local aware comparison where the user expects a
human sorting method, also in english-only texts. This ensures correct sorting
of special chars as well (plain ASCII sort would generate this list: "!6;A]z}",
but no human would expect that).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 330946] "Treat text as regular expression" checkbox in text filter of transaction reports loses its state

2014-06-19 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=330946

Christian David  changed:

   What|Removed |Added

   Version Fixed In||4.6.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119234: Transform KHolidays into an optional dependency.

2014-07-11 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119234/#review62153
---


Is this only used until the pim libs are KF5 ready? Because I think this 
function is so important that it justifies having the pim libs a obligatory 
dependency. There will be many bug reports if a package maintainer forgets to 
compile with kdepimlibs.

- Christian David


On Juli 11, 2014, 9:58 nachm., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119234/
> ---
> 
> (Updated Juli 11, 2014, 9:58 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> If KDE PIM libraries will not be found during configuration all days will be 
> considered processing days. Note that this review request dependes on the 
> cmake changes in https://git.reviewboard.kde.org/r/119207/
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/settings/ksettingsschedules.cpp 96bfb84 
>   kmymoney/kmymoney.cpp 687187a 
> 
> Diff: https://git.reviewboard.kde.org/r/119234/diff/
> 
> 
> Testing
> ---
> 
> Build and run the application with and without HAVE_KDEPIMLIBS defined.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119234: Transform KHolidays into an optional dependency.

2014-07-12 Thread Christian David



> On Juli 11, 2014, 9:58 nachm., Christian David wrote:
> > Is this only used until the pim libs are KF5 ready? Because I think this 
> > function is so important that it justifies having the pim libs a obligatory 
> > dependency. There will be many bug reports if a package maintainer forgets 
> > to compile with kdepimlibs.
> 
> Cristian Oneț wrote:
> No, I would like to see this as a permanent change. I'm not that sure 
> about which of the features are so important that they must be a mandatory 
> dependency. I like the idea of having the freedom to build without kdepimlibs 
> if necessary and if that can be obtained easily why not have it? I'm not 
> sugesting that packagers should do this but for example in source based 
> distributions users would be able to have a choice, which is nice.
> 
> Alvaro Soliverez wrote:
> I'm against this being a permanent change. It affects how schedules are 
> handled, which impacts all over the application.
> And I certainly don't want to track down a bug reported by an unsupecting 
> user just to figure out later a packager left the dependency out because kde 
> pim libs was "too big".
> 
> Cristian Oneț wrote:
> I hate to disagree but I don't see it that way. The only effect to the 
> way schedules are handled is that processing dates are not obtained from the 
> holliday region thus the "old" (and documented) behavior of considering only 
> weekends as non-processing days will be in effect.
> 
> If you ask me is this feature really that crucial that we should make 
> everyone build kdepimlibs in oder to use kmymoney I would say no. Again, I'm 
> not removing the feature, just making it optional.
> 
> The feature isn't even documented so I'm not sure if we would start 
> receiving bug reports about it. But just to be on the safe side we could 
> finish the feature in main.cpp:69 which would provide a list of optional 
> features that were built (or found as plugins) in the about data.
> 
> If it's something I've learned from and appreacited in the KF5 model is 
> that the take everything or leave it approach is wrong. Think about it, 
> kdepimlibs has 22 libraries plus their dependecies , of which we only use 4 
> (QGpgme, KHolidays, PIMIdentities, Akonadi) for pretty slim features. Knowing 
> this wouldn't it be wiser to allow those who don't need those features to be 
> able to use the application without these dependencies?
> 
> Marko Käning wrote:
> Cristian, I am very much in favour for what you're stating here. This is 
> something which one wouldn't be too worried about on Linux, but on OSX as on 
> Windows in your case it is a real show-stopper to be forced into having far 
> too many dependencies for seemingly little functionality gain.
> 
> Thus, I also vote for making things optional!

I think, on the long term kdepimlibs will be split up anyway. So the size 
problem might be solved just by waiting.

Please see my comments as not mainly targeting this review request but more as 
a general concern about making kdepimlibs optional.

>From my point of view this patch adds more complexity to KMyMoney without a 
>real benefit.

All future development needs to wrap the usage of kdepimlibs, which means a lot 
of work. Also it is hard for a new developer to understand/change it as he has 
to learn kdepimlibs and the KMyMoney wrapper. Also using #if HAVE_KDEPIMLIBS is 
uncomfortable from my point of view but maybe I am just too sensitive to that 
(I worked in project which overdid this — bad memories).

If this has a real benefit for Windows or Mac users it could be a fair deal 
until kdepimlibs got actually split up. Especially as long as it is a small 
patch like this one.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119234/#review62153
---


On Juli 11, 2014, 9:58 nachm., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119234/
> ---
> 
> (Updated Juli 11, 2014, 9:58 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> If KDE PIM libraries will not be found during configuration all days will be 
> considered processing days. Note that this review request dependes on the 
> cmake changes in https://git.reviewboard.kde.org/r/1192

[Kmymoney-devel] Review Request 119635: Replaced KMyMoneyGlobalSettings::setSubstringSearch(QWidget* w) to make kmm_config independent of widgets

2014-08-06 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119635/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

Replaced
void KMyMoneyGlobalSettings::setSubstringSearch(QWidget* w)
by void KMyMoneyMVCCombo::setSubstringSearchForChildren(QWidget*const widget, 
bool enabled)

To use this commit you must replace
KMyMoneyGlobalSettings::setSubstringSearch(widgetPtr);
by
KMyMoneyMVCCombo::setSubstringSearchForChildren(widgetPtr, 
!KMyMoneySettings::stringMatchFromStart());

So KMyMoneyMVCCombo is not needed in KMyMoneyGlobalSettings anymore and
the target kmm_config can be used without linking the target "widgets".

My goal is to clean up the build of all widgets. Later there should be
1) a shared library which contains all KMyMoney widgets which are interessting 
for plugins,
2) a static library which contains widgets which are not interessting for 
plugins (if there are such widgets, at the moment nearly everything is put here)
3)?a shared library for QtDesigner (which is not working at the moment)


Diffs
-

  kmymoney/kmymoney.cpp c4bbf0cbf46250f69f7e2e9c13471c4e6c7cb261 
  kmymoney/kmymoney.kcfg 5d5e09cf9b1d94cec07fe97cda388819fd8a97ed 
  kmymoney/kmymoneyglobalsettings.cpp a6742fa9e329579fd81548b20bfda766ebb27863 
  kmymoney/widgets/kmymoneymvccombo.h a9d8e37ee0a600240c7ca4544964a448770d0a24 
  kmymoney/widgets/kmymoneymvccombo.cpp 
cf7c21b25716aa99d9e72ee19883f371da816c0c 
  kmymoney/wizards/endingbalancedlg/kendingbalancedlg.cpp 
adb2adae4c8e086df0a1ce5e62a36cb26859dc76 
  kmymoney/wizards/newloanwizard/knewloanwizard.cpp 
5b8134e1345a863a13469dfd32eb56ed99b9bdc2 

Diff: https://git.reviewboard.kde.org/r/119635/diff/


Testing
---

1. kwriteconfig --file kmymoneyrc --group "General Options" --key 
"stringMatchFromStart" --type bool true
2. restarted KMyMoney
3. tried completion for payees in register
 -- worked as expected --
4. removed option again
5. restarted KMyMoney
6. tried completion for payees in register
 -- worked as expected --


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 119639: Moved several widgets from the static into the shared library

2014-08-07 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119639/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

This patch is part of my effort to merge master and add-onlinebanking.

Affected are the classes
kMandatoryFieldGroup
kMyMoneyCalculator
kMyMoneyEdit
kMyMoneyLineEdit
KMyMoneyMVCCombo and several derived classes
KMyMoneySelector

and some helper classes.

Export macros are now generated by cmake.

This patch should make it easier to develop plugins which use KMyMoney's 
widgets.

Some more classes should be moved into the shared library as well but this is 
not so easy. I guess I have to understand more of what is going on. Also this 
makes the problem that the library for QtDesigner cannot be compiled even worse 
– but if the move from a static to the shared library is continued it will be 
easier to fix the designer problems.


Diffs
-

  kmymoney/widgets/kmymoneyedit.h 96fd811285b8951387c8248ddc3e7b08d051d6b1 
  kmymoney/CMakeLists.txt fdd80faa54558da1c44908a7c8dff8c1baed3435 
  kmymoney/dialogs/CMakeLists.txt 2e933e0a26309fb78bb87fd78795091961b499b6 
  kmymoney/widgets/CMakeLists.txt c444558b27e056eef1065befb9cfc5e0e4c07244 
  kmymoney/widgets/kguiutils.h aa194f65856d6c2c2914631cd110bb8546c76e0b 
  kmymoney/widgets/kmm_widgets_export.h 
19275cce2d07b90a756f9222f23a6d347a7fce97 
  kmymoney/widgets/kmymoneycalculator.h 
68cd4b82a30207e215cc3ddfc237e5c3187c7de1 
  kmymoney/widgets/kmymoneylineedit.h b95f6441e362813bfbd373b6b7c9cb60ac354978 
  kmymoney/widgets/kmymoneymvccombo.h a9d8e37ee0a600240c7ca4544964a448770d0a24 
  kmymoney/widgets/kmymoneyselector.h 6b3d65b1fa4632581fc9d2ddc7a26575aaba9a1a 

Diff: https://git.reviewboard.kde.org/r/119639/diff/


Testing
---

KMyMoney still compiles and everything looks normal.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-08-07 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119647/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

MyMoneyStorageSql stored the row count of several tables in the table
kmmFileInfo. But this is error-prone and bad style.

Now this information is read from the database directly. Usually a database
caches the row count of tables anyway. Also all tables have an index so even
a `count(*)` is really fast. The result is still cached within
MyMoneyStorageSQL as it did before.


Diffs
-

  kmymoney/mymoney/storage/mymoneystoragesql.h 
5e148756739fcbdc3b9ffb6e11751ea035209c2b 
  kmymoney/mymoney/storage/mymoneystoragesql.cpp 
6e7a0715842da5ccb6d40f5f4a512e3433196ce6 

Diff: https://git.reviewboard.kde.org/r/119647/diff/


Testing
---

All test were done using SQLite. But all command I use are available in all 
other databases as well.

1. Tested the used SQL query in a (huge) database using sqlite:

```SQL
SELECT (SELECT count(*) from kmmAccounts) AS accounts, (SELECT count(*) FROM 
kmmCurrencies) AS currencies, (SELECT count(*) FROM kmmPayees) AS payees, 
(SELECT count(*) from kmmTags) AS tags, (SELECT count(*) FROM kmmTransactions) 
AS transactions, (SELECT count(*) FROM kmmSplits) AS splits, (SELECT count(*) 
FROM kmmSecurities) AS securities, (SELECT count(*) FROM kmmCurrencies) AS 
currencies, (SELECT count(*) FROM kmmSchedules) AS schedules, (SELECT count(*) 
FROM kmmPrices) AS prices, (SELECT count(*) FROM kmmKeyValuePairs) AS kvps, 
(SELECT count(*) FROM kmmReportConfig) AS reports, (SELECT count(*) FROM 
kmmBudgetConfig) AS budgets UNION ALL SELECT accounts, currencies, payees, 
tags, transactions, splits, securities, currencies, schedules, prices, kvps, 
reports, budgets FROM kmmFileInfo;
```

Result:

9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= the new query )
9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= what is stored in kmmFileInfo )

2. Saved a .kmy file and into a database (to test the INSERT routine), 
inspected database by hand

3. Changed something and inspected database by hand afterward.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 109913: transaction matching criteria change

2014-08-07 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109913/#review63994
---

Ship it!


Ship It!

- Christian David


On April 8, 2013, 8:19 nachm., Łukasz Maszczyński wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109913/
> ---
> 
> (Updated April 8, 2013, 8:19 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> This review is a follow-up of discussion started in review 108489.
> 
> There was an open point whether payee should be included in match criteria 
> for detecting a duplicate transaction on import. Cristian's comment on this:
> "If the amount and the post date are checked you could also add the payee 
> check although I'm not sure about the first two checks either. Scoping the 
> bankId within an account seems OK though (I don't have a strong argument for 
> this, it's just a feeling)."
> 
> I see two options:
> 1. (the one I prefer) Extend match criteria to include payee check (so that 
> the 'account', 'post date', 'amount' and 'payee' would be checked)
> 2. Get rid of extra checks and trust the bankId of imported transaction only 
> - this would require removing 'post date' and 'amount' checks, possibly 
> 'account' check as well (to be decided)
> 
> This review implements option 1, since I believe the extra checks are sanity 
> checks after all (I cannot imagine that two supposedly identical transactions 
> would have different parameters, e.g. amounts).
> 
> 
> Diffs
> -
> 
>   kmymoney/converter/matchfindertest.h 
> 28edbb6664474b8a873a0744bd48f42ed15526ed 
>   kmymoney/converter/matchfindertest.cpp 
> 879b3c26781cf2b7177febb3b8816dc6abac7de7 
>   kmymoney/converter/transactionmatchfinder.cpp 
> 63619e183617e017343c26ffee044f21127a5cac 
> 
> Diff: https://git.reviewboard.kde.org/r/109913/diff/
> 
> 
> Testing
> ---
> 
> make test
> 
> 
> Thanks,
> 
> Łukasz Maszczyński
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 109913: transaction matching criteria change

2014-08-07 Thread Christian David



> On Aug. 7, 2014, 5:51 nachm., Christian David wrote:
> > Ship It!

Sorry, wrong button.

I think it should be discarded: using HBCI import the payee name is not a good 
criteria. It changes quite often in details (like "KDE e.V." -> "KDE E.V.", or 
"Company Inc" -> "Company, New York City" -> "Company Incorporated"). If 
someone entered a transaction himself he has nearly no chance that it will be 
matched with an transaction imported using HBCI.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109913/#review63994
---


On April 8, 2013, 8:19 nachm., Łukasz Maszczyński wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109913/
> ---
> 
> (Updated April 8, 2013, 8:19 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> This review is a follow-up of discussion started in review 108489.
> 
> There was an open point whether payee should be included in match criteria 
> for detecting a duplicate transaction on import. Cristian's comment on this:
> "If the amount and the post date are checked you could also add the payee 
> check although I'm not sure about the first two checks either. Scoping the 
> bankId within an account seems OK though (I don't have a strong argument for 
> this, it's just a feeling)."
> 
> I see two options:
> 1. (the one I prefer) Extend match criteria to include payee check (so that 
> the 'account', 'post date', 'amount' and 'payee' would be checked)
> 2. Get rid of extra checks and trust the bankId of imported transaction only 
> - this would require removing 'post date' and 'amount' checks, possibly 
> 'account' check as well (to be decided)
> 
> This review implements option 1, since I believe the extra checks are sanity 
> checks after all (I cannot imagine that two supposedly identical transactions 
> would have different parameters, e.g. amounts).
> 
> 
> Diffs
> -
> 
>   kmymoney/converter/matchfindertest.h 
> 28edbb6664474b8a873a0744bd48f42ed15526ed 
>   kmymoney/converter/matchfindertest.cpp 
> 879b3c26781cf2b7177febb3b8816dc6abac7de7 
>   kmymoney/converter/transactionmatchfinder.cpp 
> 63619e183617e017343c26ffee044f21127a5cac 
> 
> Diff: https://git.reviewboard.kde.org/r/109913/diff/
> 
> 
> Testing
> ---
> 
> make test
> 
> 
> Thanks,
> 
> Łukasz Maszczyński
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 112026: Move XDG icons to icons/xdg, drop unused icon

2014-08-07 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112026/#review63999
---


This review should be marked as discarded. It is really old and merging it now 
could be a lot of work. Also it seems easier to me to solve that problem 
during/after the frameworks port.

- Christian David


On Aug. 14, 2013, 10:22 nachm., Yury Kudryashov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112026/
> ---
> 
> (Updated Aug. 14, 2013, 10:22 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> 
> This way icons are not mixed with sources in `ls` output.
> git pull kde:clones/kmymoney/kudryashov/kmymoney move-icons
> to see moved files not as removed & created
> 
> 
> Diffs
> -
> 
>   kmymoney/CMakeLists.txt 593cda911041ba74303405b042465e66095269b1 
>   kmymoney/hi128-app-kmymoney.png 8831c8984fe043f6fa95c68c5502931009b743fc 
>   kmymoney/hi128-mimetypes-application-x-kmymoney.png 
> b7b07754c92fc257419ff26d343d899e44666e27 
>   kmymoney/hi16-app-kmymoney.png 602dfe2c6138925bfab0f658ef590d7796fdb4d9 
>   kmymoney/hi16-mimetypes-application-x-kmymoney.png 
> 6ba3367e88a18b272a48c2dd4b19103b040047cc 
>   kmymoney/hi22-mimetypes-application-x-kmymoney.png 
> 9e2a8a463d8e60ade5d952a08fe33d27c2c692a8 
>   kmymoney/hi32-app-kmymoney.png 2c094bd6e3a6b8838eeb4c316e6b4af76e97baef 
>   kmymoney/hi32-mimetypes-application-x-kmymoney.png 
> 13a8bd2a9e8c106098cfef0178130c1de84eb9f8 
>   kmymoney/hi48-app-kmymoney.png 5d3dd78a57dca266b5da5153a036783b25f243a1 
>   kmymoney/hi48-mimetypes-application-x-kmymoney.png 
> d362bf40b93549ac331f282e9bf337784370bf23 
>   kmymoney/hi64-app-kmymoney.png c92938c8659e835b1941dfdf1072daacfa4cc008 
>   kmymoney/hi64-mimetypes-application-x-kmymoney.png 
> f045903d8b91d88db677d768ff1f6fb633230bed 
>   kmymoney/icons/CMakeLists.txt PRE-CREATION 
>   kmymoney/icons/xdg/CMakeLists.txt PRE-CREATION 
>   kmymoney/icons/xdg/hi128-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi128-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi16-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi16-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi22-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi32-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi32-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi48-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi48-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi64-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/hi64-mimetypes-application-x-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/lo16-app-kmymoney.png PRE-CREATION 
>   kmymoney/icons/xdg/lo32-app-kmymoney.png PRE-CREATION 
>   kmymoney/kmymoney_wizard.png be61ab7d4696c40edfe08b64b373b2c1c1a0aa08 
>   kmymoney/lo16-app-kmymoney.png 5a245b70bfde4eff384b56b027837ceec710459f 
>   kmymoney/lo32-app-kmymoney.png 2c094bd6e3a6b8838eeb4c316e6b4af76e97baef 
> 
> Diff: https://git.reviewboard.kde.org/r/112026/diff/
> 
> 
> Testing
> ---
> 
> cmake ..; make; make instal
> 
> 
> Thanks,
> 
> Yury Kudryashov
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119639: Moved several widgets from the static into the shared library

2014-08-08 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119639/
---

(Updated Aug. 8, 2014, 11:03 a.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
---

This patch is part of my effort to merge master and add-onlinebanking.

Affected are the classes
kMandatoryFieldGroup
kMyMoneyCalculator
kMyMoneyEdit
kMyMoneyLineEdit
KMyMoneyMVCCombo and several derived classes
KMyMoneySelector

and some helper classes.

Export macros are now generated by cmake.

This patch should make it easier to develop plugins which use KMyMoney's 
widgets.

Some more classes should be moved into the shared library as well but this is 
not so easy. I guess I have to understand more of what is going on. Also this 
makes the problem that the library for QtDesigner cannot be compiled even worse 
– but if the move from a static to the shared library is continued it will be 
easier to fix the designer problems.


Diffs
-

  kmymoney/widgets/kmymoneyedit.h 96fd811285b8951387c8248ddc3e7b08d051d6b1 
  kmymoney/CMakeLists.txt fdd80faa54558da1c44908a7c8dff8c1baed3435 
  kmymoney/dialogs/CMakeLists.txt 2e933e0a26309fb78bb87fd78795091961b499b6 
  kmymoney/widgets/CMakeLists.txt c444558b27e056eef1065befb9cfc5e0e4c07244 
  kmymoney/widgets/kguiutils.h aa194f65856d6c2c2914631cd110bb8546c76e0b 
  kmymoney/widgets/kmm_widgets_export.h 
19275cce2d07b90a756f9222f23a6d347a7fce97 
  kmymoney/widgets/kmymoneycalculator.h 
68cd4b82a30207e215cc3ddfc237e5c3187c7de1 
  kmymoney/widgets/kmymoneylineedit.h b95f6441e362813bfbd373b6b7c9cb60ac354978 
  kmymoney/widgets/kmymoneymvccombo.h a9d8e37ee0a600240c7ca4544964a448770d0a24 
  kmymoney/widgets/kmymoneyselector.h 6b3d65b1fa4632581fc9d2ddc7a26575aaba9a1a 

Diff: https://git.reviewboard.kde.org/r/119639/diff/


Testing
---

KMyMoney still compiles and everything looks normal.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119635: Replaced KMyMoneyGlobalSettings::setSubstringSearch(QWidget* w) to make kmm_config independent of widgets

2014-08-08 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119635/
---

(Updated Aug. 8, 2014, 11:03 a.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
---

Replaced
void KMyMoneyGlobalSettings::setSubstringSearch(QWidget* w)
by void KMyMoneyMVCCombo::setSubstringSearchForChildren(QWidget*const widget, 
bool enabled)

To use this commit you must replace
KMyMoneyGlobalSettings::setSubstringSearch(widgetPtr);
by
KMyMoneyMVCCombo::setSubstringSearchForChildren(widgetPtr, 
!KMyMoneySettings::stringMatchFromStart());

So KMyMoneyMVCCombo is not needed in KMyMoneyGlobalSettings anymore and
the target kmm_config can be used without linking the target "widgets".

My goal is to clean up the build of all widgets. Later there should be
1) a shared library which contains all KMyMoney widgets which are interessting 
for plugins,
2) a static library which contains widgets which are not interessting for 
plugins (if there are such widgets, at the moment nearly everything is put here)
3)?a shared library for QtDesigner (which is not working at the moment)


Diffs
-

  kmymoney/kmymoney.cpp c4bbf0cbf46250f69f7e2e9c13471c4e6c7cb261 
  kmymoney/kmymoney.kcfg 5d5e09cf9b1d94cec07fe97cda388819fd8a97ed 
  kmymoney/kmymoneyglobalsettings.cpp a6742fa9e329579fd81548b20bfda766ebb27863 
  kmymoney/widgets/kmymoneymvccombo.h a9d8e37ee0a600240c7ca4544964a448770d0a24 
  kmymoney/widgets/kmymoneymvccombo.cpp 
cf7c21b25716aa99d9e72ee19883f371da816c0c 
  kmymoney/wizards/endingbalancedlg/kendingbalancedlg.cpp 
adb2adae4c8e086df0a1ce5e62a36cb26859dc76 
  kmymoney/wizards/newloanwizard/knewloanwizard.cpp 
5b8134e1345a863a13469dfd32eb56ed99b9bdc2 

Diff: https://git.reviewboard.kde.org/r/119635/diff/


Testing
---

1. kwriteconfig --file kmymoneyrc --group "General Options" --key 
"stringMatchFromStart" --type bool true
2. restarted KMyMoney
3. tried completion for payees in register
 -- worked as expected --
4. removed option again
5. restarted KMyMoney
6. tried completion for payees in register
 -- worked as expected --


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 321649] No input form dialog appears when i try to add a new account in aqbanking

2014-08-10 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=321649

Christian David  changed:

   What|Removed |Added

 CC||christian-da...@web.de

--- Comment #4 from Christian David  ---
Did you send this bug to the aqbanking mailing list?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-08-11 Thread Christian David



> On Aug. 11, 2014, 12:51 vorm., Fernando Vilas wrote:
> > I like the direction you are going, and that someone else is taking a look 
> > at the database code.
> > 
> > I would recommend making the row counts into a view so you can use a JOIN 
> > rather than the long statement you created. This has the advantage of 
> > letting the DBMS cache the answer when any index changes. That probably has 
> > more of an effect before the change to index all the tables, but may be 
> > useful anyway.

I recommend we should try it without a view and optimize it if necessarey. Also 
the function is not call that often and the query is very fast already. On my 
large test file I could not notice any delay (maybe it is even faster than 
before).


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119647/#review64213
-------


On Aug. 7, 2014, 4:57 nachm., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119647/
> ---
> 
> (Updated Aug. 7, 2014, 4:57 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> MyMoneyStorageSql stored the row count of several tables in the table
> kmmFileInfo. But this is error-prone and bad style.
> 
> Now this information is read from the database directly. Usually a database
> caches the row count of tables anyway. Also all tables have an index so even
> a `count(*)` is really fast. The result is still cached within
> MyMoneyStorageSQL as it did before.
> 
> 
> Diffs
> -
> 
>   kmymoney/mymoney/storage/mymoneystoragesql.h 
> 5e148756739fcbdc3b9ffb6e11751ea035209c2b 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 
> 6e7a0715842da5ccb6d40f5f4a512e3433196ce6 
> 
> Diff: https://git.reviewboard.kde.org/r/119647/diff/
> 
> 
> Testing
> ---
> 
> All test were done using SQLite. But all command I use are available in all 
> other databases as well.
> 
> 1. Tested the used SQL query in a (huge) database using sqlite:
> 
> ```SQL
> SELECT (SELECT count(*) from kmmAccounts) AS accounts, (SELECT count(*) FROM 
> kmmCurrencies) AS currencies, (SELECT count(*) FROM kmmPayees) AS payees, 
> (SELECT count(*) from kmmTags) AS tags, (SELECT count(*) FROM 
> kmmTransactions) AS transactions, (SELECT count(*) FROM kmmSplits) AS splits, 
> (SELECT count(*) FROM kmmSecurities) AS securities, (SELECT count(*) FROM 
> kmmCurrencies) AS currencies, (SELECT count(*) FROM kmmSchedules) AS 
> schedules, (SELECT count(*) FROM kmmPrices) AS prices, (SELECT count(*) FROM 
> kmmKeyValuePairs) AS kvps, (SELECT count(*) FROM kmmReportConfig) AS reports, 
> (SELECT count(*) FROM kmmBudgetConfig) AS budgets UNION ALL SELECT accounts, 
> currencies, payees, tags, transactions, splits, securities, currencies, 
> schedules, prices, kvps, reports, budgets FROM kmmFileInfo;
> ```
> 
> Result:
> 
> 9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= the new query )
> 9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= what is stored in 
> kmmFileInfo )
> 
> 2. Saved a .kmy file and into a database (to test the INSERT routine), 
> inspected database by hand
> 
> 3. Changed something and inspected database by hand afterward.
> 
> 
> Thanks,
> 
> Christian David
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 119780: Corrected inconsistent usage of kvp key "iban" and "IBAN"

2014-08-14 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119780/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

Now everything is lower case and old keys written in upper case are
updated or removed.


Diffs
-

  kmymoney/mymoney/mymoneyaccount.cpp 732390c386925dc1aff19a17c16d2f30f9b34cea 
  kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp 
b85e8d492f4a66356b4a8e7fe11f28b12ab53322 

Diff: https://git.reviewboard.kde.org/r/119780/diff/


Testing
---

Manipulated a file manually and reopened it. Keys were updated and removed 
correctly.
Created a new account using the new account dialog and checked the file 
manually.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119780: Corrected inconsistent usage of kvp key "iban" and "IBAN"

2014-08-14 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119780/
---

(Updated Aug. 14, 2014, 8:26 a.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
---

Now everything is lower case and old keys written in upper case are
updated or removed.


Diffs
-

  kmymoney/mymoney/mymoneyaccount.cpp 732390c386925dc1aff19a17c16d2f30f9b34cea 
  kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp 
b85e8d492f4a66356b4a8e7fe11f28b12ab53322 

Diff: https://git.reviewboard.kde.org/r/119780/diff/


Testing
---

Manipulated a file manually and reopened it. Keys were updated and removed 
correctly.
Created a new account using the new account dialog and checked the file 
manually.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-08-15 Thread Christian David



> On Aug. 11, 2014, 12:51 vorm., Fernando Vilas wrote:
> > I like the direction you are going, and that someone else is taking a look 
> > at the database code.
> > 
> > I would recommend making the row counts into a view so you can use a JOIN 
> > rather than the long statement you created. This has the advantage of 
> > letting the DBMS cache the answer when any index changes. That probably has 
> > more of an effect before the change to index all the tables, but may be 
> > useful anyway.
> 
> Christian David wrote:
> I recommend we should try it without a view and optimize it if 
> necessarey. Also the function is not call that often and the query is very 
> fast already. On my large test file I could not notice any delay (maybe it is 
> even faster than before).
> 
> Thomas Baumgart wrote:
> Looks good to me, though I am not a DB expert at all. For backward 
> compatibility we should make sure to keep the values in kmmFileInfo for the 
> next major release and update them when the DB is closed. This way, a user is 
> not stranded when he falls back to a previous version of the application code.

That is a good idea, Thomas. I'll do that.

But before that I want to solve the issue in the upgrade progress (see mailing 
list). Because this patch is affected in the same way.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119647/#review64213
---


On Aug. 7, 2014, 4:57 nachm., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119647/
> ---
> 
> (Updated Aug. 7, 2014, 4:57 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> MyMoneyStorageSql stored the row count of several tables in the table
> kmmFileInfo. But this is error-prone and bad style.
> 
> Now this information is read from the database directly. Usually a database
> caches the row count of tables anyway. Also all tables have an index so even
> a `count(*)` is really fast. The result is still cached within
> MyMoneyStorageSQL as it did before.
> 
> 
> Diffs
> -
> 
>   kmymoney/mymoney/storage/mymoneystoragesql.h 
> 5e148756739fcbdc3b9ffb6e11751ea035209c2b 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 
> 6e7a0715842da5ccb6d40f5f4a512e3433196ce6 
> 
> Diff: https://git.reviewboard.kde.org/r/119647/diff/
> 
> 
> Testing
> ---
> 
> All test were done using SQLite. But all command I use are available in all 
> other databases as well.
> 
> 1. Tested the used SQL query in a (huge) database using sqlite:
> 
> ```SQL
> SELECT (SELECT count(*) from kmmAccounts) AS accounts, (SELECT count(*) FROM 
> kmmCurrencies) AS currencies, (SELECT count(*) FROM kmmPayees) AS payees, 
> (SELECT count(*) from kmmTags) AS tags, (SELECT count(*) FROM 
> kmmTransactions) AS transactions, (SELECT count(*) FROM kmmSplits) AS splits, 
> (SELECT count(*) FROM kmmSecurities) AS securities, (SELECT count(*) FROM 
> kmmCurrencies) AS currencies, (SELECT count(*) FROM kmmSchedules) AS 
> schedules, (SELECT count(*) FROM kmmPrices) AS prices, (SELECT count(*) FROM 
> kmmKeyValuePairs) AS kvps, (SELECT count(*) FROM kmmReportConfig) AS reports, 
> (SELECT count(*) FROM kmmBudgetConfig) AS budgets UNION ALL SELECT accounts, 
> currencies, payees, tags, transactions, splits, securities, currencies, 
> schedules, prices, kvps, reports, budgets FROM kmmFileInfo;
> ```
> 
> Result:
> 
> 9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= the new query )
> 9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= what is stored in 
> kmmFileInfo )
> 
> 2. Saved a .kmy file and into a database (to test the INSERT routine), 
> inspected database by hand
> 
> 3. Changed something and inspected database by hand afterward.
> 
> 
> Thanks,
> 
> Christian David
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 338413] [onlinebanking] crash while entering account numbers and switching to different payee

2014-09-08 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=338413

Christian David  changed:

   What|Removed |Added

   Assignee|kmymoney-devel@kde.org  |christian-da...@web.de
 CC||christian-da...@web.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 338413] [onlinebanking] crash while entering account numbers and switching to different payee

2014-09-15 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=338413

Christian David  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kmym
   ||oney/ac56ec5bf4c9940448f251
   ||9a33ac1c38d2f14341
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Christian David  ---
Git commit ac56ec5bf4c9940448f2519a33ac1c38d2f14341 by Christian Dávid.
Committed on 15/09/2014 at 19:21.
Pushed by christiand into branch 'add-onlinebanking'.

Fixed a crash in payeeIdentifierModel

Fixed this behaviour: "Tried to enter BIC/IBAN numbers for payee X.
Selected different payee Y while entered data of X is not saved. Crash
occurred."

M  +0-2kmymoney/models/payeeidentifiermodel.cpp

http://commits.kde.org/kmymoney/ac56ec5bf4c9940448f2519a33ac1c38d2f14341

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120339: New "Weboob" plugin for online banking

2014-09-23 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120339/#review67307
---


Hi, that looks really, really cool!

I wanted to review it but could just briefly look over it leaving a lot of 
minor notes. Maybe someone else can do a more deeply review.


CMakeLists.txt
<https://git.reviewboard.kde.org/r/120339/#comment46983>

This comment does not fit.



kmymoney/plugins/weboob/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120339/#comment46992>

If these lines are not needed, you should remove them.



kmymoney/plugins/weboob/dialogs/webaccount.cpp
<https://git.reviewboard.kde.org/r/120339/#comment46991>

This file does not follow the coding style



kmymoney/plugins/weboob/plugin.hpp
<https://git.reviewboard.kde.org/r/120339/#comment46990>

In KMyMoney c++ headers usually have the .h suffix (some of your files use 
.h as well). Consider using .h everywhere.



kmymoney/plugins/weboob/plugin.cpp
<https://git.reviewboard.kde.org/r/120339/#comment46984>

Do not use "NULL" but 0 (the C++ way of doing this).



kmymoney/plugins/weboob/plugin.cpp
<https://git.reviewboard.kde.org/r/120339/#comment46985>

Maybe you want to remove this debug message. There is no reason for it at 
this stage of your work.



kmymoney/plugins/weboob/plugin.cpp
<https://git.reviewboard.kde.org/r/120339/#comment46986>

You should remove this debug message.



kmymoney/plugins/weboob/plugin.cpp
<https://git.reviewboard.kde.org/r/120339/#comment46987>

Just an idea: name the keys weboob-...?



kmymoney/plugins/weboob/plugin.cpp
<https://git.reviewboard.kde.org/r/120339/#comment46989>

NULL -> 0



kmymoney/plugins/weboob/plugin.cpp
<https://git.reviewboard.kde.org/r/120339/#comment46988>

NULL -> 0



kmymoney/plugins/weboob/plugin.cpp
<https://git.reviewboard.kde.org/r/120339/#comment46993>

Consider removing this debug message.


- Christian David


On Sept. 23, 2014, 4:46 nachm., Florent Fourcot wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120339/
> ---
> 
> (Updated Sept. 23, 2014, 4:46 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Weboob (http://weboob.org) is a library and a collection of applications to 
> extract data from the Web. One of the features is to simplify online banking, 
> on many french banks and several outside of France. About 33 modules are 
> currently available.
> 
> This module provides a easy way to import the transactions extracted by 
> Weboob in Kmymoney, providing an online banking like the aqbanking module.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/weboob/dialogs/webaccount.ui PRE-CREATION 
>   kmymoney/plugins/weboob/kmm_weboob.desktop PRE-CREATION 
>   CMakeLists.txt d8f9ef4 
>   kmymoney/plugins/CMakeLists.txt eb3a62f 
>   kmymoney/plugins/weboob/CMakeLists.txt PRE-CREATION 
>   kmymoney/plugins/weboob/dialogs/CMakeLists.txt PRE-CREATION 
>   kmymoney/plugins/weboob/dialogs/mapaccount.hpp PRE-CREATION 
>   kmymoney/plugins/weboob/dialogs/mapaccount.cpp PRE-CREATION 
>   kmymoney/plugins/weboob/dialogs/mapaccount.ui PRE-CREATION 
>   kmymoney/plugins/weboob/dialogs/webaccount.h PRE-CREATION 
>   kmymoney/plugins/weboob/dialogs/webaccount.cpp PRE-CREATION 
>   kmymoney/plugins/weboob/weboob.cpp PRE-CREATION 
>   kmymoney/plugins/weboob/weboob.py PRE-CREATION 
>   kmymoney/plugins/weboob/kmm_weboob.rc PRE-CREATION 
>   kmymoney/plugins/weboob/plugin.hpp PRE-CREATION 
>   kmymoney/plugins/weboob/plugin.cpp PRE-CREATION 
>   kmymoney/plugins/weboob/weboob.hpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120339/diff/
> 
> 
> Testing
> ---
> 
> The module needs krosspython to work. The tests have been ran on a Debian 
> Stable, with a krosspython in version 4.8.
> It looks like a bug in krosspython 
> (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762593) prevents to use it 
> with a newer krosspython version.
> 
> 
> Thanks,
> 
> Florent Fourcot
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 331638] Transaction splitting ignores third decimal place

2014-09-24 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=331638

Christian David  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/49c06bbd56834f963f20dc |oney/5131eaf3fa1c4dec7ca6a4
   |7a96b2cb3bcff393b3  |d0dcb177d281e3fa57

--- Comment #9 from Christian David  ---
Git commit 5131eaf3fa1c4dec7ca6a4d0dcb177d281e3fa57 by Christian Dávid, on
behalf of Cristian Oneț.
Committed on 19/08/2014 at 12:37.
Pushed by christiand into branch 'add-onlinebanking'.

Use the proper precision in the split table.

We must have only a few users with a precision more than 2
otherwise this should have been catched a long time ago.

M  +5-2kmymoney/dialogs/kmymoneysplittable.cpp
M  +6-1kmymoney/dialogs/kmymoneysplittable.h
M  +1-1kmymoney/dialogs/ksplittransactiondlg.cpp

http://commits.kde.org/kmymoney/5131eaf3fa1c4dec7ca6a4d0dcb177d281e3fa57

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 327663] crash on reports

2014-09-24 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=327663

Christian David  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/e7b64d1488cfdfce7813db |oney/58944b69daeb8ae49c3ccf
   |bd7388f3f5ffcbd068  |5916852b8efc9ce3d4

--- Comment #13 from Christian David  ---
Git commit 58944b69daeb8ae49c3ccf5916852b8efc9ce3d4 by Christian Dávid, on
behalf of Cristian Oneț.
Committed on 19/08/2014 at 15:35.
Pushed by christiand into branch 'add-onlinebanking'.

Properly initialize a report object before reading it.

This way we make sure that it's valid even if the xml data is not.

M  +2-0kmymoney/mymoney/mymoneyreport.cpp

http://commits.kde.org/kmymoney/58944b69daeb8ae49c3ccf5916852b8efc9ce3d4

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 296614] Ledger view scrolls to end on merging two transactions.

2014-09-24 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=296614

Christian David  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/2316fde061f24e307cbbc3 |oney/a8cd47ebeb24d1fa935e25
   |7e91c42b9928f597ee  |8f82d8403f9ca7eb60

--- Comment #6 from Christian David  ---
Git commit a8cd47ebeb24d1fa935e258f82d8403f9ca7eb60 by Christian Dávid, on
behalf of Cristian Oneț.
Committed on 28/08/2014 at 19:13.
Pushed by christiand into branch 'add-onlinebanking'.

Select previous/next items when transactions go away from the ledger.

When loading the ledger prepare for the fact that the current selected
transactions might go away by storing the id's of the previous/next
unselected siblings so they may be used to restore a selection.

This should fix all cases of the ledger view scrolling to the last
selection.

M  +38   -9kmymoney/views/kgloballedgerview.cpp

http://commits.kde.org/kmymoney/a8cd47ebeb24d1fa935e258f82d8403f9ca7eb60

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 336258] Crash while editing a split

2014-09-24 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=336258

Christian David  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/f3d666d93dbcb2f0b51a34 |oney/c6639a214066388a6c718b
   |4ab2d78f7c68c92c67  |5a9a42db2e7cf9fd5b

--- Comment #6 from Christian David  ---
Git commit c6639a214066388a6c718b5a9a42db2e7cf9fd5b by Christian Dávid, on
behalf of Cristian Oneț.
Committed on 31/08/2014 at 15:49.
Pushed by christiand into branch 'add-onlinebanking'.

Fix a nasty split editor bug.

Because of the way the endEdit method was written the endEdit
operation could be executed without actually ending the edit
(missing category). But code that was calling endEdit expected
that it allways would end the edit thus sometimes edit widgets
could be obtained on two rows.

Once in this state accepting both editors would cause a crash.

Also removed a workaround which would end the edit on a resize.
Instead don't do the operation that was resizing the rows while
in edit.

M  +24   -21   kmymoney/dialogs/kmymoneysplittable.cpp
M  +9-1kmymoney/dialogs/kmymoneysplittable.h

http://commits.kde.org/kmymoney/c6639a214066388a6c718b5a9a42db2e7cf9fd5b

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 338684] Cleared amount is incorrect for liability accounts

2014-09-24 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=338684

Christian David  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/93afc106c9a861349b3fe6 |oney/0d66dc42d97e29cd38bd70
   |f71f7351f26aab3d92  |6c1b77d4ccb19efb3c

--- Comment #3 from Christian David  ---
Git commit 0d66dc42d97e29cd38bd706c1b77d4ccb19efb3c by Christian Dávid, on
behalf of Cristian Oneț.
Committed on 31/08/2014 at 18:41.
Pushed by christiand into branch 'add-onlinebanking'.

Fix the cleared balance of liability accounts.

The problem was caused by the fact that when refactored, the code
didn't consider the fact that previously the balance was also being
multiplied by factor. Instead of using factor at each step use it
only at the end when the result is returned since it's faster this
way.

M  +3-4kmymoney/mymoney/mymoneyfile.cpp

http://commits.kde.org/kmymoney/0d66dc42d97e29cd38bd706c1b77d4ccb19efb3c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 338099] loan wizard doesn't show correct recipient

2014-09-24 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=338099

Christian David  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/4f2774331e4fd5cb9c0f54 |oney/c7d08be702e077894b
   |1c808a739a1d762faa  |ef24352cb9010b476b

--- Comment #3 from Christian David  ---
Git commit c7d08be702e077894bef24352cb9010b476b by Christian Dávid, on
behalf of Cristian Oneț.
Committed on 08/09/2014 at 21:41.
Pushed by christiand into branch 'add-onlinebanking'.

Display the payee name instead of the id on the summary page.

There are still some issues when going back from the summary page
and changing something but this should be in the scope of another
report.

M  +9-3kmymoney/wizards/newloanwizard/summarywizardpage.cpp

http://commits.kde.org/kmymoney/c7d08be702e077894bef24352cb9010b476b

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 120377: Added emitting of signal in KMyMoneyAccountCombo::setSelected()

2014-09-26 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120377/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

The accountSelected(QString) signal is emitted if
KMyMoneyAccountCombo::setSelected() is used to change the selection.
This should be the behavior expected by any user of this signal.

The name "accountSelected" could be meant as "account selected by user". Could 
someone with a better understanding of the internals tell me if my change does 
not cause any issues.

Also: are there other ways to change selection which do not emit this signal?

Btw:?This is the most elegant solution of some issues in the credit transfer 
editors.


Diffs
-

  kmymoney/widgets/kmymoneyaccountcombo.cpp 
bde7d9b9935e82e714a74a41bfcfa426d045066a 

Diff: https://git.reviewboard.kde.org/r/120377/diff/


Testing
---

In a short test I could not find any disadvantages.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120377: Added emitting of signal in KMyMoneyAccountCombo::setSelected()

2014-10-03 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120377/
---

(Updated Oct. 3, 2014, 10:36 a.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
---

The accountSelected(QString) signal is emitted if
KMyMoneyAccountCombo::setSelected() is used to change the selection.
This should be the behavior expected by any user of this signal.

The name "accountSelected" could be meant as "account selected by user". Could 
someone with a better understanding of the internals tell me if my change does 
not cause any issues.

Also: are there other ways to change selection which do not emit this signal?

Btw:?This is the most elegant solution of some issues in the credit transfer 
editors.


Diffs
-

  kmymoney/widgets/kmymoneyaccountcombo.cpp 
bde7d9b9935e82e714a74a41bfcfa426d045066a 

Diff: https://git.reviewboard.kde.org/r/120377/diff/


Testing
---

In a short test I could not find any disadvantages.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 339103] reports cannot be created using the DB backend

2014-10-04 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=339103

Christian David  changed:

   What|Removed |Added

 CC||christian-da...@web.de

--- Comment #9 from Christian David  ---
During the upgrade of database version 6.4 to 7.x the hiTransactionId filed is
set 0 as well. It seems to be an issue in the upgrade process...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-10-04 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119647/
---

(Updated Okt. 4, 2014, 8:45 nachm.)


Review request for KMymoney.


Changes
---

The row count is stored in kmmFileInfo again for backwards compatibility (but 
it is not used).


Repository: kmymoney


Description (updated)
---

MyMoneyStorageSql stored the row count of several tables in the table
kmmFileInfo. But this is error-prone and bad style.

Now this information is read from the database directly. Usually a
database caches the row count of tables anyway. Also all tables have an
index so even a count(*) is really fast. The result is still cached
within MyMoneyStorageSQL as it did before.

REVIEW: 119647


Diffs (updated)
-

  kmymoney/mymoney/storage/mymoneystoragesql.h 
5e148756739fcbdc3b9ffb6e11751ea035209c2b 
  kmymoney/mymoney/storage/mymoneystoragesql.cpp 
6e7a0715842da5ccb6d40f5f4a512e3433196ce6 

Diff: https://git.reviewboard.kde.org/r/119647/diff/


Testing
---

All test were done using SQLite. But all command I use are available in all 
other databases as well.

1. Tested the used SQL query in a (huge) database using sqlite:

```SQL
SELECT (SELECT count(*) from kmmAccounts) AS accounts, (SELECT count(*) FROM 
kmmCurrencies) AS currencies, (SELECT count(*) FROM kmmPayees) AS payees, 
(SELECT count(*) from kmmTags) AS tags, (SELECT count(*) FROM kmmTransactions) 
AS transactions, (SELECT count(*) FROM kmmSplits) AS splits, (SELECT count(*) 
FROM kmmSecurities) AS securities, (SELECT count(*) FROM kmmCurrencies) AS 
currencies, (SELECT count(*) FROM kmmSchedules) AS schedules, (SELECT count(*) 
FROM kmmPrices) AS prices, (SELECT count(*) FROM kmmKeyValuePairs) AS kvps, 
(SELECT count(*) FROM kmmReportConfig) AS reports, (SELECT count(*) FROM 
kmmBudgetConfig) AS budgets UNION ALL SELECT accounts, currencies, payees, 
tags, transactions, splits, securities, currencies, schedules, prices, kvps, 
reports, budgets FROM kmmFileInfo;
```

Result:

9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= the new query )
9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= what is stored in kmmFileInfo )

2. Saved a .kmy file and into a database (to test the INSERT routine), 
inspected database by hand

3. Changed something and inspected database by hand afterward.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 119647: Database backend does not store row count in a table anymore

2014-10-05 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119647/
---

(Updated Oct. 5, 2014, 11:25 a.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
---

MyMoneyStorageSql stored the row count of several tables in the table
kmmFileInfo. But this is error-prone and bad style.

Now this information is read from the database directly. Usually a
database caches the row count of tables anyway. Also all tables have an
index so even a count(*) is really fast. The result is still cached
within MyMoneyStorageSQL as it did before.

REVIEW: 119647


Diffs
-

  kmymoney/mymoney/storage/mymoneystoragesql.h 
5e148756739fcbdc3b9ffb6e11751ea035209c2b 
  kmymoney/mymoney/storage/mymoneystoragesql.cpp 
6e7a0715842da5ccb6d40f5f4a512e3433196ce6 

Diff: https://git.reviewboard.kde.org/r/119647/diff/


Testing
---

All test were done using SQLite. But all command I use are available in all 
other databases as well.

1. Tested the used SQL query in a (huge) database using sqlite:

```SQL
SELECT (SELECT count(*) from kmmAccounts) AS accounts, (SELECT count(*) FROM 
kmmCurrencies) AS currencies, (SELECT count(*) FROM kmmPayees) AS payees, 
(SELECT count(*) from kmmTags) AS tags, (SELECT count(*) FROM kmmTransactions) 
AS transactions, (SELECT count(*) FROM kmmSplits) AS splits, (SELECT count(*) 
FROM kmmSecurities) AS securities, (SELECT count(*) FROM kmmCurrencies) AS 
currencies, (SELECT count(*) FROM kmmSchedules) AS schedules, (SELECT count(*) 
FROM kmmPrices) AS prices, (SELECT count(*) FROM kmmKeyValuePairs) AS kvps, 
(SELECT count(*) FROM kmmReportConfig) AS reports, (SELECT count(*) FROM 
kmmBudgetConfig) AS budgets UNION ALL SELECT accounts, currencies, payees, 
tags, transactions, splits, securities, currencies, schedules, prices, kvps, 
reports, budgets FROM kmmFileInfo;
```

Result:

9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= the new query )
9|185|6330|0|9|18|0|185|0|22|10|0|0 ( <= what is stored in kmmFileInfo )

2. Saved a .kmy file and into a database (to test the INSERT routine), 
inspected database by hand

3. Changed something and inspected database by hand afterward.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2014-10-05 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120499/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

MyMoneyStorageSql::upgradeToV7() does not use readFileInfo() and
writeFileInfo() anymore.

This should prevent an issue if this metod is used to upgrade the
database to a version higher than 7 as readFileInfo() and
writeFileInfo() assume a database of the most recent version. This
will cause errors (=> crash) if a column in kmmFileInfo was
renamed or added between version 7 and the final version.

KMyMoney should still crash if you upgradeToV1() is used.


Diffs
-

  kmymoney/mymoney/storage/mymoneystoragesql.cpp 
0fa790d435bc978279038893b945de31811f34f1 

Diff: https://git.reviewboard.kde.org/r/120499/diff/


Testing
---

Opened an sqlite database which was created with KMyMoney 4.5.3, database 
version 6.
The upgrade still worked and kmmFileInfo was still filled with correct data.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120632: FAQ uses Capacity now

2014-10-17 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120632/#review68619
---


Very cool! I tried it on my test sever and the patch looks fine.

The issues I opend are not important, I was just fussy because you asked me to 
do so.


faq.php
<https://git.reviewboard.kde.org/r/120632/#comment47803>

Whitespace at end of line. Consider to remove it.



faq.php
<https://git.reviewboard.kde.org/r/120632/#comment47804>

General note, you do not have to do it: This should be replaced by  or 
similar.



faq.php
<https://git.reviewboard.kde.org/r/120632/#comment47805>

same as above


- Christian David


On Okt. 17, 2014, 7:11 nachm., Lars Meiendresch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120632/
> ---
> 
> (Updated Okt. 17, 2014, 7:11 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney-org
> 
> 
> Description
> ---
> 
> FAQ uses Capacity now and bug fixed in plasmaMenu.inc
> 
> 
> Diffs
> -
> 
>   faq.php 85aaec8 
>   plasmaMenu.inc 109ab08 
> 
> Diff: https://git.reviewboard.kde.org/r/120632/diff/
> 
> 
> Testing
> ---
> 
> Created my own Webserver. Everything looks fine.
> 
> 
> Thanks,
> 
> Lars Meiendresch
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120632: FAQ uses Capacity now

2014-10-17 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120632/#review68620
---

Ship it!


Ship It!

- Christian David


On Okt. 17, 2014, 7:29 nachm., Lars Meiendresch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120632/
> ---
> 
> (Updated Okt. 17, 2014, 7:29 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney-org
> 
> 
> Description
> ---
> 
> FAQ uses Capacity now and bug fixed in plasmaMenu.inc
> 
> 
> Diffs
> -
> 
>   faq.php 85aaec8 
>   plasmaMenu.inc 109ab08 
> 
> Diff: https://git.reviewboard.kde.org/r/120632/diff/
> 
> 
> Testing
> ---
> 
> Created my own Webserver. Everything looks fine.
> 
> 
> Thanks,
> 
> Lars Meiendresch
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120632: FAQ uses Capacity now

2014-10-17 Thread Christian David



> On Okt. 17, 2014, 9:39 nachm., Jack Ostroff wrote:
> > I apologize if I'm being dense, but what do you mean by "uses Capacity now" 
> > ?  I see mainly a reordering of questions.
> 
> Lars Meiendresch wrote:
> Capacity is the framework for KDE Webpages (see 
> https://community.kde.org/KDE.org/Capacity_HOWTO). I used their functions to 
> create the FAQ.

Btw.: "We" removed a question regarding the autotools configure file since we 
use cmake for a couple of years now.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120632/#review68629
---


On Okt. 17, 2014, 8:42 nachm., Lars Meiendresch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120632/
> ---
> 
> (Updated Okt. 17, 2014, 8:42 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney-org
> 
> 
> Description
> ---
> 
> FAQ uses Capacity now and bug fixed in plasmaMenu.inc
> 
> 
> Diffs
> -
> 
>   faq.php 85aaec8 
>   plasmaMenu.inc 109ab08 
> 
> Diff: https://git.reviewboard.kde.org/r/120632/diff/
> 
> 
> Testing
> ---
> 
> Created my own Webserver. Everything looks fine.
> 
> 
> Thanks,
> 
> Lars Meiendresch
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 340244] Update the documentation screenshots

2014-10-22 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=340244

Christian David  changed:

   What|Removed |Added

 CC||christian-da...@web.de

--- Comment #1 from Christian David  ---
Please note: I will change that specific widget in a month (or so).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120818: Take advantage of the implicit sharing available in AlkValue.

2014-10-28 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120818/#review69331
---


I think the minimum alkimia version must be adopted in the requirements.

- Christian David


On Okt. 26, 2014, 9:58 nachm., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120818/
> ---
> 
> (Updated Okt. 26, 2014, 9:58 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Since the values 1 and -1 seem to be used pretty often (in loops) it's worth 
> to have static values for these constants to benefit from implicit sharing in 
> the places where these values are necessary.
> 
> The sharing of value 0 is already provided by AlkValue so we don't need a 
> static value for 0.
> 
> This patch will work just fine with alkimia 4.3.2 but the advantages will be 
> visible when combined with REVIEW 120815.
> 
> 
> Diffs
> -
> 
>   kmymoney/reports/pivotgrid.cpp b608a28257ba60c4ec83eb744e1891f58c6dac58 
>   kmymoney/reports/pivotgridtest.cpp e0deaf07b2fadcbc54dabe96633adde653bbda4f 
>   kmymoney/reports/pivottable.cpp 340f7a8d6ec98bcc2968bec12ecb9706b6cbfff0 
>   kmymoney/reports/querytable.cpp cd4371946974c8936c076dd4865c763ce6f77edb 
>   kmymoney/reports/reportaccount.cpp d3b42c33ef09b31545639092676dc76c5d737b65 
>   kmymoney/views/kforecastview.cpp e5120b03aa345929d92d7af508f16ee54a7e8309 
>   kmymoney/views/kgloballedgerview.cpp 
> 22f40e139fc1d5d9280c84539bdcf9ad457f7de1 
>   kmymoney/views/khomeview.cpp 5f3c66608564edcc6a078dbda9d78122b166c646 
>   kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp 
> 56e7d4112fc4b6b95b11d9de58b47689e5e2e643 
>   kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp 
> 801b76147b35af7548357ef200a84a8714947374 
>   kmymoney/wizards/newinvestmentwizard/konlineupdatewizardpage.cpp 
> 847ff8c89055774513231c3bb65d1d4155b8407b 
>   kmymoney/wizards/newloanwizard/knewloanwizard.cpp 
> 99ea10fc2ace66f1590d53a7555b39818fc054b3 
>   kmymoney/dialogs/investactivities.cpp 
> ca425f99d70169d7ba6c80870ab6be86e8069970 
>   kmymoney/dialogs/investtransactioneditor.cpp 
> 4f870039d2de55d73550c944c7f5e3403eb9abd0 
>   kmymoney/dialogs/kcurrencycalculator.cpp 
> b50aa8a1c6db0fd569adc97cf01877c76465d52f 
>   kmymoney/dialogs/kmymoneypricedlg.cpp 
> 9aa220fb4a558ef0945bb68be85c39b927451e8c 
>   kmymoney/dialogs/knewaccountdlg.cpp 
> 47c20a2708cd998b4b53ee2d97d5dcc1e6bd6021 
>   kmymoney/kmymoney.cpp 84bd9a3a6da487ba0d41bcca48dc82b4842f1c28 
>   kmymoney/models/accountsmodel.cpp 37384d26e7bd7321ddf247b35517da28d4e11a45 
>   kmymoney/mymoney/mymoneyaccounttest.cpp 
> 2506f8eb4efb0053e3e1c7c7ce755b27d288345d 
>   kmymoney/mymoney/mymoneyfile.cpp dd4af2e3a9883998f2ad95ccecb5bcbfa23068db 
>   kmymoney/mymoney/mymoneyfiletest.cpp 
> 1e196ad92f3890e2e6ecfbcc9da66dad91e6dcf7 
>   kmymoney/mymoney/mymoneyforecast.cpp 
> 9f3e384584f4ded4f72be830fa2dd1f0b18017fd 
>   kmymoney/mymoney/mymoneyforecasttest.cpp 
> dc098af51620d858728ed706e189d9218ef49543 
>   kmymoney/mymoney/mymoneymoney.h 033983b4fe4c2c140cbeb7b55cdaf9d18c4db154 
>   kmymoney/mymoney/mymoneymoney.cpp 5de7fa9085552c7fae01b7380258ea3752672c52 
>   kmymoney/mymoney/mymoneyprice.cpp 27b847480b3800d512d81dba66639f224c220dfd 
>   kmymoney/mymoney/mymoneypricetest.cpp 
> 1acd388a8928a8d9fcd3e04afd694836c7bb7b2e 
>   kmymoney/mymoney/mymoneysplit.cpp 2f811328a10e4e612d4431c81b467f9e69a57c3b 
>   kmymoney/mymoney/mymoneytransactionfilter.cpp 
> 1883971dcf5fb1ea771efb178b58a30a1698ad65 
>   kmymoney/mymoney/storage/mymoneystorageanon.cpp 
> 08f42f2b8c6cd89fcbb9b449a46bc8406e30746b 
>   kmymoney/reports/objectinfotable.cpp 
> 49d3ae1ed98f374f82c5ed6832a00c12b48a132a 
>   kmymoney/reports/pivotgrid.h 8205eb22ca40e01b66310e33b035aac70b63b675 
> 
> Diff: https://git.reviewboard.kde.org/r/120818/diff/
> 
> 
> Testing
> ---
> 
> Ran KMyMoney and the tests.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120818: Take advantage of the implicit sharing available in AlkValue.

2014-10-28 Thread Christian David



> On Okt. 28, 2014, 8:23 nachm., Christian David wrote:
> > I think the minimum alkimia version must be adopted in the requirements.

Just noticed: I am wrong - sorry.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120818/#review69331
---


On Okt. 26, 2014, 9:58 nachm., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120818/
> ---
> 
> (Updated Okt. 26, 2014, 9:58 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Since the values 1 and -1 seem to be used pretty often (in loops) it's worth 
> to have static values for these constants to benefit from implicit sharing in 
> the places where these values are necessary.
> 
> The sharing of value 0 is already provided by AlkValue so we don't need a 
> static value for 0.
> 
> This patch will work just fine with alkimia 4.3.2 but the advantages will be 
> visible when combined with REVIEW 120815.
> 
> 
> Diffs
> -
> 
>   kmymoney/reports/pivotgrid.cpp b608a28257ba60c4ec83eb744e1891f58c6dac58 
>   kmymoney/reports/pivotgridtest.cpp e0deaf07b2fadcbc54dabe96633adde653bbda4f 
>   kmymoney/reports/pivottable.cpp 340f7a8d6ec98bcc2968bec12ecb9706b6cbfff0 
>   kmymoney/reports/querytable.cpp cd4371946974c8936c076dd4865c763ce6f77edb 
>   kmymoney/reports/reportaccount.cpp d3b42c33ef09b31545639092676dc76c5d737b65 
>   kmymoney/views/kforecastview.cpp e5120b03aa345929d92d7af508f16ee54a7e8309 
>   kmymoney/views/kgloballedgerview.cpp 
> 22f40e139fc1d5d9280c84539bdcf9ad457f7de1 
>   kmymoney/views/khomeview.cpp 5f3c66608564edcc6a078dbda9d78122b166c646 
>   kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp 
> 56e7d4112fc4b6b95b11d9de58b47689e5e2e643 
>   kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp 
> 801b76147b35af7548357ef200a84a8714947374 
>   kmymoney/wizards/newinvestmentwizard/konlineupdatewizardpage.cpp 
> 847ff8c89055774513231c3bb65d1d4155b8407b 
>   kmymoney/wizards/newloanwizard/knewloanwizard.cpp 
> 99ea10fc2ace66f1590d53a7555b39818fc054b3 
>   kmymoney/dialogs/investactivities.cpp 
> ca425f99d70169d7ba6c80870ab6be86e8069970 
>   kmymoney/dialogs/investtransactioneditor.cpp 
> 4f870039d2de55d73550c944c7f5e3403eb9abd0 
>   kmymoney/dialogs/kcurrencycalculator.cpp 
> b50aa8a1c6db0fd569adc97cf01877c76465d52f 
>   kmymoney/dialogs/kmymoneypricedlg.cpp 
> 9aa220fb4a558ef0945bb68be85c39b927451e8c 
>   kmymoney/dialogs/knewaccountdlg.cpp 
> 47c20a2708cd998b4b53ee2d97d5dcc1e6bd6021 
>   kmymoney/kmymoney.cpp 84bd9a3a6da487ba0d41bcca48dc82b4842f1c28 
>   kmymoney/models/accountsmodel.cpp 37384d26e7bd7321ddf247b35517da28d4e11a45 
>   kmymoney/mymoney/mymoneyaccounttest.cpp 
> 2506f8eb4efb0053e3e1c7c7ce755b27d288345d 
>   kmymoney/mymoney/mymoneyfile.cpp dd4af2e3a9883998f2ad95ccecb5bcbfa23068db 
>   kmymoney/mymoney/mymoneyfiletest.cpp 
> 1e196ad92f3890e2e6ecfbcc9da66dad91e6dcf7 
>   kmymoney/mymoney/mymoneyforecast.cpp 
> 9f3e384584f4ded4f72be830fa2dd1f0b18017fd 
>   kmymoney/mymoney/mymoneyforecasttest.cpp 
> dc098af51620d858728ed706e189d9218ef49543 
>   kmymoney/mymoney/mymoneymoney.h 033983b4fe4c2c140cbeb7b55cdaf9d18c4db154 
>   kmymoney/mymoney/mymoneymoney.cpp 5de7fa9085552c7fae01b7380258ea3752672c52 
>   kmymoney/mymoney/mymoneyprice.cpp 27b847480b3800d512d81dba66639f224c220dfd 
>   kmymoney/mymoney/mymoneypricetest.cpp 
> 1acd388a8928a8d9fcd3e04afd694836c7bb7b2e 
>   kmymoney/mymoney/mymoneysplit.cpp 2f811328a10e4e612d4431c81b467f9e69a57c3b 
>   kmymoney/mymoney/mymoneytransactionfilter.cpp 
> 1883971dcf5fb1ea771efb178b58a30a1698ad65 
>   kmymoney/mymoney/storage/mymoneystorageanon.cpp 
> 08f42f2b8c6cd89fcbb9b449a46bc8406e30746b 
>   kmymoney/reports/objectinfotable.cpp 
> 49d3ae1ed98f374f82c5ed6832a00c12b48a132a 
>   kmymoney/reports/pivotgrid.h 8205eb22ca40e01b66310e33b035aac70b63b675 
> 
> Diff: https://git.reviewboard.kde.org/r/120818/diff/
> 
> 
> Testing
> ---
> 
> Ran KMyMoney and the tests.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2014-10-29 Thread Christian David



> On Okt. 29, 2014, 2:59 nachm., Cristian Oneț wrote:
> > Could the fact that writeFileInfo() is now used be causing this bug? 
> > https://bugs.kde.org/show_bug.cgi?id=339103
> 
> Cristian Oneț wrote:
> Soory, I just noticed your comment 
> https://bugs.kde.org/show_bug.cgi?id=339103#c9 are you saying this would 
> actually fix that bug? By looking at the upgradeToV7() I don't really 
> understand why the tags code is there in the first place. Since we didn't had 
> tags before there should be nothing to upgrade.

I have just began to understand the update system. But I know: upgradeToV7() is 
needed to add the hiTagId column to kmmFileInfo. Actually you are right: the 
line ```m_tags = getRecCount("kmmTags");``` should be equivalent to ```m_tags = 
0;```.

The upgrade process has some other issues — some of them are caused by calling 
readFileInfo() and writeFileInfo() in wrong places. Bug 339103 could be caused 
by this as well. But I do not think it is solved with this review request.

Btw: using ```getRecCount( some-table )``` to get the highest record number 
will fail in most cases. It will return a already used id if the user ever 
removed a row from "some-table". Or am I wrong here?


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120499/#review69451
-------


On Okt. 5, 2014, 1:53 nachm., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120499/
> ---
> 
> (Updated Okt. 5, 2014, 1:53 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> MyMoneyStorageSql::upgradeToV7() does not use readFileInfo() and
> writeFileInfo() anymore.
> 
> This should prevent an issue if this metod is used to upgrade the
> database to a version higher than 7 as readFileInfo() and
> writeFileInfo() assume a database of the most recent version. This
> will cause errors (=> crash) if a column in kmmFileInfo was
> renamed or added between version 7 and the final version.
> 
> KMyMoney should still crash if you upgradeToV1() is used.
> 
> 
> Diffs
> -
> 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 
> 0fa790d435bc978279038893b945de31811f34f1 
> 
> Diff: https://git.reviewboard.kde.org/r/120499/diff/
> 
> 
> Testing
> ---
> 
> Opened an sqlite database which was created with KMyMoney 4.5.3, database 
> version 6.
> The upgrade still worked and kmmFileInfo was still filled with correct data.
> 
> 
> Thanks,
> 
> Christian David
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

2014-11-02 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120815/#review69687
---


The patch looks good and I like it. It also works on my computer :)

I am just not totaly sure if this patch is ABI compatible. The size of AlkValue 
is unchanged but is that enough? After all the QSharedDataPointer has a 
constructor and destructor, in which compile unit is it called?

Also I think the change ```mpq_class &valueRef() const``` to ```const mpq_class 
&valueRef() const``` is not ABI compatible.

If it is not ABI compatible the so version must be increased.

- Christian David


On Okt. 26, 2014, 10:33 nachm., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120815/
> ---
> 
> (Updated Okt. 26, 2014, 10:33 nachm.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Repository: alkimia
> 
> 
> Description
> ---
> 
> Before this the biggest cost of using an AlkValue object, implicitly a 
> KMyMoneyMoney object was assignment, construction and destruction.
> 
> By using implicit sharing combined with a shared zero value, copying on 
> assignment and construction can be greatly reduced.
> 
> Implicit sharing was easy to implement using QSharedDataPointer.
> 
> Bumped the library version because API changes were necessary. The mpq_class 
> &valueRef() const method was bad beacause it was returning a non-const 
> reference from a const function. Now There is a const version which will not 
> detach the shared data while the non-const version will detach from the 
> shared data.
> 
> 
> Diffs
> -
> 
>   libalkimia/CMakeLists.txt 3dbe4db 
>   libalkimia/alkvalue.h 7c02403 
>   libalkimia/alkvalue.cpp ae5d3a4 
> 
> Diff: https://git.reviewboard.kde.org/r/120815/diff/
> 
> 
> Testing
> ---
> 
> Succesfully ran KMyMoney and KMyMoney tests. See the attached screeshots for 
> the callgrind data about AlkValue obtained while loading the same KMyMoney 
> file without and with this change. Note that the second run also contains 
> some MyMoneyMoney optimizations based on this feature (subject of a different 
> review request).
> 
> 
> File Attachments
> 
> 
> Callgrind data using AlkValue from alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/f79cfa4b-b01a-4d14-adbe-dc905ad1a4c9__alk-value.png
> Callgrind data using AlkValue from alkimia 4.4.0 (with implicit sharing)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/ceb1cb24-fe5e-414e-a0c1-09746bcb9bcc__alk-value-implicitly-shared.png
> Callgrind data while loading file by KMyMoney using review 120818 and alkimia 
> 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/9d142707-962b-434a-b847-8af7154ff4a1__alk-value-4.3.2.png
> Callgrind data while loading register by KMyMoney using review 120818 and 
> alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/25200104-be0e-434e-941d-c7c51c9bcb2c__register-load-4.3.2.png
> Callgrind data while loading register by KMyMoney using review 120818 and 
> alkimia 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/58ee7a28-2723-4b2c-9818-e82b0b6a03e8__register-load-4.4.0.png
> Callgrind data while editing transaction by KMyMoney using review 120818 and 
> alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/6f25d85b-3c3e-4d92-9f1a-1315daf3788c__transaction-edit-4.3.2.png
> Callgrind data while editing transaction by KMyMoney using review 120818 and 
> alkimia 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/e4d5d50f-efb8-4f0b-bed8-23fa1c5db391__transaction-edit-4.4.0.png
> Callgrind data while loading file by KMyMoney using review 120818 and alkimia 
> 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/8808ebc3-a112-4425-b35e-05acd8ba94d1__alk-value-4.4.0.png
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

2014-11-03 Thread Christian David



> On Nov. 2, 2014, 9:24 nachm., Christian David wrote:
> > The patch looks good and I like it. It also works on my computer :)
> > 
> > I am just not totaly sure if this patch is ABI compatible. The size of 
> > AlkValue is unchanged but is that enough? After all the QSharedDataPointer 
> > has a constructor and destructor, in which compile unit is it called?
> > 
> > Also I think the change ```mpq_class &valueRef() const``` to ```const 
> > mpq_class &valueRef() const``` is not ABI compatible.
> > 
> > If it is not ABI compatible the so version must be increased.
> 
> Cristian Oneț wrote:
> Yes, this breaks the ABI. Do you mean that we should change is to 5.0.0? 
> Isn't 4.4.0 enough to signal this?

This depends on the policy about ABI changes in alkimia. It should be enough to 
set ```set(ALKIMIA_LIB_SOVERSION "${VERSION_MAJOR}")``` to 
```set(ALKIMIA_LIB_SOVERSION "5")```. This will prevent that an application 
linked to alkimia starts with an unsupported ABI version.

But if alkimia guarantees ABI compatibility within a major release, the version 
has to be increased to 5.0.0.

I prefer the first soloution. As far as I know there is no stand alone version 
of alkimia distributed to Mac/OS X or Windows. And on Linux the distributions 
won't have any issues with this (I think). So there is no point in keeping ABI 
compatibility between releases.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120815/#review69687
---


On Okt. 26, 2014, 10:33 nachm., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120815/
> ---
> 
> (Updated Okt. 26, 2014, 10:33 nachm.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Repository: alkimia
> 
> 
> Description
> ---
> 
> Before this the biggest cost of using an AlkValue object, implicitly a 
> KMyMoneyMoney object was assignment, construction and destruction.
> 
> By using implicit sharing combined with a shared zero value, copying on 
> assignment and construction can be greatly reduced.
> 
> Implicit sharing was easy to implement using QSharedDataPointer.
> 
> Bumped the library version because API changes were necessary. The mpq_class 
> &valueRef() const method was bad beacause it was returning a non-const 
> reference from a const function. Now There is a const version which will not 
> detach the shared data while the non-const version will detach from the 
> shared data.
> 
> 
> Diffs
> -
> 
>   libalkimia/CMakeLists.txt 3dbe4db 
>   libalkimia/alkvalue.h 7c02403 
>   libalkimia/alkvalue.cpp ae5d3a4 
> 
> Diff: https://git.reviewboard.kde.org/r/120815/diff/
> 
> 
> Testing
> ---
> 
> Succesfully ran KMyMoney and KMyMoney tests. See the attached screeshots for 
> the callgrind data about AlkValue obtained while loading the same KMyMoney 
> file without and with this change. Note that the second run also contains 
> some MyMoneyMoney optimizations based on this feature (subject of a different 
> review request).
> 
> 
> File Attachments
> 
> 
> Callgrind data using AlkValue from alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/f79cfa4b-b01a-4d14-adbe-dc905ad1a4c9__alk-value.png
> Callgrind data using AlkValue from alkimia 4.4.0 (with implicit sharing)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/ceb1cb24-fe5e-414e-a0c1-09746bcb9bcc__alk-value-implicitly-shared.png
> Callgrind data while loading file by KMyMoney using review 120818 and alkimia 
> 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/9d142707-962b-434a-b847-8af7154ff4a1__alk-value-4.3.2.png
> Callgrind data while loading register by KMyMoney using review 120818 and 
> alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/25200104-be0e-434e-941d-c7c51c9bcb2c__register-load-4.3.2.png
> Callgrind data while loading register by KMyMoney using review 120818 and 
> alkimia 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/58ee7a28-2723-4b2c-9818-e82b0b6a03e8__register-load-4.4.0.png
> Callgrind data while editing transaction by KMyMoney using review 120818 and 
> alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/6f25d85b-3c3e-4d92-9f1a-1315daf3788c__transacti

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

2014-11-04 Thread Christian David



> On Nov. 2, 2014, 9:24 nachm., Christian David wrote:
> > The patch looks good and I like it. It also works on my computer :)
> > 
> > I am just not totaly sure if this patch is ABI compatible. The size of 
> > AlkValue is unchanged but is that enough? After all the QSharedDataPointer 
> > has a constructor and destructor, in which compile unit is it called?
> > 
> > Also I think the change ```mpq_class &valueRef() const``` to ```const 
> > mpq_class &valueRef() const``` is not ABI compatible.
> > 
> > If it is not ABI compatible the so version must be increased.
> 
> Cristian Oneț wrote:
> Yes, this breaks the ABI. Do you mean that we should change is to 5.0.0? 
> Isn't 4.4.0 enough to signal this?
> 
> Christian David wrote:
> This depends on the policy about ABI changes in alkimia. It should be 
> enough to set ```set(ALKIMIA_LIB_SOVERSION "${VERSION_MAJOR}")``` to 
> ```set(ALKIMIA_LIB_SOVERSION "5")```. This will prevent that an application 
> linked to alkimia starts with an unsupported ABI version.
> 
> But if alkimia guarantees ABI compatibility within a major release, the 
> version has to be increased to 5.0.0.
> 
> I prefer the first soloution. As far as I know there is no stand alone 
> version of alkimia distributed to Mac/OS X or Windows. And on Linux the 
> distributions won't have any issues with this (I think). So there is no point 
> in keeping ABI compatibility between releases.
> 
> Cristian Oneț wrote:
> I'd rather avoid using set(ALKIMIA_LIB_SOVERSION "5") instead I would 
> bump the version to 5.0.0. I'll update the patch accordingly.

I think ```set(ALKIMIA_LIB_SOVERSION "5")``` is okay - it is a pure technical 
version and likely nobody after us two will ever see it again. But I have to 
admit most libraries keep the so version equal to the major version. So your 
way of setting the version to 5.0.0 may cause less confusion.

Another question: I need access to the numerator and denominator to convert a 
MyMoneyValue to the value type of the online banking library. Should I make 
```const mpq_class &valueRef() const``` public, add another method ```const 
mpq_class& toMpqClass() const``` or should I add two methods (```long 
numerator() const``` and ```long denominator() const```)?


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120815/#review69687
---


On Okt. 26, 2014, 10:33 nachm., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120815/
> ---
> 
> (Updated Okt. 26, 2014, 10:33 nachm.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Repository: alkimia
> 
> 
> Description
> ---
> 
> Before this the biggest cost of using an AlkValue object, implicitly a 
> KMyMoneyMoney object was assignment, construction and destruction.
> 
> By using implicit sharing combined with a shared zero value, copying on 
> assignment and construction can be greatly reduced.
> 
> Implicit sharing was easy to implement using QSharedDataPointer.
> 
> Bumped the library version because API changes were necessary. The mpq_class 
> &valueRef() const method was bad beacause it was returning a non-const 
> reference from a const function. Now There is a const version which will not 
> detach the shared data while the non-const version will detach from the 
> shared data.
> 
> 
> Diffs
> -
> 
>   libalkimia/CMakeLists.txt 3dbe4db 
>   libalkimia/alkvalue.h 7c02403 
>   libalkimia/alkvalue.cpp ae5d3a4 
> 
> Diff: https://git.reviewboard.kde.org/r/120815/diff/
> 
> 
> Testing
> ---
> 
> Succesfully ran KMyMoney and KMyMoney tests. See the attached screeshots for 
> the callgrind data about AlkValue obtained while loading the same KMyMoney 
> file without and with this change. Note that the second run also contains 
> some MyMoneyMoney optimizations based on this feature (subject of a different 
> review request).
> 
> 
> File Attachments
> 
> 
> Callgrind data using AlkValue from alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/f79cfa4b-b01a-4d14-adbe-dc905ad1a4c9__alk-value.png
> Callgrind data using AlkValue from alkimia 4.4.0 (with implicit sharing)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/ceb1cb24-fe5e-414e-a0c1-09746b

[Kmymoney-devel] Review Request 121009: Added .reviewboard file

2014-11-06 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121009/
---

Review request for KMymoney and Skrooge.


Repository: alkimia


Description
---

So it is possible to use rb tools.


Diffs
-

  .reviewboardrc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121009/diff/


Testing
---

This review request.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121009: Added .reviewboard file

2014-11-06 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121009/
---

(Updated Nov. 6, 2014, 10:57 vorm.)


Status
--

This change has been marked as submitted.


Review request for KMymoney and Skrooge.


Repository: alkimia


Description
---

So it is possible to use rb tools.


Diffs
-

  .reviewboardrc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121009/diff/


Testing
---

This review request.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 121030: Fixed a potential static initialization order fiasco in rr120815

2014-11-06 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121030/
---

Review request for KMymoney, Skrooge, Cristian Oneț, and Thomas Baumgart.


Repository: alkimia


Description
---

This review request is based on 120815.

Wrapped creation of sharedZero into a static method sharedZero(). So the 
implicid shared object is created the first time it is used which prevents a 
static initialization order fiasco.


Diffs
-

  libalkimia/alkvalue.h 7c02403adc641d1acf44c65fec39c1435e54405b 
  libalkimia/alkvalue.cpp ae5d3a4ba61c4f0100d2598660ae76c432914d90 

Diff: https://git.reviewboard.kde.org/r/121030/diff/


Testing
---

KMyMoneys tests


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue

2014-11-06 Thread Christian David



> On Nov. 5, 2014, 7:51 nachm., Thomas Baumgart wrote:
> > libalkimia/alkvalue.cpp, line 86
> > 
> >
> > Does this get initialized under all circumstances?
> 
> Cristian Oneț wrote:
> It's a static so it's initialized once. The purpose of this value is to 
> make constructing/copying zero values fast. Do you see something wrong with 
> this?

If someone uses a static or global AlkValue() it is not guaranteed that the 
static ```AlkValue::sharedZero``` was initialized before. I have a suggestion 
how to solve that in /r/121030.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120815/#review69912
---


On Nov. 5, 2014, 7:21 nachm., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120815/
> ---
> 
> (Updated Nov. 5, 2014, 7:21 nachm.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Repository: alkimia
> 
> 
> Description
> ---
> 
> Before this the biggest cost of using an AlkValue object, implicitly a 
> KMyMoneyMoney object was assignment, construction and destruction.
> 
> By using implicit sharing combined with a shared zero value, copying on 
> assignment and construction can be greatly reduced.
> 
> Implicit sharing was easy to implement using QSharedDataPointer.
> 
> Bumped the library version because API changes were necessary. The mpq_class 
> &valueRef() const method was bad beacause it was returning a non-const 
> reference from a const function. Now There is a const version which will not 
> detach the shared data while the non-const version will detach from the 
> shared data.
> 
> 
> Diffs
> -
> 
>   libalkimia/CMakeLists.txt 3dbe4db 
>   libalkimia/alkvalue.h 7c02403 
>   libalkimia/alkvalue.cpp ae5d3a4 
> 
> Diff: https://git.reviewboard.kde.org/r/120815/diff/
> 
> 
> Testing
> ---
> 
> Succesfully ran KMyMoney and KMyMoney tests. See the attached screeshots for 
> the callgrind data about AlkValue obtained while loading the same KMyMoney 
> file without and with this change. Note that the second run also contains 
> some MyMoneyMoney optimizations based on this feature (subject of a different 
> review request).
> 
> 
> File Attachments
> 
> 
> Callgrind data using AlkValue from alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/f79cfa4b-b01a-4d14-adbe-dc905ad1a4c9__alk-value.png
> Callgrind data using AlkValue from alkimia 4.4.0 (with implicit sharing)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/ceb1cb24-fe5e-414e-a0c1-09746bcb9bcc__alk-value-implicitly-shared.png
> Callgrind data while loading file by KMyMoney using review 120818 and alkimia 
> 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/9d142707-962b-434a-b847-8af7154ff4a1__alk-value-4.3.2.png
> Callgrind data while loading register by KMyMoney using review 120818 and 
> alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/25200104-be0e-434e-941d-c7c51c9bcb2c__register-load-4.3.2.png
> Callgrind data while loading register by KMyMoney using review 120818 and 
> alkimia 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/58ee7a28-2723-4b2c-9818-e82b0b6a03e8__register-load-4.4.0.png
> Callgrind data while editing transaction by KMyMoney using review 120818 and 
> alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/6f25d85b-3c3e-4d92-9f1a-1315daf3788c__transaction-edit-4.3.2.png
> Callgrind data while editing transaction by KMyMoney using review 120818 and 
> alkimia 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/e4d5d50f-efb8-4f0b-bed8-23fa1c5db391__transaction-edit-4.4.0.png
> Callgrind data while loading file by KMyMoney using review 120818 and alkimia 
> 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/8808ebc3-a112-4425-b35e-05acd8ba94d1__alk-value-4.4.0.png
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120815: Use implicit sharing in AlkValue.

2014-11-07 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120815/#review70013
---

Ship it!


- Christian David


On Nov. 7, 2014, 8:06 nachm., Cristian Oneț wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120815/
> ---
> 
> (Updated Nov. 7, 2014, 8:06 nachm.)
> 
> 
> Review request for KMymoney, Skrooge and Thomas Baumgart.
> 
> 
> Repository: alkimia
> 
> 
> Description
> ---
> 
> Before this the biggest cost of using an AlkValue object, implicitly
> a KMyMoneyMoney object was assignment, construction and destruction.
> 
> By using implicit sharing combined with a shared zero value, copying
> on assignment and construction can be greatly reduced.
> 
> Implicit sharing was easy to implement using QSharedDataPointer.
> 
> Bumped the library version because API changes were necessary. The
> mpq_class &valueRef() const method was bad beacause it was returning
> a non-const reference from a const function. Now There is a const
> version which will not detach the shared data while the non-const
> version will detach from the shared data.
> 
> REVIEW: 120815
> REVIEW: 121030
> 
> 
> Diffs
> -
> 
>   libalkimia/CMakeLists.txt 3dbe4db2d1d4ce6d324f7df947e3f284a40b492a 
>   libalkimia/alkvalue.h 7c02403adc641d1acf44c65fec39c1435e54405b 
>   libalkimia/alkvalue.cpp ae5d3a4ba61c4f0100d2598660ae76c432914d90 
> 
> Diff: https://git.reviewboard.kde.org/r/120815/diff/
> 
> 
> Testing
> ---
> 
> Succesfully ran KMyMoney and KMyMoney tests. See the attached screeshots for 
> the callgrind data about AlkValue obtained while loading the same KMyMoney 
> file without and with this change. Note that the second run also contains 
> some MyMoneyMoney optimizations based on this feature (subject of a different 
> review request).
> 
> 
> File Attachments
> 
> 
> Callgrind data using AlkValue from alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/f79cfa4b-b01a-4d14-adbe-dc905ad1a4c9__alk-value.png
> Callgrind data using AlkValue from alkimia 4.4.0 (with implicit sharing)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/ceb1cb24-fe5e-414e-a0c1-09746bcb9bcc__alk-value-implicitly-shared.png
> Callgrind data while loading file by KMyMoney using review 120818 and alkimia 
> 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/9d142707-962b-434a-b847-8af7154ff4a1__alk-value-4.3.2.png
> Callgrind data while loading register by KMyMoney using review 120818 and 
> alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/25200104-be0e-434e-941d-c7c51c9bcb2c__register-load-4.3.2.png
> Callgrind data while loading register by KMyMoney using review 120818 and 
> alkimia 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/58ee7a28-2723-4b2c-9818-e82b0b6a03e8__register-load-4.4.0.png
> Callgrind data while editing transaction by KMyMoney using review 120818 and 
> alkimia 4.3.2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/6f25d85b-3c3e-4d92-9f1a-1315daf3788c__transaction-edit-4.3.2.png
> Callgrind data while editing transaction by KMyMoney using review 120818 and 
> alkimia 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/e4d5d50f-efb8-4f0b-bed8-23fa1c5db391__transaction-edit-4.4.0.png
> Callgrind data while loading file by KMyMoney using review 120818 and alkimia 
> 4.4.0
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/8808ebc3-a112-4425-b35e-05acd8ba94d1__alk-value-4.4.0.png
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121030: Fixed a potential static initialization order fiasco in rr120815

2014-11-07 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121030/
---

(Updated Nov. 7, 2014, 7:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney, Skrooge, Cristian Oneț, and Thomas Baumgart.


Repository: alkimia


Description
---

This review request is based on 120815.

Wrapped creation of sharedZero into a static method sharedZero(). So the 
implicid shared object is created the first time it is used which prevents a 
static initialization order fiasco.


Diffs
-

  libalkimia/alkvalue.h 7c02403adc641d1acf44c65fec39c1435e54405b 
  libalkimia/alkvalue.cpp ae5d3a4ba61c4f0100d2598660ae76c432914d90 

Diff: https://git.reviewboard.kde.org/r/121030/diff/


Testing
---

KMyMoneys tests


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121192: Support Page, PlasmaMenu and Home Button

2014-11-20 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121192/#review70710
---



index.php
<https://git.reviewboard.kde.org/r/121192/#comment49458>

These changes should not be here.



news.rdf
<https://git.reviewboard.kde.org/r/121192/#comment49454>

This seems to be an error during rebase. This part should not be removed.



news.rdf
<https://git.reviewboard.kde.org/r/121192/#comment49457>

This should not get removed. Seems to be an error during rebase.



release-notes.rdf
<https://git.reviewboard.kde.org/r/121192/#comment49455>

Another merge error.



release-notes.rdf
<https://git.reviewboard.kde.org/r/121192/#comment49456>

    Another rebase error :(


- Christian David


On Nov. 20, 2014, 9:51 nachm., Lars Meiendresch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121192/
> ---
> 
> (Updated Nov. 20, 2014, 9:51 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney-org
> 
> 
> Description
> ---
> 
> New "Support" Page, Bugs removed in the PlasmaMenu and "Home" Button refer 
> you to the "index".
> 
> 
> Diffs
> -
> 
>   changelogs/ChangeLog-4.7.1.txt 2596c1f78b0446be2d3360dbaa9b4e09de8bbb12 
>   documentation.php ba6067f637b0c7ec81ba81a67cc01ac8a373d816 
>   faq.php 2ca35b98c95b381f8d2cd5a0c9e64069dbe76cfe 
>   index.php cda35e1c45bbd37da55f381c61acfa798bf5aff2 
>   news.rdf 412dd002bc2988adc4d45fa6558f4f04e378aa9a 
>   plasmaMenu.inc ab9217a274fd5ec997d58453b2f9d81520b2b5f4 
>   release-notes.rdf 5f5bc68582432ad763a66bcf99ff5514a1edc79b 
>   support.php PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121192/diff/
> 
> 
> Testing
> ---
> 
> There will be bugs - im sure. Sorry for that. Im tried my best.
> 
> 
> Thanks,
> 
> Lars Meiendresch
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121192: Support Page, PlasmaMenu and Home Button

2014-11-20 Thread Christian David



> On Nov. 20, 2014, 9:28 nachm., Marko Käning wrote:
> > I wonder why 3 out of 4 diffs cannot be displayed here in ReviewBoard...
> 
> Lars Meiendresch wrote:
> There was an error with git. It should work now.

But now you have another git issue now :( Git does not welcome new users.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121192/#review70708
---


On Nov. 20, 2014, 9:51 nachm., Lars Meiendresch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121192/
> ---
> 
> (Updated Nov. 20, 2014, 9:51 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney-org
> 
> 
> Description
> ---
> 
> New "Support" Page, Bugs removed in the PlasmaMenu and "Home" Button refer 
> you to the "index".
> 
> 
> Diffs
> -
> 
>   changelogs/ChangeLog-4.7.1.txt 2596c1f78b0446be2d3360dbaa9b4e09de8bbb12 
>   documentation.php ba6067f637b0c7ec81ba81a67cc01ac8a373d816 
>   faq.php 2ca35b98c95b381f8d2cd5a0c9e64069dbe76cfe 
>   index.php cda35e1c45bbd37da55f381c61acfa798bf5aff2 
>   news.rdf 412dd002bc2988adc4d45fa6558f4f04e378aa9a 
>   plasmaMenu.inc ab9217a274fd5ec997d58453b2f9d81520b2b5f4 
>   release-notes.rdf 5f5bc68582432ad763a66bcf99ff5514a1edc79b 
>   support.php PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121192/diff/
> 
> 
> Testing
> ---
> 
> There will be bugs - im sure. Sorry for that. Im tried my best.
> 
> 
> Thanks,
> 
> Lars Meiendresch
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121192: Support Page, PlasmaMenu and Home Button

2014-11-22 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121192/#review70775
---

Ship it!


Ship It!

- Christian David


On Nov. 22, 2014, 11:54 vorm., Lars Meiendresch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121192/
> ---
> 
> (Updated Nov. 22, 2014, 11:54 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney-org
> 
> 
> Description
> ---
> 
> New "Support" Page, Bugs removed in the PlasmaMenu and "Home" Button refer 
> you to the "index".
> 
> 
> Diffs
> -
> 
>   documentation.php ba6067f637b0c7ec81ba81a67cc01ac8a373d816 
>   faq.php 2ca35b98c95b381f8d2cd5a0c9e64069dbe76cfe 
>   plasmaMenu.inc ab9217a274fd5ec997d58453b2f9d81520b2b5f4 
>   support.php PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121192/diff/
> 
> 
> Testing
> ---
> 
> There will be bugs - im sure. Sorry for that. Im tried my best.
> 
> 
> Thanks,
> 
> Lars Meiendresch
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 341304] New: upgrade database to version 1 does not work with sqlite

2014-11-26 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=341304

Bug ID: 341304
   Summary: upgrade database to version 1 does not work with
sqlite
   Product: kmymoney4
   Version: git master
  Platform: Compiled Sources
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: database
  Assignee: kmymoney-devel@kde.org
  Reporter: christian-da...@web.de

MyMoneyStorageSql::upgradeToV1() uses the query "ALTER TABLE kmmSplits ADD
PRIMARY KEY (transactionId, splitId);" which will always fail in SQLite because
it does not support adding primary keys in alter table
(http://sqlite.org/lang_altertable.html).

KMyMoney will not open SQLite databases of version 0 - that issue must be there
for five years already. So we have to decide if it will be fixed as nobody
complained before. I found it only because the databasemrgtest persistently
fails/crashes on my system.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2014-11-29 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121288/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

So the upgrade routine is not executed starting from version 0 - which
is useless as the database should be the most recent version anyway.

Also removed the version param from createTables(int version). It was
not used and was totaly useless as createTables() calls upgradeDb().

This is also a workaround bug 341304 as the upgradeToV1() won't be
called after creation of tables anymore. The bug persists if the user
has a version 0 database.

CCBUG: 341304


Diffs
-

  kmymoney/mymoney/storage/mymoneystoragesql.cpp 
2f403b1151cf86d5092981e60a5b7e0b308736b6 
  kmymoney/mymoney/storage/mymoneystoragesql.h 
ae79b484186e700367f9a4362ffd19772825cf22 
  kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 
80ff5a725e41e2a344cf32019b22803059ab9f93 

Diff: https://git.reviewboard.kde.org/r/121288/diff/


Testing
---

make test

only one fail left (see comments)

FAIL!  : MyMoneyDatabaseMgrTest::testBadConnections() 'sql->open(m_url, 
QIODevice::ReadWrite) != 0' returned FALSE. ()
   Loc: 
[/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(105)]


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2014-11-29 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121288/#review71073
---


The failed test asumes that opening an empty database should fail. But the rest 
of the code says:?"If the tables are missing, create them". So we have to 
decide what we want.


kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp
<https://git.reviewboard.kde.org/r/121288/#comment49647>

Why was this needed? If opened the database should have the most recent 
version.



kmymoney/mymoney/storage/mymoneystoragesql.cpp
<https://git.reviewboard.kde.org/r/121288/#comment49649>

This is still an open issue: ```m_storage->fileFixVersion()``` was never 
set before - so it just contains junk.

But it is not really set anywhere else. The database driver just uses 
```m_storage->fileFixVersion()``` to write it to the database and 
```m_storage->setFileFixVersion()``` is only called with the version which was 
stored in the database.



kmymoney/mymoney/storage/mymoneystoragesql.cpp
<https://git.reviewboard.kde.org/r/121288/#comment49648>

I think this can be replaced by return 0; upgradeDb() just removes all 
views and then it recreates them (if I did everything correctly). If someone 
knows that for sure please write me.


- Christian David


On Nov. 29, 2014, 10:22 vorm., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121288/
> ---
> 
> (Updated Nov. 29, 2014, 10:22 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> So the upgrade routine is not executed starting from version 0 - which
> is useless as the database should be the most recent version anyway.
> 
> Also removed the version param from createTables(int version). It was
> not used and was totaly useless as createTables() calls upgradeDb().
> 
> This is also a workaround bug 341304 as the upgradeToV1() won't be
> called after creation of tables anymore. The bug persists if the user
> has a version 0 database.
> 
> CCBUG: 341304
> 
> 
> Diffs
> -
> 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 
> 2f403b1151cf86d5092981e60a5b7e0b308736b6 
>   kmymoney/mymoney/storage/mymoneystoragesql.h 
> ae79b484186e700367f9a4362ffd19772825cf22 
>   kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 
> 80ff5a725e41e2a344cf32019b22803059ab9f93 
> 
> Diff: https://git.reviewboard.kde.org/r/121288/diff/
> 
> 
> Testing
> ---
> 
> make test
> 
> only one fail left (see comments)
> 
> FAIL!  : MyMoneyDatabaseMgrTest::testBadConnections() 'sql->open(m_url, 
> QIODevice::ReadWrite) != 0' returned FALSE. ()
>Loc: 
> [/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(105)]
> 
> 
> Thanks,
> 
> Christian David
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2014-11-29 Thread Christian David



> On Okt. 29, 2014, 2:59 nachm., Cristian Oneț wrote:
> > Could the fact that writeFileInfo() is now used be causing this bug? 
> > https://bugs.kde.org/show_bug.cgi?id=339103
> 
> Cristian Oneț wrote:
> Soory, I just noticed your comment 
> https://bugs.kde.org/show_bug.cgi?id=339103#c9 are you saying this would 
> actually fix that bug? By looking at the upgradeToV7() I don't really 
> understand why the tags code is there in the first place. Since we didn't had 
> tags before there should be nothing to upgrade.
> 
> Christian David wrote:
> I have just began to understand the update system. But I know: 
> upgradeToV7() is needed to add the hiTagId column to kmmFileInfo. Actually 
> you are right: the line ```m_tags = getRecCount("kmmTags");``` should be 
> equivalent to ```m_tags = 0;```.
> 
> The upgrade process has some other issues — some of them are caused by 
> calling readFileInfo() and writeFileInfo() in wrong places. Bug 339103 could 
> be caused by this as well. But I do not think it is solved with this review 
> request.
> 
> Btw: using ```getRecCount( some-table )``` to get the highest record 
> number will fail in most cases. It will return a already used id if the user 
> ever removed a row from "some-table". Or am I wrong here?

No answer for a month. What do we do now?


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120499/#review69451
---


On Okt. 5, 2014, 1:53 nachm., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120499/
> ---
> 
> (Updated Okt. 5, 2014, 1:53 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> MyMoneyStorageSql::upgradeToV7() does not use readFileInfo() and
> writeFileInfo() anymore.
> 
> This should prevent an issue if this metod is used to upgrade the
> database to a version higher than 7 as readFileInfo() and
> writeFileInfo() assume a database of the most recent version. This
> will cause errors (=> crash) if a column in kmmFileInfo was
> renamed or added between version 7 and the final version.
> 
> KMyMoney should still crash if you upgradeToV1() is used.
> 
> 
> Diffs
> -
> 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 
> 0fa790d435bc978279038893b945de31811f34f1 
> 
> Diff: https://git.reviewboard.kde.org/r/120499/diff/
> 
> 
> Testing
> ---
> 
> Opened an sqlite database which was created with KMyMoney 4.5.3, database 
> version 6.
> The upgrade still worked and kmmFileInfo was still filled with correct data.
> 
> 
> Thanks,
> 
> Christian David
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2014-12-02 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121288/
---

(Updated Dez. 2, 2014, 10:05 nachm.)


Review request for KMymoney.


Repository: kmymoney


Description (updated)
---

So the upgrade routine is not executed starting from version 0 - which
is useless as the database should be in the most recent version anyway.

Also removed the version param from createTables(int version). It was
not used and was totaly useless as createTables() calls upgradeDb().

This is also a workaround for bug 341304 as the upgradeToV1() won't be
called after creation of tables anymore. The bug persists if the user
has a version 0 database.

CCBUG: 341304
REVIEW: 121288


Diffs (updated)
-

  kmymoney/mymoney/storage/mymoneystoragesql.h 
ae79b484186e700367f9a4362ffd19772825cf22 
  kmymoney/mymoney/storage/mymoneystoragesql.cpp 
2f403b1151cf86d5092981e60a5b7e0b308736b6 
  kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 
80ff5a725e41e2a344cf32019b22803059ab9f93 

Diff: https://git.reviewboard.kde.org/r/121288/diff/


Testing (updated)
---

make test

only one fail left (see comments)

XFAIL  : MyMoneyDatabaseMgrTest::testBadConnections() Will fix when correct 
behaviour in this case is clear.
   Loc: 
[/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(106)]


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2014-12-03 Thread Christian David



> On Okt. 29, 2014, 2:59 nachm., Cristian Oneț wrote:
> > Could the fact that writeFileInfo() is now used be causing this bug? 
> > https://bugs.kde.org/show_bug.cgi?id=339103
> 
> Cristian Oneț wrote:
> Soory, I just noticed your comment 
> https://bugs.kde.org/show_bug.cgi?id=339103#c9 are you saying this would 
> actually fix that bug? By looking at the upgradeToV7() I don't really 
> understand why the tags code is there in the first place. Since we didn't had 
> tags before there should be nothing to upgrade.
> 
> Christian David wrote:
> I have just began to understand the update system. But I know: 
> upgradeToV7() is needed to add the hiTagId column to kmmFileInfo. Actually 
> you are right: the line ```m_tags = getRecCount("kmmTags");``` should be 
> equivalent to ```m_tags = 0;```.
> 
> The upgrade process has some other issues — some of them are caused by 
> calling readFileInfo() and writeFileInfo() in wrong places. Bug 339103 could 
> be caused by this as well. But I do not think it is solved with this review 
> request.
> 
> Btw: using ```getRecCount( some-table )``` to get the highest record 
> number will fail in most cases. It will return a already used id if the user 
> ever removed a row from "some-table". Or am I wrong here?
> 
> Christian David wrote:
> No answer for a month. What do we do now?
> 
> Cristian Oneț wrote:
> I'll try to take another look at this, in the meantime maybe Fernando can 
> also review this. But it seems to me that you already have a better 
> understanding of the database storage than me :) so if you think, you can 
> move ahead with this.

Thank you! The database module has many side effects, even in const methods. 
That makes me really uncertain about any change I make.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120499/#review69451
---


On Okt. 5, 2014, 1:53 nachm., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120499/
> ---
> 
> (Updated Okt. 5, 2014, 1:53 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> MyMoneyStorageSql::upgradeToV7() does not use readFileInfo() and
> writeFileInfo() anymore.
> 
> This should prevent an issue if this metod is used to upgrade the
> database to a version higher than 7 as readFileInfo() and
> writeFileInfo() assume a database of the most recent version. This
> will cause errors (=> crash) if a column in kmmFileInfo was
> renamed or added between version 7 and the final version.
> 
> KMyMoney should still crash if you upgradeToV1() is used.
> 
> 
> Diffs
> -
> 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 
> 0fa790d435bc978279038893b945de31811f34f1 
> 
> Diff: https://git.reviewboard.kde.org/r/120499/diff/
> 
> 
> Testing
> ---
> 
> Opened an sqlite database which was created with KMyMoney 4.5.3, database 
> version 6.
> The upgrade still worked and kmmFileInfo was still filled with correct data.
> 
> 
> Thanks,
> 
> Christian David
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 296073] Adding the monetary symbols of the Turkish lira

2014-12-15 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=296073

Christian David  changed:

   What|Removed |Added

   Assignee|kmymoney-devel@kde.org  |christian-da...@web.de
 CC||christian-da...@web.de,
   ||kmymoney-devel@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 296073] Adding the monetary symbols of the Turkish lira

2014-12-15 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=296073

Christian David  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kmym
   ||oney/f5d48ea7af7cdc6ecf1e94
   ||a7cdbb65f57c70ad73
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.7.2

--- Comment #4 from Christian David  ---
Git commit f5d48ea7af7cdc6ecf1e94a7cdbb65f57c70ad73 by Christian Dávid.
Committed on 15/12/2014 at 21:16.
Pushed by christiand into branch '4.7'.

Added currency sign for turkish lira

The sign (U+20BA) was added to the unicode standard in 2012, it should
be save to use it now.
FIXED-IN: 4.7.2

M  +1-1kmymoney/views/kmymoneyview.cpp

http://commits.kde.org/kmymoney/f5d48ea7af7cdc6ecf1e94a7cdbb65f57c70ad73

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Make the world a better place. Donate to our year end fundraiser 
https://www.kde.org/fundraisers/yearend2014/
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 296073] Adding the monetary symbols of the Turkish lira

2014-12-15 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=296073

Christian David  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/f5d48ea7af7cdc6ecf1e94 |oney/860579efc36486087e5a44
   |a7cdbb65f57c70ad73  |9ad507daa11e9ffbfd

--- Comment #6 from Christian David  ---
Git commit 860579efc36486087e5a449ad507daa11e9ffbfd by Christian Dávid.
Committed on 15/12/2014 at 21:16.
Pushed by christiand into branch 'master'.

Added currency sign for turkish lira

The sign (U+20BA) was added to the unicode standard in 2012, it should
be save to use it now.
FIXED-IN: 4.7.2
(cherry picked from commit f5d48ea7af7cdc6ecf1e94a7cdbb65f57c70ad73)

M  +1-1kmymoney/views/kmymoneyview.cpp

http://commits.kde.org/kmymoney/860579efc36486087e5a449ad507daa11e9ffbfd

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Make the world a better place. Donate to our year end fundraiser 
https://www.kde.org/fundraisers/yearend2014/
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 296073] Adding the monetary symbols of the Turkish lira

2014-12-15 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=296073

--- Comment #7 from Christian David  ---
> Could you please remove  (new) part from its name ? and also its sort name ?
>  Because Our currency changed its name from New Turkish Lira to Turkish Lira
> again.

Already did this
(http://commits.kde.org/kmymoney/0a64d08f9a1056fcbb598d5ab07991f7f9ce4523). But
this includes changes for the translation teams, so I just pushed it into
master only -> it will be visible in Version 4.8.

> And YTL -> TL. 
>  Starting in January 2009, the "new" marking was removed from the second
> Turkish lira, its official name becoming just "Turkish lira" again,
> abbreviated "TL" instead of "YTL".
There is no YTL anymore, it was replaced by the Symbol. The TRY was kept
because it is the ISO 4217 code. TL is still the symbol/abbreviation for
"Turkish Lira (old)" (ISO Code TRL), I can replace that by something else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Make the world a better place. Donate to our year end fundraiser 
https://www.kde.org/fundraisers/yearend2014/
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 338296] In Ledger: Keyboard shortcut for Search (Alt-E) does not work

2015-01-03 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=338296

Christian David  changed:

   What|Removed |Added

 CC||christian-da...@web.de,
   ||kmymoney-devel@kde.org
   Assignee|kmymoney-devel@kde.org  |christian-da...@web.de

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

2015-01-03 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121803/
---

Review request for KMymoney.


Bugs: 338296
http://bugs.kde.org/show_bug.cgi?id=338296


Repository: kmymoney


Description
---

The field is actually more filter than search.

This also fixes the bug "In Ledger: Keyboard shortcut for Search (Alt-E)
does not work".

I could not change the label in scheduled transactions view because it
is hard coded in the library. But this should be done as well.

BUG: 338296
FIXED-IN: 4.7.2


Diffs
-

  kmymoney/widgets/registersearchline.cpp 
cae7a3fa22bf5ccd559ebeefc12885bff8d1051d 

Diff: https://git.reviewboard.kde.org/r/121803/diff/


Testing
---

Opened with english local and tested shortcut. Works fine.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 338296] In Ledger: Keyboard shortcut for Search (Alt-E) does not work

2015-01-03 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=338296

--- Comment #1 from Christian David  ---
Added patch: https://git.reviewboard.kde.org/r/121803/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

2015-01-03 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121803/
---

(Updated Jan. 3, 2015, 2:28 nachm.)


Review request for KMymoney.


Changes
---

Added reason why I made a review request for such a change.


Bugs: 338296
http://bugs.kde.org/show_bug.cgi?id=338296


Repository: kmymoney


Description (updated)
---

The field is actually more filter than search.

This also fixes the bug "In Ledger: Keyboard shortcut for Search (Alt-E)
does not work".

I could not change the label in scheduled transactions view because it
is hard coded in the library. But this should be done as well. Shall we wait 
with this request until it is done there as well?

BUG: 338296
FIXED-IN: 4.7.2


Diffs
-

  kmymoney/widgets/registersearchline.cpp 
cae7a3fa22bf5ccd559ebeefc12885bff8d1051d 

Diff: https://git.reviewboard.kde.org/r/121803/diff/


Testing
---

Opened with english local and tested shortcut. Works fine.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

2015-01-04 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121803/
---

(Updated Jan. 4, 2015, 2:35 nachm.)


Review request for KMymoney.


Changes
---

changed label in scheduled transactions view as well


Bugs: 338296
http://bugs.kde.org/show_bug.cgi?id=338296


Repository: kmymoney


Description (updated)
---

The field is actually more filter than search.

This also fixes the bug "In Ledger: Keyboard shortcut for Search (Alt-E)
does not work".

I could not change the label in scheduled transactions view because it
is hard coded in the library. But this should be done as well.

BUG: 338296
FIXED-IN: 4.7.2
REVIEW: 121803

Changed label for serach bar in scheduled transactions to "Filter"

Before is was "Search" but that is not correct.

REVIEW: 121803


Diffs (updated)
-

  kmymoney/views/kscheduledview.cpp 2933bfc1f3d341b1d14122980da048004dd38902 
  kmymoney/widgets/CMakeLists.txt 4936827c0b13720be2fb547e2a1e0db8926939c9 
  kmymoney/widgets/ktreewidgetfilterlinewidget.h PRE-CREATION 
  kmymoney/widgets/ktreewidgetfilterlinewidget.cpp PRE-CREATION 
  kmymoney/widgets/registersearchline.cpp 
cae7a3fa22bf5ccd559ebeefc12885bff8d1051d 

Diff: https://git.reviewboard.kde.org/r/121803/diff/


Testing
---

Opened with english local and tested shortcut. Works fine.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 120499: Removed readFileInfo() and writeFileInfo() from upgradeToV7()

2015-01-04 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120499/
---

(Updated Jan. 4, 2015, 2:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
---

MyMoneyStorageSql::upgradeToV7() does not use readFileInfo() and
writeFileInfo() anymore.

This should prevent an issue if this metod is used to upgrade the
database to a version higher than 7 as readFileInfo() and
writeFileInfo() assume a database of the most recent version. This
will cause errors (=> crash) if a column in kmmFileInfo was
renamed or added between version 7 and the final version.

KMyMoney should still crash if you upgradeToV1() is used.


Diffs
-

  kmymoney/mymoney/storage/mymoneystoragesql.cpp 
0fa790d435bc978279038893b945de31811f34f1 

Diff: https://git.reviewboard.kde.org/r/120499/diff/


Testing
---

Opened an sqlite database which was created with KMyMoney 4.5.3, database 
version 6.
The upgrade still worked and kmmFileInfo was still filled with correct data.


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2015-01-04 Thread Christian David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121288/
---

(Updated Jan. 4, 2015, 3:13 nachm.)


Review request for KMymoney.


Repository: kmymoney


Description (updated)
---

So the upgrade routine is not executed starting from version 0 - which
is useless as the database should be the most recent version anyway.

Also removed the version param from createTables(int version). It was
not used and was totaly useless as createTables() calls upgradeDb().

This is also a workaround for bug 341304 as the upgradeToV1() won't be
called after creation of tables anymore. The bug persists if the user
has a version 0 database.

CCBUG: 341304
REVIEW: 121288


Diffs (updated)
-

  kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 
80ff5a725e41e2a344cf32019b22803059ab9f93 
  kmymoney/mymoney/storage/mymoneystoragesql.h 
ae79b484186e700367f9a4362ffd19772825cf22 
  kmymoney/mymoney/storage/mymoneystoragesql.cpp 
3b82d2b45623ed0e4d3e8cba7e6dc7364ed50f9e 

Diff: https://git.reviewboard.kde.org/r/121288/diff/


Testing
---

make test

only one fail left (see comments)

XFAIL  : MyMoneyDatabaseMgrTest::testBadConnections() Will fix when correct 
behaviour in this case is clear.
   Loc: 
[/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(106)]


Thanks,

Christian David

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121288: Database version is set after creating tables

2015-01-04 Thread Christian David



> On Nov. 29, 2014, 10:33 vorm., Christian David wrote:
> > kmymoney/mymoney/storage/mymoneystoragesql.cpp, line 740
> > <https://git.reviewboard.kde.org/r/121288/diff/1/?file=331058#file331058line740>
> >
> > This is still an open issue: ```m_storage->fileFixVersion()``` was 
> > never set before - so it just contains junk.
> > 
> > But it is not really set anywhere else. The database driver just uses 
> > ```m_storage->fileFixVersion()``` to write it to the database and 
> > ```m_storage->setFileFixVersion()``` is only called with the version which 
> > was stored in the database.

I guess nobody has any idea (anymore)?!


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121288/#review71073
-------


On Jan. 4, 2015, 3:13 nachm., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121288/
> ---
> 
> (Updated Jan. 4, 2015, 3:13 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> So the upgrade routine is not executed starting from version 0 - which
> is useless as the database should be the most recent version anyway.
> 
> Also removed the version param from createTables(int version). It was
> not used and was totaly useless as createTables() calls upgradeDb().
> 
> This is also a workaround for bug 341304 as the upgradeToV1() won't be
> called after creation of tables anymore. The bug persists if the user
> has a version 0 database.
> 
> CCBUG: 341304
> REVIEW: 121288
> 
> 
> Diffs
> -
> 
>   kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 
> 80ff5a725e41e2a344cf32019b22803059ab9f93 
>   kmymoney/mymoney/storage/mymoneystoragesql.h 
> ae79b484186e700367f9a4362ffd19772825cf22 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 
> 3b82d2b45623ed0e4d3e8cba7e6dc7364ed50f9e 
> 
> Diff: https://git.reviewboard.kde.org/r/121288/diff/
> 
> 
> Testing
> ---
> 
> make test
> 
> only one fail left (see comments)
> 
> XFAIL  : MyMoneyDatabaseMgrTest::testBadConnections() Will fix when correct 
> behaviour in this case is clear.
>Loc: 
> [/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(106)]
> 
> 
> Thanks,
> 
> Christian David
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 339103] reports cannot be created using the DB backend

2015-01-04 Thread Christian David

https://bugs.kde.org/show_bug.cgi?id=339103

--- Comment #10 from Christian David  ---
I published a Google Code In task to start solving this issue. So please do not
fix it within the next 15 days ;)

About Google Code In: http://www.google-melange.com/gci/homepage/google/gci2014

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

2015-01-04 Thread Christian David



> On Jan. 4, 2015, 5:13 nachm., Thomas Baumgart wrote:
> > kmymoney/widgets/ktreewidgetfilterlinewidget.cpp, line 41
> > <https://git.reviewboard.kde.org/r/121803/diff/2/?file=338147#file338147line41>
> >
> > Why do you use a second translation item here? Doesn't using the same 
> > i18nc that is used in RegisterSearchLineWidget result in a single item? At 
> > least I thought it would, not sure though.

Do you mean I should use ```i18nc("Filter widget label", 
"Fi<er:")```??Updated request to do so…


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121803/#review73079
-------


On Jan. 4, 2015, 5:20 nachm., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121803/
> ---
> 
> (Updated Jan. 4, 2015, 5:20 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 338296
> http://bugs.kde.org/show_bug.cgi?id=338296
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> The field is actually more filter than search.
> 
> This also fixes the bug "In Ledger: Keyboard shortcut for Search (Alt-E)
> does not work".
> 
> I could not change the label in scheduled transactions view because it
> is hard coded in the library. But this should be done as well.
> 
> BUG: 338296
> FIXED-IN: 4.7.2
> REVIEW: 121803
> 
> Changed label for serach bar in scheduled transactions to "Filter"
> 
> Before is was "Search" but that is not correct.
> 
> REVIEW: 121803
> 
> 
> Diffs
> -
> 
>   kmymoney/widgets/registersearchline.cpp 
> cae7a3fa22bf5ccd559ebeefc12885bff8d1051d 
>   kmymoney/views/kscheduledview.cpp 2933bfc1f3d341b1d14122980da048004dd38902 
>   kmymoney/widgets/CMakeLists.txt 4936827c0b13720be2fb547e2a1e0db8926939c9 
>   kmymoney/widgets/ktreewidgetfilterlinewidget.h PRE-CREATION 
>   kmymoney/widgets/ktreewidgetfilterlinewidget.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121803/diff/
> 
> 
> Testing
> ---
> 
> Opened with english local and tested shortcut. Works fine.
> 
> 
> Thanks,
> 
> Christian David
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

1 2 3 4 >

1 - 100 of 306 matches

Mail list logo