[jira] [Created] (MPMD-343) Upgrade to PMD 6.46.0
Andreas Dangel created MPMD-343: --- Summary: Upgrade to PMD 6.46.0 Key: MPMD-343 URL: https://issues.apache.org/jira/browse/MPMD-343 Project: Maven PMD Plugin Issue Type: Dependency upgrade Components: CPD, PMD Reporter: Andreas Dangel Assignee: Andreas Dangel Fix For: 3.17.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-pmd-plugin] adangel opened a new pull request, #71: [MPMD-343] - Upgrade to PMD 6.46.0
adangel opened a new pull request, #71: URL: https://github.com/apache/maven-pmd-plugin/pull/71 https://issues.apache.org/jira/browse/MPMD-343 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPMD) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPMD-XXX] - Subject of the JIRA Ticket`, where you replace `MPMD-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] adangel commented on pull request #71: [MPMD-343] - Upgrade to PMD 6.46.0
adangel commented on PR #71: URL: https://github.com/apache/maven-pmd-plugin/pull/71#issuecomment-1140234828 @michael-o Let me know, whether I should spin a new release of m-pmd-p. I can do it next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #153: [MENFORCER-418] Upgrade Parent to 36
slawekjaranowski merged PR #153: URL: https://github.com/apache/maven-enforcer/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MENFORCER-418) Upgrade Parent to 36
[ https://issues.apache.org/jira/browse/MENFORCER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-418. - Assignee: Slawomir Jaranowski Resolution: Fixed > Upgrade Parent to 36 > > > Key: MENFORCER-418 > URL: https://issues.apache.org/jira/browse/MENFORCER-418 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.0.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MENFORCER-418) Upgrade Parent to 36
[ https://issues.apache.org/jira/browse/MENFORCER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543451#comment-17543451 ] Hudson commented on MENFORCER-418: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-enforcer » master #21 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-enforcer/job/master/21/ > Upgrade Parent to 36 > > > Key: MENFORCER-418 > URL: https://issues.apache.org/jira/browse/MENFORCER-418 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.0.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543452#comment-17543452 ] Michael Osipov commented on MSHARED-831: The proportion between a sounds new solution and the benefit is truly unhealthy for me. > Configuration in reporting section not taken into account when running from > cli > --- > > Key: MSHARED-831 > URL: https://issues.apache.org/jira/browse/MSHARED-831 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl 3.0 >Reporter: Hans Aikema >Assignee: Michael Osipov >Priority: Major > Fix For: waiting-for-feedback > > > Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444] > my conclusion is that plugin configuration using the reporting section does > not work as documented on > [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag] > When configuring the plugin using the reporting section of the pom the > configuration is not applied when calling the plugin goal from the CLI > whereas the guide states that it is first looked up there and only when not > found searched for in the build section. > Don't know if this is the intended behaviour of the CLI-invocation of the > plugins (and thus a documentation bug) or an actual bug in the configuration > evaluation, but I spotted similar behaviour with the > maven-project-info-reports-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MNG-7485) Failed To Load JANSI Native Library
[
https://issues.apache.org/jira/browse/MNG-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7485:
Fix Version/s: waiting-for-feedback
> Failed To Load JANSI Native Library
> ---
>
> Key: MNG-7485
> URL: https://issues.apache.org/jira/browse/MNG-7485
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.5
>Reporter: Mark
>Priority: Minor
> Fix For: waiting-for-feedback
>
>
> Hi All
> Wondering if anyone else has experienced a similar issue. I have recently
> upgraded to JDK 8 and Maven 3.8.5 and when i try mvn --version i get an error
> as such:
> {color:#505f79}Failed to load native
> library:jansi-2.4.0-bbb285ac9ffab828-libjansi.so. The native library file at
> /tmp/jansi-2.4.0-bbb285ac9ffab828-libjansi.so is not executable, make sure
> that the directory is mounted on a partition without the noexec flag, or set
> the jansi.tmpdir system property to point to a proper location. osinfo:
> Linux/x86_64{color}
> {color:#505f79}java.lang.UnsatisfiedLinkError:
> /tmp/jansi-2.4.0-bbb285ac9ffab828-libjansi.so:
> /tmp/jansi-2.4.0-bbb285ac9ffab828-libjansi.so: failed to map segment from
> shared object: Operation not permitted{color}
> {color:#505f79}Apache Maven 3.8.5
> (3599d3414f046de2324203b78ddcf9b5e4388aa0){color}
> {color:#505f79}Maven home: /opt/apache-maven-3.8.5{color}
> {color:#505f79}Java version: 1.8.0_251, vendor: Oracle Corporation, runtime:
> /opt/jdk1.8.0_251/jre{color}
> {color:#505f79}Default locale: en_US, platform encoding: UTF-8{color}
> {color:#505f79}OS name: "linux", version: "3.10.0-1160.49.1.el7.x86_64",
> arch: "amd64", family: "unix"{color}
> {color:#505f79}java version "1.8.0_251"{color}
> {color:#505f79}Java(TM) SE Runtime Environment (build 1.8.0_251-b08){color}
> {color:#505f79}Java HotSpot(TM) 64-Bit Server VM (build 25.251-b08, mixed
> mode){color}
> I have also tried installing JANSI through yum and that does not seem to
> resolve it. sudo yum -y install jansi-native
> Any help or guidance on how to resolve this would be greatly appreciated.
> CentOS Linux release 7.9.2009 (Core)
> apache-maven-3.8.5
> jdk1.8.0_251
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #140: [MENFORCER-402] - fix provided dependencies in RequireUpperBoundDeps
slawekjaranowski merged PR #140: URL: https://github.com/apache/maven-enforcer/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MENFORCER-402) RequireUpperBoundDeps now follow scope provided transitive dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MENFORCER-402.
-
Resolution: Fixed
> RequireUpperBoundDeps now follow scope provided transitive dependencies
> ---
>
> Key: MENFORCER-402
> URL: https://issues.apache.org/jira/browse/MENFORCER-402
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.0.0
>Reporter: Thomas Mortagne
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.0.1
>
>
> I have a dependency on org.infinispan:infinispan-core:12.1.7.Final and
> upgrading to the enforcer plugin 3.0.0 suddenly made my module fail because
> infinispan-core have conflicting provided dependencies on
> javax.annotation-api:
> {noformat}
> Require upper bound dependencies error for
> javax.annotation:javax.annotation-api:1.3.1 [provided] paths to dependency
> are:
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-commons:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-component-processor:12.1.7.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostream:protostream-types:4.4.1.Final
> +-javax.annotation:javax.annotation-api:1.3.2 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostream:protostream-processor:4.4.1.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.2 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-commons:12.1.7.Final
> +-org.infinispan:infinispan-commons-jdk11:12.1.7.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> {noformat}
> It's not clear if this was done on purpose since I cannot find anything about
> that in the release note, but I might have missed it. Problem is that
> provided scope dependencies are not necessarily used at runtime (it's often
> used as a way to avoid making transitive a dependency you only need at build
> time) and adding an for a non-transitive dependency feels quite
> weird.
> At least if this is not a bug, it would be nice to make this behavior
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (MENFORCER-411) DependencyConvergence should support including/excluding certain dependencies
[ https://issues.apache.org/jira/browse/MENFORCER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MENFORCER-411: -- Issue Type: New Feature (was: Improvement) > DependencyConvergence should support including/excluding certain dependencies > - > > Key: MENFORCER-411 > URL: https://issues.apache.org/jira/browse/MENFORCER-411 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Affects Versions: 3.0.1 >Reporter: Forrest Feaser >Priority: Major > Original Estimate: 4h > Remaining Estimate: 4h > > It would be nice if the DependencyConvergence rule could specify certain > dependencies that should/should not fail the build. This might be useful if > your project has a lot of dependency conflicts, but you know there are just a > few troublesome ones that cause issues, and you don't want to resolve the > conflicts for your entire project. > Here is my PR: https://github.com/apache/maven-enforcer/pull/136 > Do I need to sign the Contributor License Agreement for this? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MENFORCER-402) RequireUpperBoundDeps now follow scope provided transitive dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543457#comment-17543457
]
Hudson commented on MENFORCER-402:
--
Build succeeded in Jenkins: Maven » Maven TLP » maven-enforcer » master #22
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-enforcer/job/master/22/
> RequireUpperBoundDeps now follow scope provided transitive dependencies
> ---
>
> Key: MENFORCER-402
> URL: https://issues.apache.org/jira/browse/MENFORCER-402
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.0.0
>Reporter: Thomas Mortagne
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.0.1
>
>
> I have a dependency on org.infinispan:infinispan-core:12.1.7.Final and
> upgrading to the enforcer plugin 3.0.0 suddenly made my module fail because
> infinispan-core have conflicting provided dependencies on
> javax.annotation-api:
> {noformat}
> Require upper bound dependencies error for
> javax.annotation:javax.annotation-api:1.3.1 [provided] paths to dependency
> are:
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-commons:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-component-processor:12.1.7.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostream:protostream-types:4.4.1.Final
> +-javax.annotation:javax.annotation-api:1.3.2 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostream:protostream-processor:4.4.1.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.2 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-commons:12.1.7.Final
> +-org.infinispan:infinispan-commons-jdk11:12.1.7.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> {noformat}
> It's not clear if this was done on purpose since I cannot find anything about
> that in the release note, but I might have missed it. Problem is that
> provided scope dependencies are not necessarily used at runtime (it's often
> used as a way to avoid making transitive a dependency you only need at build
> time) and adding an for a non-transitive dependency feels quite
> weird.
> At least if this is not a bug, it would be nice to make this behavior
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Comment Edited] (MRESOLVER-259) Enable the option of getting all dependencies names (including poms) without downloading them
[ https://issues.apache.org/jira/browse/MRESOLVER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543460#comment-17543460 ] robjea edited comment on MRESOLVER-259 at 5/28/22 1:05 PM: --- [~michael-o] I've been looking at all of the demos and couldn't manage to find any way of extracting a list of dependencies that contains pom-only based dependencies. Which demo class did you refer to? was (Author: JIRAUSER289833): [~michael-o] I've been looking at all of the demos and couldn't manage to find any way of extracting a list of dependencies that contains pom-only based dependencies. For which class did you refer? > Enable the option of getting all dependencies names (including poms) without > downloading them > - > > Key: MRESOLVER-259 > URL: https://issues.apache.org/jira/browse/MRESOLVER-259 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: robjea >Priority: Major > > I may just not know how to perform this (that's pretty hard learning to use > this awesome library without any documentation available - just through > digging in the code). > Anyway, I'm building a dependencies resolving system, and for this, I need to > get all of the transitive jars and *poms* needed for resolving a single > artifact. I was looking at the demo on the `GetDependencyHierarchy` class, > but when I use a function like > `dependencyResult.getRequest().getCollectRequest().getManagedDependencies()` > I only get a list of artifacts. No poms. I really need to list these poms and > the only way I've figured out to do that was to add them from the listener > class (through events). This is a pretty dirty way of doing this and I wonder > if there's a way of getting the dependencies list including poms in an easier > and cleaner way? > My second request is to be able to do this without actually installing them. > I don't need them locally and I just want this list. I currently delete the > local folder after each resolving cycle, but this is dirty. Is there a way to > resolve dependency and only get the list of the resolving result? Without > some `localRepositoryManager`. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRESOLVER-259) Enable the option of getting all dependencies names (including poms) without downloading them
[ https://issues.apache.org/jira/browse/MRESOLVER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543460#comment-17543460 ] robjea commented on MRESOLVER-259: -- [~michael-o] I've been looking at all of the demos and couldn't manage to find any way of extracting a list of dependencies that contains pom-only based dependencies. For which class did you refer? > Enable the option of getting all dependencies names (including poms) without > downloading them > - > > Key: MRESOLVER-259 > URL: https://issues.apache.org/jira/browse/MRESOLVER-259 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: robjea >Priority: Major > > I may just not know how to perform this (that's pretty hard learning to use > this awesome library without any documentation available - just through > digging in the code). > Anyway, I'm building a dependencies resolving system, and for this, I need to > get all of the transitive jars and *poms* needed for resolving a single > artifact. I was looking at the demo on the `GetDependencyHierarchy` class, > but when I use a function like > `dependencyResult.getRequest().getCollectRequest().getManagedDependencies()` > I only get a list of artifacts. No poms. I really need to list these poms and > the only way I've figured out to do that was to add them from the listener > class (through events). This is a pretty dirty way of doing this and I wonder > if there's a way of getting the dependencies list including poms in an easier > and cleaner way? > My second request is to be able to do this without actually installing them. > I don't need them locally and I just want this list. I currently delete the > local folder after each resolving cycle, but this is dirty. Is there a way to > resolve dependency and only get the list of the resolving result? Without > some `localRepositoryManager`. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MRESOLVER-261) Resolve a pom file
robjea created MRESOLVER-261: Summary: Resolve a pom file Key: MRESOLVER-261 URL: https://issues.apache.org/jira/browse/MRESOLVER-261 Project: Maven Resolver Issue Type: New Feature Reporter: robjea I'd like to be able to give a name of a pom-only-based artifact (such as some bom) and be able to resolve it. I'm currently not sure if that's possible, so if it doesn't I'd like that ability to get implemented. That's shouldn't be hard since the library is already capable of doing exactly this, even though there's no (at least not that I know of) public function that exposes this. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1140263425 I have a question for the reviewers (@michael-o): This is essentially a plugin for a plugin for maven. Is there a better way to do the configuration of this "plugin for a plugin for maven" ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543461#comment-17543461 ] Herve Boutemy commented on MSHARED-831: --- what we need is to fix site, because it's clearly wrong now on implementing the improvement, sure, I don't see really the interest... > Configuration in reporting section not taken into account when running from > cli > --- > > Key: MSHARED-831 > URL: https://issues.apache.org/jira/browse/MSHARED-831 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl 3.0 >Reporter: Hans Aikema >Assignee: Michael Osipov >Priority: Major > Fix For: waiting-for-feedback > > > Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444] > my conclusion is that plugin configuration using the reporting section does > not work as documented on > [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag] > When configuring the plugin using the reporting section of the pom the > configuration is not applied when calling the plugin goal from the CLI > whereas the guide states that it is first looked up there and only when not > found searched for in the build section. > Don't know if this is the intended behaviour of the CLI-invocation of the > plugins (and thus a documentation bug) or an actual bug in the configuration > evaluation, but I spotted similar behaviour with the > maven-project-info-reports-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-doxia] hboutemy commented on pull request #98: [DOXIA-590] Either provided element class or default class gets ignored
hboutemy commented on PR #98: URL: https://github.com/apache/maven-doxia/pull/98#issuecomment-1140267582 I don't understand anything, sorry: what is the issue? what does the code change (apart from order in attributes)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-590) Either provided element class or default class gets ignored
[ https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543462#comment-17543462 ] ASF GitHub Bot commented on DOXIA-590: -- hboutemy commented on PR #98: URL: https://github.com/apache/maven-doxia/pull/98#issuecomment-1140267582 I don't understand anything, sorry: what is the issue? what does the code change (apart from order in attributes)? > Either provided element class or default class gets ignored > --- > > Key: DOXIA-590 > URL: https://issues.apache.org/jira/browse/DOXIA-590 > Project: Maven Doxia > Issue Type: Bug > Components: Core >Affects Versions: 1.8 >Reporter: Fred Eckertson >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M3, 1.11.2 > > Attachments: image-2022-05-18-21-57-40-619.png > > > The following construct is somewhat common in doxia-core > att.addAttribute( Attribute.CLASS, "a" ); > The documentation says that basic attributes (including CLASS) are supported. > However in cases like this either that "a" or the CLASS that was provided in > the attributes parameter will be ignored. The correct way to do this is to > append the provided CLASS to "a " if a CLASS attribute was provided. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven] mthmulders commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages
mthmulders commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884137008
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
+for ( String word : words )
+{
+if ( sb.length() >= rem - word.length() - ( sb.length() > 0 ?
1 : 0 ) )
Review Comment:
What in the hypothetical case a word is longer than the line length? I guess
it would never get printed?
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
project contains the following "
++ "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
+"While this /may/ work fine, please look for plugin
updates and/or "
++ "request plugins be made thread-safe.",
+"If reporting an issue, report it against the plugin
in question, not against Apache Maven." ) )
+{
+logger.warn( s );
+}
if ( logger.isDebugEnabled() )
{
final Set unsafeGoals =
executionPlan.getNonThreadSafeMojos();
-logger.warn( "The following goals are not marked
@threadSafe in " + project.getName() + ":" );
+logger.warn( "The following goals are not marked as
@threadSafe in " + project.getName() + ":" );
Review Comment:
Same as above.
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins
[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages
[
https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543463#comment-17543463
]
ASF GitHub Bot commented on MNG-7486:
-
mthmulders commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884137008
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
+for ( String word : words )
+{
+if ( sb.length() >= rem - word.length() - ( sb.length() > 0 ?
1 : 0 ) )
Review Comment:
What in the hypothetical case a word is longer than the line length? I guess
it would never get printed?
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
project contains the following "
++ "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
+"While this /may/ work fine, please look for plugin
updates and/or "
++ "request plugins be made thread-safe.",
+"If reporting an issue, report it against the plugin
in question, not against Apache Maven." ) )
+{
+logger.warn( s );
+}
if ( logger.isDebugEnabled() )
{
final Set unsafeGoals =
executionPlan.getNonThreadSafeMojos();
-logger.warn( "The following goals are not marked
@threadSafe in " + project.getName() + ":" );
+logger.warn( "The following goals are not marked as
@threadSafe in " + project.getName() + ":" );
Review Comment:
Same as above.
###
[jira] [Commented] (MRESOLVER-259) Enable the option of getting all dependencies names (including poms) without downloading them
[ https://issues.apache.org/jira/browse/MRESOLVER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543467#comment-17543467 ] Michael Osipov commented on MRESOLVER-259: -- [~cstamas] to the rescue! > Enable the option of getting all dependencies names (including poms) without > downloading them > - > > Key: MRESOLVER-259 > URL: https://issues.apache.org/jira/browse/MRESOLVER-259 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: robjea >Priority: Major > > I may just not know how to perform this (that's pretty hard learning to use > this awesome library without any documentation available - just through > digging in the code). > Anyway, I'm building a dependencies resolving system, and for this, I need to > get all of the transitive jars and *poms* needed for resolving a single > artifact. I was looking at the demo on the `GetDependencyHierarchy` class, > but when I use a function like > `dependencyResult.getRequest().getCollectRequest().getManagedDependencies()` > I only get a list of artifacts. No poms. I really need to list these poms and > the only way I've figured out to do that was to add them from the listener > class (through events). This is a pretty dirty way of doing this and I wonder > if there's a way of getting the dependencies list including poms in an easier > and cleaner way? > My second request is to be able to do this without actually installing them. > I don't need them locally and I just want this list. I currently delete the > local folder after each resolving cycle, but this is dirty. Is there a way to > resolve dependency and only get the list of the resolving result? Without > some `localRepositoryManager`. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-release] michael-o commented on pull request #104: [MRELEASE-1078] Conventional commits
michael-o commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1140272950 > I have a question for the reviewers (@michael-o): This is essentially a plugin for a plugin for maven. Is there a better way to do the configuration of this "plugin for a plugin for maven" ? What do you mean? Maven Release Plugin is a not a plugin on top of a plugin. Maven Release Plugin => Maven Release => Maven SCM API => Maven SCM Providers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543468#comment-17543468 ] Michael Osipov commented on MSHARED-831: I gree with that. Let's update the docs with the reality and move on. > Configuration in reporting section not taken into account when running from > cli > --- > > Key: MSHARED-831 > URL: https://issues.apache.org/jira/browse/MSHARED-831 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl 3.0 >Reporter: Hans Aikema >Assignee: Michael Osipov >Priority: Major > Fix For: waiting-for-feedback > > > Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444] > my conclusion is that plugin configuration using the reporting section does > not work as documented on > [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag] > When configuring the plugin using the reporting section of the pom the > configuration is not applied when calling the plugin goal from the CLI > whereas the guide states that it is first looked up there and only when not > found searched for in the build section. > Don't know if this is the intended behaviour of the CLI-invocation of the > plugins (and thus a documentation bug) or an actual bug in the configuration > evaluation, but I spotted similar behaviour with the > maven-project-info-reports-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-doxia] michael-o commented on pull request #98: [DOXIA-590] Either provided element class or default class gets ignored
michael-o commented on PR #98: URL: https://github.com/apache/maven-doxia/pull/98#issuecomment-1140273753 > I don't understand anything, sorry: what is the issue? what does the code change (apart from order in attributes)? One of the basic problems is that you cannot provide a CSS class attribute from outside because it is overridden so you cannot customize. It is not merged, but simply wiped out. This problem existed now for a very long time, I knew that, but this is the first issue regarding this. Stupid simple: https://github.com/apache/maven-doxia/blob/c098cc9972b13c761091e66a57261e89195a9271/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L1533-L1544 You pass the attribute set, but your potential, custom `CLASS` is dropped in any case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-590) Either provided element class or default class gets ignored
[ https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543469#comment-17543469 ] ASF GitHub Bot commented on DOXIA-590: -- michael-o commented on PR #98: URL: https://github.com/apache/maven-doxia/pull/98#issuecomment-1140273753 > I don't understand anything, sorry: what is the issue? what does the code change (apart from order in attributes)? One of the basic problems is that you cannot provide a CSS class attribute from outside because it is overridden so you cannot customize. It is not merged, but simply wiped out. This problem existed now for a very long time, I knew that, but this is the first issue regarding this. Stupid simple: https://github.com/apache/maven-doxia/blob/c098cc9972b13c761091e66a57261e89195a9271/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L1533-L1544 You pass the attribute set, but your potential, custom `CLASS` is dropped in any case. > Either provided element class or default class gets ignored > --- > > Key: DOXIA-590 > URL: https://issues.apache.org/jira/browse/DOXIA-590 > Project: Maven Doxia > Issue Type: Bug > Components: Core >Affects Versions: 1.8 >Reporter: Fred Eckertson >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M3, 1.11.2 > > Attachments: image-2022-05-18-21-57-40-619.png > > > The following construct is somewhat common in doxia-core > att.addAttribute( Attribute.CLASS, "a" ); > The documentation says that basic attributes (including CLASS) are supported. > However in cases like this either that "a" or the CLASS that was provided in > the attributes parameter will be ignored. The correct way to do this is to > append the provided CLASS to "a " if a CLASS attribute was provided. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven] michael-o commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884141711
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
project contains the following "
++ "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
Review Comment:
That is true, the Javadoc tag is gone and we don't have a separate Java
annotation for "thread-safe". You proposal is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages
[
https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543472#comment-17543472
]
ASF GitHub Bot commented on MNG-7486:
-
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884141711
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
project contains the following "
++ "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
Review Comment:
That is true, the Javadoc tag is gone and we don't have a separate Java
annotation for "thread-safe". You proposal is correct.
> Create a multiline message helper for boxed log messages
>
>
> Key: MNG-7486
> URL: https://issues.apache.org/jira/browse/MNG-7486
> Project: Maven
> Issue Type: New Feature
>Reporter: Michael Osipov
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Simplify the way how boxed messages, e.g., for non-threadsafe plugins is
> created.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven] michael-o commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884142160
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
Review Comment:
Done.
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
project contains the following "
++ "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
Review Comment:
Done.
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
project contains the following "
++ "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
+"While this /may/ work fine, please loo
[GitHub] [maven] michael-o commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884142181
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
project contains the following "
++ "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
+"While this /may/ work fine, please look for plugin
updates and/or "
++ "request plugins be made thread-safe.",
+"If reporting an issue, report it against the plugin
in question, not against Apache Maven." ) )
+{
+logger.warn( s );
+}
if ( logger.isDebugEnabled() )
{
final Set unsafeGoals =
executionPlan.getNonThreadSafeMojos();
-logger.warn( "The following goals are not marked
@threadSafe in " + project.getName() + ":" );
+logger.warn( "The following goals are not marked as
@threadSafe in " + project.getName() + ":" );
for ( MojoDescriptor unsafeGoal : unsafeGoals )
{
-logger.warn( unsafeGoal.getId() );
+logger.warn( " " + unsafeGoal.getId() );
}
}
else
{
-logger.warn( "The following plugins are not marked
@threadSafe in " + project.getName() + ":" );
+logger.warn( "The following plugins are not marked as
@threadSafe in " + project.getName() + ":" );
for ( Plugin unsafePlugin : unsafePlugins )
{
-logger.warn( unsafePlugin.getId() );
+logger.warn( " " + unsafePlugin.getId() );
}
-logger.warn( "Enable verbose output (-X) to see more
precisely which goals are not marked"
+logger.warn( "" );
+logger.warn( "Enable verbose output (-X) to see precisely
which goals are not marked as"
+ " @threadSafe." );
Review Comment:
Done.
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
proje
[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages
[
https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543473#comment-17543473
]
ASF GitHub Bot commented on MNG-7486:
-
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884142160
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
Review Comment:
Done.
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
project contains the following "
++ "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
Review Comment:
Done.
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting
[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages
[
https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543474#comment-17543474
]
ASF GitHub Bot commented on MNG-7486:
-
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884142181
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-logger.warn(
"*" );
+for ( String s : MultilineMessageHelper.format(
+"Your build is requesting parallel execution, but this
project contains the following "
++ "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
+"While this /may/ work fine, please look for plugin
updates and/or "
++ "request plugins be made thread-safe.",
+"If reporting an issue, report it against the plugin
in question, not against Apache Maven." ) )
+{
+logger.warn( s );
+}
if ( logger.isDebugEnabled() )
{
final Set unsafeGoals =
executionPlan.getNonThreadSafeMojos();
-logger.warn( "The following goals are not marked
@threadSafe in " + project.getName() + ":" );
+logger.warn( "The following goals are not marked as
@threadSafe in " + project.getName() + ":" );
for ( MojoDescriptor unsafeGoal : unsafeGoals )
{
-logger.warn( unsafeGoal.getId() );
+logger.warn( " " + unsafeGoal.getId() );
}
}
else
{
-logger.warn( "The following plugins are not marked
@threadSafe in " + project.getName() + ":" );
+logger.warn( "The following plugins are not marked as
@threadSafe in " + project.getName() + ":" );
for ( Plugin unsafePlugin : unsafePlugins )
{
-logger.warn( unsafePlugin.getId() );
+logger.warn( " " + unsafePlugin.getId() );
}
-logger.warn( "Enable verbose output (-X) to see more
precisely which goals are not marked"
+logger.warn( "" );
+logger.warn( "Enable verbose output (-X) to see precisely
which goals are not marked as"
+ " @threadSafe." );
Review Comment:
Done.
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
-logger.warn(
"*" );
-logger.warn( "* Your build is requesting parallel execution,
but project *" );
-logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
-logger.warn( "* as @threadSafe to support parallel building.
*" );
-logger.warn( "* While this /may/ work fine, please look for
plugin updates*" );
-logger.warn( "* and/or request plugins be made thread-safe.
*" );
-logger.warn( "* If reporting an issue, report it against the
plugin in*" );
-logger.warn( "* question, not against maven-core
*" );
-
[GitHub] [maven] michael-o commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884142308
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
Review Comment:
@gnodet I wouldn't mind. Any objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884142356
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
+for ( String word : words )
+{
+if ( sb.length() >= rem - word.length() - ( sb.length() > 0 ?
1 : 0 ) )
Review Comment:
@gnodet Opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages
[
https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543476#comment-17543476
]
ASF GitHub Bot commented on MNG-7486:
-
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884142356
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
+for ( String word : words )
+{
+if ( sb.length() >= rem - word.length() - ( sb.length() > 0 ?
1 : 0 ) )
Review Comment:
@gnodet Opinion?
> Create a multiline message helper for boxed log messages
>
>
> Key: MNG-7486
> URL: https://issues.apache.org/jira/browse/MNG-7486
> Project: Maven
> Issue Type: New Feature
>Reporter: Michael Osipov
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Simplify the way how boxed messages, e.g., for non-threadsafe plugins is
> created.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages
[
https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543475#comment-17543475
]
ASF GitHub Bot commented on MNG-7486:
-
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884142308
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
Review Comment:
@gnodet I wouldn't mind. Any objections?
> Create a multiline message helper for boxed log messages
>
>
> Key: MNG-7486
> URL: https://issues.apache.org/jira/browse/MNG-7486
> Project: Maven
> Issue Type: New Feature
>Reporter: Michael Osipov
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Simplify the way how boxed messages, e.g., for non-threadsafe plugins is
> created.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1140276099 > > I have a question for the reviewers (@michael-o): This is essentially a plugin for a plugin for maven. Is there a better way to do the configuration of this "plugin for a plugin for maven" ? > > What do you mean? Maven Release Plugin is a not a plugin on top of a plugin. Maven Release Plugin => Maven Release => Maven SCM API => Maven SCM Providers The Conventional Commits part has specific configuration. That "next version calculator" is a plugin for the maven-release plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #104: [MRELEASE-1078] Conventional commits
michael-o commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1140277012 > > > I have a question for the reviewers (@michael-o): This is essentially a plugin for a plugin for maven. Is there a better way to do the configuration of this "plugin for a plugin for maven" ? > > > > > > What do you mean? Maven Release Plugin is a not a plugin on top of a plugin. Maven Release Plugin => Maven Release => Maven SCM API => Maven SCM Providers > > The Conventional Commits part has specific configuration. That "next version calculator" is a plugin for the maven-release plugin. I know see, it is not a plugin in Maven sense, since it is not a Maven plugin with mojos. You simply provide a new implementatino for an interface pluggable at runtime, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DOXIASITETOOLS-230) Upgrade to Velocity Engine 2.3 and Velocity Tools 3.1
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated DOXIASITETOOLS-230: - Description: upgrade Velocity Engine: - from 1.7: https://velocity.apache.org/engine/1.7/ - to current latest 2.3: https://velocity.apache.org/engine/2.3/ and Velocity Tools: - from 2.0: https://velocity.apache.org/tools/2.0/ - to current latest 3.1: https://velocity.apache.org/tools/3.1/ see upgrade documentation https://velocity.apache.org/tools/3.1/upgrading.html > Upgrade to Velocity Engine 2.3 and Velocity Tools 3.1 > - > > Key: DOXIASITETOOLS-230 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-230 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M3 > > > upgrade Velocity Engine: > - from 1.7: https://velocity.apache.org/engine/1.7/ > - to current latest 2.3: https://velocity.apache.org/engine/2.3/ > and Velocity Tools: > - from 2.0: https://velocity.apache.org/tools/2.0/ > - to current latest 3.1: https://velocity.apache.org/tools/3.1/ > see upgrade documentation https://velocity.apache.org/tools/3.1/upgrading.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-release] slavino commented on pull request #133: SSH option preparation
slavino commented on PR #133: URL: https://github.com/apache/maven-release/pull/133#issuecomment-1140280142 I don't have access to your JIRA so feel free. The contribution isn't any rocket science at this stage but shouldn't break anything (backward compatibility shouldn't be affected). If needed then feel free to delete these PRs and create a new one. Before announcing it as new feature it will need to be covered by proper tests. Afterwards it can also be mentioned in the official plugin documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #133: SSH option preparation
michael-o commented on PR #133: URL: https://github.com/apache/maven-release/pull/133#issuecomment-1140283492 JIRA is available to everyone: https://issues.apache.org/jira/projects/MRELEASE/issues/MRELEASE-1079?filter=allopenissues This are a bit harde because it will required to setup SSHd with MINA and test that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-sitetools] michael-o commented on a diff in pull request #42: [DOXIASITETOOLS-230] Upgrade to Velocity Engine 2.3 and Velocity Tool…
michael-o commented on code in PR #42:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/42#discussion_r884149934
##
doxia-site-renderer/src/site/apt/index.apt.vm:
##
@@ -76,62 +76,62 @@ Doxia Sitetools - Site Renderer
There are also some tools for general use:
-#set( $plexus =
"http://codehaus-plexus.github.io/plexus-utils/apidocs/org/codehaus/plexus"; )
+#set( $plexus =
"https://codehaus-plexus.github.io/plexus-utils/apidocs/org/codehaus/plexus/util";
)
*-+--+---+
|| Variable || Type
|| Description ||
*-+--+---+
-| <<>> |
{{{$plexus/util/PathTool.html}<<>>}} |
|
+| <<>> | {{{$plexus/PathTool.html}<<>>}}
| |
*-+--+---+
-| <<>> |
{{{$plexus/util/StringUtils.html}<<>>}} |
|
+| <<>> |
{{{$plexus/StringUtils.html}<<>>}} |
|
*-+--+---+
-| <<>>|
{{{http://git.eclipse.org/c/sisu/org.eclipse.sisu.plexus.git/tree/org.eclipse.sisu.plexus/src/org/codehaus/plexus/PlexusContainer.java}<<>>}}
| |
+| <<>>|
{{{https://github.com/eclipse/sisu.plexus/blob/master/org.eclipse.sisu.plexus/src/org/codehaus/plexus/PlexusContainer.java}<<>>}}
| |
*-+--+---+
- Additionally, there are
{{{http://velocity.apache.org/tools/releases/2.0/generic.html} Velocity Generic
Tools}} populated
+ Additionally, there are
{{{https://velocity.apache.org/tools/${velocityToolsVersion}/tools-summary.html}
Velocity Generic Tools}} populated
with the site locale, the decoration model's date format, and site
renderer's resource bundle:
-#set( $generic =
"http://velocity.apache.org/tools/releases/2.0/javadoc/org/apache/velocity/tools/generic";
)
-*--+--+---+
-|| Variable|| Type
|| Description ||
-*--+--+---+
-| <<>> | {{{$generic/AlternatorTool.html}AlternatorTool}}
| <>: use CSS3 nth-child(even/odd) selectors or #if($foreach.index
% 2). For creating alternators to easily alternate over a set of values.
-*--+--+---+
-| <<>> | {{{$generic/ClassTool.html}ClassTool}}
| For simplifying reflective lookup of information about classes and their
fields, methods and constructors.
-*--+--+---+
-| <<>>| {{{$generic/ContextTool.html}ContextTool}}
| For convenient access to context data and metadata.
-*--+--+---+
-| <<>>| {{{$generic/ConversionTool.html}ConversionTool}}
| <>: use NumberTool for numbers formatting/parsing, DateTool for
date/time formatting/parsing, or CollectionTool for toStrings(). For converting
String values to richer object Types.
-*--+--+---+
-| <<>> | {{{$generic/ComparisonDateTool.html}ComparisonDateTool}}
| For manipulating, formatting, and comparing dates.
-*--+--+---+
-| <<>>| {{{$generic/DisplayTool.html}DisplayTool}}
| For controlling display of references (e.g., truncating values, "pretty
printing" lists, and displaying alternates when a reference is null).
-*--+--+---+
-| <<>>| {{{$generic/EscapeTool.html}EscapeTool}}
| For common escaping needs in Velocity templates (e.g. escaping html, xml,
javascript etc.).
-*--+--+---+
-| <<>> | {{{$generic/FieldTool.html}FieldTool}}
| For (easy) acc
[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543481#comment-17543481 ] Herve Boutemy commented on MSHARED-831: --- documentation updated in https://github.com/apache/maven-site/commit/b3db55e331c3070e79870f96196268a4d60ad208 > Configuration in reporting section not taken into account when running from > cli > --- > > Key: MSHARED-831 > URL: https://issues.apache.org/jira/browse/MSHARED-831 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl 3.0 >Reporter: Hans Aikema >Assignee: Michael Osipov >Priority: Major > Fix For: waiting-for-feedback > > > Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444] > my conclusion is that plugin configuration using the reporting section does > not work as documented on > [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag] > When configuring the plugin using the reporting section of the pom the > configuration is not applied when calling the plugin goal from the CLI > whereas the guide states that it is first looked up there and only when not > found searched for in the build section. > Don't know if this is the intended behaviour of the CLI-invocation of the > plugins (and thus a documentation bug) or an actual bug in the configuration > evaluation, but I spotted similar behaviour with the > maven-project-info-reports-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543482#comment-17543482 ] Hudson commented on MSHARED-831: Build succeeded in Jenkins: Maven » Maven TLP » maven-site » master #67 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site/job/master/67/ > Configuration in reporting section not taken into account when running from > cli > --- > > Key: MSHARED-831 > URL: https://issues.apache.org/jira/browse/MSHARED-831 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl 3.0 >Reporter: Hans Aikema >Assignee: Michael Osipov >Priority: Major > Fix For: waiting-for-feedback > > > Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444] > my conclusion is that plugin configuration using the reporting section does > not work as documented on > [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag] > When configuring the plugin using the reporting section of the pom the > configuration is not applied when calling the plugin goal from the CLI > whereas the guide states that it is first looked up there and only when not > found searched for in the build section. > Don't know if this is the intended behaviour of the CLI-invocation of the > plugins (and thus a documentation bug) or an actual bug in the configuration > evaluation, but I spotted similar behaviour with the > maven-project-info-reports-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543468#comment-17543468 ] Michael Osipov edited comment on MSHARED-831 at 5/28/22 4:38 PM: - I agree with that. Let's update the docs with the reality and move on. was (Author: michael-o): I gree with that. Let's update the docs with the reality and move on. > Configuration in reporting section not taken into account when running from > cli > --- > > Key: MSHARED-831 > URL: https://issues.apache.org/jira/browse/MSHARED-831 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl 3.0 >Reporter: Hans Aikema >Assignee: Michael Osipov >Priority: Major > Fix For: waiting-for-feedback > > > Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444] > my conclusion is that plugin configuration using the reporting section does > not work as documented on > [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag] > When configuring the plugin using the reporting section of the pom the > configuration is not applied when calling the plugin goal from the CLI > whereas the guide states that it is first looked up there and only when not > found searched for in the build section. > Don't know if this is the intended behaviour of the CLI-invocation of the > plugins (and thus a documentation bug) or an actual bug in the configuration > evaluation, but I spotted similar behaviour with the > maven-project-info-reports-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543485#comment-17543485 ] Michael Osipov commented on MSHARED-831: Update looks good to me. > Configuration in reporting section not taken into account when running from > cli > --- > > Key: MSHARED-831 > URL: https://issues.apache.org/jira/browse/MSHARED-831 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl 3.0 >Reporter: Hans Aikema >Assignee: Michael Osipov >Priority: Major > Fix For: waiting-for-feedback > > > Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444] > my conclusion is that plugin configuration using the reporting section does > not work as documented on > [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag] > When configuring the plugin using the reporting section of the pom the > configuration is not applied when calling the plugin goal from the CLI > whereas the guide states that it is first looked up there and only when not > found searched for in the build section. > Don't know if this is the intended behaviour of the CLI-invocation of the > plugins (and thus a documentation bug) or an actual bug in the configuration > evaluation, but I spotted similar behaviour with the > maven-project-info-reports-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-doxia] asfgit merged pull request #100: [DOXIA-650] Make MarkdownParser to be a text parser with text markup
asfgit merged PR #100: URL: https://github.com/apache/maven-doxia/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-650) Make MarkdownParser to be a text parser with text markup
[ https://issues.apache.org/jira/browse/DOXIA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543489#comment-17543489 ] ASF GitHub Bot commented on DOXIA-650: -- asfgit merged PR #100: URL: https://github.com/apache/maven-doxia/pull/100 > Make MarkdownParser to be a text parser with text markup > > > Key: DOXIA-650 > URL: https://issues.apache.org/jira/browse/DOXIA-650 > Project: Maven Doxia > Issue Type: Task > Components: Module - Markdown >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DOXIA-650) Make MarkdownParser to be a text parser with text markup
[ https://issues.apache.org/jira/browse/DOXIA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-650. Resolution: Fixed Fixed with [b0d40921bc90ae1c87177f3e343d7dcff4f9528e|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=b0d40921bc90ae1c87177f3e343d7dcff4f9528e]. > Make MarkdownParser to be a text parser with text markup > > > Key: DOXIA-650 > URL: https://issues.apache.org/jira/browse/DOXIA-650 > Project: Maven Doxia > Issue Type: Task > Components: Module - Markdown >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-doxia] asfgit closed pull request #99: [DOXIA-619] Sink.sectionTitle1() creates instead of
asfgit closed pull request #99: [DOXIA-619] Sink.sectionTitle1() creates instead of URL: https://github.com/apache/maven-doxia/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-619) Sink.sectionTitle1() creates instead of
[
https://issues.apache.org/jira/browse/DOXIA-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543503#comment-17543503
]
ASF GitHub Bot commented on DOXIA-619:
--
asfgit closed pull request #99: [DOXIA-619] Sink.sectionTitle1() creates
instead of
URL: https://github.com/apache/maven-doxia/pull/99
> Sink.sectionTitle1() creates instead of
> -
>
> Key: DOXIA-619
> URL: https://issues.apache.org/jira/browse/DOXIA-619
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Xhtml, Sink API
>Reporter: Bertrand Martin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> h1. Problem
> The below code in a Maven Report plugin:
> {code:java}
> Sink mainSink = getSink();
> mainSink.section1();
> mainSink.sectionTitle1();
> mainSink.text("Release Notes");
> mainSink.sectionTitle1_();
> {code}
> produces this HTML:
> {code:html}
> Release Notes
> {code}
> Expected HTML was {{}} instead of {{}}:
> {code:html}
> Release Notes
> {code}
> As a consequence, documents produced using the *Sink* API in a Maven Report
> plugin do not have any {{}} headings and start directly with {{}},
> which is not recommended for SEO, and most importantly [for
> accessibility|https://www.w3.org/WAI/tutorials/page-structure/headings/].
> h1. Specification
> Fix the mapping of section levels to HTML heading levels in _Xhtml5BaseSink_
> and _XhtmlBaseSink_ (see {{protected void onSectionTitle( int depth,
> SinkEventAttributes attributes )}}).
> Similarly (and this is riskier), update _baseStartTag()_ and _baseEndTag()_
> methods in _Xhtml5BaseParser_ and _XhtmlBaseParser_ classes.
> h1. Doc
> N/A
> h1. Tests
> Add corresponding unit and integration tests. This should not break
> *maven-site-plugin*'s own integration tests.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (DOXIA-619) Sink.sectionTitle1() creates instead of
[
https://issues.apache.org/jira/browse/DOXIA-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed DOXIA-619.
Resolution: Fixed
Fixed with
[87d1ab3979d9df3f6c9af2b2c9bb3baf4152d8b1|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=87d1ab3979d9df3f6c9af2b2c9bb3baf4152d8b1].
> Sink.sectionTitle1() creates instead of
> -
>
> Key: DOXIA-619
> URL: https://issues.apache.org/jira/browse/DOXIA-619
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Xhtml, Sink API
>Reporter: Bertrand Martin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> h1. Problem
> The below code in a Maven Report plugin:
> {code:java}
> Sink mainSink = getSink();
> mainSink.section1();
> mainSink.sectionTitle1();
> mainSink.text("Release Notes");
> mainSink.sectionTitle1_();
> {code}
> produces this HTML:
> {code:html}
> Release Notes
> {code}
> Expected HTML was {{}} instead of {{}}:
> {code:html}
> Release Notes
> {code}
> As a consequence, documents produced using the *Sink* API in a Maven Report
> plugin do not have any {{}} headings and start directly with {{}},
> which is not recommended for SEO, and most importantly [for
> accessibility|https://www.w3.org/WAI/tutorials/page-structure/headings/].
> h1. Specification
> Fix the mapping of section levels to HTML heading levels in _Xhtml5BaseSink_
> and _XhtmlBaseSink_ (see {{protected void onSectionTitle( int depth,
> SinkEventAttributes attributes )}}).
> Similarly (and this is riskier), update _baseStartTag()_ and _baseEndTag()_
> methods in _Xhtml5BaseParser_ and _XhtmlBaseParser_ classes.
> h1. Doc
> N/A
> h1. Tests
> Add corresponding unit and integration tests. This should not break
> *maven-site-plugin*'s own integration tests.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-doxia] michael-o opened a new pull request, #101: [DOXIA-651] Upgrade Flexmark to 0.50.50
michael-o opened a new pull request, #101: URL: https://github.com/apache/maven-doxia/pull/101 This closes #101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-651) Upgrade Flexmark to 0.50.50
[ https://issues.apache.org/jira/browse/DOXIA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543507#comment-17543507 ] ASF GitHub Bot commented on DOXIA-651: -- michael-o opened a new pull request, #101: URL: https://github.com/apache/maven-doxia/pull/101 This closes #101 > Upgrade Flexmark to 0.50.50 > --- > > Key: DOXIA-651 > URL: https://issues.apache.org/jira/browse/DOXIA-651 > Project: Maven Doxia > Issue Type: Dependency upgrade > Components: Module - Markdown >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M3 > > > Changed classes: > https://github.com/vsch/flexmark-java/blob/master/assets/migrations/migrate%20flexmark-java%200_42_x%20to%200_50_0.xml -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests
Tamás Cservenák created MRESOLVER-262: - Summary: Provide contextual data in trace data for collector invoked requests Key: MRESOLVER-262 URL: https://issues.apache.org/jira/browse/MRESOLVER-262 Project: Maven Resolver Issue Type: Task Components: Resolver Reporter: Tamás Cservenák Fix For: 1.8.1 During collection several RepositoryEvents are fired, but they does not carry any context related data regarding artifact collection. Simplest solution would be to extend RequestTrace to provide: * request context * the artifact path (from root to leaf) * leaf artifact being collected -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (DOXIA-652) Drop build-info,properties in favor of default pom.properties
Michael Osipov created DOXIA-652: Summary: Drop build-info,properties in favor of default pom.properties Key: DOXIA-652 URL: https://issues.apache.org/jira/browse/DOXIA-652 Project: Maven Doxia Issue Type: Task Components: Core Affects Versions: 2.0.0-M2 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 2.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DOXIA-652) Drop build-info.properties in favor of default pom.properties
[ https://issues.apache.org/jira/browse/DOXIA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-652: - Summary: Drop build-info.properties in favor of default pom.properties (was: Drop build-info,properties in favor of default pom.properties) > Drop build-info.properties in favor of default pom.properties > - > > Key: DOXIA-652 > URL: https://issues.apache.org/jira/browse/DOXIA-652 > Project: Maven Doxia > Issue Type: Task > Components: Core >Affects Versions: 2.0.0-M2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-doxia] michael-o opened a new pull request, #102: [DOXIA-652] Drop build-info.properties in favor of default pom.proper…
michael-o opened a new pull request, #102: URL: https://github.com/apache/maven-doxia/pull/102 …ties Remove corresponding test because properties are only available in the JAR after the tests have been run. This closes #102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-652) Drop build-info.properties in favor of default pom.properties
[ https://issues.apache.org/jira/browse/DOXIA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543509#comment-17543509 ] ASF GitHub Bot commented on DOXIA-652: -- michael-o opened a new pull request, #102: URL: https://github.com/apache/maven-doxia/pull/102 …ties Remove corresponding test because properties are only available in the JAR after the tests have been run. This closes #102 > Drop build-info.properties in favor of default pom.properties > - > > Key: DOXIA-652 > URL: https://issues.apache.org/jira/browse/DOXIA-652 > Project: Maven Doxia > Issue Type: Task > Components: Core >Affects Versions: 2.0.0-M2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect
michael-o commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884173911
##
maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,113 @@
+package org.apache.maven.resolver.examples.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A demo class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ */
+public class ReverseTreeRepositoryListener
+extends AbstractRepositoryListener
+{
+@Override
+public void artifactResolved( RepositoryEvent event )
+{
+requireNonNull( event, "event cannot be null" );
+
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
+while ( trace != null )
+{
+if ( trace.getData() instanceof CollectStepData )
+{
+collectStepTrace = (CollectStepData) trace.getData();
+break;
+}
+trace = trace.getParent();
+}
+
+if ( collectStepTrace == null )
+{
+return;
+}
+
+Artifact resolvedArtifact = event.getArtifact();
+Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
+
+if ( isInScope( resolvedArtifact, nodeArtifact ) )
+{
+Dependency node = collectStepTrace.getNode();
+String trackingData = node.toString() + " (" +
collectStepTrace.getContext() + ")\n";
Review Comment:
`toString()` is redudant
##
maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,113 @@
+package org.apache.maven.resolver.examples.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A demo class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ */
+public class ReverseTreeRepositoryListener
+extends AbstractRepositoryListener
[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests
[
https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543530#comment-17543530
]
ASF GitHub Bot commented on MRESOLVER-262:
--
michael-o commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884173911
##
maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,113 @@
+package org.apache.maven.resolver.examples.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A demo class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ */
+public class ReverseTreeRepositoryListener
+extends AbstractRepositoryListener
+{
+@Override
+public void artifactResolved( RepositoryEvent event )
+{
+requireNonNull( event, "event cannot be null" );
+
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
+while ( trace != null )
+{
+if ( trace.getData() instanceof CollectStepData )
+{
+collectStepTrace = (CollectStepData) trace.getData();
+break;
+}
+trace = trace.getParent();
+}
+
+if ( collectStepTrace == null )
+{
+return;
+}
+
+Artifact resolvedArtifact = event.getArtifact();
+Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
+
+if ( isInScope( resolvedArtifact, nodeArtifact ) )
+{
+Dependency node = collectStepTrace.getNode();
+String trackingData = node.toString() + " (" +
collectStepTrace.getContext() + ")\n";
Review Comment:
`toString()` is redudant
##
maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,113 @@
+package org.apache.maven.resolver.examples.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+import static java.util.Objects.requi
[GitHub] [maven-release] hboutemy commented on pull request #130: scm tag is added to child module
hboutemy commented on PR #130: URL: https://github.com/apache/maven-release/pull/130#issuecomment-1140327553 merged only the fix commit https://github.com/apache/maven-release/commit/6da9fbe80d983d640dcc64604915d68bde6d60d3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] hboutemy closed pull request #130: scm tag is added to child module
hboutemy closed pull request #130: scm tag is added to child module URL: https://github.com/apache/maven-release/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRELEASE-1079) scm tag is added to child module
[ https://issues.apache.org/jira/browse/MRELEASE-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MRELEASE-1079. --- Assignee: Herve Boutemy (was: Karl Heinz Marbaise) Resolution: Fixed issue fixed in https://github.com/apache/maven-release/commit/6da9fbe80d983d640dcc64604915d68bde6d60d3 > scm tag is added to child module > > > Key: MRELEASE-1079 > URL: https://issues.apache.org/jira/browse/MRELEASE-1079 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare >Affects Versions: 3.0.0-M5 >Reporter: Markus Schäfer >Assignee: Herve Boutemy >Priority: Critical > Fix For: 3.0.0-M6 > > > With Version 3.0.0-M5 child modules gets an scm tag during the prepare step > when there is more than one module level. > The Bug seems to be in RewritePomsForReleasePhase. > RewritePomsForDevelopmentPhase removes the scm tag. Only the tagged release > has these scm tags. > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRELEASE-998) Add ability to create custom phases
[ https://issues.apache.org/jira/browse/MRELEASE-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543541#comment-17543541 ] Hudson commented on MRELEASE-998: - Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #44 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/44/ > Add ability to create custom phases > --- > > Key: MRELEASE-998 > URL: https://issues.apache.org/jira/browse/MRELEASE-998 > Project: Maven Release Plugin > Issue Type: New Feature >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Major > Fix For: 3.0.0-M1 > > > With the implementation of strategies it should also be possible to create > custom phases. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRELEASE-1079) scm tag is added to child module
[ https://issues.apache.org/jira/browse/MRELEASE-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543540#comment-17543540 ] Hudson commented on MRELEASE-1079: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #44 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/44/ > scm tag is added to child module > > > Key: MRELEASE-1079 > URL: https://issues.apache.org/jira/browse/MRELEASE-1079 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare >Affects Versions: 3.0.0-M5 >Reporter: Markus Schäfer >Assignee: Herve Boutemy >Priority: Critical > Fix For: 3.0.0-M6 > > > With Version 3.0.0-M5 child modules gets an scm tag during the prepare step > when there is more than one module level. > The Bug seems to be in RewritePomsForReleasePhase. > RewritePomsForDevelopmentPhase removes the scm tag. Only the tagged release > has these scm tags. > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DOXIASITETOOLS-230) Upgrade to Velocity Engine 2.3 and Velocity Tools 3.1
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIASITETOOLS-230. - Resolution: Fixed Fixed with [423a4106c9eaea8045709800d1bbb0cc1089fda8|https://gitbox.apache.org/repos/asf?p=maven-doxia-sitetools.git;a=commit;h=423a4106c9eaea8045709800d1bbb0cc1089fda8]. > Upgrade to Velocity Engine 2.3 and Velocity Tools 3.1 > - > > Key: DOXIASITETOOLS-230 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-230 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M3 > > > upgrade Velocity Engine: > - from 1.7: https://velocity.apache.org/engine/1.7/ > - to current latest 2.3: https://velocity.apache.org/engine/2.3/ > and Velocity Tools: > - from 2.0: https://velocity.apache.org/tools/2.0/ > - to current latest 3.1: https://velocity.apache.org/tools/3.1/ > see upgrade documentation https://velocity.apache.org/tools/3.1/upgrading.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-doxia-sitetools] asfgit closed pull request #42: [DOXIASITETOOLS-230] Upgrade to Velocity Engine 2.3 and Velocity Tool…
asfgit closed pull request #42: [DOXIASITETOOLS-230] Upgrade to Velocity Engine 2.3 and Velocity Tool… URL: https://github.com/apache/maven-doxia-sitetools/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DOXIASITETOOLS-256) Upgrade to Doxia 2.0.0-M3
Michael Osipov created DOXIASITETOOLS-256: - Summary: Upgrade to Doxia 2.0.0-M3 Key: DOXIASITETOOLS-256 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-256 Project: Maven Doxia Sitetools Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 2.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543543#comment-17543543 ] Michael Osipov commented on MSHARED-831: [~hboutemy], shall we close this now as wontfix? > Configuration in reporting section not taken into account when running from > cli > --- > > Key: MSHARED-831 > URL: https://issues.apache.org/jira/browse/MSHARED-831 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-reporting-impl >Affects Versions: maven-reporting-impl 3.0 >Reporter: Hans Aikema >Assignee: Michael Osipov >Priority: Major > Fix For: waiting-for-feedback > > > Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444] > my conclusion is that plugin configuration using the reporting section does > not work as documented on > [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag] > When configuring the plugin using the reporting section of the pom the > configuration is not applied when calling the plugin goal from the CLI > whereas the guide states that it is first looked up there and only when not > found searched for in the build section. > Don't know if this is the intended behaviour of the CLI-invocation of the > plugins (and thus a documentation bug) or an actual bug in the configuration > evaluation, but I spotted similar behaviour with the > maven-project-info-reports-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSHARED-1045) MSHARED-1024 breaks binary backwards compatibility
[
https://issues.apache.org/jira/browse/MSHARED-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543546#comment-17543546
]
Michael Osipov commented on MSHARED-1045:
-
Please report upstream.
> MSHARED-1024 breaks binary backwards compatibility
> --
>
> Key: MSHARED-1045
> URL: https://issues.apache.org/jira/browse/MSHARED-1045
> Project: Maven Shared Components
> Issue Type: Bug
>Reporter: Andrei Silviu Dragnea
>Assignee: Michael Osipov
>Priority: Major
>
> [https://github.com/apache/maven-reporting-api/pull/2] breaks binary
> backwards compatibility of interface `MavenReport`, because replacing
> `org.codehaus.doxia.sink.Sink` with `org.apache.maven.doxia.sink.Sink`
> changes the signature of method:
> {code:java}
> void generate( Sink sink, Locale locale ) throws MavenReportException;{code}
> So nothing compiled against version `3.0` of the `maven-reporting-api` works
> with `3.1.0` anymore.
> I suggest either reverting this commit in a new release or updating the code
> in a backwards-compatible manner with two mutually recursive default
> implementations for both the old and new signature (this requires Java 8
> support though):
>
> {code:java}
> @Deprecated
> default void generate( org.codehaus.doxia.sink.Sink sink, Locale locale )
> throws MavenReportException {
> generate((Sink) sink, locale);
> }
> default void generate( Sink sink, Locale locale ) throws MavenReportException
> {
> generate((org.codehaus.doxia.sink.Sink) sink, locale);
> } {code}
> The solution above can result in `ClassCastException`s though, because some
> `org.apache.maven.doxia.sink.Sink` maybe do not implement
> `org.codehaus.doxia.sink`. I do not know any way of safely evolving the type
> of an input parameter for a method.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven] gnodet commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages
gnodet commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884189028
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
Review Comment:
Sounds good.
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
Review Comment:
Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages
[
https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543552#comment-17543552
]
ASF GitHub Bot commented on MNG-7486:
-
gnodet commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884189028
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
Review Comment:
Sounds good.
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
Review Comment:
Sounds good to me.
> Create a multiline message helper for boxed log messages
>
>
> Key: MNG-7486
> URL: https://issues.apache.org/jira/browse/MNG-7486
> Project: Maven
> Issue Type: New Feature
>Reporter: Michael Osipov
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Simplify the way how boxed messages, e.g., for non-threadsafe plugins is
> created.
--
This message was sent by Atlassian Jira
[GitHub] [maven] gnodet commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages
gnodet commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884189390
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
+for ( String word : words )
+{
+if ( sb.length() >= rem - word.length() - ( sb.length() > 0 ?
1 : 0 ) )
Review Comment:
I don't think so. We loop over words and each one is appended, eventually
starting a new line if the current line does not have enough space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages
[
https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543553#comment-17543553
]
ASF GitHub Bot commented on MNG-7486:
-
gnodet commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884189390
##
maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java:
##
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format multiline messages to the console
+ */
+public class MultilineMessageHelper
+{
+
+private static final int DEFAULT_MAX_SIZE = 65;
+private static final char BOX_CHAR = '*';
+
+public static String separatorLine()
+{
+StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+repeat( sb, '*', DEFAULT_MAX_SIZE );
+return sb.toString();
+}
+
+public static List format( String... lines )
+{
+int size = DEFAULT_MAX_SIZE;
+int rem = size - 4; // 4 chars = 2 box_char + 2 spaces
+List result = new ArrayList<>();
+StringBuilder sb = new StringBuilder( size );
+// first line
+sb.setLength( 0 );
+repeat( sb, BOX_CHAR, size );
+result.add( sb.toString() );
+// lines
+for ( String line : lines )
+{
+sb.setLength( 0 );
+String[] words = line.split( " " );
+for ( String word : words )
+{
+if ( sb.length() >= rem - word.length() - ( sb.length() > 0 ?
1 : 0 ) )
Review Comment:
I don't think so. We loop over words and each one is appended, eventually
starting a new line if the current line does not have enough space.
> Create a multiline message helper for boxed log messages
>
>
> Key: MNG-7486
> URL: https://issues.apache.org/jira/browse/MNG-7486
> Project: Maven
> Issue Type: New Feature
>Reporter: Michael Osipov
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Simplify the way how boxed messages, e.g., for non-threadsafe plugins is
> created.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MJAVADOC-707) Plugin won't work if Automatic-Module-Name is used
[ https://issues.apache.org/jira/browse/MJAVADOC-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543556#comment-17543556 ] Daniel Huss commented on MJAVADOC-707: -- For people who stumble upon this issue: * You might've searched for the following error message, so I'll just paste the keywords: Maven Javadoc Plugin Unable to derive module descriptor * As a temporary workaround, try relocating the maven-javadoc-plugin execution to the "process-classes" phase, while also relocating the execution of whatever-sets-the-manifest-entry (in my case: maven-bundle-plugin) to a later phase such as "prepare-package" :-/ > Plugin won't work if Automatic-Module-Name is used > -- > > Key: MJAVADOC-707 > URL: https://issues.apache.org/jira/browse/MJAVADOC-707 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.3.1, 3.3.2, 3.4.0 >Reporter: Christopher Tubbs >Priority: Critical > > Using Automatic-Module-Name in a manifest (an intermediate step to help > transition to using modules) prevents this plugin from adding the necessary > dependencies to the class path, so it can build javadocs. > maven-compiler-plugin seems to work fine, as does surefire and all the others > when Automatic-Module-Name entries appear in a project's jar manifests. > However, this plugin, as of 3.3.1, still does not work correctly with these. > Instead of using the traditional class path, this plugin seems to force > treating the project as a module, even though it does not have any > module-info.java files, and most of its dependencies have not transitioned to > using modules. > Here's a pull request that demonstrates adding the Automatic-Module-Name to > the manifest for a multi-module (Maven module) project, that fails on the > javadoc plugin: > https://github.com/apache/accumulo/pull/2498 ; both javadoc:aggregate and > javadoc:jar are known to fail. I did not test with any other mojos. > Not supporting this feature holds all projects back from being able to > transition to modules over time. > http://branchandbound.net/blog/java/2017/12/automatic-module-name/ > https://docs.oracle.com/javase/9/docs/api/java/lang/module/ModuleFinder.html#automatic-modules -- This message was sent by Atlassian Jira (v8.20.7#820007)
