[
https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543469#comment-17543469
]
ASF GitHub Bot commented on DOXIA-590:
--------------------------------------
michael-o commented on PR #98:
URL: https://github.com/apache/maven-doxia/pull/98#issuecomment-1140273753
> I don't understand anything, sorry: what is the issue? what does the code
change (apart from order in attributes)?
One of the basic problems is that you cannot provide a CSS class attribute
from outside because it is overridden so you cannot customize. It is not
merged, but simply wiped out. This problem existed now for a very long time, I
knew that, but this is the first issue regarding this.
Stupid simple:
https://github.com/apache/maven-doxia/blob/c098cc9972b13c761091e66a57261e89195a9271/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L1533-L1544
You pass the attribute set, but your potential, custom `CLASS` is dropped in
any case.
> Either provided element class or default class gets ignored
> -----------------------------------------------------------
>
> Key: DOXIA-590
> URL: https://issues.apache.org/jira/browse/DOXIA-590
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.8
> Reporter: Fred Eckertson
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0-M3, 1.11.2
>
> Attachments: image-2022-05-18-21-57-40-619.png
>
>
> The following construct is somewhat common in doxia-core
> att.addAttribute( Attribute.CLASS, "a" );
> The documentation says that basic attributes (including CLASS) are supported.
> However in cases like this either that "a" or the CLASS that was provided in
> the attributes parameter will be ignored. The correct way to do this is to
> append the provided CLASS to "a " if a CLASS attribute was provided.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
