michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884141711


##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##########
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession 
session, MavenProject p
             final Set<Plugin> unsafePlugins = 
executionPlan.getNonThreadSafePlugins();
             if ( !unsafePlugins.isEmpty() )
             {
-                logger.warn( 
"*****************************************************************" );
-                logger.warn( "* Your build is requesting parallel execution, 
but project      *" );
-                logger.warn( "* contains the following plugin(s) that have 
goals not marked   *" );
-                logger.warn( "* as @threadSafe to support parallel building.   
               *" );
-                logger.warn( "* While this /may/ work fine, please look for 
plugin updates    *" );
-                logger.warn( "* and/or request plugins be made thread-safe.    
               *" );
-                logger.warn( "* If reporting an issue, report it against the 
plugin in        *" );
-                logger.warn( "* question, not against maven-core               
               *" );
-                logger.warn( 
"*****************************************************************" );
+                for ( String s : MultilineMessageHelper.format(
+                        "Your build is requesting parallel execution, but this 
project contains the following "
+                                + "plugin(s) that have goals not marked as 
@threadSafe to support parallel execution.",

Review Comment:
   That is true, the Javadoc tag is gone and we don't have a separate Java 
annotation for "thread-safe". You proposal is correct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to