michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884142181
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##########
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set<Plugin> unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
- logger.warn(
"*****************************************************************" );
- logger.warn( "* Your build is requesting parallel execution,
but project *" );
- logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
- logger.warn( "* as @threadSafe to support parallel building.
*" );
- logger.warn( "* While this /may/ work fine, please look for
plugin updates *" );
- logger.warn( "* and/or request plugins be made thread-safe.
*" );
- logger.warn( "* If reporting an issue, report it against the
plugin in *" );
- logger.warn( "* question, not against maven-core
*" );
- logger.warn(
"*****************************************************************" );
+ for ( String s : MultilineMessageHelper.format(
+ "Your build is requesting parallel execution, but this
project contains the following "
+ + "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
+ "While this /may/ work fine, please look for plugin
updates and/or "
+ + "request plugins be made thread-safe.",
+ "If reporting an issue, report it against the plugin
in question, not against Apache Maven." ) )
+ {
+ logger.warn( s );
+ }
if ( logger.isDebugEnabled() )
{
final Set<MojoDescriptor> unsafeGoals =
executionPlan.getNonThreadSafeMojos();
- logger.warn( "The following goals are not marked
@threadSafe in " + project.getName() + ":" );
+ logger.warn( "The following goals are not marked as
@threadSafe in " + project.getName() + ":" );
for ( MojoDescriptor unsafeGoal : unsafeGoals )
{
- logger.warn( unsafeGoal.getId() );
+ logger.warn( " " + unsafeGoal.getId() );
}
}
else
{
- logger.warn( "The following plugins are not marked
@threadSafe in " + project.getName() + ":" );
+ logger.warn( "The following plugins are not marked as
@threadSafe in " + project.getName() + ":" );
for ( Plugin unsafePlugin : unsafePlugins )
{
- logger.warn( unsafePlugin.getId() );
+ logger.warn( " " + unsafePlugin.getId() );
}
- logger.warn( "Enable verbose output (-X) to see more
precisely which goals are not marked"
+ logger.warn( "" );
+ logger.warn( "Enable verbose output (-X) to see precisely
which goals are not marked as"
+ " @threadSafe." );
Review Comment:
Done.
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##########
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set<Plugin> unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
- logger.warn(
"*****************************************************************" );
- logger.warn( "* Your build is requesting parallel execution,
but project *" );
- logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
- logger.warn( "* as @threadSafe to support parallel building.
*" );
- logger.warn( "* While this /may/ work fine, please look for
plugin updates *" );
- logger.warn( "* and/or request plugins be made thread-safe.
*" );
- logger.warn( "* If reporting an issue, report it against the
plugin in *" );
- logger.warn( "* question, not against maven-core
*" );
- logger.warn(
"*****************************************************************" );
+ for ( String s : MultilineMessageHelper.format(
+ "Your build is requesting parallel execution, but this
project contains the following "
+ + "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
+ "While this /may/ work fine, please look for plugin
updates and/or "
+ + "request plugins be made thread-safe.",
+ "If reporting an issue, report it against the plugin
in question, not against Apache Maven." ) )
+ {
+ logger.warn( s );
+ }
if ( logger.isDebugEnabled() )
{
final Set<MojoDescriptor> unsafeGoals =
executionPlan.getNonThreadSafeMojos();
- logger.warn( "The following goals are not marked
@threadSafe in " + project.getName() + ":" );
+ logger.warn( "The following goals are not marked as
@threadSafe in " + project.getName() + ":" );
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
