[
https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543472#comment-17543472
]
ASF GitHub Bot commented on MNG-7486:
-------------------------------------
michael-o commented on code in PR #746:
URL: https://github.com/apache/maven/pull/746#discussion_r884141711
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
##########
@@ -141,35 +142,36 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
final Set<Plugin> unsafePlugins =
executionPlan.getNonThreadSafePlugins();
if ( !unsafePlugins.isEmpty() )
{
- logger.warn(
"*****************************************************************" );
- logger.warn( "* Your build is requesting parallel execution,
but project *" );
- logger.warn( "* contains the following plugin(s) that have
goals not marked *" );
- logger.warn( "* as @threadSafe to support parallel building.
*" );
- logger.warn( "* While this /may/ work fine, please look for
plugin updates *" );
- logger.warn( "* and/or request plugins be made thread-safe.
*" );
- logger.warn( "* If reporting an issue, report it against the
plugin in *" );
- logger.warn( "* question, not against maven-core
*" );
- logger.warn(
"*****************************************************************" );
+ for ( String s : MultilineMessageHelper.format(
+ "Your build is requesting parallel execution, but this
project contains the following "
+ + "plugin(s) that have goals not marked as
@threadSafe to support parallel execution.",
Review Comment:
That is true, the Javadoc tag is gone and we don't have a separate Java
annotation for "thread-safe". You proposal is correct.
> Create a multiline message helper for boxed log messages
> --------------------------------------------------------
>
> Key: MNG-7486
> URL: https://issues.apache.org/jira/browse/MNG-7486
> Project: Maven
> Issue Type: New Feature
> Reporter: Michael Osipov
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Simplify the way how boxed messages, e.g., for non-threadsafe plugins is
> created.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
