[GitHub] geode pull request #429: Geode-2686

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/429#discussion_r107192442
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
 ---
@@ -67,18 +68,16 @@ public static void 
deployJarsReceivedFromClusterConfiguration(Cache cache,
 String[] jarFileNames = response.getJarNames();
 byte[][] jarBytes = response.getJars();
 
-final JarDeployer jarDeployer = new JarDeployer(
-((GemFireCacheImpl) 
cache).getDistributedSystem().getConfig().getDeployWorkingDir());
-
 /**
  * Un-deploy the existing jars, deployed during cache creation, do not 
delete anything
  */
 
 if (jarFileNames != null && jarBytes != null) {
-  JarClassLoader[] jarClassLoaders = jarDeployer.deploy(jarFileNames, 
jarBytes);
+  List jarClassLoaders =
+  
ClassPathLoader.getLatest().getJarDeployer().deploy(jarFileNames, jarBytes);
   for (int i = 0; i < jarFileNames.length; i++) {
-if (jarClassLoaders[i] != null) {
-  logger.info("Deployed " + 
(jarClassLoaders[i].getFileCanonicalPath()));
+if (jarClassLoaders.get(i) != null) {
--- End diff --

This loop is just printing the jars that got deployed from 
ClusterConfiguration on member startup.  If another thread deploys a jar in the 
middle of this loop, this list won't be updated to  include that jar.  But I 
believe that is the desired behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #429: Geode-2686

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/429#discussion_r107192575
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
 ---
@@ -39,83 +44,63 @@
   @Rule
   public TemporaryFolder temporaryFolder = new TemporaryFolder();
 
-  @Rule
-  public RestoreSystemProperties restoreSystemProperties = new 
RestoreSystemProperties();
+  JarDeployer jarDeployer;
 
   @Before
   public void setup() {
-System.setProperty("user.dir", 
temporaryFolder.getRoot().getAbsolutePath());
 classBuilder = new ClassBuilder();
-ClassPathLoader.setLatestToDefault();
+jarDeployer = new JarDeployer(temporaryFolder.getRoot());
   }
 
-  @Test
-  public void testDeployFileAndChange() throws Exception {
-final JarDeployer jarDeployer = new JarDeployer();
+  private byte[] createJarWithClass(String className) throws IOException {
+String stringBuilder = "package integration.parent;" + "public class " 
+ className + " {}";
 
-// First deploy of the JAR file
-byte[] jarBytes = this.classBuilder.createJarFromName("ClassA");
-JarClassLoader jarClassLoader =
-jarDeployer.deploy(new String[] {"JarDeployerDUnit.jar"}, new 
byte[][] {jarBytes})[0];
-File deployedJar = new File(jarClassLoader.getFileCanonicalPath());
+return 
this.classBuilder.createJarFromClassContent("integration/parent/" + className,
+stringBuilder);
+  }
 
-assertThat(deployedJar).exists();
-assertThat(deployedJar.getName()).contains("#1");
-assertThat(deployedJar.getName()).doesNotContain("#2");
+  @Test
+  public void testFileVersioning() throws IOException, 
ClassNotFoundException {
+String jarName = "JarDeployerIntegrationTest.jar";
 
-assertThat(ClassPathLoader.getLatest().forName("ClassA")).isNotNull();
+byte[] firstJarBytes = createJarWithClass("ClassA");
 
-assertThat(doesFileMatchBytes(deployedJar, jarBytes));
+// First deploy of the JAR file
+DeployedJar firstDeployedJar = 
jarDeployer.deployWithoutRegistering(jarName, firstJarBytes);
 
-// Now deploy an updated JAR file and make sure that the next version 
of the JAR file
-// was created and the first one was deleted.
-jarBytes = this.classBuilder.createJarFromName("ClassB");
-JarClassLoader newJarClassLoader =
-jarDeployer.deploy(new String[] {"JarDeployerDUnit.jar"}, new 
byte[][] {jarBytes})[0];
-File nextDeployedJar = new 
File(newJarClassLoader.getFileCanonicalPath());
+
assertThat(firstDeployedJar.getFile()).exists().hasBinaryContent(firstJarBytes);
+
assertThat(firstDeployedJar.getFile().getName()).contains(".v1.").doesNotContain(".v2.");
 
-assertThat(nextDeployedJar.exists());
-assertThat(nextDeployedJar.getName()).contains("#2");
-assertThat(doesFileMatchBytes(nextDeployedJar, jarBytes));
+// Now deploy an updated JAR file and make sure that the next version 
of the JAR file
+// was created
+byte[] secondJarBytes = createJarWithClass("ClassB");
 
-assertThat(ClassPathLoader.getLatest().forName("ClassB")).isNotNull();
+DeployedJar secondDeployedJar = 
jarDeployer.deployWithoutRegistering(jarName, secondJarBytes);
+File secondDeployedJarFile = new 
File(secondDeployedJar.getFileCanonicalPath());
 
-assertThatThrownBy(() -> ClassPathLoader.getLatest().forName("ClassA"))
-.isExactlyInstanceOf(ClassNotFoundException.class);
+
assertThat(secondDeployedJarFile).exists().hasBinaryContent(secondJarBytes);
+
assertThat(secondDeployedJarFile.getName()).contains(".v2.").doesNotContain(".v1.");
 
-
assertThat(jarDeployer.findSortedOldVersionsOfJar("JarDeployerDUnit.jar")).hasSize(1);
+File[] sortedOldJars = jarDeployer.findSortedOldVersionsOfJar(jarName);
+assertThat(sortedOldJars).hasSize(2);
+assertThat(sortedOldJars[0].getName()).contains(".v2.");
+assertThat(sortedOldJars[1].getName()).contains(".v1.");
 assertThat(jarDeployer.findDistinctDeployedJars()).hasSize(1);
   }
 
   @Test
-  public void testDeployNoUpdateWhenNoChange() throws Exception {
-final JarDeployer jarDeployer = new JarDeployer();
-
-// First deploy of the JAR file
-byte[] jarBytes = 
this.classBuilder.createJarFromName("JarDeployerDUnitDNUWNC");
-JarClassLoader jarClassLoader =
-jarDeployer.deploy(new String[] {"JarDeployerDUnit2.jar"}, new 
byte[][] {jarBytes})[0];
-File deployedJar = new File(jarClassLoader.getFileCanonicalPath());
-
-assertThat(deployedJar).exists();
-assertThat(deployedJar.getName()).contains("#1");
-JarClassL

[GitHub] geode pull request #429: Geode-2686

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/429#discussion_r107194282
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
 ---
@@ -126,14 +111,16 @@ public void testDeployToInvalidDirectory() throws 
IOException, ClassNotFoundExce
   public void run() {
 try {
   barrier.await();
-} catch (Exception e) {
-  fail(e);
+} catch (InterruptedException iex) {
--- End diff --

This wasn't a test I wrote, it's been around for awhile.  I pulled it out 
of a DUnit into this class in 917dfa0.  It wasn't actually clear to me what the 
author was trying to test here, so I left it around intending to come back to 
it later.  Do you have any idea of what the author was trying to test?  The 
name of the test (testDeployToInvalidDirectory) seems unrelated to Concurrency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #429: Geode-2686

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/429#discussion_r107195612
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderTest.java ---
@@ -65,6 +65,26 @@ public void testLatestExists() throws Exception {
 assertNotNull(ClassPathLoader.getLatest());
   }
 
+  @Test
+  public void testZeroLengthFile() throws IOException, 
ClassNotFoundException {
+try {
+  ClassPathLoader.getLatest().getJarDeployer().deploy(new String[] 
{"JarDeployerDUnitZLF.jar"},
+  new byte[][] {new byte[0]});
+  fail("Zero length files are not deployable");
+} catch (IllegalArgumentException expected) {
--- End diff --

I'll clean this up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #429: Geode-2686

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/429#discussion_r107195082
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
 ---
@@ -144,40 +131,99 @@ public void run() {
   Thread.sleep(500);
   alternateDir.mkdir();
   thread.join();
-} catch (Exception e) {
-  fail(e);
+} catch (InterruptedException iex) {
+  fail("Interrupted while waiting.");
--- End diff --

I made sure to avoid this antipattern in the tests I added, but I had left 
some old tests around unchanged.  I'll go back and clean them up today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #783

[Apache Jenkins Server]

See 


Changes:

[jstewart] GEODE-2692: Fix tests relying on file creation time

[huynhja] GEODE-2679: Lucene asynchronous disk writes for aeq can lead to data

[upthewaterspout] GEODE-688: Changing 1 second pause to a wait in 
AsyncEventListenerDUnit

[jiliao] GEODE-2634: use log4j levels for auto-completion

--
[...truncated 99.91 KB...]

org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest > 
testSystemClientEventsInServer FAILED
org.junit.ComparisonFailure: 
expected:<[67.195.81.148](13093):3277...> but 
was:<[asf904](13093):3277...>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.doTestSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:946)
at 
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:731)

6835 tests completed, 1 failed, 606 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaC

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/
---

(Updated March 21, 2017, 9:35 a.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
embedded pulse server still tries to connect to jmx using 1099


Diffs
-

  geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
  
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
 57711258fbbc73570656e14ee8f05550ae32e891 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
 5408a5651774a63c16f27722c6ff7bda25cbaaa8 
  geode-pulse/src/main/resources/pulse.properties 
878bc680bbcc4369eb2d3859c6377b8942bc89d7 


Diff: https://reviews.apache.org/r/57796/diff/1/


Testing (updated)
---

precheckin successful


Thanks,

Kevin Duling

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934918#comment-15934918
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit bb33fc085b9b977c72e348a071aaa61367932d18 in geode-native's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=bb33fc0 ]

GEODE-2513 Unbrand geode-native docs: Continuous Query
This closes #64


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #429: Geode-2686

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/429#discussion_r107221701
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
 ---
@@ -126,14 +111,16 @@ public void testDeployToInvalidDirectory() throws 
IOException, ClassNotFoundExce
   public void run() {
 try {
   barrier.await();
-} catch (Exception e) {
-  fail(e);
+} catch (InterruptedException iex) {
--- End diff --

Do you have an idea for how to avoid this line?

```
Thread.sleep(500) you have commented with `//don't ever do this
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169587
---




geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
Lines 72 (patched)


I would hope we shouldn't need to manully set this in the test.



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
Lines 159 (patched)


Is this system proeprty set manually or by the locator/server when starting 
up the pulse service?



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
Lines 160 (patched)


Which StringUtils is this? I believe we can use apache common's 
StringUtils.isBlank to do this.



geode-pulse/src/main/resources/pulse.properties
Line 28 (original)


I don't think we need to change this. This property file is only used when 
pulse is not in the embedded mode.


- Jinmei Liao


On March 21, 2017, 4:35 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 4:35 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

[GitHub] geode issue #429: Geode-2686

[jinmeiliao]

Github user jinmeiliao commented on the issue:

https://github.com/apache/geode/pull/429
  
It would be a good idea to do a walkthrough of these changes for us to 
understand the major change points. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934984#comment-15934984
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/65

GEODE-2513 Unbrand section on Remote Querying

- Corrected typos along the way
- Added prose to identify when links take the reader to
the Geode manual

@davebarnes97 @joeymcallister @echobravopapa @PivotalSarge @dgkimura 
@mmartell @mhansonp Please review this PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513-11

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #65


commit 26d8541264032ed30e21790fb4200b8479687bcd
Author: Karen Miller 
Date:   2017-03-21T17:47:06Z

GEODE-2513 Unbrand section on Remote Querying

- Corrected typos along the way
- Added prose to identify when links take the reader to
the Geode manual




> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #65: GEODE-2513 Unbrand section on Remote Querying

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/65

GEODE-2513 Unbrand section on Remote Querying

- Corrected typos along the way
- Added prose to identify when links take the reader to
the Geode manual

@davebarnes97 @joeymcallister @echobravopapa @PivotalSarge @dgkimura 
@mmartell @mhansonp Please review this PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513-11

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #65


commit 26d8541264032ed30e21790fb4200b8479687bcd
Author: Karen Miller 
Date:   2017-03-21T17:47:06Z

GEODE-2513 Unbrand section on Remote Querying

- Corrected typos along the way
- Added prose to identify when links take the reader to
the Geode manual




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #66: GEODE-2513 Unbranding docs: remove GemFire re...

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/66

GEODE-2513 Unbranding docs: remove GemFire rel notes

Removed the entire directory that would hold release notes from the repo.

@davebarnes97 @joeymcallister @PivotalSarge @echobravopapa @mmartell 
@dgkimura @mhansonp  Please review these simple changes that remove GemFire 
release notes from the docs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513-12

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #66


commit 099f61b5494824f45a06699101c9a87ad5ca5c12
Author: Karen Miller 
Date:   2017-03-21T18:06:45Z

GEODE-2513 Unbranding docs: remove GemFire rel notes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kevin Duling]

> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
> > Lines 72 (patched)
> > 
> >
> > I would hope we shouldn't need to manully set this in the test.

I was hoping not, also, but couldn't find another way to handle this.  None of 
the parameters we are interested in are set in the system properties.  For 
example `jmx-manager-port` is being set in the test, but it is not visible in 
`System.properties` when Pulse starts.


> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 159 (patched)
> > 
> >
> > Is this system proeprty set manually or by the locator/server when 
> > starting up the pulse service?

It is set manually by the test.  Prior to my change, Pulse only read from 
`pulse.properties` off of the classpath to set the `pulse.port` value or used 
the default.


> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 160 (patched)
> > 
> >
> > Which StringUtils is this? I believe we can use apache common's 
> > StringUtils.isBlank to do this.

It is `org.apache.geode.tools.pulse.internal.util.StringUtils` which is already 
used heavily within `PulseAppListener`.  Perhaps another ticket to remove this 
StringUtils in favor of apache commons?


> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-pulse/src/main/resources/pulse.properties
> > Line 28 (original)
> > 
> >
> > I don't think we need to change this. This property file is only used 
> > when pulse is not in the embedded mode.

Please look again at the diff.  I've removed double-declared properties so your 
previous change is read.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169587
---


On March 21, 2017, 9:35 a.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 9:35 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935003#comment-15935003
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/66

GEODE-2513 Unbranding docs: remove GemFire rel notes

Removed the entire directory that would hold release notes from the repo.

@davebarnes97 @joeymcallister @PivotalSarge @echobravopapa @mmartell 
@dgkimura @mhansonp  Please review these simple changes that remove GemFire 
release notes from the docs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513-12

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #66


commit 099f61b5494824f45a06699101c9a87ad5ca5c12
Author: Karen Miller 
Date:   2017-03-21T18:06:45Z

GEODE-2513 Unbranding docs: remove GemFire rel notes




> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Blacklist asf904 for Geode nightly job

[Kirk Lund]

Please blacklist asf904 for the Geode nightly job. It seems to be giving
bad DNS info to our tests, causing UniversalMembershipListenerAdapterDUnitTest
to fail again. Alternatively, if someone else wants to look into the
failures in UniversalMembershipListenerAdapterDUnitTest please go ahead.
I've done all I can for the test.

Thanks,
Kirk

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Jinmei Liao]

> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote:
> > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
> > Lines 72 (patched)
> > 
> >
> > I would hope we shouldn't need to manully set this in the test.
> 
> Kevin Duling wrote:
> I was hoping not, also, but couldn't find another way to handle this.  
> None of the parameters we are interested in are set in the system properties. 
>  For example `jmx-manager-port` is being set in the test, but it is not 
> visible in `System.properties` when Pulse starts.

how is this IsEmbededMode system property set? I would think if we are starting 
pulse in the managementAgent, we should set this system property.


> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 159 (patched)
> > 
> >
> > Is this system proeprty set manually or by the locator/server when 
> > starting up the pulse service?
> 
> Kevin Duling wrote:
> It is set manually by the test.  Prior to my change, Pulse only read from 
> `pulse.properties` off of the classpath to set the `pulse.port` value or used 
> the default.

So when a user starts a locator with jmx-manager-port other than 1099, he still 
would have problem having pulse connect to this locator?


> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 160 (patched)
> > 
> >
> > Which StringUtils is this? I believe we can use apache common's 
> > StringUtils.isBlank to do this.
> 
> Kevin Duling wrote:
> It is `org.apache.geode.tools.pulse.internal.util.StringUtils` which is 
> already used heavily within `PulseAppListener`.  Perhaps another ticket to 
> remove this StringUtils in favor of apache commons?

We should really get rid of those random StringUtils to use a standard library. 
Agree another ticket is probably a good idea if you can get to it.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169587
---


On March 21, 2017, 4:35 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 4:35 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Blacklist asf904 for Geode nightly job

[Mark Bretl]

Hi Kirk,

It looks like the build actually ran on a machine called 'H4', which is
designated as a Hadoop machine. I do not see why running on a Hadoop system
would be an issue, however, I do not know the ASF infrastructure well
enough to know why there are DNS issues.

We use labels, tied to certain Jenkins nodes, to restrict where we run our
builds, however, if a new system is added to the label, there is not much
we can do. Maybe it is time to work worth INFRA, or some other container,
to get a environment we can rely on all the time?

--Mark

On Tue, Mar 21, 2017 at 11:13 AM, Kirk Lund  wrote:

> Please blacklist asf904 for the Geode nightly job. It seems to be giving
> bad DNS info to our tests, causing UniversalMembershipListenerAda
> pterDUnitTest
> to fail again. Alternatively, if someone else wants to look into the
> failures in UniversalMembershipListenerAdapterDUnitTest please go ahead.
> I've done all I can for the test.
>
> Thanks,
> Kirk
>

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kevin Duling]

> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
> > Lines 72 (patched)
> > 
> >
> > I would hope we shouldn't need to manully set this in the test.
> 
> Kevin Duling wrote:
> I was hoping not, also, but couldn't find another way to handle this.  
> None of the parameters we are interested in are set in the system properties. 
>  For example `jmx-manager-port` is being set in the test, but it is not 
> visible in `System.properties` when Pulse starts.
> 
> Jinmei Liao wrote:
> how is this IsEmbededMode system property set? I would think if we are 
> starting pulse in the managementAgent, we should set this system property.

`ManagementAgent` has `System.setProperty(PULSE_EMBEDDED_PROP, "true");` at 
line within `if (agentUtil.isWebApplicationAvailable(gemfireWar, pulseWar, 
gemfireAPIWar)) {`


> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 159 (patched)
> > 
> >
> > Is this system proeprty set manually or by the locator/server when 
> > starting up the pulse service?
> 
> Kevin Duling wrote:
> It is set manually by the test.  Prior to my change, Pulse only read from 
> `pulse.properties` off of the classpath to set the `pulse.port` value or used 
> the default.
> 
> Jinmei Liao wrote:
> So when a user starts a locator with jmx-manager-port other than 1099, he 
> still would have problem having pulse connect to this locator?

He would have to set `pulse.port` to match `jmx-manager-port`.  Pulse has a lot 
of different properties, such as `pulse.host`, `pulse.embedded`, 
`pulse.embedded.sqlf`, etc.  They're laid out in the `pulse.properties` file.  
One could argue that pulse should look for `jmx-manager-port` but then rules 
will have to be defined for when someone specifies both properties. Which one 
wins?


> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 160 (patched)
> > 
> >
> > Which StringUtils is this? I believe we can use apache common's 
> > StringUtils.isBlank to do this.
> 
> Kevin Duling wrote:
> It is `org.apache.geode.tools.pulse.internal.util.StringUtils` which is 
> already used heavily within `PulseAppListener`.  Perhaps another ticket to 
> remove this StringUtils in favor of apache commons?
> 
> Jinmei Liao wrote:
> We should really get rid of those random StringUtils to use a standard 
> library. Agree another ticket is probably a good idea if you can get to it.

Agreed, I'll open another ticket to remove it.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169587
---


On March 21, 2017, 9:35 a.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 9:35 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

[jira] [Created] (GEODE-2704) Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

[Kevin Duling (JIRA)]

Kevin Duling created GEODE-2704:
---

 Summary: Remove Pulse's custom StringUtils in favor of Apache 
Commons StringUtils
 Key: GEODE-2704
 URL: https://issues.apache.org/jira/browse/GEODE-2704
 Project: Geode
  Issue Type: Bug
  Components: pulse
Reporter: Kevin Duling






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2704) Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

[Kevin Duling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling updated GEODE-2704:

Description: Moving away from these custom classes to use more standardized 
ones.

> Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils
> 
>
> Key: GEODE-2704
> URL: https://issues.apache.org/jira/browse/GEODE-2704
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Reporter: Kevin Duling
>
> Moving away from these custom classes to use more standardized ones.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Jinmei Liao]

> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote:
> > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
> > Lines 72 (patched)
> > 
> >
> > I would hope we shouldn't need to manully set this in the test.
> 
> Kevin Duling wrote:
> I was hoping not, also, but couldn't find another way to handle this.  
> None of the parameters we are interested in are set in the system properties. 
>  For example `jmx-manager-port` is being set in the test, but it is not 
> visible in `System.properties` when Pulse starts.
> 
> Jinmei Liao wrote:
> how is this IsEmbededMode system property set? I would think if we are 
> starting pulse in the managementAgent, we should set this system property.
> 
> Kevin Duling wrote:
> `ManagementAgent` has `System.setProperty(PULSE_EMBEDDED_PROP, "true");` 
> at line within `if (agentUtil.isWebApplicationAvailable(gemfireWar, pulseWar, 
> gemfireAPIWar)) {`

I believe we should set the system property for pulse jmx port here as well.


> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 159 (patched)
> > 
> >
> > Is this system proeprty set manually or by the locator/server when 
> > starting up the pulse service?
> 
> Kevin Duling wrote:
> It is set manually by the test.  Prior to my change, Pulse only read from 
> `pulse.properties` off of the classpath to set the `pulse.port` value or used 
> the default.
> 
> Jinmei Liao wrote:
> So when a user starts a locator with jmx-manager-port other than 1099, he 
> still would have problem having pulse connect to this locator?
> 
> Kevin Duling wrote:
> He would have to set `pulse.port` to match `jmx-manager-port`.  Pulse has 
> a lot of different properties, such as `pulse.host`, `pulse.embedded`, 
> `pulse.embedded.sqlf`, etc.  They're laid out in the `pulse.properties` file. 
>  One could argue that pulse should look for `jmx-manager-port` but then rules 
> will have to be defined for when someone specifies both properties. Which one 
> wins?

In the embeded case, I don't think that property file is even used


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169587
---


On March 21, 2017, 4:35 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 4:35 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

[jira] [Created] (GEODE-2705) Jars removed from cluster configuration while a server is offline will still be loaded from disk when that server comes back online

[Jared Stewart (JIRA)]

Jared Stewart created GEODE-2705:


 Summary: Jars removed from cluster configuration while a server is 
offline will still be loaded from disk when that server comes back online
 Key: GEODE-2705
 URL: https://issues.apache.org/jira/browse/GEODE-2705
 Project: Geode
  Issue Type: Bug
  Components: configuration, management
Reporter: Jared Stewart


1. Start a locator and two servers
2. Deploy jar to cluster
3. Shutdown server 2
4. Undeploy jar from cluster
5. Start server 2 

Then server 2 will load jar 1 from disk, even though it’s been removed from the 
cluster configuration.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2705) Jars removed from cluster configuration while a server is offline will still be loaded from disk when the server comes back online

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-2705:
-
Summary: Jars removed from cluster configuration while a server is offline 
will still be loaded from disk when the server comes back online  (was: Jars 
removed from cluster configuration while a server is offline will still be 
loaded from disk when that server comes back online)

> Jars removed from cluster configuration while a server is offline will still 
> be loaded from disk when the server comes back online
> --
>
> Key: GEODE-2705
> URL: https://issues.apache.org/jira/browse/GEODE-2705
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, management
>Reporter: Jared Stewart
>
> 1. Start a locator and two servers
> 2. Deploy jar to cluster
> 3. Shutdown server 2
> 4. Undeploy jar from cluster
> 5. Start server 2 
> Then server 2 will load jar 1 from disk, even though it’s been removed from 
> the cluster configuration.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2705) Jars removed from cluster configuration while a server is offline will still be loaded from disk when the server comes back online

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-2705:
-
Affects Version/s: 1.1.0

> Jars removed from cluster configuration while a server is offline will still 
> be loaded from disk when the server comes back online
> --
>
> Key: GEODE-2705
> URL: https://issues.apache.org/jira/browse/GEODE-2705
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, management
>Affects Versions: 1.1.0
>Reporter: Jared Stewart
>
> 1. Start a locator and two servers
> 2. Deploy jar to cluster
> 3. Shutdown server 2
> 4. Undeploy jar from cluster
> 5. Start server 2 
> Then server 2 will load jar 1 from disk, even though it’s been removed from 
> the cluster configuration.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2705) Jars undeployed from cluster configuration while a server is offline will still be loaded from disk when the server comes back online

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-2705:
-
Summary: Jars undeployed from cluster configuration while a server is 
offline will still be loaded from disk when the server comes back online  (was: 
Jars removed from cluster configuration while a server is offline will still be 
loaded from disk when the server comes back online)

> Jars undeployed from cluster configuration while a server is offline will 
> still be loaded from disk when the server comes back online
> -
>
> Key: GEODE-2705
> URL: https://issues.apache.org/jira/browse/GEODE-2705
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, management
>Affects Versions: 1.1.0
>Reporter: Jared Stewart
>
> 1. Start a locator and two servers
> 2. Deploy jar to cluster
> 3. Shutdown server 2
> 4. Undeploy jar from cluster
> 5. Start server 2 
> Then server 2 will load jar 1 from disk, even though it’s been removed from 
> the cluster configuration.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #65: GEODE-2513 Unbrand section on Remote Querying

[davebarnes97]

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/65
  
Noticed one typo: 
...native-docs/remote-querying/91-quickintro/41-quickintro-query-portfolioregion.html.md.erb,
 "porfolio" should be "portfolio",


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935246#comment-15935246
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/65
  
Noticed one typo: 
...native-docs/remote-querying/91-quickintro/41-quickintro-query-portfolioregion.html.md.erb,
 "porfolio" should be "portfolio",


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Fwd: [NOTICE] Transient network issues affecting mail today

[Mark Bretl]

Forwarding to Dev list...

A few people have received bounced notification email, this may explain it.
Hopefully should be resolved now.

--Mark

-- Forwarded message --
From: Daniel Gruno 
Date: Tue, Mar 21, 2017 at 7:31 AM
Subject: [NOTICE] Transient network issues affecting mail today
To: us...@infra.apache.org


Hi folks,
We've discovered some network errors that caused mail to be rejected
(5.3.0) for a few hours this morning.  The issue has been fixed now, but
some email may have gone to the gnomish void for good. So, if you sent
some email and it doesn't show up in the next hour or so, you may want
to resend it.

With regards,
Daniel on behalf of ASF Infra.

[GitHub] geode issue #404: Geode 2469

[ggreen]

Github user ggreen commented on the issue:

https://github.com/apache/geode/pull/404
  
@galen-pivotal and @metatype, please take a look at my latest change. It 
uses a java.util.concurrent.locks.Lock instead of a distribute lock for the 
hash and set synchronization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #404: Geode 2469

[ggreen]

GitHub user ggreen reopened a pull request:

https://github.com/apache/geode/pull/404

Geode 2469

The updated Geode Redis Adapter now works with a sample Spring Data Redis 
Example 

[GEODE-2469.pdf](https://github.com/apache/geode/files/785580/GEODE-2469.pdf)

These changes are focused on the HASH and Set Redis Data Types to support 
Spring Data Redis sample code located at the following URL


https://github.com/Pivotal-Data-Engineering/gemfire9_examples/tree/person_example_sdg_Tracker139498217/redis/spring-data-redis-example/src/test/java/io/pivotal/redis/gemfire/example/repository

The Hash performance changes from this pull request had a 99.8% performance 
improvement. 

This is based on the Hashes JUNIT Tests.


https://github.com/Pivotal-Data-Engineering/gemfire9_examples/blob/person_example_sdg_Tracker139498217/redis/gemfire-streaming-client/src/test/java/io/pivotal/gemfire9/HashesJUnitTest.java

This code executed in 12.549s against Gemfire 9.0.1 code. After the 
changes, the test executed in 0.022s with the GEODE-2469 pull request.

Redis Set related command performance had a 99.9% performance improvement. 

See  
https://github.com/Pivotal-Data-Engineering/gemfire9_examples/blob/person_example_sdg_Tracker139498217/redis/gemfire-streaming-client/src/test/java/io/pivotal/gemfire9/SetsJUnitTest.java

The previous Set Junit tests executed against GemFire 9.0.1 executed in 
31.507 seconds. These same test executed in 0.036 seconds with the GEODE-2469 
pull request changes.

The GemFire 9.0.1 Geode (1.1.0) version for the Geode Redis adapter created 
a Geode Region for each key provided in the Redis Hash or Set related command. 
Each Redis command to remove key entry previously destroyed the region. The big 
performance gain is based on using a new ReDiS_HASH and ReDiS_SET region. Note 
the changed will create or reuse an existing region with a matching name for 
Redis HASH commands references objects. For Redis HASH object's key will have a 
format of object:key

Please see https://redis.io/topics/data-types-intro HASH section on objects 
for information on Redis objects.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ggreen/geode GEODE-2469

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #404


commit 44b90c4f3f8e1ec4fdae63a8be126982d7c837a2
Author: Gregory Green 
Date:   2017-02-14T20:31:49Z

GEODE-2469 initial changes to support Redis objects

commit 27d7600e85945a7134115630efe378ed43d980f8
Author: Gregory Green 
Date:   2017-02-17T00:26:11Z

GEODE-2469 changes to corrected introduced issue found during JUNIT runs

commit a4ee164ddc944e8eed93c28d2db798c222a21cd4
Author: Gregory Green 
Date:   2017-02-17T00:27:55Z

Merge branch 'develop' into GEODE-2469

commit d5191fb5cd10df1c9c2f34399b849d8bbf8c5bf7
Author: Gregory Green 
Date:   2017-02-18T21:14:02Z

GEODE-2469 add additional junit test coverage

commit 0b3bf689b835628b8573a49e3f0bb2900d07ff1c
Author: Gregory Green 
Date:   2017-02-18T21:14:33Z

GEODE-2469 add additional junit test coverage

commit 1958b1e129ab22be6dbb2d347fb189718fa5f8c4
Author: Gregory Green 
Date:   2017-02-18T21:15:44Z

Merge branch 'develop' into GEODE-2469

commit 628f5093d32a272f7515bdd0953f90e91f559ec7
Author: Gregory Green 
Date:   2017-02-19T02:24:26Z

GEODE-2469 adding licenses to fix RAT issues

commit 3316d25d54d7dcf957180eb258a72d3c66ec3a8d
Author: Gregory Green 
Date:   2017-02-22T17:53:18Z

GEODE-2469 missed check into for SetInterpreter

commit f2b7ee7c7a5ae479158c35d91cdb2bfe6be58603
Author: Gregory Green 
Date:   2017-02-25T04:54:02Z

GEODE-2469 fixing CI build issues

commit 886289e24e254d56f7501b27f1d6c86fcfff39de
Author: Gregory Green 
Date:   2017-03-06T12:00:22Z

Merge branch 'develop' into GEODE-2469

commit 0327403108fbb2139b9452a422878ee2fb91df76
Author: Gregory Green 
Date:   2017-03-06T22:16:26Z

GEODE-2469 addressing pull request feedback

commit c29b3ca58c0496e2a9672649d9f5ea45fdf00249
Author: Gregory Green 
Date:   2017-03-08T16:38:40Z

GEOD-2469 incorporating pull request feedback, adding hash integration 
tests and enhancing documentation

commit 64124126d5c4e5616e43dab0aa368890a0dfd66a
Author: Gregory Green 
Date:   2017-03-11T15:54:31Z

Merge branch 'develop' into GEODE-2469

commit 454e09a86abf7c141910ec29faeb4d830ae74772
Author: Galen OSullivan 
Date:   2017-03-10T23:29:12Z

Use DLockService in Redis adapter for Hashes and Sets.

commit 3f8c590885137f730e2399fbf33090ec115a6223
Author: ggreen 
Date:   2017-03-18T17:04:47Z

Merge pull request #1 from galen-pivotal/pr-404-DLock

Use DLockService to avo

[GitHub] geode pull request #404: Geode 2469

[ggreen]

Github user ggreen closed the pull request at:

https://github.com/apache/geode/pull/404


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2469) Redis adapter Hash key support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935316#comment-15935316
 ] 

ASF GitHub Bot commented on GEODE-2469:
---

Github user ggreen closed the pull request at:

https://github.com/apache/geode/pull/404


> Redis adapter Hash key support
> --
>
> Key: GEODE-2469
> URL: https://issues.apache.org/jira/browse/GEODE-2469
> Project: Geode
>  Issue Type: Sub-task
>  Components: redis
>Reporter: Gregory Green
>Assignee: Hitesh Khamesra
>
> The Redis adapter does not appear to handle hash keys correctly.
> The following Example: Redis CLI works.
> localhost:11211>  HSET companies name "John Smith"
> Using a  HSET :id  .. produces an error
> Example:
> localhost:11211>  HSET companies:1000 name "John Smith"
> [Server error]
> [fine 2017/02/10 16:04:33.289 EST server1  
> tid=0x6a] Region names may only be alphanumeric and may contain hyphens or 
> underscores: companies: 1000
> java.lang.IllegalArgumentException: Region names may only be alphanumeric and 
> may contain hyphens or underscores: companies: 1000
> at 
> org.apache.geode.internal.cache.LocalRegion.validateRegionName(LocalRegion.java:7618)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3201)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:3181)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createRegion(GemFireCacheImpl.java:3169)
> at org.apache.geode.cache.RegionFactory.create(RegionFactory.java:762)
> at 
> org.apache.geode.management.internal.cli.functions.RegionCreateFunction.createRegion(RegionCreateFunction.java:355)
> at 
> org.apache.geode.management.internal.cli.functions.RegionCreateFunction.execute(RegionCreateFunction.java:90)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution$2.run(AbstractExecution.java:303)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
> at 
> org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
> at java.lang.Thread.run(Thread.java:745)
> //Example Spring Data Redis Object sample
> @Data
> @EqualsAndHashCode()
> @RedisHash(value="companies")
> @NoArgsConstructor
> public class Company
> {
>   private @Id String id;
>
> //Repository
> public interface CompanyRepository extends CrudRepository 
> {
>  
> }
> //When saving using a repository
> repository.save(this.myCompany);
> [Same Server error]
> java.lang.IllegalArgumentException: Region names may only be alphanumeric and 
> may contain hyphens or underscores: 
> companies:f05405c2-86f2-4aaf-bd0c-6fecd483bf28
> at 
> org.apache.geode.internal.cache.LocalRegion.validateRegionName(LocalRegion.java:7618)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3201)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:3181)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createRegion(GemFireCacheImpl.java:3169)
> at org.apache.geode.cache.RegionFactory.create(RegionFactory.java:762)
> at 
> org.apache.geode.management.internal.cli.functions.RegionCreateFunction.createRegion(RegionCreateFunction.java:355)
> at 
> org.apache.geode.management.internal.cli.functions.RegionCreateFunction.execute(RegionCreateFunction.java:90)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution$2.run(AbstractExecution.java:303)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
> at 
> org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
> at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2469) Redis adapter Hash key support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935317#comment-15935317
 ] 

ASF GitHub Bot commented on GEODE-2469:
---

GitHub user ggreen reopened a pull request:

https://github.com/apache/geode/pull/404

Geode 2469

The updated Geode Redis Adapter now works with a sample Spring Data Redis 
Example 

[GEODE-2469.pdf](https://github.com/apache/geode/files/785580/GEODE-2469.pdf)

These changes are focused on the HASH and Set Redis Data Types to support 
Spring Data Redis sample code located at the following URL


https://github.com/Pivotal-Data-Engineering/gemfire9_examples/tree/person_example_sdg_Tracker139498217/redis/spring-data-redis-example/src/test/java/io/pivotal/redis/gemfire/example/repository

The Hash performance changes from this pull request had a 99.8% performance 
improvement. 

This is based on the Hashes JUNIT Tests.


https://github.com/Pivotal-Data-Engineering/gemfire9_examples/blob/person_example_sdg_Tracker139498217/redis/gemfire-streaming-client/src/test/java/io/pivotal/gemfire9/HashesJUnitTest.java

This code executed in 12.549s against Gemfire 9.0.1 code. After the 
changes, the test executed in 0.022s with the GEODE-2469 pull request.

Redis Set related command performance had a 99.9% performance improvement. 

See  
https://github.com/Pivotal-Data-Engineering/gemfire9_examples/blob/person_example_sdg_Tracker139498217/redis/gemfire-streaming-client/src/test/java/io/pivotal/gemfire9/SetsJUnitTest.java

The previous Set Junit tests executed against GemFire 9.0.1 executed in 
31.507 seconds. These same test executed in 0.036 seconds with the GEODE-2469 
pull request changes.

The GemFire 9.0.1 Geode (1.1.0) version for the Geode Redis adapter created 
a Geode Region for each key provided in the Redis Hash or Set related command. 
Each Redis command to remove key entry previously destroyed the region. The big 
performance gain is based on using a new ReDiS_HASH and ReDiS_SET region. Note 
the changed will create or reuse an existing region with a matching name for 
Redis HASH commands references objects. For Redis HASH object's key will have a 
format of object:key

Please see https://redis.io/topics/data-types-intro HASH section on objects 
for information on Redis objects.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ggreen/geode GEODE-2469

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #404


commit 44b90c4f3f8e1ec4fdae63a8be126982d7c837a2
Author: Gregory Green 
Date:   2017-02-14T20:31:49Z

GEODE-2469 initial changes to support Redis objects

commit 27d7600e85945a7134115630efe378ed43d980f8
Author: Gregory Green 
Date:   2017-02-17T00:26:11Z

GEODE-2469 changes to corrected introduced issue found during JUNIT runs

commit a4ee164ddc944e8eed93c28d2db798c222a21cd4
Author: Gregory Green 
Date:   2017-02-17T00:27:55Z

Merge branch 'develop' into GEODE-2469

commit d5191fb5cd10df1c9c2f34399b849d8bbf8c5bf7
Author: Gregory Green 
Date:   2017-02-18T21:14:02Z

GEODE-2469 add additional junit test coverage

commit 0b3bf689b835628b8573a49e3f0bb2900d07ff1c
Author: Gregory Green 
Date:   2017-02-18T21:14:33Z

GEODE-2469 add additional junit test coverage

commit 1958b1e129ab22be6dbb2d347fb189718fa5f8c4
Author: Gregory Green 
Date:   2017-02-18T21:15:44Z

Merge branch 'develop' into GEODE-2469

commit 628f5093d32a272f7515bdd0953f90e91f559ec7
Author: Gregory Green 
Date:   2017-02-19T02:24:26Z

GEODE-2469 adding licenses to fix RAT issues

commit 3316d25d54d7dcf957180eb258a72d3c66ec3a8d
Author: Gregory Green 
Date:   2017-02-22T17:53:18Z

GEODE-2469 missed check into for SetInterpreter

commit f2b7ee7c7a5ae479158c35d91cdb2bfe6be58603
Author: Gregory Green 
Date:   2017-02-25T04:54:02Z

GEODE-2469 fixing CI build issues

commit 886289e24e254d56f7501b27f1d6c86fcfff39de
Author: Gregory Green 
Date:   2017-03-06T12:00:22Z

Merge branch 'develop' into GEODE-2469

commit 0327403108fbb2139b9452a422878ee2fb91df76
Author: Gregory Green 
Date:   2017-03-06T22:16:26Z

GEODE-2469 addressing pull request feedback

commit c29b3ca58c0496e2a9672649d9f5ea45fdf00249
Author: Gregory Green 
Date:   2017-03-08T16:38:40Z

GEOD-2469 incorporating pull request feedback, adding hash integration 
tests and enhancing documentation

commit 64124126d5c4e5616e43dab0aa368890a0dfd66a
Author: Gregory Green 
Date:   2017-03-11T15:54:31Z

Merge branch 'develop' into GEODE-2469

commit 454e09a86abf7c141910ec29faeb4d830ae74772
Author: Galen OSullivan 
Date:   2017-03-10

[GitHub] geode-native pull request #66: GEODE-2513 Unbranding docs: remove GemFire re...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/66


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kevin Duling]

> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
> > Lines 72 (patched)
> > 
> >
> > I would hope we shouldn't need to manully set this in the test.
> 
> Kevin Duling wrote:
> I was hoping not, also, but couldn't find another way to handle this.  
> None of the parameters we are interested in are set in the system properties. 
>  For example `jmx-manager-port` is being set in the test, but it is not 
> visible in `System.properties` when Pulse starts.
> 
> Jinmei Liao wrote:
> how is this IsEmbededMode system property set? I would think if we are 
> starting pulse in the managementAgent, we should set this system property.
> 
> Kevin Duling wrote:
> `ManagementAgent` has `System.setProperty(PULSE_EMBEDDED_PROP, "true");` 
> at line within `if (agentUtil.isWebApplicationAvailable(gemfireWar, pulseWar, 
> gemfireAPIWar)) {`
> 
> Jinmei Liao wrote:
> I believe we should set the system property for pulse jmx port here as 
> well.

If I set it as a system property, I can resolve this issue and the one below.


> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 159 (patched)
> > 
> >
> > Is this system proeprty set manually or by the locator/server when 
> > starting up the pulse service?
> 
> Kevin Duling wrote:
> It is set manually by the test.  Prior to my change, Pulse only read from 
> `pulse.properties` off of the classpath to set the `pulse.port` value or used 
> the default.
> 
> Jinmei Liao wrote:
> So when a user starts a locator with jmx-manager-port other than 1099, he 
> still would have problem having pulse connect to this locator?
> 
> Kevin Duling wrote:
> He would have to set `pulse.port` to match `jmx-manager-port`.  Pulse has 
> a lot of different properties, such as `pulse.host`, `pulse.embedded`, 
> `pulse.embedded.sqlf`, etc.  They're laid out in the `pulse.properties` file. 
>  One could argue that pulse should look for `jmx-manager-port` but then rules 
> will have to be defined for when someone specifies both properties. Which one 
> wins?
> 
> Jinmei Liao wrote:
> In the embeded case, I don't think that property file is even used

Not quite correct.  In the case of embedded, `pulse.host` and `pulse.port` are 
ignored, but the rest of the properties are loaded and used.  I had tried to 
use `jmx-manager-port` before, but the properties are not set in the system.  
Instead, they are passed down as a properties object and visibility is lost 
once we reach `line 137` in `ManagementAgent.startAgent()`.  At this point, we 
turn it over to Jetty to start the service, but the properties aren't handed 
off.  I'm not sure they can be without setting a system property.  This is why 
I chose to use the `pulse.port` parameter that Pulse normally looks for.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169587
---


On March 21, 2017, 9:35 a.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 9:35 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935324#comment-15935324
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit 099f61b5494824f45a06699101c9a87ad5ca5c12 in geode-native's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=099f61b ]

GEODE-2513 Unbranding docs: remove GemFire rel notes


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935325#comment-15935325
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/66


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Blacklist asf904 for Geode nightly job

[Kirk Lund]

Unfortunately I don't know enough about DNS or more likely the internal
membership details of client/server to determine why one part of geode says
the hostname is 67.195.81.148 while another part of geode says the hostname
is asf904.

DistributedMember.getId() for a client is returning 67.195.81.148

ClientMembershipListener fires events with ClientMembershipEvent and
ClientMembershipEvent.getMemberId() is returning asf904

I think this is beyond my knowledge of JMX, management, type stuff and
requires someone with client/server membership knowledge to investigate
further. I'm not sure why DistributedMember.getId() and
ClientMembershipEvent.getMemberId() returns the same value on some asf
machines but on other machines one returns ip address while one returns a
host name. I don't really know if it's the machine that's wrong, the test
code that's wrong or something inside that client membership code.

org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest >
testSystemClientEventsInServer FAILEDorg.junit.ComparisonFailure:
expected:<[67.195.81.148](13093):3277...> but
was:<[asf904](13093):3277...>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.doTestSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:946)
at
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:731)

Thanks,
Kirk

On Tue, Mar 21, 2017 at 12:01 PM, Mark Bretl  wrote:

> Hi Kirk,
>
> It looks like the build actually ran on a machine called 'H4', which is
> designated as a Hadoop machine. I do not see why running on a Hadoop system
> would be an issue, however, I do not know the ASF infrastructure well
> enough to know why there are DNS issues.
>
> We use labels, tied to certain Jenkins nodes, to restrict where we run our
> builds, however, if a new system is added to the label, there is not much
> we can do. Maybe it is time to work worth INFRA, or some other container,
> to get a environment we can rely on all the time?
>
> --Mark
>
> On Tue, Mar 21, 2017 at 11:13 AM, Kirk Lund  wrote:
>
> > Please blacklist asf904 for the Geode nightly job. It seems to be giving
> > bad DNS info to our tests, causing UniversalMembershipListenerAda
> > pterDUnitTest
> > to fail again. Alternatively, if someone else wants to look into the
> > failures in UniversalMembershipListenerAdapterDUnitTest please go ahead.
> > I've done all I can for the test.
> >
> > Thanks,
> > Kirk
> >
>

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Jinmei Liao]

> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 159 (patched)
> > 
> >
> > Is this system proeprty set manually or by the locator/server when 
> > starting up the pulse service?
> 
> Kevin Duling wrote:
> It is set manually by the test.  Prior to my change, Pulse only read from 
> `pulse.properties` off of the classpath to set the `pulse.port` value or used 
> the default.
> 
> Jinmei Liao wrote:
> So when a user starts a locator with jmx-manager-port other than 1099, he 
> still would have problem having pulse connect to this locator?
> 
> Kevin Duling wrote:
> He would have to set `pulse.port` to match `jmx-manager-port`.  Pulse has 
> a lot of different properties, such as `pulse.host`, `pulse.embedded`, 
> `pulse.embedded.sqlf`, etc.  They're laid out in the `pulse.properties` file. 
>  One could argue that pulse should look for `jmx-manager-port` but then rules 
> will have to be defined for when someone specifies both properties. Which one 
> wins?
> 
> Jinmei Liao wrote:
> In the embeded case, I don't think that property file is even used
> 
> Kevin Duling wrote:
> Not quite correct.  In the case of embedded, `pulse.host` and 
> `pulse.port` are ignored, but the rest of the properties are loaded and used. 
>  I had tried to use `jmx-manager-port` before, but the properties are not set 
> in the system.  Instead, they are passed down as a properties object and 
> visibility is lost once we reach `line 137` in 
> `ManagementAgent.startAgent()`.  At this point, we turn it over to Jetty to 
> start the service, but the properties aren't handed off.  I'm not sure they 
> can be without setting a system property.  This is why I chose to use the 
> `pulse.port` parameter that Pulse normally looks for.

In the end, I would like to see user do not have to change a property file in 
order to get the imbeded pulse to work correctly when starting a locator on a 
non-default jmx port. The work flow should just be usual:
1) in gfsh, when user do: "start locator --jmx-manager-port=2000" (or via 
proeprty file)
2) fire up a browser, type in localhost:7070/pulse and pulse should just work.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169587
---


On March 21, 2017, 4:35 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 4:35 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57820/
---

Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

* be able to configure the various aspects of the rules before starting the 
server when declaring the rules.
* delete the unnecessary abstract test classes
* allowing tests to use default ports if needed
* created HttpClientRule to ease the connection to to pulse server


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
 dee004ffdf9602969cf6f4c5acb59588eef9b03d 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ab21094b41fd0e5966142ced48ee831872a1cbdd 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityWithSSLTest.java
 09c3e355cf99905777fb92bf85a653258df2e05d 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestServersJUnitTest.java
 d97bede0d432569d398ca1203ee64220b82df3d5 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java
 43960a8983138a368d4fc1657f8518342b6987d0 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/HttpClientRule.java
 PRE-CREATION 
  
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java
 b9e90b6d77f29875e63ba7d742ff4ee55947dc90 
  
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
 57711258fbbc73570656e14ee8f05550ae32e891 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java
 55687438d1ceb319cedb705d720336e124818637 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
 46a07ada5cb48d9090879937a28ac8fb285e535d 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
 c2fde4d3659cf86c4b9e6def810cd3f299efbd0e 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
 0df00b0340cbbcb8dace23e782490b30034f8404 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/AccessControlMBeanJUnitTest.java
 f8aa0bd73a050ee46ac0cd631ee28b3ff4b5395f 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthenticationJUnitTest.java
 31a4d77514f3a073af8a50da69dd1c116de5b149 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java
 45a4b6d02a513297620b0f35af5ffb5f6e79deff 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanShiroJUnitTest.java
 31679319a49efe4dc3c6163b4f3a6ee6f34b4eda 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerStartupRule.java
 11077796b6c234eb63127d0c11c9d07c6bc4b0b5 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/CliCommandsSecurityTest.java
 1e092ff837da1af79e87f31bfe91e187b8e7d9a2 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/DataCommandsSecurityTest.java
 f403c21554a93faaabdc075fdc20dce4379458d5 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/DeployCommandsSecurityTest.java
 88cbfe92f18bdc2ac27486e5f804728e012e8ffc 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
 0187f802758a0efd9f2504f6297140aa61806ab0 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/GatewayReceiverMBeanSecurityTest.java
 7cc2f29b35c2bc3ce64e3164dfee44811c680786 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/GatewaySenderMBeanSecurityTest.java
 676243e70150e4015a043fc975a21c82c810d7a9 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java
 62c0b854d351e0a2ac980a6f356367e8f74a51c6 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
 45d437a528b7554e7a71346807fb341b56008f33 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameTest.java
 070e9057d7594255c984aab9f0222776798f8e64 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/LockServiceMBeanAuthorizationJUnitTest.java
 97b9730e10fc6775e156007295aa351e85ef1b50 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/MBeanSecurityJUnitTest.java
 95659e2f57ba6f27dd710dbbc4ec39a9c168 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/ManagerMBeanAuthorizationJUnitTest.java
 e9e29fd2fbfe31eb89d62f64309cd692693ebc2f 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/MemberMBeanSecurityJUnitT

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935367#comment-15935367
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/67

GEODE-2513 Unbranding docs: Top-level files



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-FRONTMATTER

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit e46f6f1a5107336b1d0614598ccf438239799539
Author: Dave Barnes 
Date:   2017-03-21T21:12:24Z

GEODE-2513 Unbranding docs: Top-level files




> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #67: GEODE-2513 Unbranding docs: Top-level files

[davebarnes97]

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/67

GEODE-2513 Unbranding docs: Top-level files



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-FRONTMATTER

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit e46f6f1a5107336b1d0614598ccf438239799539
Author: Dave Barnes 
Date:   2017-03-21T21:12:24Z

GEODE-2513 Unbranding docs: Top-level files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/
---

(Updated March 21, 2017, 2:48 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
embedded pulse server still tries to connect to jmx using 1099


Diffs (updated)
-

  geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
  
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
 57711258fbbc73570656e14ee8f05550ae32e891 
  
geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
 e88360ba1506f1a7b9c7df87899d5ec19abec630 
  geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
 5408a5651774a63c16f27722c6ff7bda25cbaaa8 
  geode-pulse/src/main/resources/pulse.properties 
878bc680bbcc4369eb2d3859c6377b8942bc89d7 


Diff: https://reviews.apache.org/r/57796/diff/2/

Changes: https://reviews.apache.org/r/57796/diff/1-2/


Testing
---

precheckin successful


Thanks,

Kevin Duling

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/
---

(Updated March 21, 2017, 2:48 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
embedded pulse server still tries to connect to jmx using 1099


Diffs
-

  geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
  
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
 57711258fbbc73570656e14ee8f05550ae32e891 
  
geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
 e88360ba1506f1a7b9c7df87899d5ec19abec630 
  geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
 5408a5651774a63c16f27722c6ff7bda25cbaaa8 
  geode-pulse/src/main/resources/pulse.properties 
878bc680bbcc4369eb2d3859c6377b8942bc89d7 


Diff: https://reviews.apache.org/r/57796/diff/2/


Testing (updated)
---

precheckin restarted


Thanks,

Kevin Duling

Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57822/
---

Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
Kirk Lund, and Swapnil Bawaskar.


Repository: geode


Description
---

GEODE-1274: Migration from PulseLogWriter to Log4j standard.


Diffs
-

  geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
 5408a5651774a63c16f27722c6ff7bda25cbaaa8 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/ExceptionHandlingAdvice.java
 80a3c63b5d9170cf9933c43edf56da78dc62bf46 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
 9b24393792cc52773089e08db6f1739c0d2c553f 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
 083731ba9e26e711b72f8bf0bdf470d9852aa663 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java
 d20be590d12faf53f91a64ad0d96646b92dd118e 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
 758ad4be1f41946b98283c45ac27a022c75a9f14 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JmxManagerFinder.java
 fa2b5b79f40a95b0a20be38c20e61d9e94a39688 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConfig.java
 dc643b49462af9365859d899f2c798f0f2448b72 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConstants.java
 b36c283630fcd3d143c1398ac0fecf45eec0eb54 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java
 b228e4a754100fe07c9dbec232d5e88809aefeef 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/LogWriter.java
 6f90e7a48a10ab2778ee00cf3d707a476ebe91eb 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/MessageFormatter.java
 924520d3ba70a48379bd6ff9a6ce4d6e0d4ed804 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogWriter.java
 241b34bfe5bc56e062c43944ec7aaf1cfaa657c7 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogger.java
 d22f188248d2d8fb685074523e22eac7c26f5e20 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
 884e51fa71b79de9e5ab9e7f0f933e37b6031438 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
 4d300f04ff82f701509d44b83dd46698dbc6035e 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/LogoutHandler.java
 e18e35d596552a40715ee772e559ffc2d077af5e 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java
 e94ef631724b4a62d5a2486674fc7a2e5f746788 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionsMemberService.java
 d5a913793cd22c408398f3e76767ea7379c14042 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/testbed/PropMockDataUpdater.java
 df315728dbcc07444249f68829b9bed349736ac9 


Diff: https://reviews.apache.org/r/57822/diff/1/


Testing
---

Precheckin up and running.  Includes general PulseLogWriter conversion to 
Log4j, with the hope that the missing pulse logging will now be gathered with 
other artifacts.

Also included in this patch are a number of minor readability improvements 
regarding repeated error blocks and logging text typo corrections.


Thanks,

Patrick Rhomberg

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57822/#review169629
---




geode-pulse/build.gradle
Line 70 (original)


you only updated one test class which doesn't need logging at all. Let's 
not introduce this test compile dependency.



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
Line 46 (original), 48 (patched)


delete this line



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
Line 3712 (original), 3713 (patched)


can we just catc Exception here?



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConstants.java
Line 20 (original), 20 (patched)


delete this line



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/LogWriter.java
Lines 28 (patched)


Can we delete it?



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/MessageFormatter.java
Lines 40 (patched)


Can we delete it?



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogWriter.java
Lines 38 (patched)


Since it's internal package, can we delete it?


- Jinmei Liao


On March 21, 2017, 10:05 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57822/
> ---
> 
> (Updated March 21, 2017, 10:05 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1274: Migration from PulseLogWriter to Log4j standard.
> 
> 
> Diffs
> -
> 
>   geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/ExceptionHandlingAdvice.java
>  80a3c63b5d9170cf9933c43edf56da78dc62bf46 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
>  9b24393792cc52773089e08db6f1739c0d2c553f 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
>  083731ba9e26e711b72f8bf0bdf470d9852aa663 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java
>  d20be590d12faf53f91a64ad0d96646b92dd118e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
>  758ad4be1f41946b98283c45ac27a022c75a9f14 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JmxManagerFinder.java
>  fa2b5b79f40a95b0a20be38c20e61d9e94a39688 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConfig.java
>  dc643b49462af9365859d899f2c798f0f2448b72 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConstants.java
>  b36c283630fcd3d143c1398ac0fecf45eec0eb54 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java
>  b228e4a754100fe07c9dbec232d5e88809aefeef 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/LogWriter.java
>  6f90e7a48a10ab2778ee00cf3d707a476ebe91eb 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/MessageFormatter.java
>  924520d3ba70a48379bd6ff9a6ce4d6e0d4ed804 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogWriter.java
>  241b34bfe5bc56e062c43944ec7aaf1cfaa657c7 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogger.java
>  d22f188248d2d8fb685074523e22eac7c26f5e20 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
>  884e51fa71b79de9e5ab9e7f0f933e37b6031438 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
>  4d300f04ff82f701509d44b83dd46698dbc6035e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/LogoutHandler.java
>  e18e35d596552a40715ee772e559ffc2d077af5e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java
>  e94ef631724b4a62d5a2486674fc7a2e5f746788 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelect

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

[Kevin Duling]

> On March 21, 2017, 3:16 p.m., Jinmei Liao wrote:
> > geode-pulse/build.gradle
> > Line 70 (original)
> > 
> >
> > you only updated one test class which doesn't need logging at all. 
> > Let's not introduce this test compile dependency.

I am also introducing this in GEODE-2671 in order to get ahold of the 
`jmx-manager-port` constant.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57822/#review169629
---


On March 21, 2017, 3:05 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57822/
> ---
> 
> (Updated March 21, 2017, 3:05 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1274: Migration from PulseLogWriter to Log4j standard.
> 
> 
> Diffs
> -
> 
>   geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/ExceptionHandlingAdvice.java
>  80a3c63b5d9170cf9933c43edf56da78dc62bf46 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
>  9b24393792cc52773089e08db6f1739c0d2c553f 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
>  083731ba9e26e711b72f8bf0bdf470d9852aa663 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java
>  d20be590d12faf53f91a64ad0d96646b92dd118e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
>  758ad4be1f41946b98283c45ac27a022c75a9f14 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JmxManagerFinder.java
>  fa2b5b79f40a95b0a20be38c20e61d9e94a39688 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConfig.java
>  dc643b49462af9365859d899f2c798f0f2448b72 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConstants.java
>  b36c283630fcd3d143c1398ac0fecf45eec0eb54 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java
>  b228e4a754100fe07c9dbec232d5e88809aefeef 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/LogWriter.java
>  6f90e7a48a10ab2778ee00cf3d707a476ebe91eb 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/MessageFormatter.java
>  924520d3ba70a48379bd6ff9a6ce4d6e0d4ed804 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogWriter.java
>  241b34bfe5bc56e062c43944ec7aaf1cfaa657c7 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogger.java
>  d22f188248d2d8fb685074523e22eac7c26f5e20 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
>  884e51fa71b79de9e5ab9e7f0f933e37b6031438 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
>  4d300f04ff82f701509d44b83dd46698dbc6035e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/LogoutHandler.java
>  e18e35d596552a40715ee772e559ffc2d077af5e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java
>  e94ef631724b4a62d5a2486674fc7a2e5f746788 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionsMemberService.java
>  d5a913793cd22c408398f3e76767ea7379c14042 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/testbed/PropMockDataUpdater.java
>  df315728dbcc07444249f68829b9bed349736ac9 
> 
> 
> Diff: https://reviews.apache.org/r/57822/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin up and running.  Includes general PulseLogWriter conversion to 
> Log4j, with the hope that the missing pulse logging will now be gathered with 
> other artifacts.
> 
> Also included in this patch are a number of minor readability improvements 
> regarding repeated error blocks and logging text typo corrections.
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

[Kevin Duling]

> On March 21, 2017, 3:16 p.m., Jinmei Liao wrote:
> > geode-pulse/build.gradle
> > Line 70 (original)
> > 
> >
> > you only updated one test class which doesn't need logging at all. 
> > Let's not introduce this test compile dependency.
> 
> Kevin Duling wrote:
> I am also introducing this in GEODE-2671 in order to get ahold of the 
> `jmx-manager-port` constant.

Wait...that should be compile, not testCompile.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57822/#review169629
---


On March 21, 2017, 3:05 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57822/
> ---
> 
> (Updated March 21, 2017, 3:05 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1274: Migration from PulseLogWriter to Log4j standard.
> 
> 
> Diffs
> -
> 
>   geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/ExceptionHandlingAdvice.java
>  80a3c63b5d9170cf9933c43edf56da78dc62bf46 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
>  9b24393792cc52773089e08db6f1739c0d2c553f 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
>  083731ba9e26e711b72f8bf0bdf470d9852aa663 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java
>  d20be590d12faf53f91a64ad0d96646b92dd118e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
>  758ad4be1f41946b98283c45ac27a022c75a9f14 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JmxManagerFinder.java
>  fa2b5b79f40a95b0a20be38c20e61d9e94a39688 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConfig.java
>  dc643b49462af9365859d899f2c798f0f2448b72 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConstants.java
>  b36c283630fcd3d143c1398ac0fecf45eec0eb54 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java
>  b228e4a754100fe07c9dbec232d5e88809aefeef 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/LogWriter.java
>  6f90e7a48a10ab2778ee00cf3d707a476ebe91eb 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/MessageFormatter.java
>  924520d3ba70a48379bd6ff9a6ce4d6e0d4ed804 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogWriter.java
>  241b34bfe5bc56e062c43944ec7aaf1cfaa657c7 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogger.java
>  d22f188248d2d8fb685074523e22eac7c26f5e20 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
>  884e51fa71b79de9e5ab9e7f0f933e37b6031438 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
>  4d300f04ff82f701509d44b83dd46698dbc6035e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/LogoutHandler.java
>  e18e35d596552a40715ee772e559ffc2d077af5e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java
>  e94ef631724b4a62d5a2486674fc7a2e5f746788 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionsMemberService.java
>  d5a913793cd22c408398f3e76767ea7379c14042 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/testbed/PropMockDataUpdater.java
>  df315728dbcc07444249f68829b9bed349736ac9 
> 
> 
> Diff: https://reviews.apache.org/r/57822/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin up and running.  Includes general PulseLogWriter conversion to 
> Log4j, with the hope that the missing pulse logging will now be gathered with 
> other artifacts.
> 
> Also included in this patch are a number of minor readability improvements 
> regarding repeated error blocks and logging text typo corrections.
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>

[GitHub] geode-native pull request #67: GEODE-2513 Unbranding docs: Top-level files

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/67


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 57823: GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57823/
---

Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons 
StringUtils


Diffs
-

  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
 5408a5651774a63c16f27722c6ff7bda25cbaaa8 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
 9b24393792cc52773089e08db6f1739c0d2c553f 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
 083731ba9e26e711b72f8bf0bdf470d9852aa663 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java
 d20be590d12faf53f91a64ad0d96646b92dd118e 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
 758ad4be1f41946b98283c45ac27a022c75a9f14 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionService.java
 2e0a6f4b40c789add5854690cfc0882ea41218a5 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionsService.java
 79937425fa9ad4f90b1b3d8aa64d17975421106e 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java
 e94ef631724b4a62d5a2486674fc7a2e5f746788 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberAsynchEventQueuesService.java
 e421ea09e81843c037e0430089a3d1062a44e814 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberClientsService.java
 2486fd46dd7155a08353717ea965f10533312366 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberDetailsService.java
 c311c67413eb74099a6f6f31b31555d9f9c86a2f 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberDiskThroughputService.java
 98d094fe646be181c4724f85b4eb72ef912f33b9 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGCPausesService.java
 1a34b0a9bb3d0942d11f975b714cff57bd002ddd 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java
 c9b40fd5e9ecf64fcd262750797dc79cacd4ed11 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberHeapUsageService.java
 1a7c54f135ac6aa29983d66cf50b4c59294ece07 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberKeyStatisticsService.java
 ef6ccb82f58637cb714de2cf06bdcb5f23f98f13 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberRegionsService.java
 c8addd979d72bf472e487b090c751deb2fcd9ff5 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/SystemAlertsService.java
 d7f119b711c3b6168d826d195c582f655f10af68 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/StringUtils.java
 df7c5a5e5dde97fd726b46f7007121e0538bd01a 


Diff: https://reviews.apache.org/r/57823/diff/1/


Testing
---

precheckin running


Thanks,

Kevin Duling

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935464#comment-15935464
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/67


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935463#comment-15935463
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit 08795832274957222c986b37e09d5c3f5a0fa5b2 in geode-native's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=0879583 ]

GEODE-2513 Unbranding docs: Top-level files, sys req fix
This closes #67


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57822/#review169628
---



The localization resource bundles in Pulse require some thought (do we delete 
them? do we use them with log4j2 in the standard way that log4j2 would normally 
use them?).


geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
Line 46 (original), 48 (patched)


delete any dead code



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
Line 87 (original), 89 (patched)


Pulse has localization resource bundles:

geode-pulse/src/main/resources/Resource Bundle 
'LogMessages'/LogMessages_en_US.properties

geode-pulse/src/main/resources/Resource Bundle 
'LogMessages'/LogMessages_fr_FR.properties

I'm a little worried about this use of ResourceBundle. I suspect Log4j2 has 
a specific way of dealing with resource bundles and I recommend researching 
that before committing this:


http://logging.apache.org/log4j/2.x/manual/configuration.html#PropertySubstitution


https://logging.apache.org/log4j/2.0/log4j-api/apidocs/org/apache/logging/log4j/message/LocalizedMessage.html

https://dzone.com/articles/log4j-2-configuration-using-properties-file

Another thought: GEODE-536 says to remove our hacky/broken i18n from Geode 
and then we can start over from scratch if we decide to add proper localization 
support. Perhaps we should delete the Pulse resource bundles and use the 
English values as the log statements.



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
Line 210 (original), 206 (patched)


Change any log statements that don't use ResourceBundle to use full log4j2 
syntax (we'll revisit the ResourceBundle in the future):
```java
logger.info("#SpringProfilesConfigured : {}", sb);
```
No need to invoke toString() because log4j2 will do that when it replaces 
"{}"

Multiple arguments simply have multiple "{}" in the log message.



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
Line 212 (original), 208 (patched)


Use {}



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
Line 114 (original), 116 (patched)


Any place where you're logging exception, don't log getMessage, just give 
Logger the exception itself. This will allow log4j2 to log the stack trace as 
well.

logger.debug("Exception Occurred : {}", e);


- Kirk Lund


On March 21, 2017, 10:05 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57822/
> ---
> 
> (Updated March 21, 2017, 10:05 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1274: Migration from PulseLogWriter to Log4j standard.
> 
> 
> Diffs
> -
> 
>   geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/ExceptionHandlingAdvice.java
>  80a3c63b5d9170cf9933c43edf56da78dc62bf46 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
>  9b24393792cc52773089e08db6f1739c0d2c553f 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
>  083731ba9e26e711b72f8bf0bdf470d9852aa663 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java
>  d20be590d12faf53f91a64ad0d96646b92dd118e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
>  758ad4be1f41946b98283c45ac27a022c75a9f14 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JmxManagerFinder.java
>  fa2b5b79f40a95b0a20be38c20e61d9e94a39688 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConfig.java
>  dc643b49462af9365859d899f2c798f0f2448b72 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConstants.java
>  b36c283630fcd3d143c1398ac0fecf45eec0eb54 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java
>  b228e4a754100fe07c

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935470#comment-15935470
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit 5dba1201b1881728c9e4af637d4e0cec315e3db7 in geode-native's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=5dba120 ]

GEODE-2513 Unbranding docs: Top-level files, nav correction


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57823: GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57823/#review169635
---


Ship it!




Ship It!

- Kirk Lund


On March 21, 2017, 10:25 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57823/
> ---
> 
> (Updated March 21, 2017, 10:25 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons 
> StringUtils
> 
> 
> Diffs
> -
> 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
>  9b24393792cc52773089e08db6f1739c0d2c553f 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
>  083731ba9e26e711b72f8bf0bdf470d9852aa663 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java
>  d20be590d12faf53f91a64ad0d96646b92dd118e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
>  758ad4be1f41946b98283c45ac27a022c75a9f14 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionService.java
>  2e0a6f4b40c789add5854690cfc0882ea41218a5 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionsService.java
>  79937425fa9ad4f90b1b3d8aa64d17975421106e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java
>  e94ef631724b4a62d5a2486674fc7a2e5f746788 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberAsynchEventQueuesService.java
>  e421ea09e81843c037e0430089a3d1062a44e814 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberClientsService.java
>  2486fd46dd7155a08353717ea965f10533312366 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberDetailsService.java
>  c311c67413eb74099a6f6f31b31555d9f9c86a2f 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberDiskThroughputService.java
>  98d094fe646be181c4724f85b4eb72ef912f33b9 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGCPausesService.java
>  1a34b0a9bb3d0942d11f975b714cff57bd002ddd 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java
>  c9b40fd5e9ecf64fcd262750797dc79cacd4ed11 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberHeapUsageService.java
>  1a7c54f135ac6aa29983d66cf50b4c59294ece07 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberKeyStatisticsService.java
>  ef6ccb82f58637cb714de2cf06bdcb5f23f98f13 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberRegionsService.java
>  c8addd979d72bf472e487b090c751deb2fcd9ff5 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/SystemAlertsService.java
>  d7f119b711c3b6168d826d195c582f655f10af68 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/StringUtils.java
>  df7c5a5e5dde97fd726b46f7007121e0538bd01a 
> 
> 
> Diff: https://reviews.apache.org/r/57823/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Blacklist asf904 for Geode nightly job

[Anthony Baker]

Would be very nice to run our jenkins jobs from a docker container to avoid 
these environmental quirks.

Anthony

> On Mar 21, 2017, at 12:01 PM, Mark Bretl  wrote:
> 
> Hi Kirk,
> 
> It looks like the build actually ran on a machine called 'H4', which is
> designated as a Hadoop machine. I do not see why running on a Hadoop system
> would be an issue, however, I do not know the ASF infrastructure well
> enough to know why there are DNS issues.
> 
> We use labels, tied to certain Jenkins nodes, to restrict where we run our
> builds, however, if a new system is added to the label, there is not much
> we can do. Maybe it is time to work worth INFRA, or some other container,
> to get a environment we can rely on all the time?
> 
> --Mark
> 
> On Tue, Mar 21, 2017 at 11:13 AM, Kirk Lund  wrote:
> 
>> Please blacklist asf904 for the Geode nightly job. It seems to be giving
>> bad DNS info to our tests, causing UniversalMembershipListenerAda
>> pterDUnitTest
>> to fail again. Alternatively, if someone else wants to look into the
>> failures in UniversalMembershipListenerAdapterDUnitTest please go ahead.
>> I've done all I can for the test.
>> 
>> Thanks,
>> Kirk
>> 

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #500 was SUCCESSFUL (with 1680 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #500 was successful.
---
Scheduled
1682 tests in total.

https://build.spring.io/browse/SGF-NAG-500/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169637
---


Fix it, then Ship it!




Fix it and Ship it!


geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
Lines 72 (patched)


Just in case we eventually change integrationTest to not forkEvery 1, we 
should add this in to undo the System.setProperty:
```java
@ClassRule
public static RestoreSystemProperties restoreSystemProperties = new 
RestoreSystemProperties();
```
Or code it by hand in @AfterClass.


- Kirk Lund


On March 21, 2017, 9:48 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 9:48 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
>  e88360ba1506f1a7b9c7df87899d5ec19abec630 
>   geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin restarted
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57797: GEODE-2535: added a boolean flag to track if an entry is in memory or on disk

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57797/#review169638
---




geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java
Lines 1749 (patched)


now that this method is on RecoveredEntry the method name 
"updateRecoveredEntry" is bad.
The "RecoveredEntry" is now implicit because it is on the RecoveredEntry 
class.

Also these methods apply the contents of the RecoveredEntry to the 
DiskEntry parameter.
So I'd suggest you rename these methods:
"applyToDiskEntry"


- Darrel Schneider


On March 20, 2017, 5:37 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57797/
> ---
> 
> (Updated March 20, 2017, 5:37 p.m.)
> 
> 
> Review request for geode, anilkumar gingade and Darrel Schneider.
> 
> 
> Bugs: GEODE-2535
> https://issues.apache.org/jira/browse/GEODE-2535
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Use the boolean flag to determine if an entry is in memory or on disk so that 
> stats are correctly updated.
> Avoid negating keyId by using the boolean flag.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
>  e3e87ea 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java 
> d00f7a0 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskId.java 
> 8d2c675 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> 642eed3 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 27f41a2 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegRecoveryJUnitTest.java
>  3fd091b 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/OplogJUnitTest.java 
> 7549ea7 
> 
> 
> Diff: https://reviews.apache.org/r/57797/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169636
---




geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
Lines 72 (patched)


remove this and the test should still pass.



geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
Lines 270 (patched)


declare a PUSE_PORT_PROP here to be the same value of the 
PulsePort.SYSTEM_PROPERTY_PULSE_PORT



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
Lines 20 (patched)


We should not introduce this dependency here. Pulse needs to be run 
separately without the gemfire jars.



geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
Lines 152 (patched)


Should not use ConfigurationProperties here, Use 
PuseConstants.SYSTEM_PROPERTY_PULSE_PORT


- Jinmei Liao


On March 21, 2017, 9:48 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 9:48 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
>  e88360ba1506f1a7b9c7df87899d5ec19abec630 
>   geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin restarted
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

[jira] [Assigned] (GEODE-2704) Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

[Kevin Duling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling reassigned GEODE-2704:
---

Assignee: Kevin Duling

> Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils
> 
>
> Key: GEODE-2704
> URL: https://issues.apache.org/jira/browse/GEODE-2704
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Moving away from these custom classes to use more standardized ones.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57823: GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57823/#review169640
---


Ship it!




Ship It!

- Jared Stewart


On March 21, 2017, 10:25 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57823/
> ---
> 
> (Updated March 21, 2017, 10:25 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons 
> StringUtils
> 
> 
> Diffs
> -
> 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
>  9b24393792cc52773089e08db6f1739c0d2c553f 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
>  083731ba9e26e711b72f8bf0bdf470d9852aa663 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java
>  d20be590d12faf53f91a64ad0d96646b92dd118e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
>  758ad4be1f41946b98283c45ac27a022c75a9f14 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionService.java
>  2e0a6f4b40c789add5854690cfc0882ea41218a5 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionsService.java
>  79937425fa9ad4f90b1b3d8aa64d17975421106e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java
>  e94ef631724b4a62d5a2486674fc7a2e5f746788 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberAsynchEventQueuesService.java
>  e421ea09e81843c037e0430089a3d1062a44e814 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberClientsService.java
>  2486fd46dd7155a08353717ea965f10533312366 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberDetailsService.java
>  c311c67413eb74099a6f6f31b31555d9f9c86a2f 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberDiskThroughputService.java
>  98d094fe646be181c4724f85b4eb72ef912f33b9 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGCPausesService.java
>  1a34b0a9bb3d0942d11f975b714cff57bd002ddd 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java
>  c9b40fd5e9ecf64fcd262750797dc79cacd4ed11 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberHeapUsageService.java
>  1a7c54f135ac6aa29983d66cf50b4c59294ece07 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberKeyStatisticsService.java
>  ef6ccb82f58637cb714de2cf06bdcb5f23f98f13 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberRegionsService.java
>  c8addd979d72bf472e487b090c751deb2fcd9ff5 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/SystemAlertsService.java
>  d7f119b711c3b6168d826d195c582f655f10af68 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/StringUtils.java
>  df7c5a5e5dde97fd726b46f7007121e0538bd01a 
> 
> 
> Diff: https://reviews.apache.org/r/57823/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/
---

(Updated March 21, 2017, 4:22 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
embedded pulse server still tries to connect to jmx using 1099


Diffs (updated)
-

  geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
  
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
 57711258fbbc73570656e14ee8f05550ae32e891 
  
geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
 e88360ba1506f1a7b9c7df87899d5ec19abec630 
  geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
 5408a5651774a63c16f27722c6ff7bda25cbaaa8 
  geode-pulse/src/main/resources/pulse.properties 
878bc680bbcc4369eb2d3859c6377b8942bc89d7 


Diff: https://reviews.apache.org/r/57796/diff/3/

Changes: https://reviews.apache.org/r/57796/diff/2-3/


Testing
---

precheckin restarted


Thanks,

Kevin Duling

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kevin Duling]

> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
> > Lines 159 (patched)
> > 
> >
> > Is this system proeprty set manually or by the locator/server when 
> > starting up the pulse service?
> 
> Kevin Duling wrote:
> It is set manually by the test.  Prior to my change, Pulse only read from 
> `pulse.properties` off of the classpath to set the `pulse.port` value or used 
> the default.
> 
> Jinmei Liao wrote:
> So when a user starts a locator with jmx-manager-port other than 1099, he 
> still would have problem having pulse connect to this locator?
> 
> Kevin Duling wrote:
> He would have to set `pulse.port` to match `jmx-manager-port`.  Pulse has 
> a lot of different properties, such as `pulse.host`, `pulse.embedded`, 
> `pulse.embedded.sqlf`, etc.  They're laid out in the `pulse.properties` file. 
>  One could argue that pulse should look for `jmx-manager-port` but then rules 
> will have to be defined for when someone specifies both properties. Which one 
> wins?
> 
> Jinmei Liao wrote:
> In the embeded case, I don't think that property file is even used
> 
> Kevin Duling wrote:
> Not quite correct.  In the case of embedded, `pulse.host` and 
> `pulse.port` are ignored, but the rest of the properties are loaded and used. 
>  I had tried to use `jmx-manager-port` before, but the properties are not set 
> in the system.  Instead, they are passed down as a properties object and 
> visibility is lost once we reach `line 137` in 
> `ManagementAgent.startAgent()`.  At this point, we turn it over to Jetty to 
> start the service, but the properties aren't handed off.  I'm not sure they 
> can be without setting a system property.  This is why I chose to use the 
> `pulse.port` parameter that Pulse normally looks for.
> 
> Jinmei Liao wrote:
> In the end, I would like to see user do not have to change a property 
> file in order to get the imbeded pulse to work correctly when starting a 
> locator on a non-default jmx port. The work flow should just be usual:
> 1) in gfsh, when user do: "start locator --jmx-manager-port=2000" (or via 
> proeprty file)
> 2) fire up a browser, type in localhost:7070/pulse and pulse should just 
> work.

Agreed, and tested that scenario.  Works fine.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169587
---


On March 21, 2017, 2:48 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 2:48 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
>  e88360ba1506f1a7b9c7df87899d5ec19abec630 
>   geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin restarted
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57822/#review169644
---




geode-pulse/build.gradle
Lines 31 (patched)


I just noticed this line. Pulse should NOT require geode-core and 
geode-common because it is a pulse requirement that the pulse.war can be 
deployed onto a standalone web server, any communication between pulse and 
geode needs to be done via http or jmx.

I think we will just need to use log4j api to do the logging instead of 
using LogService.getLogger api if we want to get rid of PulseLogWriter


- Jinmei Liao


On March 21, 2017, 10:05 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57822/
> ---
> 
> (Updated March 21, 2017, 10:05 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1274: Migration from PulseLogWriter to Log4j standard.
> 
> 
> Diffs
> -
> 
>   geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/ExceptionHandlingAdvice.java
>  80a3c63b5d9170cf9933c43edf56da78dc62bf46 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java
>  9b24393792cc52773089e08db6f1739c0d2c553f 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java
>  083731ba9e26e711b72f8bf0bdf470d9852aa663 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java
>  d20be590d12faf53f91a64ad0d96646b92dd118e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java
>  758ad4be1f41946b98283c45ac27a022c75a9f14 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JmxManagerFinder.java
>  fa2b5b79f40a95b0a20be38c20e61d9e94a39688 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConfig.java
>  dc643b49462af9365859d899f2c798f0f2448b72 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/PulseConstants.java
>  b36c283630fcd3d143c1398ac0fecf45eec0eb54 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java
>  b228e4a754100fe07c9dbec232d5e88809aefeef 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/LogWriter.java
>  6f90e7a48a10ab2778ee00cf3d707a476ebe91eb 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/MessageFormatter.java
>  924520d3ba70a48379bd6ff9a6ce4d6e0d4ed804 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogWriter.java
>  241b34bfe5bc56e062c43944ec7aaf1cfaa657c7 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/log/PulseLogger.java
>  d22f188248d2d8fb685074523e22eac7c26f5e20 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
>  884e51fa71b79de9e5ab9e7f0f933e37b6031438 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
>  4d300f04ff82f701509d44b83dd46698dbc6035e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/LogoutHandler.java
>  e18e35d596552a40715ee772e559ffc2d077af5e 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java
>  e94ef631724b4a62d5a2486674fc7a2e5f746788 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionsMemberService.java
>  d5a913793cd22c408398f3e76767ea7379c14042 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/testbed/PropMockDataUpdater.java
>  df315728dbcc07444249f68829b9bed349736ac9 
> 
> 
> Diff: https://reviews.apache.org/r/57822/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin up and running.  Includes general PulseLogWriter conversion to 
> Log4j, with the hope that the missing pulse logging will now be gathered with 
> other artifacts.
> 
> Also included in this patch are a number of minor readability improvements 
> regarding repeated error blocks and logging text typo corrections.
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169645
---


Ship it!




Ship It!

- Jinmei Liao


On March 21, 2017, 11:22 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57796/
> ---
> 
> (Updated March 21, 2017, 11:22 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2671: When a locator is started with a custom jmx-manager-port, the 
> embedded pulse server still tries to connect to jmx using 1099
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
>  e88360ba1506f1a7b9c7df87899d5ec19abec630 
>   geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java
>  5408a5651774a63c16f27722c6ff7bda25cbaaa8 
>   geode-pulse/src/main/resources/pulse.properties 
> 878bc680bbcc4369eb2d3859c6377b8942bc89d7 
> 
> 
> Diff: https://reviews.apache.org/r/57796/diff/3/
> 
> 
> Testing
> ---
> 
> precheckin restarted
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57820/#review169639
---



A couple tests appear to still have a couple hardcoded ports (7070 and 1099).

Please read what I have to say about chaining of @Before methods and having 
many subclasses extending super tests. These are the kinds of things I ran into 
that caused lots of problems when I untangled the worst dunit tests during the 
upgrade to JUnit 4. I want to avoid reintroducing anything similar to this.


geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestServersJUnitTest.java
Line 51 (original), 41 (patched)


7070 is hardcoded



geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestServersJUnitTest.java
Line 67 (original), 56 (patched)


7070 is hardcoded



geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
Line 67 (original), 55 (patched)


7070 and 1099 are both hardcoded



geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java
Line 33 (original), 34 (patched)


Did these changes fix GEODE-1953?



geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameTest.java
Line 56 (original), 37 (patched)


Can we delete this line? Or move it into javadocs for 
testThatJavaRmiServerNameGetsSet?



geode-core/src/test/java/org/apache/geode/security/IntegratedClientContainsKeyAuthDistributedTest.java
Line 47 (original), 67 (patched)


It's not really part of this review, but the newer syntax for these 
join()/checkException() calls is:
```java
@Test
public void testContainsKey() throws Exception {
  ...
  ai1.await();  
  ai2.await();
}
```
So if you get the chance, use that new syntax. The await() even has a 
default timeout.



geode-core/src/test/java/org/apache/geode/security/IntegratedClientDestroyInvalidateAuthDistributedTest.java
Lines 46 (patched)


This is the most important part of this review and it's mostly because of 
what I've seen in previous DUnit tests. It's also because JUnit4 has 
well-defined ordering of invoking @Before/@After in super and sub classes that 
I think we should rely on.

Please don't chain before/after or setup/teardown. Fixing up this sort of 
thing was a nightmare when I fixed up dunit and brought it up to junit4.

First best practice is don't extend another test. Avoid this if possible. 
If you really have to subclass then minimize what's in either the super class 
or the sub class. For example, just set a System Property in the subclass to 
change some basic behavior. It's better to have redundant code than intertwine 
all the sub classes of the super class.

Second best practice (if you really have to do extend a super class) is to 
give each super and sub class their own uniquely named before and don't chain 
them:
```java
@Before
public void beforeSuperClass() throws Exception {

@Before
public void beforeSubClass() throws Exception {
```
JUnit4 will handle the ordering like this: it will always execute the 
@Before method(s) in the super class first and then execute the @Before 
method(s) in the subclass. So if you're going to extend tests, please give them 
unique @Before methods and don't chain them with super.xxx.



geode-core/src/test/java/org/apache/geode/security/IntegratedClientGetPutAuthDistributedTest.java
Lines 51 (patched)


Please don't chain the before/after methods. See previous comments.



geode-core/src/test/java/org/apache/geode/security/IntegratedClientRegionClearAuthDistributedTest.java
Line 32 (original), 44 (patched)


Is there any chance the ServerStarterRule changes fix GEODE-1876?



geode-core/src/test/java/org/apache/geode/security/IntegratedClientSizeAuthDistributedTest.java
Line 32 (original), 44 (patched)


I'm really tempted to delete these @Ignored tests since we will never 
enable them.



geode-core/src/test/java/org/apache/geode/security/NoShowValue1PostProcessorDUnitTest.java
Lines 55 (patched)


Please don't chain the before/after methods. See previous comments.



geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java
Line 152 (original), 151 (patched)

[jira] [Updated] (GEODE-2670) pulse with integrated security has authentication and authorization issues

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2670:
-
Component/s: security
 pulse

> pulse with integrated security has authentication and authorization issues
> --
>
> Key: GEODE-2670
> URL: https://issues.apache.org/jira/browse/GEODE-2670
> Project: Geode
>  Issue Type: Bug
>  Components: pulse, security
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
> Fix For: 1.2.0
>
>
> Steps to reproduce:
> 1) in gfsh, start up a locator with a security manager
> 2) in the browser, try to connect to pulse: http://localhost:7070/pulse
> 3) when presented a login page, try a invalid username/password.
> 4) when getting "incorrect password" hint, use the same username, try using 
> the correct password for that user. It would still say "incorrect password".
> Also, repeat above step 1 and 2, 
> 3), use a correct username and password that only have cluster:read previlage.
> 4) try to access the dataBrowser.html, expect to get denied access, but is 
> still able to access. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2671) When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2671:
-
Component/s: jmx

> When a locator is started with a custom jmx-manager-port, the embedded pulse 
> server still tries to connect to jmx using 1099
> 
>
> Key: GEODE-2671
> URL: https://issues.apache.org/jira/browse/GEODE-2671
> Project: Geode
>  Issue Type: Bug
>  Components: jmx, pulse
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
>
> embedded pulse does not use the jmx-manager-port used by the locator to 
> connect.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

[Jinmei Liao]

> On March 21, 2017, 11:41 p.m., Kirk Lund wrote:
> > A couple tests appear to still have a couple hardcoded ports (7070 and 
> > 1099).
> > 
> > Please read what I have to say about chaining of @Before methods and having 
> > many subclasses extending super tests. These are the kinds of things I ran 
> > into that caused lots of problems when I untangled the worst dunit tests 
> > during the upgrade to JUnit 4. I want to avoid reintroducing anything 
> > similar to this.

Will address this. Ideally we should not use any abstractTest class at all. 
Will see how I can deal with this.


> On March 21, 2017, 11:41 p.m., Kirk Lund wrote:
> > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestServersJUnitTest.java
> > Line 67 (original), 56 (patched)
> > 
> >
> > 7070 is hardcoded

this is test is specifically testing the default port is used if we didn't set 
any ports. This test was originally written because the default port was set to 
8080 by accident at some point.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57820/#review169639
---


On March 21, 2017, 9:09 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57820/
> ---
> 
> (Updated March 21, 2017, 9:09 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * be able to configure the various aspects of the rules before starting the 
> server when declaring the rules.
> * delete the unnecessary abstract test classes
> * allowing tests to use default ports if needed
> * created HttpClientRule to ease the connection to to pulse server
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
>  dee004ffdf9602969cf6f4c5acb59588eef9b03d 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
>  ab21094b41fd0e5966142ced48ee831872a1cbdd 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityWithSSLTest.java
>  09c3e355cf99905777fb92bf85a653258df2e05d 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestServersJUnitTest.java
>  d97bede0d432569d398ca1203ee64220b82df3d5 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java
>  43960a8983138a368d4fc1657f8518342b6987d0 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/HttpClientRule.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java
>  b9e90b6d77f29875e63ba7d742ff4ee55947dc90 
>   
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java
>  57711258fbbc73570656e14ee8f05550ae32e891 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java
>  55687438d1ceb319cedb705d720336e124818637 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
>  46a07ada5cb48d9090879937a28ac8fb285e535d 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
>  c2fde4d3659cf86c4b9e6def810cd3f299efbd0e 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
>  0df00b0340cbbcb8dace23e782490b30034f8404 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/AccessControlMBeanJUnitTest.java
>  f8aa0bd73a050ee46ac0cd631ee28b3ff4b5395f 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthenticationJUnitTest.java
>  31a4d77514f3a073af8a50da69dd1c116de5b149 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java
>  45a4b6d02a513297620b0f35af5ffb5f6e79deff 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanShiroJUnitTest.java
>  31679319a49efe4dc3c6163b4f3a6ee6f34b4eda 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerStartupRule.java
>  11077796b6c234eb63127d0c11c9d07c6bc4b0b5 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/CliCommandsSecurityTest.java
>  1e092ff837da1af79e87f31bfe91e187b8e7d9a2 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/DataCommandsSecurityTest.java
>  f403c21554a93faaabdc075fdc20dce4379458d5 
>   
> geode-core/src/test/java/org