[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEODE-2508) Generize lib naming
[ https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880633#comment-15880633 ] ASF GitHub Bot commented on GEODE-2508: --- Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/24 > Generize lib naming > --- > > Key: GEODE-2508 > URL: https://issues.apache.org/jira/browse/GEODE-2508 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Ernest Burghardt > > Make naming configurable -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2508) Generize lib naming
[ https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880632#comment-15880632 ] ASF subversion and git services commented on GEODE-2508: Commit c45b7895d91bbace062b26061aae1b50b484ab6c in geode-native's branch refs/heads/develop from [~eburghardt] [ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=c45b789 ] GEODE-2508: Fixes for Windows + suggested changes - removed dead code - reworked algo for dll finding to be modern c++ - clean up of CMakeList.txt file This closes #24. > Generize lib naming > --- > > Key: GEODE-2508 > URL: https://issues.apache.org/jira/browse/GEODE-2508 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Ernest Burghardt > > Make naming configurable -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2508) Generize lib naming
[ https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880631#comment-15880631 ] ASF subversion and git services commented on GEODE-2508: Commit 90f7514a43b81b63d20f6dbccdfa00978037aa9c in geode-native's branch refs/heads/develop from [~eburghardt] [ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=90f7514 ] GEODE-2508: Initial work on new approach to generic lib naming. > Generize lib naming > --- > > Key: GEODE-2508 > URL: https://issues.apache.org/jira/browse/GEODE-2508 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Ernest Burghardt > > Make naming configurable -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] geode-native pull request #25: GEODE-2382: Replace gemstone with geode.
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/25#discussion_r102736948 --- Diff: src/xsds/gfcpp-cache-9.0.xsd --- @@ -33,7 +33,7 @@ limitations under the License. version="9.0"> The contents of a declarative XML file correspond to APIs found in the -com.gemstone.gemfire.cache and com.gemstone.gemfire.cache.client +org.apache.geode.cache and org.apache.geode.cache.client --- End diff -- Have you verified that these are the correct packages after GemFire became Geode? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEODE-2382) Remove "gemstone" from code base
[ https://issues.apache.org/jira/browse/GEODE-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880643#comment-15880643 ] ASF GitHub Bot commented on GEODE-2382: --- Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/25#discussion_r102736948 --- Diff: src/xsds/gfcpp-cache-9.0.xsd --- @@ -33,7 +33,7 @@ limitations under the License. version="9.0"> The contents of a declarative XML file correspond to APIs found in the -com.gemstone.gemfire.cache and com.gemstone.gemfire.cache.client +org.apache.geode.cache and org.apache.geode.cache.client --- End diff -- Have you verified that these are the correct packages after GemFire became Geode? > Remove "gemstone" from code base > > > Key: GEODE-2382 > URL: https://issues.apache.org/jira/browse/GEODE-2382 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Ernest Burghardt > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (GEODE-2532) .NET Integration Tests Creates Temp Files in the Source Directory
Michael Martell created GEODE-2532: -- Summary: .NET Integration Tests Creates Temp Files in the Source Directory Key: GEODE-2532 URL: https://issues.apache.org/jira/browse/GEODE-2532 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell The C++/CLI integration tests create temporary .xml files in the src directory as shown in attachment. This pollutes your working area with files that should not be added to the repo. This task is to create these temp files in the runtime test folder. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-2532: --- Summary: .NET Integration Tests Create Temp Files in the Source Directory (was: .NET Integration Tests Creates Temp Files in the Source Directory) > .NET Integration Tests Create Temp Files in the Source Directory > > > Key: GEODE-2532 > URL: https://issues.apache.org/jira/browse/GEODE-2532 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell > > The C++/CLI integration tests create temporary .xml files in the src > directory as shown in attachment. This pollutes your working area with files > that should not be added to the repo. > This task is to create these temp files in the runtime test folder. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-2532: --- Attachment: ExtraneousTempFiles.jpg Description: The C++/CLI integration tests create temporary .xml files in the src directory as shown in attachment. This pollutes your working area with files that should not be added to the repo. This task is to create these temp files in the runtime test folder. was: The C++/CLI integration tests create temporary .xml files in the src directory as shown in attachment. This pollutes your working area with files that should not be added to the repo. This task is to create these temp files in the runtime test folder. > .NET Integration Tests Create Temp Files in the Source Directory > > > Key: GEODE-2532 > URL: https://issues.apache.org/jira/browse/GEODE-2532 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell > Attachments: ExtraneousTempFiles.jpg > > > The C++/CLI integration tests create temporary .xml files in the src > directory as shown in attachment. This pollutes your working area with files > that should not be added to the repo. > This task is to create these temp files in the runtime test folder. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: C++ Style
Just looking a new PR and we have a BUNCH of m_memberVariables... so if we choose that transformation we'll probably touch 99% of the files #funfact On Wed, Feb 22, 2017 at 3:50 PM, Ernest Burghardt wrote: > +1 for camelCase - not a fan of allowed (not as readable) or > under_scores(requires extra keying/shift) > > -1 for variable decoration regardless of scope > > +1 for const refs and I'm good with the pointers too, I think that tends > to work itself out with modern design patterns (in my experience) > > *Preincrement and Predecrement > We have A LOT of var++ that ought to be ++var --- seems like an > opportunity for some sed-Fu if no other tool will handle this for us... > > *Write Short Functions > Stretch goal for refactoring :-) > > EB > > On Tue, Feb 21, 2017 at 8:52 AM, Michael William Dodge > wrote: > >> * Variable Naming - I agree that lowercase-first camelCase is more >> readable and preferable for variable and data member names. Since class >> names are uppercase-first CamelCase, underscores should not be used. And >> alllowercase is unreadable. >> >> * Class Data Members - Any sort of Hungarian notation, including the >> leading "m_", is more trouble than it's worth, e.g., the compiler doesn't >> enforce m_foo actually being a data member. For those who have an aversion >> to this->foo, foo_ would be much better than m_foo. But I think neither a >> leading "m_" or trailing "_" is needed. >> >> * Constant Names - I always associated the leading "k" with Smalltalk >> since I first saw it in Objective-C but apparently it's originally from >> mathematics somehow. Just like with the rest of Hungarian notation, it >> doesn't mean anything to the compiler and I think it makes the code harder >> to read. It is unnecessary. >> >> * Reference vs. Pointer - I'll admit I don't see the logic to their >> argument. As far as I know, compilers pass the address for both references >> and pointers so there's no difference there. From a language standpoint, >> however, there is the very important difference that references may not be >> null. Thus, pointers (both const and non-const) should be used in cases >> where the value may be entirely absent (e.g., there is no foo) and >> references (both const and non-const) used in all other cases. There may be >> special cases (e.g., mocks for Google Test) where a pointer to an interface >> is preferable but as a general rule the precondition that a reference can >> not be null makes them preferable. >> >> Sarge >> >> > On 20 Feb, 2017, at 13:48, Jacob Barrett wrote: >> > >> > A bit back we discussed and adopted the Google C++ Style Guide. As we >> dig >> > deeper into the C++ sources we find some striking differences in some of >> > the conventions that we may want to discuss and address before tackling >> > them. >> > >> > *Variable Naming* >> > Google style dictates no *camelCase*, use either *alllowercase* or >> > *variable_name. >> > *Our C++ code has a mix of all three. Personally I prefer cameCase as >> more >> > readable. >> > >> > *Class Data Members* >> > Google style says members must end with underscore, *my_member_*. While >> I >> > find this preferable to the common practice in our code of *m_* prefix, >> > like *m_myVariable,* I am not super fond of any decoration of member >> > variables. >> > >> > *Constant Names* >> > Google says prefix with *k* and gives and example with *kCamelCase*. I >> > think *cameCase* might be a typo but again I am not fond of any variable >> > decorations. >> > >> > *Reference vs. Pointer* >> > Google says use pointer if you intend to modify the value being passed >> and >> > use const references for values that are not going to be modified. It >> says >> > do not use references except for very limited use cases. We have >> references >> > and pointers spread inconsistently throughout the source. Worst, it is >> not >> > consistent in the public API. We should decide on a standard and make >> sure >> > our API adheres to it first. >> > >> > Others may pop up as we go but these are the obvious ones standing out. >> > >> > -Jake >> >> >
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102739212 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime; int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; - m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32); + m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32); --- End diff -- C++/CLI code does not need to worry about c-style casting since it is also not C++11. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102745344
--- Diff: src/cppcache/src/statistics/HostStatHelperSolaris.cpp ---
@@ -86,23 +86,23 @@ void
HostStatHelperSolaris::refreshProcess(ProcessStats* processStats) {
}
close(fPtr);
}
- ACE_OS::snprintf(procFileName, 64, "/proc/%u/usage", (uint32)thePid);
+ ACE_OS::snprintf(procFileName, 64, "/proc/%u/usage", (uint32_t)thePid);
--- End diff --
Replace c-style casting where you are touching to C++11 style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742460
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1,
CheckPrSingleHopForIntKeysTask_REGION)
if (networkhop) {
failureCount++;
}
-int8 serverGroupFlag =
TestUtils::getCacheImpl(getHelper()->cachePtr)
+int8_t serverGroupFlag =
TestUtils::getCacheImpl(getHelper()->cachePtr)
--- End diff --
This sounds like another `bool`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743540
--- Diff: src/cppcache/src/CacheImpl.cpp ---
@@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() {
return networkhop;
}
-int8 CacheImpl::getAndResetServerGroupFlag() {
- int8 serverGroupFlag = CacheImpl::s_serverGroupFlag;
+int8_t CacheImpl::getAndResetServerGroupFlag() {
+ int8_t serverGroupFlag = CacheImpl::s_serverGroupFlag;
--- End diff --
Is this really `bool`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102744883
--- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp ---
@@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public StatisticsFactory
{
Statistics* createStatistics(StatisticsType* type, const char* textId);
Statistics* createStatistics(StatisticsType* type, const char* textId,
- int64 numericId);
+ int64_t numericId);
Statistics* createOsStatistics(StatisticsType* type, const char* textId,
- int64 numericId);
+ int64_t numericId);
Statistics* createAtomicStatistics(StatisticsType* type);
Statistics* createAtomicStatistics(StatisticsType* type, const char*
textId);
Statistics* createAtomicStatistics(StatisticsType* type, const char*
textId,
- int64 numericId);
+ int64_t numericId);
// StatisticsFactory methods: Statistics Type
//--
StatisticsType* createType(const char* name, const char* description,
- StatisticDescriptor** stats, int32
statsLength);
+ StatisticDescriptor** stats, int32_t
statsLength);
StatisticsType* findType(const char* name);
// StatisticsFactory methods: Statistics Descriptor
//-
StatisticDescriptor* createIntCounter(const char* name,
const char* description,
-const char* units, int8
largerBetter);
+const char* units, int8_t
largerBetter);
--- End diff --
Pretty sure these are `bool`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102738544 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime; int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; - m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32); + m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32); --- End diff -- You should also be addressing: - Thec-style casting - Use of int vs int32_t ``` int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; m_hashcode = static_cast(millitime) ^ static_cast(millitime >> 32); ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743673
--- Diff: src/cppcache/src/CqServiceVsdStats.hpp ---
@@ -108,7 +108,7 @@ class CPPCACHE_EXPORT CqServiceVsdStats : public
CqServiceStatistics {
class CqServiceStatType {
private:
- static int8 instanceFlag;
+ static int8_t instanceFlag;
--- End diff --
`bool`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102739037 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime; int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; - m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32); + m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32); --- End diff -- Actually, I question the need to convert any of the C++/CLI sources since the C++/CLI language isn't C++ and defines its own integer types. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102747392
--- Diff: src/cppcache/src/statistics/StatisticDescriptorImpl.cpp ---
@@ -41,8 +41,8 @@ StatisticDescriptorImpl::StatisticDescriptorImpl(const
char* statName,
FieldType
statDescriptorType,
const char*
statDescription,
const char* statUnit,
- int8 statIsStatCounter,
- int8
statIsStatLargerBetter) {
+ int8_t statIsStatCounter,
--- End diff --
`bool`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743360
--- Diff: src/cppcache/src/BucketServerLocation.hpp ---
@@ -130,7 +130,7 @@ class BucketServerLocation : public ServerLocation {
}
uint32_t objectSize() const {
-return sizeof(int) + sizeof(bool) + sizeof(int8);
+return sizeof(int) + sizeof(bool) + sizeof(int8_t);
--- End diff --
For completeness `int` should be changed `int32_t`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102746696
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.cpp ---
@@ -535,21 +535,21 @@ uint32
HostStatHelperWin::getInt32Value(PPERF_COUNTER_DEFINITION PerfCntr,
}
if (PerfCntr->CounterSize == 4) {
-uint32* lptr;
-lptr = (uint32*)((char*)PerfCntrBlk + PerfCntr->CounterOffset);
+uint32_t* lptr;
+lptr = (uint32_t*)((char*)PerfCntrBlk + PerfCntr->CounterOffset);
--- End diff --
What is this really trying to do? Maybe fix it?
C++11 style casting changes at least.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742228
--- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp ---
@@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory {
virtual StatisticDescriptor* createDoubleCounter(
const char* name, const char* description, const char* units,
- int8 largerBetter = true) = 0;
+ int8_t largerBetter = true) = 0;
--- End diff --
Might be an opportunity to correct this to `bool`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102739522 --- Diff: src/cppcache/include/geode/geode_base.hpp --- @@ -69,32 +69,9 @@ #define GF_TEMPLATE_EXPORT #endif -#if defined(_MSC_VER) -/* 32 bit Windows only, for now */ -typedef signed char int8;/**< single byte, character or boolean field */ -typedef unsigned char uint8; /**< unsigned integer value */ -typedef signed short int16; /**< signed 16 bit integer (short) */ -typedef unsigned short uint16; /**< unsigned 16 bit integer (ushort) */ -typedef signed int int32;/**< signed 32 bit integer */ -typedef unsigned int uint32; /**< unsigned 32 bit integer */ -typedef signed __int64 int64;/**< signed 64 bit integer */ -typedef unsigned __int64 uint64; /**< unsigned 64 bit integer */ - -// typedef int32intptr_t; /**< a pointer to a 32 bit integer */ -// typedef uint32 uintptr_t; /**< a pointer to an unsigned 32 bit -// integer */ - -/* Windows does not have stdint.h */ -typedef int8 int8_t; -typedef uint8 uint8_t; -typedef int16 int16_t; -typedef uint16 uint16_t; -typedef int32 int32_t; -typedef uint32 uint32_t; -typedef int64 int64_t; -typedef uint64 uint64_t; -/* end stdint.h */ +#include --- End diff -- Is it really necessary to include this at such a low level? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r10278
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType {
private:
- static int8 instanceFlag;
+ static int8_t instanceFlag;
--- End diff --
`bool`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880726#comment-15880726 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102739522 --- Diff: src/cppcache/include/geode/geode_base.hpp --- @@ -69,32 +69,9 @@ #define GF_TEMPLATE_EXPORT #endif -#if defined(_MSC_VER) -/* 32 bit Windows only, for now */ -typedef signed char int8;/**< single byte, character or boolean field */ -typedef unsigned char uint8; /**< unsigned integer value */ -typedef signed short int16; /**< signed 16 bit integer (short) */ -typedef unsigned short uint16; /**< unsigned 16 bit integer (ushort) */ -typedef signed int int32;/**< signed 32 bit integer */ -typedef unsigned int uint32; /**< unsigned 32 bit integer */ -typedef signed __int64 int64;/**< signed 64 bit integer */ -typedef unsigned __int64 uint64; /**< unsigned 64 bit integer */ - -// typedef int32intptr_t; /**< a pointer to a 32 bit integer */ -// typedef uint32 uintptr_t; /**< a pointer to an unsigned 32 bit -// integer */ - -/* Windows does not have stdint.h */ -typedef int8 int8_t; -typedef uint8 uint8_t; -typedef int16 int16_t; -typedef uint16 uint16_t; -typedef int32 int32_t; -typedef uint32 uint32_t; -typedef int64 int64_t; -typedef uint64 uint64_t; -/* end stdint.h */ +#include --- End diff -- Is it really necessary to include this at such a low level? > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880722#comment-15880722 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102739212 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime; int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; - m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32); + m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32); --- End diff -- C++/CLI code does not need to worry about c-style casting since it is also not C++11. > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880723#comment-15880723
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102747392
--- Diff: src/cppcache/src/statistics/StatisticDescriptorImpl.cpp ---
@@ -41,8 +41,8 @@ StatisticDescriptorImpl::StatisticDescriptorImpl(const
char* statName,
FieldType
statDescriptorType,
const char*
statDescription,
const char* statUnit,
- int8 statIsStatCounter,
- int8
statIsStatLargerBetter) {
+ int8_t statIsStatCounter,
--- End diff --
`bool`?
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880718#comment-15880718
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743673
--- Diff: src/cppcache/src/CqServiceVsdStats.hpp ---
@@ -108,7 +108,7 @@ class CPPCACHE_EXPORT CqServiceVsdStats : public
CqServiceStatistics {
class CqServiceStatType {
private:
- static int8 instanceFlag;
+ static int8_t instanceFlag;
--- End diff --
`bool`?
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880716#comment-15880716
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742228
--- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp ---
@@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory {
virtual StatisticDescriptor* createDoubleCounter(
const char* name, const char* description, const char* units,
- int8 largerBetter = true) = 0;
+ int8_t largerBetter = true) = 0;
--- End diff --
Might be an opportunity to correct this to `bool`.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880714#comment-15880714 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102739037 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime; int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; - m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32); + m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32); --- End diff -- Actually, I question the need to convert any of the C++/CLI sources since the C++/CLI language isn't C++ and defines its own integer types. > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880721#comment-15880721
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102745344
--- Diff: src/cppcache/src/statistics/HostStatHelperSolaris.cpp ---
@@ -86,23 +86,23 @@ void
HostStatHelperSolaris::refreshProcess(ProcessStats* processStats) {
}
close(fPtr);
}
- ACE_OS::snprintf(procFileName, 64, "/proc/%u/usage", (uint32)thePid);
+ ACE_OS::snprintf(procFileName, 64, "/proc/%u/usage", (uint32_t)thePid);
--- End diff --
Replace c-style casting where you are touching to C++11 style.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880719#comment-15880719
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r10278
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType {
private:
- static int8 instanceFlag;
+ static int8_t instanceFlag;
--- End diff --
`bool`?
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880720#comment-15880720
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102746696
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.cpp ---
@@ -535,21 +535,21 @@ uint32
HostStatHelperWin::getInt32Value(PPERF_COUNTER_DEFINITION PerfCntr,
}
if (PerfCntr->CounterSize == 4) {
-uint32* lptr;
-lptr = (uint32*)((char*)PerfCntrBlk + PerfCntr->CounterOffset);
+uint32_t* lptr;
+lptr = (uint32_t*)((char*)PerfCntrBlk + PerfCntr->CounterOffset);
--- End diff --
What is this really trying to do? Maybe fix it?
C++11 style casting changes at least.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880717#comment-15880717
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742460
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1,
CheckPrSingleHopForIntKeysTask_REGION)
if (networkhop) {
failureCount++;
}
-int8 serverGroupFlag =
TestUtils::getCacheImpl(getHelper()->cachePtr)
+int8_t serverGroupFlag =
TestUtils::getCacheImpl(getHelper()->cachePtr)
--- End diff --
This sounds like another `bool`.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880725#comment-15880725 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102738544 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime; int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; - m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32); + m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32); --- End diff -- You should also be addressing: - Thec-style casting - Use of int vs int32_t ``` int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; m_hashcode = static_cast(millitime) ^ static_cast(millitime >> 32); ``` > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880724#comment-15880724
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102744883
--- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp ---
@@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public StatisticsFactory
{
Statistics* createStatistics(StatisticsType* type, const char* textId);
Statistics* createStatistics(StatisticsType* type, const char* textId,
- int64 numericId);
+ int64_t numericId);
Statistics* createOsStatistics(StatisticsType* type, const char* textId,
- int64 numericId);
+ int64_t numericId);
Statistics* createAtomicStatistics(StatisticsType* type);
Statistics* createAtomicStatistics(StatisticsType* type, const char*
textId);
Statistics* createAtomicStatistics(StatisticsType* type, const char*
textId,
- int64 numericId);
+ int64_t numericId);
// StatisticsFactory methods: Statistics Type
//--
StatisticsType* createType(const char* name, const char* description,
- StatisticDescriptor** stats, int32
statsLength);
+ StatisticDescriptor** stats, int32_t
statsLength);
StatisticsType* findType(const char* name);
// StatisticsFactory methods: Statistics Descriptor
//-
StatisticDescriptor* createIntCounter(const char* name,
const char* description,
-const char* units, int8
largerBetter);
+const char* units, int8_t
largerBetter);
--- End diff --
Pretty sure these are `bool`.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880727#comment-15880727
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743540
--- Diff: src/cppcache/src/CacheImpl.cpp ---
@@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() {
return networkhop;
}
-int8 CacheImpl::getAndResetServerGroupFlag() {
- int8 serverGroupFlag = CacheImpl::s_serverGroupFlag;
+int8_t CacheImpl::getAndResetServerGroupFlag() {
+ int8_t serverGroupFlag = CacheImpl::s_serverGroupFlag;
--- End diff --
Is this really `bool`?
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880715#comment-15880715
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743360
--- Diff: src/cppcache/src/BucketServerLocation.hpp ---
@@ -130,7 +130,7 @@ class BucketServerLocation : public ServerLocation {
}
uint32_t objectSize() const {
-return sizeof(int) + sizeof(bool) + sizeof(int8);
+return sizeof(int) + sizeof(bool) + sizeof(int8_t);
--- End diff --
For completeness `int` should be changed `int32_t`.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] geode-native pull request #28: Feature/geode 2440
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/28#discussion_r102749040
--- Diff: src/cppcache/src/ClientMetadata.cpp ---
@@ -344,7 +344,7 @@ int ClientMetadata::assignFixedBucketId(const char*
partitionName,
FixedMapType::iterator iter = m_fpaMap.find(partitionName);
if (iter != m_fpaMap.end()) {
std::vector attList = iter->second;
-int hc = static_cast(resolvekey->hashcode());
+int hc = resolvekey->hashcode();
--- End diff --
Use consistent typing. Change `int` to `int32_t`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
Review Request 56986: GEODE-2497 surprise members are never timed out during startu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56986/ --- Review request for geode, Galen O'Sullivan and Hitesh Khamesra. Bugs: GEODE-2497 https://issues.apache.org/jira/browse/GEODE-2497 Repository: geode Description --- fixing NPE hit by tests using disable-tcp=true. In this configuration there is no dclistener in the membership manager but there _is_ a listener. Diffs - geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java d0a0cbed9c895af26dfba9c5d5ca7fe50b195a30 Diff: https://reviews.apache.org/r/56986/diff/ Testing --- precheckin, disable-tcp=true testing Thanks, Bruce Schuchardt
[jira] [Created] (GEODE-2533) Export CSV
Gregory Green created GEODE-2533:
Summary: Export CSV
Key: GEODE-2533
URL: https://issues.apache.org/jira/browse/GEODE-2533
Project: Geode
Issue Type: Wish
Components: gfsh
Reporter: Gregory Green
Fix For: 1.2.0
I would like the ability to export region data into a CSV format.
The interface should be exposed thru a gfsh command
Example: gfsh>exportCSV --region=name
A header column should exist for each object property.
User
{
String name
String email
}
[CSV]
"key","name","mail"
"1","test","t...@test.io"
Properties in nested objects will contain a dot notation for the property name.
class User
{
String name
String email
class Address
{
String street
String city
}
}
[CSV]
"key","name","mail", "address.street", "address.city"
"1","test","t...@test.io","123","charlotte"
Arrays, collections, iterators and multi-value object properties will be
converted to string using the object.toString() method.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742761
--- Diff: src/cppcache/src/Log.cpp ---
@@ -732,7 +732,7 @@ void Log::put(LogLevel level, const char* msg) {
// struct dirent **resultArray;
// int entries_count = ACE_OS::scandir(dirname.c_str(), &resultArray,
// selector, comparator);
- // int64 spaceUsed = 0;
+ // int64_t spaceUsed = 0;
--- End diff --
dead code, could go
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102757059
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -434,17 +434,17 @@ void StatArchiveWriter::openFile(std::string
filename) {
/*
ACE_Time_Value now = ACE_OS::gettimeofday();
- int64 epochsec = now.sec();
- int64 initialDate = (int64)epochsec * 1000;
+ int64_t epochsec = now.sec();
--- End diff --
another block of dead code to be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102747970
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public
LocalRegion {
CacheableVectorPtr routingObj, uint8_t getResult,
ResultCollectorPtr rc, int32_t retryAttempts,
uint32_t timeout = DEFAULT_QUERY_RESPONSE_TIMEOUT);
- GfErrType getFuncAttributes(const char* func, std::vector** attr);
+ GfErrType getFuncAttributes(const char* func, std::vector**
attr);
--- End diff --
a vector** ya don't see those too often
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743038 --- Diff: src/cppcache/src/PdxHelper.cpp --- @@ -183,9 +183,9 @@ void PdxHelper::serializePdx(DataOutput& output, nType->InitializeType(); -// int32 nTypeId =(int32) +// int32_t nTypeId =(int32_t) --- End diff -- lets delete this line too, not sure what to think about it... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743535 --- Diff: src/cppcache/src/PdxType.hpp --- @@ -89,7 +89,7 @@ class PdxType : public Serializable, int32_t* m_localToRemoteFieldMap; // TODO: - // int32 **m_positionMap; + // int32_t **m_positionMap; --- End diff -- TONOTGONNA HAPPEN is that TODO meant, let's dump this as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102756763
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -228,10 +228,10 @@ void ResourceInst::writeStatValue(StatisticDescriptor
*sd, int64 v) {
switch (typeCode) {
/* case GF_FIELDTYPE_BYTE:
-this->dataOut->writeByte((int8)v);
+this->dataOut->writeByte((int8_t)v);
--- End diff --
delete this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880812#comment-15880812
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102756763
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -228,10 +228,10 @@ void ResourceInst::writeStatValue(StatisticDescriptor
*sd, int64 v) {
switch (typeCode) {
/* case GF_FIELDTYPE_BYTE:
-this->dataOut->writeByte((int8)v);
+this->dataOut->writeByte((int8_t)v);
--- End diff --
delete this please
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880811#comment-15880811
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742761
--- Diff: src/cppcache/src/Log.cpp ---
@@ -732,7 +732,7 @@ void Log::put(LogLevel level, const char* msg) {
// struct dirent **resultArray;
// int entries_count = ACE_OS::scandir(dirname.c_str(), &resultArray,
// selector, comparator);
- // int64 spaceUsed = 0;
+ // int64_t spaceUsed = 0;
--- End diff --
dead code, could go
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880810#comment-15880810
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102747970
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public
LocalRegion {
CacheableVectorPtr routingObj, uint8_t getResult,
ResultCollectorPtr rc, int32_t retryAttempts,
uint32_t timeout = DEFAULT_QUERY_RESPONSE_TIMEOUT);
- GfErrType getFuncAttributes(const char* func, std::vector** attr);
+ GfErrType getFuncAttributes(const char* func, std::vector**
attr);
--- End diff --
a vector** ya don't see those too often
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880808#comment-15880808 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743038 --- Diff: src/cppcache/src/PdxHelper.cpp --- @@ -183,9 +183,9 @@ void PdxHelper::serializePdx(DataOutput& output, nType->InitializeType(); -// int32 nTypeId =(int32) +// int32_t nTypeId =(int32_t) --- End diff -- lets delete this line too, not sure what to think about it... > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880807#comment-15880807 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743535 --- Diff: src/cppcache/src/PdxType.hpp --- @@ -89,7 +89,7 @@ class PdxType : public Serializable, int32_t* m_localToRemoteFieldMap; // TODO: - // int32 **m_positionMap; + // int32_t **m_positionMap; --- End diff -- TONOTGONNA HAPPEN is that TODO meant, let's dump this as well > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880809#comment-15880809
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102757059
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -434,17 +434,17 @@ void StatArchiveWriter::openFile(std::string
filename) {
/*
ACE_Time_Value now = ACE_OS::gettimeofday();
- int64 epochsec = now.sec();
- int64 initialDate = (int64)epochsec * 1000;
+ int64_t epochsec = now.sec();
--- End diff --
another block of dead code to be removed
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Review Request 56960: GEODE-2491 - Don't suppress IOExceptions when writing to the lucene index
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56960/ --- Review request for geode and Jason Huynh. Repository: geode Description --- Generic IOExceptions should not be suppressed, they may indicate a real problem, not just bucket movement. Diffs - geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java 4a6a8358033a9ed0525b8b66f1b899b3b99728f7 Diff: https://reviews.apache.org/r/56960/diff/ Testing --- Thanks, Dan Smith
Review Request 56989: Adding an exception listener for the last lucene exception
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56989/ --- Review request for geode, Jason Huynh and Lynn Hughes-Godfrey. Repository: geode Description --- Adding a way for tests to observe the last seen exception from the LuceneAsyncEventListener. Diffs - geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java 4a6a8358033a9ed0525b8b66f1b899b3b99728f7 geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneExceptionObserver.java PRE-CREATION geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneEventListenerJUnitTest.java 2b7af4a8bd3db8bfe9886250f2aa0f0c48fca7f6 Diff: https://reviews.apache.org/r/56989/diff/ Testing --- Thanks, Dan Smith
Review Request 56990: Lowering the log level for errors when cleaning up the index repository
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56990/ --- Review request for geode and Jason Huynh. Repository: geode Description --- Because we pull the rug out from under the IndexWriter when a member is no longer primary, we may get exceptions back while trying to close the writer. Diffs - geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 8a68b07ebb9f83ce13da6c7922525fca113ae092 Diff: https://reviews.apache.org/r/56990/diff/ Testing --- Thanks, Dan Smith
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102769513 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime; int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; - m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32); + m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32); --- End diff -- I'm not sure I follow why you think C++/CLI sources don't need to be converted. Are you suggesting changing types like `int32` to be `System::Int32` instead? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880883#comment-15880883 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102769513 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime; int64_t millitime = epochSpan.Ticks / TimeSpan::TicksPerMillisecond; - m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32); + m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32); --- End diff -- I'm not sure I follow why you think C++/CLI sources don't need to be converted. Are you suggesting changing types like `int32` to be `System::Int32` instead? > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] geode-native pull request #25: GEODE-2382: Replace gemstone with geode.
Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/25#discussion_r102769835 --- Diff: src/xsds/gfcpp-cache-9.0.xsd --- @@ -33,7 +33,7 @@ limitations under the License. version="9.0"> The contents of a declarative XML file correspond to APIs found in the -com.gemstone.gemfire.cache and com.gemstone.gemfire.cache.client +org.apache.geode.cache and org.apache.geode.cache.client --- End diff -- I got those packages names off a checkout of the develop branch of geode yesterday so I'm pretty confident they're right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEODE-2382) Remove "gemstone" from code base
[ https://issues.apache.org/jira/browse/GEODE-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880887#comment-15880887 ] ASF GitHub Bot commented on GEODE-2382: --- Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/25#discussion_r102769835 --- Diff: src/xsds/gfcpp-cache-9.0.xsd --- @@ -33,7 +33,7 @@ limitations under the License. version="9.0"> The contents of a declarative XML file correspond to APIs found in the -com.gemstone.gemfire.cache and com.gemstone.gemfire.cache.client +org.apache.geode.cache and org.apache.geode.cache.client --- End diff -- I got those packages names off a checkout of the develop branch of geode yesterday so I'm pretty confident they're right. > Remove "gemstone" from code base > > > Key: GEODE-2382 > URL: https://issues.apache.org/jira/browse/GEODE-2382 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Ernest Burghardt > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102771046 --- Diff: src/cppcache/include/geode/geode_base.hpp --- @@ -69,32 +69,9 @@ #define GF_TEMPLATE_EXPORT #endif -#if defined(_MSC_VER) -/* 32 bit Windows only, for now */ -typedef signed char int8;/**< single byte, character or boolean field */ -typedef unsigned char uint8; /**< unsigned integer value */ -typedef signed short int16; /**< signed 16 bit integer (short) */ -typedef unsigned short uint16; /**< unsigned 16 bit integer (ushort) */ -typedef signed int int32;/**< signed 32 bit integer */ -typedef unsigned int uint32; /**< unsigned 32 bit integer */ -typedef signed __int64 int64;/**< signed 64 bit integer */ -typedef unsigned __int64 uint64; /**< unsigned 64 bit integer */ - -// typedef int32intptr_t; /**< a pointer to a 32 bit integer */ -// typedef uint32 uintptr_t; /**< a pointer to an unsigned 32 bit -// integer */ - -/* Windows does not have stdint.h */ -typedef int8 int8_t; -typedef uint8 uint8_t; -typedef int16 int16_t; -typedef uint16 uint16_t; -typedef int32 int32_t; -typedef uint32 uint32_t; -typedef int64 int64_t; -typedef uint64 uint64_t; -/* end stdint.h */ +#include --- End diff -- Keeping it here kept refactor simpler. I suspect reason it was originally here is because we `typedef` own integer fixed types across all platforms and obviously don't want to do that in every file we use these types. I'm not sure why they chose without `_t`. I will move this include to each individual file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880896#comment-15880896 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102771046 --- Diff: src/cppcache/include/geode/geode_base.hpp --- @@ -69,32 +69,9 @@ #define GF_TEMPLATE_EXPORT #endif -#if defined(_MSC_VER) -/* 32 bit Windows only, for now */ -typedef signed char int8;/**< single byte, character or boolean field */ -typedef unsigned char uint8; /**< unsigned integer value */ -typedef signed short int16; /**< signed 16 bit integer (short) */ -typedef unsigned short uint16; /**< unsigned 16 bit integer (ushort) */ -typedef signed int int32;/**< signed 32 bit integer */ -typedef unsigned int uint32; /**< unsigned 32 bit integer */ -typedef signed __int64 int64;/**< signed 64 bit integer */ -typedef unsigned __int64 uint64; /**< unsigned 64 bit integer */ - -// typedef int32intptr_t; /**< a pointer to a 32 bit integer */ -// typedef uint32 uintptr_t; /**< a pointer to an unsigned 32 bit -// integer */ - -/* Windows does not have stdint.h */ -typedef int8 int8_t; -typedef uint8 uint8_t; -typedef int16 int16_t; -typedef uint16 uint16_t; -typedef int32 int32_t; -typedef uint32 uint32_t; -typedef int64 int64_t; -typedef uint64 uint64_t; -/* end stdint.h */ +#include --- End diff -- Keeping it here kept refactor simpler. I suspect reason it was originally here is because we `typedef` own integer fixed types across all platforms and obviously don't want to do that in every file we use these types. I'm not sure why they chose without `_t`. I will move this include to each individual file. > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] geode-native pull request #28: Feature/geode 2440
Github user mmartell commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/28#discussion_r102771536
--- Diff: src/cppcache/src/ClientMetadata.cpp ---
@@ -344,7 +344,7 @@ int ClientMetadata::assignFixedBucketId(const char*
partitionName,
FixedMapType::iterator iter = m_fpaMap.find(partitionName);
if (iter != m_fpaMap.end()) {
std::vector attList = iter->second;
-int hc = static_cast(resolvekey->hashcode());
+int32_t hc = resolvekey->hashcode();
--- End diff --
Here's the change @pivotal-jbarrett suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GEODE-2231) Create new partitioning example
[ https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880901#comment-15880901 ] ASF subversion and git services commented on GEODE-2231: Commit c4b79dd9a1d81adac1e03dcc30a469788ea43fd1 in geode-examples's branch refs/heads/feature/GEODE-2231 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=c4b79dd ] Merge branch 'develop' into feature/GEODE-2231 > Create new partitioning example > --- > > Key: GEODE-2231 > URL: https://issues.apache.org/jira/browse/GEODE-2231 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Minor > > Add a new example to the geode-examples that demonstrates partitioning. > The example will use the same structure as the replicated example, starting 2 > servers that host a partitioned region (with no redundant copies). Run the > producer to populate the region. Run the consumer to see the contents of the > region. Then, stop one of the servers and run the consumer again to notice > that only roughly half (with 2 servers and hopefully a reasonable hash) of > the entries are present. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102771834
--- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp ---
@@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory {
virtual StatisticDescriptor* createDoubleCounter(
const char* name, const char* description, const char* units,
- int8 largerBetter = true) = 0;
+ int8_t largerBetter = true) = 0;
--- End diff --
Sure, I will do if obvious like this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880906#comment-15880906
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102771834
--- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp ---
@@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory {
virtual StatisticDescriptor* createDoubleCounter(
const char* name, const char* description, const char* units,
- int8 largerBetter = true) = 0;
+ int8_t largerBetter = true) = 0;
--- End diff --
Sure, I will do if obvious like this one.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772268
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType {
private:
- static int8 instanceFlag;
+ static int8_t instanceFlag;
--- End diff --
I'm not sure so I will skip this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880909#comment-15880909
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772118
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1,
CheckPrSingleHopForIntKeysTask_REGION)
if (networkhop) {
failureCount++;
}
-int8 serverGroupFlag =
TestUtils::getCacheImpl(getHelper()->cachePtr)
+int8_t serverGroupFlag =
TestUtils::getCacheImpl(getHelper()->cachePtr)
--- End diff --
I'm not sure so I will skip this one.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772225
--- Diff: src/cppcache/src/CacheImpl.cpp ---
@@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() {
return networkhop;
}
-int8 CacheImpl::getAndResetServerGroupFlag() {
- int8 serverGroupFlag = CacheImpl::s_serverGroupFlag;
+int8_t CacheImpl::getAndResetServerGroupFlag() {
+ int8_t serverGroupFlag = CacheImpl::s_serverGroupFlag;
--- End diff --
I'm not sure so I will skip this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772209
--- Diff: src/cppcache/src/BucketServerLocation.hpp ---
@@ -130,7 +130,7 @@ class BucketServerLocation : public ServerLocation {
}
uint32_t objectSize() const {
-return sizeof(int) + sizeof(bool) + sizeof(int8);
+return sizeof(int) + sizeof(bool) + sizeof(int8_t);
--- End diff --
Yes, will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772252
--- Diff: src/cppcache/src/CqServiceVsdStats.hpp ---
@@ -108,7 +108,7 @@ class CPPCACHE_EXPORT CqServiceVsdStats : public
CqServiceStatistics {
class CqServiceStatType {
private:
- static int8 instanceFlag;
+ static int8_t instanceFlag;
--- End diff --
I'm not sure so I will skip this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880911#comment-15880911
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772225
--- Diff: src/cppcache/src/CacheImpl.cpp ---
@@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() {
return networkhop;
}
-int8 CacheImpl::getAndResetServerGroupFlag() {
- int8 serverGroupFlag = CacheImpl::s_serverGroupFlag;
+int8_t CacheImpl::getAndResetServerGroupFlag() {
+ int8_t serverGroupFlag = CacheImpl::s_serverGroupFlag;
--- End diff --
I'm not sure so I will skip this one.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880912#comment-15880912
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772252
--- Diff: src/cppcache/src/CqServiceVsdStats.hpp ---
@@ -108,7 +108,7 @@ class CPPCACHE_EXPORT CqServiceVsdStats : public
CqServiceStatistics {
class CqServiceStatType {
private:
- static int8 instanceFlag;
+ static int8_t instanceFlag;
--- End diff --
I'm not sure so I will skip this one.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2533) Export CSV
[
https://issues.apache.org/jira/browse/GEODE-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880914#comment-15880914
]
Anthony Baker commented on GEODE-2533:
--
I suggest extending `gfsh export data` for this.
Note that you could use {{SnapshotReader}} to write a standalone CSV utility
that operates on previously exported binary snapshot files.
> Export CSV
> --
>
> Key: GEODE-2533
> URL: https://issues.apache.org/jira/browse/GEODE-2533
> Project: Geode
> Issue Type: Wish
> Components: gfsh
>Reporter: Gregory Green
> Fix For: 1.2.0
>
>
> I would like the ability to export region data into a CSV format.
> The interface should be exposed thru a gfsh command
> Example: gfsh>exportCSV --region=name
> A header column should exist for each object property.
> User
> {
>String name
>String email
> }
> [CSV]
> "key","name","mail"
> "1","test","t...@test.io"
> Properties in nested objects will contain a dot notation for the property
> name.
> class User
> {
>String name
>String email
>class Address
>{
> String street
> String city
>}
> }
> [CSV]
> "key","name","mail", "address.street", "address.city"
> "1","test","t...@test.io","123","charlotte"
> Arrays, collections, iterators and multi-value object properties will be
> converted to string using the object.toString() method.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880913#comment-15880913
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772268
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType {
private:
- static int8 instanceFlag;
+ static int8_t instanceFlag;
--- End diff --
I'm not sure so I will skip this one.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (GEODE-2533) Export CSV
[
https://issues.apache.org/jira/browse/GEODE-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anthony Baker updated GEODE-2533:
-
Fix Version/s: (was: 1.2.0)
> Export CSV
> --
>
> Key: GEODE-2533
> URL: https://issues.apache.org/jira/browse/GEODE-2533
> Project: Geode
> Issue Type: Wish
> Components: gfsh
>Reporter: Gregory Green
>
> I would like the ability to export region data into a CSV format.
> The interface should be exposed thru a gfsh command
> Example: gfsh>exportCSV --region=name
> A header column should exist for each object property.
> User
> {
>String name
>String email
> }
> [CSV]
> "key","name","mail"
> "1","test","t...@test.io"
> Properties in nested objects will contain a dot notation for the property
> name.
> class User
> {
>String name
>String email
>class Address
>{
> String street
> String city
>}
> }
> [CSV]
> "key","name","mail", "address.street", "address.city"
> "1","test","t...@test.io","123","charlotte"
> Arrays, collections, iterators and multi-value object properties will be
> converted to string using the object.toString() method.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (GEODE-2486) Developer can use encrypted ciphers
[ https://issues.apache.org/jira/browse/GEODE-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2486: - Fix Version/s: (was: 1.2.0) > Developer can use encrypted ciphers > --- > > Key: GEODE-2486 > URL: https://issues.apache.org/jira/browse/GEODE-2486 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Jacob S. Barrett > > SSLImpl does not correctly initialize the OpenSSL library so ciphers other > than the NULL cipher can be used. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (GEODE-2319) Native Client Build fails on Ubuntu 16
[
https://issues.apache.org/jira/browse/GEODE-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anthony Baker updated GEODE-2319:
-
Fix Version/s: (was: 1.2.0)
> Native Client Build fails on Ubuntu 16
> --
>
> Key: GEODE-2319
> URL: https://issues.apache.org/jira/browse/GEODE-2319
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> Error get on Ubuntu is :
> {code:java}
> [ 49%] Building CXX object
> cppcache/src/CMakeFiles/gfcppcache.dir/PdxLocalWriter.cpp.o
> [ 49%] Building CXX object
> cppcache/src/CMakeFiles/gfcppcache.dir/CacheStatistics.cpp.o
> [ 49%] Linking CXX shared library libgfcppcache.so
> ../../dependencies/libxml2/libxml2-extern-prefix/lib/libxml2.a(xmlIO.o): In
> function `xmlGzfileOpen_real':
> xmlIO.c:(.text+0xf9d): undefined reference to `gzdopen'
> xmlIO.c:(.text+0x1055): undefined reference to `gzopen64'
> ../../dependencies/libxml2/libxml2-extern-prefix/lib/libxml2.a(xmlIO.o): In
> function `xmlGzfileOpenW':
> xmlIO.c:(.text+0x1158): undefined reference to `gzdopen'
> xmlIO.c:(.text+0x11f9): undefined reference to `gzopen64'
> ../../dependencies/libxml2/libxml2-extern-prefix/lib/libxml2.a(xmlIO.o): In
> function `xmlGzfileRead':
> xmlIO.c:(.text+0x1240): undefined reference to `gzread'
> ../../dependencies/libxml2/libxml2-extern-prefix/lib/libxml2.a(xmlIO.o): In
> function `xmlGzfileWrite':
> ...
> collect2: error: ld returned 1 exit status
> cppcache/src/CMakeFiles/gfcppcache.dir/build.make:6212: recipe for target
> 'cppcache/src/libgfcppcache.so' failed
> make[2]: *** [cppcache/src/libgfcppcache.so] Error 1
> CMakeFiles/Makefile2:936: recipe for target
> 'cppcache/src/CMakeFiles/gfcppcache.dir/all' failed
> make[1]: *** [cppcache/src/CMakeFiles/gfcppcache.dir/all] Error 2
> Makefile:149: recipe for target 'all' failed
> make: *** [all] Error 2
> {code}
> More Details are here http://markmail.org/message/f7pczufeelgxz6fx
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102773776
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.cpp ---
@@ -535,21 +535,21 @@ uint32
HostStatHelperWin::getInt32Value(PPERF_COUNTER_DEFINITION PerfCntr,
}
if (PerfCntr->CounterSize == 4) {
-uint32* lptr;
-lptr = (uint32*)((char*)PerfCntrBlk + PerfCntr->CounterOffset);
+uint32_t* lptr;
+lptr = (uint32_t*)((char*)PerfCntrBlk + PerfCntr->CounterOffset);
--- End diff --
I'll add C++ style casts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880910#comment-15880910
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772209
--- Diff: src/cppcache/src/BucketServerLocation.hpp ---
@@ -130,7 +130,7 @@ class BucketServerLocation : public ServerLocation {
}
uint32_t objectSize() const {
-return sizeof(int) + sizeof(bool) + sizeof(int8);
+return sizeof(int) + sizeof(bool) + sizeof(int8_t);
--- End diff --
Yes, will do
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102772118
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1,
CheckPrSingleHopForIntKeysTask_REGION)
if (networkhop) {
failureCount++;
}
-int8 serverGroupFlag =
TestUtils::getCacheImpl(getHelper()->cachePtr)
+int8_t serverGroupFlag =
TestUtils::getCacheImpl(getHelper()->cachePtr)
--- End diff --
I'm not sure so I will skip this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880925#comment-15880925
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102773776
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.cpp ---
@@ -535,21 +535,21 @@ uint32
HostStatHelperWin::getInt32Value(PPERF_COUNTER_DEFINITION PerfCntr,
}
if (PerfCntr->CounterSize == 4) {
-uint32* lptr;
-lptr = (uint32*)((char*)PerfCntrBlk + PerfCntr->CounterOffset);
+uint32_t* lptr;
+lptr = (uint32_t*)((char*)PerfCntrBlk + PerfCntr->CounterOffset);
--- End diff --
I'll add C++ style casts.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774007
--- Diff: src/cppcache/src/Log.cpp ---
@@ -732,7 +732,7 @@ void Log::put(LogLevel level, const char* msg) {
// struct dirent **resultArray;
// int entries_count = ACE_OS::scandir(dirname.c_str(), &resultArray,
// selector, comparator);
- // int64 spaceUsed = 0;
+ // int64_t spaceUsed = 0;
--- End diff --
Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774104
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -434,17 +434,17 @@ void StatArchiveWriter::openFile(std::string
filename) {
/*
ACE_Time_Value now = ACE_OS::gettimeofday();
- int64 epochsec = now.sec();
- int64 initialDate = (int64)epochsec * 1000;
+ int64_t epochsec = now.sec();
--- End diff --
Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880928#comment-15880928 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774038 --- Diff: src/cppcache/src/PdxHelper.cpp --- @@ -183,9 +183,9 @@ void PdxHelper::serializePdx(DataOutput& output, nType->InitializeType(); -// int32 nTypeId =(int32) +// int32_t nTypeId =(int32_t) --- End diff -- Will do. > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (GEODE-2343) Windows image sshd fails to start after build user password expires
[ https://issues.apache.org/jira/browse/GEODE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2343: - Fix Version/s: (was: 1.2.0) > Windows image sshd fails to start after build user password expires > --- > > Key: GEODE-2343 > URL: https://issues.apache.org/jira/browse/GEODE-2343 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Jacob S. Barrett > > When the password for the build user expires sshd does not start rending the > image useless after a period of time. > Disable build user password expiration in build-windows packer script. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (GEODE-2344) Upgrade Geode-NC ordinal
[ https://issues.apache.org/jira/browse/GEODE-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2344: - Fix Version/s: (was: 1.2.0) > Upgrade Geode-NC ordinal > > > Key: GEODE-2344 > URL: https://issues.apache.org/jira/browse/GEODE-2344 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > currently we use 8.x ordinal, need to work using the 9.0 ordinal -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (GEODE-2408) Refactor CacheableDate to use C++ std::chrono
[ https://issues.apache.org/jira/browse/GEODE-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2408: - Fix Version/s: (was: 1.2.0) > Refactor CacheableDate to use C++ std::chrono > - > > Key: GEODE-2408 > URL: https://issues.apache.org/jira/browse/GEODE-2408 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774081 --- Diff: src/cppcache/src/PdxType.hpp --- @@ -89,7 +89,7 @@ class PdxType : public Serializable, int32_t* m_localToRemoteFieldMap; // TODO: - // int32 **m_positionMap; + // int32_t **m_positionMap; --- End diff -- Will do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (GEODE-2308) Replace GemFire branding with Geode branding.
[ https://issues.apache.org/jira/browse/GEODE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2308: - Fix Version/s: (was: 1.2.0) > Replace GemFire branding with Geode branding. > - > > Key: GEODE-2308 > URL: https://issues.apache.org/jira/browse/GEODE-2308 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Jacob S. Barrett > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774094
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -228,10 +228,10 @@ void ResourceInst::writeStatValue(StatisticDescriptor
*sd, int64 v) {
switch (typeCode) {
/* case GF_FIELDTYPE_BYTE:
-this->dataOut->writeByte((int8)v);
+this->dataOut->writeByte((int8_t)v);
--- End diff --
Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774038 --- Diff: src/cppcache/src/PdxHelper.cpp --- @@ -183,9 +183,9 @@ void PdxHelper::serializePdx(DataOutput& output, nType->InitializeType(); -// int32 nTypeId =(int32) +// int32_t nTypeId =(int32_t) --- End diff -- Will do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (GEODE-2316) Replace GemFire namespace with Geode namespace
[ https://issues.apache.org/jira/browse/GEODE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2316: - Fix Version/s: (was: 1.2.0) > Replace GemFire namespace with Geode namespace > -- > > Key: GEODE-2316 > URL: https://issues.apache.org/jira/browse/GEODE-2316 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Dodge >Assignee: Jacob S. Barrett > > For the code under cppcache, replace gemfire with apache::geode::client. > For the code under clicache, replace GemStone.GemFire.Cache.Generic and > GemStone.GemFire.Cache with Apache.Geode.Client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (GEODE-2306) Update native client BUILDING.md to reflect changes for Geode
[ https://issues.apache.org/jira/browse/GEODE-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2306: - Fix Version/s: (was: 1.2.0) > Update native client BUILDING.md to reflect changes for Geode > - > > Key: GEODE-2306 > URL: https://issues.apache.org/jira/browse/GEODE-2306 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Jacob S. Barrett >Assignee: Michael Dodge > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880929#comment-15880929 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774081 --- Diff: src/cppcache/src/PdxType.hpp --- @@ -89,7 +89,7 @@ class PdxType : public Serializable, int32_t* m_localToRemoteFieldMap; // TODO: - // int32 **m_positionMap; + // int32_t **m_positionMap; --- End diff -- Will do. > Replace all non-standard types in all public includes / API > --- > > Key: GEODE-2439 > URL: https://issues.apache.org/jira/browse/GEODE-2439 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > research other non-standard types in API, ACE_Time -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880927#comment-15880927
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774007
--- Diff: src/cppcache/src/Log.cpp ---
@@ -732,7 +732,7 @@ void Log::put(LogLevel level, const char* msg) {
// struct dirent **resultArray;
// int entries_count = ACE_OS::scandir(dirname.c_str(), &resultArray,
// selector, comparator);
- // int64 spaceUsed = 0;
+ // int64_t spaceUsed = 0;
--- End diff --
Will do.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (GEODE-2370) Need to create a CONTRIBUTING.md
[ https://issues.apache.org/jira/browse/GEODE-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2370: - Fix Version/s: (was: 1.2.0) > Need to create a CONTRIBUTING.md > > > Key: GEODE-2370 > URL: https://issues.apache.org/jira/browse/GEODE-2370 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt > > The community will be contributing and will want some basic instruction as to > how this is done and expectations... > i.e. the expectation to submit properly formatted code; we need to create a > CONTRIBUTING.md that among other items it might cover, should show how to > apply the formatting using the "format" target for c++ code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (GEODE-2340) Update GemfireCppCache
[ https://issues.apache.org/jira/browse/GEODE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2340: - Fix Version/s: (was: 1.2.0) > Update GemfireCppCache > -- > > Key: GEODE-2340 > URL: https://issues.apache.org/jira/browse/GEODE-2340 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Ernest Burghardt > > the following files are called Gemfire* let's make them Geode* > src//cppcache/include/gfcpp/GemfireCppCache.hpp > src//cppcache/include/gfcpp/GemfireCppCache.inl > Also, update inclusions usage and named components as appropriate. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API
[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880930#comment-15880930
]
ASF GitHub Bot commented on GEODE-2439:
---
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774094
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -228,10 +228,10 @@ void ResourceInst::writeStatValue(StatisticDescriptor
*sd, int64 v) {
switch (typeCode) {
/* case GF_FIELDTYPE_BYTE:
-this->dataOut->writeByte((int8)v);
+this->dataOut->writeByte((int8_t)v);
--- End diff --
Will do.
> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774330
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public
LocalRegion {
CacheableVectorPtr routingObj, uint8_t getResult,
ResultCollectorPtr rc, int32_t retryAttempts,
uint32_t timeout = DEFAULT_QUERY_RESPONSE_TIMEOUT);
- GfErrType getFuncAttributes(const char* func, std::vector** attr);
+ GfErrType getFuncAttributes(const char* func, std::vector**
attr);
--- End diff --
Yes, this is nearly 3 star code!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
