[GitHub] [doris] zddr commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
zddr commented on PR #19123: URL: https://github.com/apache/doris/pull/19123#issuecomment-1539577673 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19372: [Interface](exec) Add interface for multi cast data sink
github-actions[bot] commented on PR #19372: URL: https://github.com/apache/doris/pull/19372#issuecomment-1539578260 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
github-actions[bot] commented on PR #19123: URL: https://github.com/apache/doris/pull/19123#issuecomment-1539580454 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
github-actions[bot] commented on PR #19123: URL: https://github.com/apache/doris/pull/19123#issuecomment-1539579394 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wangbo opened a new pull request, #19443: [improvement][executor]Split free block when using shared scan
wangbo opened a new pull request, #19443: URL: https://github.com/apache/doris/pull/19443 # Proposed changes When exec shared scan, multiple scanners visit freeblocks may cause performance bottleneck in tpch q17. So we need to split free blocks to reduce competition. # Key Design Introducing _scan_producer_group_num, it means the group num which shared variables of producer should divied into. For example, we pre-allocate 100 freeblocks, we should divide them to ```_scan_producer_group_num``` groups. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #19325: [Chore](build) update some doc about build enviroment
adonis0147 commented on PR #19325: URL: https://github.com/apache/doris/pull/19325#issuecomment-1539584683 [This line](https://github.com/apache/doris/blob/master/env.sh#L64) should be changed to `llvm@16` . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19410: [enhance](Cold&Heat separation) use file block cache for cold heat separation rowset
github-actions[bot] commented on PR #19410: URL: https://github.com/apache/doris/pull/19410#issuecomment-1539586192 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #19443: [improvement](executor)Split free block when using shared scan
github-actions[bot] commented on code in PR #19443:
URL: https://github.com/apache/doris/pull/19443#discussion_r1188228479
##
be/src/vec/exec/scan/pip_scanner_context.h:
##
@@ -169,19 +173,87 @@ class PipScannerContext : public
vectorized::ScannerContext {
}
}
+vectorized::BlockUPtr get_free_block(bool* has_free_block, bool
get_not_empty_block = false,
+ int id = -1) override {
+id = id % _free_block_queue_len;
+{
+std::unique_lock l(*_free_block_queue_mutexs[id]);
+if (auto& free_blocks = _free_blocks_queues[id];
!free_blocks.empty()) {
+if (!get_not_empty_block || free_blocks.back()->mem_reuse()) {
+auto block = std::move(free_blocks.back());
+free_blocks.pop_back();
+_total_free_block_num--;
+_free_blocks_memory_usage->add(-block->allocated_bytes());
+return block;
+}
+}
+}
+*has_free_block = false;
+
+COUNTER_UPDATE(_newly_create_free_blocks_num, 1);
+return vectorized::Block::create_unique(_real_tuple_desc->slots(),
_batch_size,
+true /*ignore invalid slots*/);
+}
+
+void return_free_block(std::unique_ptr block, int id)
override {
+id = id % _free_block_queue_len;
+block->clear_column_data();
+_free_blocks_memory_usage->add(block->allocated_bytes());
+std::unique_lock l(*_free_block_queue_mutexs[id]);
+_free_blocks_queues[id].emplace_back(std::move(block));
+_total_free_block_num++;
+}
+
+void _init_free_block(int pre_alloc_block_count, int real_block_size)
override {
+// The free blocks is used for final output block of scanners.
+// So use _output_tuple_desc;
+int64_t free_blocks_memory_usage = 0;
+for (int i = 0, j = 0; i < pre_alloc_block_count; ++i, j++) {
+auto block = vectorized::Block::create_unique(
+_output_tuple_desc->slots(), real_block_size, true
/*ignore invalid slots*/);
+free_blocks_memory_usage += block->allocated_bytes();
+_free_blocks_queues[j].emplace_back(std::move(block));
+if (j == _free_block_queue_len - 1) j = -1;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (j == _free_block_queue_len - 1) { j = -1;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #19410: [enhance](Cold&Heat separation) use file block cache for cold heat separation rowset
ByteYue commented on PR #19410: URL: https://github.com/apache/doris/pull/19410#issuecomment-1539587667 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] caoliang-web closed pull request #17805: [improvement](config)update FE config max_running_txn_num_per_db default value
caoliang-web closed pull request #17805: [improvement](config)update FE config max_running_txn_num_per_db default value URL: https://github.com/apache/doris/pull/17805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #19325: [Chore](build) update some doc about build enviroment
adonis0147 commented on code in PR #19325: URL: https://github.com/apache/doris/pull/19325#discussion_r1188230291 ## be/CMakeLists.txt: ## @@ -503,6 +503,10 @@ if (COMPILER_CLANG) message(FATAL_ERROR "Need Clang version at least 13") endif() +if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS "16") +message(WARNING "Doris recommended to use Clang-16 to build backend") +endif() + Review Comment: I think we should retain one of these `if` statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] AshinGau closed pull request #19178: [fix](FileReader) fix profile of json&csv reader
AshinGau closed pull request #19178: [fix](FileReader) fix profile of json&csv reader URL: https://github.com/apache/doris/pull/19178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
chenlinzhong commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1539594564 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19441: [fix](Nereids): avoid to push top Project of JoinCluster in PushdownProjectThroughJoin
hello-stephen commented on PR #19441: URL: https://github.com/apache/doris/pull/19441#issuecomment-1539595139 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.09 seconds stream load tsv: 428 seconds loaded 74807831229 Bytes, about 166 MB/s stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230509072141_clickbench_pr_140781.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19142: [feature](load-refactor) Step1: InsertStmt as facade layer and run S3/Broker Load as POC
HHoflittlefish777 commented on PR #19142: URL: https://github.com/apache/doris/pull/19142#issuecomment-1539599102 @TangSiyang2001 you can rebase master and try again, some case have error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
chenlinzhong commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1539601928 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
github-actions[bot] commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1539603201 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
github-actions[bot] commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1539603251 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong merged pull request #19209: [feature](graph)Support querying data from the Nebula graph database
chenlinzhong merged PR #19209: URL: https://github.com/apache/doris/pull/19209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (1424fb96ca -> aeb3450151)
This is an automated email from the ASF dual-hosted git repository. linzhongcheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 1424fb96ca [bugfix](regression-test) disable string column length too large test and disable auto statistics collector and disable window function test (#19428) add aeb3450151 [feature](graph)Support querying data from the Nebula graph database (#19209) No new revisions were added by this update. Summary of changes: be/src/vec/exec/vjdbc_connector.cpp| 4 +- docs/en/docs/lakehouse/external-table/jdbc.md | 103 + docs/zh-CN/docs/lakehouse/external-table/jdbc.md | 102 .../org/apache/doris/catalog/JdbcResource.java | 4 + .../java/org/apache/doris/catalog/JdbcTable.java | 1 + .../org/apache/doris/planner/JdbcScanNode.java | 25 + fe/java-udf/pom.xml| 5 + .../java/org/apache/doris/udf/JdbcExecutor.java| 101 .../main/java/org/apache/doris/udf/UdfUtils.java | 55 +++ gensrc/script/doris_builtins_functions.py | 3 +- gensrc/thrift/Types.thrift | 3 +- 11 files changed, 364 insertions(+), 42 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dutyu commented on pull request #19271: [Feature](block-rule) Support qps for sql block rule
dutyu commented on PR #19271: URL: https://github.com/apache/doris/pull/19271#issuecomment-1539604938 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 closed pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
ZhangYu0123 closed pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists URL: https://github.com/apache/doris/pull/19358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Jibing-Li commented on pull request #19434: [Fix](multi catalog)Return all partition values while reading hive table.
Jibing-Li commented on PR #19434: URL: https://github.com/apache/doris/pull/19434#issuecomment-1539615008 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 opened a new pull request, #19444: [fix](inverted index) fix query fail caused by FullTextIndexReader not check index file whether exists
ZhangYu0123 opened a new pull request, #19444: URL: https://github.com/apache/doris/pull/19444 # Proposed changes (1) = predicate should support INVERTED_INDEX_FILE_NOT_FOUND error.  the problem: FullTextIndexReader doesn't check file and throws CLuceneError directly and lead to query error.  (2) refactor some java style code in C++ file (3) fix MatchPredicate dose not check the error code Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname opened a new pull request, #19445: [Enhance](Nereids)add default order by of non-order query for nereids
sohardforaname opened a new pull request, #19445: URL: https://github.com/apache/doris/pull/19445 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19345: [feature](executor) Automatically set the instance_num using the info from be.
Mryange commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1539618374 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] SWJTU-ZhangLei commented on pull request #19335: [fix](bdbje) remove `System.exit(-1)` in BDBEnvironment.close()
SWJTU-ZhangLei commented on PR #19335: URL: https://github.com/apache/doris/pull/19335#issuecomment-1539618673 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19345: [feature](executor) Automatically set the instance_num using the info from be.
github-actions[bot] commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1539619816 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #19445: [Enhance](Nereids)add default order by of non-order query for nereids
sohardforaname commented on PR #19445: URL: https://github.com/apache/doris/pull/19445#issuecomment-1539620996 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #19438: [Enhance](planner)add default order by of non-order query for original planner
sohardforaname commented on PR #19438: URL: https://github.com/apache/doris/pull/19438#issuecomment-1539620891 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #19444: [fix](inverted index) fix query fail caused by FullTextIndexReader not check index file whether exists
ZhangYu0123 commented on PR #19444: URL: https://github.com/apache/doris/pull/19444#issuecomment-1539622444 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19444: [fix](inverted index) fix query fail caused by FullTextIndexReader not check index file whether exists
github-actions[bot] commented on PR #19444: URL: https://github.com/apache/doris/pull/19444#issuecomment-1539622780 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18805: [Feature](stat) Collect the information statistics of the query hit
github-actions[bot] commented on PR #18805: URL: https://github.com/apache/doris/pull/18805#issuecomment-1539625102 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on pull request #19242: [Improvement](multicatalog) support show_partitions for hms catalog
Yulei-Yang commented on PR #19242: URL: https://github.com/apache/doris/pull/19242#issuecomment-1539631220 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on pull request #19319: [Improvement](planner) expand sql-block-rule to make it can be used on all kinds of sql stmt
Yulei-Yang commented on PR #19319: URL: https://github.com/apache/doris/pull/19319#issuecomment-1539631383 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19434: [Fix](multi catalog)Return all partition values while reading hive table.
github-actions[bot] commented on PR #19434: URL: https://github.com/apache/doris/pull/19434#issuecomment-1539632041 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19434: [Fix](multi catalog)Return all partition values while reading hive table.
github-actions[bot] commented on PR #19434: URL: https://github.com/apache/doris/pull/19434#issuecomment-1539632088 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #19142: [feature](load-refactor) Step1: InsertStmt as facade layer and run S3/Broker Load as POC
TangSiyang2001 commented on PR #19142: URL: https://github.com/apache/doris/pull/19142#issuecomment-1539633435 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #19089: [fix](core) fix multi_match_any maybe core down
nextdreamblue commented on PR #19089: URL: https://github.com/apache/doris/pull/19089#issuecomment-1539634087 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #19356: [enhancement](http) add fail reply for failed submitting tasks in single-replica-download
TangSiyang2001 commented on PR #19356: URL: https://github.com/apache/doris/pull/19356#issuecomment-1539634432 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #19104: [fix](core) fix multi_search_all_positions cause coredump when column nullable
nextdreamblue commented on PR #19104: URL: https://github.com/apache/doris/pull/19104#issuecomment-1539634487 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #19326: [feature-wip](duplicate-no-keys) schame change support for duplicate no keys
nextdreamblue commented on PR #19326: URL: https://github.com/apache/doris/pull/19326#issuecomment-1539634740 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk commented on issue #19364: [Bug] doris-1.2.4.1 is much slower than doris-1.2.1
zy-kkk commented on issue #19364: URL: https://github.com/apache/doris/issues/19364#issuecomment-1539636063 你可以在1.2.4在be.conf设置disable_storage_page_cache=false,然后重启be重新测试 我们从1.2.2版本开始默认打开了此选项  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19104: [fix](core) fix multi_search_all_positions cause coredump when column nullable
github-actions[bot] commented on PR #19104: URL: https://github.com/apache/doris/pull/19104#issuecomment-1539636762 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 closed pull request #19425: [Only-Test] master 2 weeks ago version : b3b261e
ZhangYu0123 closed pull request #19425: [Only-Test] master 2 weeks ago version : b3b261e URL: https://github.com/apache/doris/pull/19425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19356: [enhancement](http) add fail reply for failed submitting tasks in single-replica-download
github-actions[bot] commented on PR #19356: URL: https://github.com/apache/doris/pull/19356#issuecomment-1539637953 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 closed pull request #19424: [Only-Test] current master even
ZhangYu0123 closed pull request #19424: [Only-Test] current master even URL: https://github.com/apache/doris/pull/19424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19089: [fix](core) fix multi_match_any maybe core down
github-actions[bot] commented on PR #19089: URL: https://github.com/apache/doris/pull/19089#issuecomment-1539638225 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 closed pull request #19423: [Only-Test] current master odd
ZhangYu0123 closed pull request #19423: [Only-Test] current master odd URL: https://github.com/apache/doris/pull/19423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18805: [Feature](stat) Collect the information statistics of the query hit
github-actions[bot] commented on PR #18805: URL: https://github.com/apache/doris/pull/18805#issuecomment-1539639385 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] gitccl commented on pull request #19389: [Enhancement](scanner) allocate blocks in scanner_context on demand and free them on close
gitccl commented on PR #19389: URL: https://github.com/apache/doris/pull/19389#issuecomment-1539641451 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19389: [Enhancement](scanner) allocate blocks in scanner_context on demand and free them on close
github-actions[bot] commented on PR #19389: URL: https://github.com/apache/doris/pull/19389#issuecomment-1539645786 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
Mryange commented on PR #18942: URL: https://github.com/apache/doris/pull/18942#issuecomment-1539649296 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #18874: [enhancement](load) lazy-open necessary partitions when load
HHoflittlefish777 commented on PR #18874: URL: https://github.com/apache/doris/pull/18874#issuecomment-1539652428 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18942: [improvement](planner) remove virtual function call in vbloom_predicate
github-actions[bot] commented on PR #18942: URL: https://github.com/apache/doris/pull/18942#issuecomment-1539654134 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18874: [enhancement](load) lazy-open necessary partitions when load
github-actions[bot] commented on PR #18874: URL: https://github.com/apache/doris/pull/18874#issuecomment-1539655780 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19443: [improvement](executor)Split free block when using shared scan
github-actions[bot] commented on PR #19443: URL: https://github.com/apache/doris/pull/19443#issuecomment-1539657297 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on a diff in pull request #18874: [enhancement](load) lazy-open necessary partitions when load
platoneko commented on code in PR #18874:
URL: https://github.com/apache/doris/pull/18874#discussion_r1188288103
##
be/src/runtime/load_channel.cpp:
##
@@ -84,6 +84,28 @@ Status LoadChannel::open(const PTabletWriterOpenRequest&
params) {
return Status::OK();
}
+Status LoadChannel::open_partition(const PartitionOpenRequest& params) {
+int64_t index_id = params.index_id();
+std::shared_ptr channel;
+{
+std::lock_guard l(_lock);
+auto it = _tablets_channels.find(index_id);
+if (it != _tablets_channels.end()) {
+channel = it->second;
+} else {
+// create a new tablets channel
+TabletsChannelKey key(params.id(), index_id);
+channel.reset(new TabletsChannel(key, _load_id, _is_high_priority,
_self_profile));
Review Comment:
`std::make_shared` is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #19185: [bug](jsonb) fix jsonb query bug When the json key value contains "."
github-actions[bot] commented on code in PR #19185:
URL: https://github.com/apache/doris/pull/19185#discussion_r1188291061
##
be/src/util/jsonb_document.h:
##
@@ -213,6 +226,83 @@ class JsonbDocument {
char payload_[0];
};
+/// A simple input stream class for the JSON path parser.
+class Stream {
+public:
+/// Creates an input stream reading from a character string.
+/// @param string the input string
+/// @param length the length of the input string
+Stream(const char* string, size_t length) : m_position(string),
m_end(string + length), leg() {}
Review Comment:
warning: initializer for member 'leg' is redundant
[readability-redundant-member-init]
```suggestion
Stream(const char* string, size_t length) : m_position(string),
m_end(string + length), {}
```
##
be/src/util/jsonb_document.h:
##
@@ -394,14 +484,12 @@
const char* getValuePtr() const;
// find the JSONB value by a key path string (null terminated)
-JsonbValue* findPath(const char* key_path, const char* delim = ".",
- hDictFind handler = nullptr) {
-return findPath(key_path, (unsigned int)strlen(key_path), delim,
handler);
+JsonbValue* findPath(const char* key_path, hDictFind handler = nullptr) {
+return findPath(key_path, (unsigned int)strlen(key_path), handler);
Review Comment:
warning: use of undeclared identifier 'strlen' [clang-diagnostic-error]
```cpp
return findPath(key_path, (unsigned int)strlen(key_path), handler);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #18874: [enhancement](load) lazy-open necessary partitions when load
HHoflittlefish777 commented on PR #18874: URL: https://github.com/apache/doris/pull/18874#issuecomment-1539665547 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] weizhengte commented on pull request #19420: [enchancement](statistics) implement automatically analyzing statistics and support table level statistics
weizhengte commented on PR #19420: URL: https://github.com/apache/doris/pull/19420#issuecomment-1539667382 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #18874: [enhancement](load) lazy-open necessary partitions when load
HHoflittlefish777 commented on PR #18874: URL: https://github.com/apache/doris/pull/18874#issuecomment-1539667580 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18874: [enhancement](load) lazy-open necessary partitions when load
github-actions[bot] commented on PR #18874: URL: https://github.com/apache/doris/pull/18874#issuecomment-1539670767 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on a diff in pull request #18874: [enhancement](load) lazy-open necessary partitions when load
platoneko commented on code in PR #18874:
URL: https://github.com/apache/doris/pull/18874#discussion_r1188303741
##
be/src/runtime/tablets_channel.cpp:
##
@@ -281,9 +292,7 @@ Status TabletsChannel::_open_all_writers(const
PTabletWriterOpenRequest& request
}
}
if (index_slots == nullptr) {
-std::stringstream ss;
-ss << "unknown index id, key=" << _key;
-return Status::InternalError(ss.str());
+return Status::InternalError("unknown index id, key=" +
_key.to_string());
Review Comment:
Recommend to use `Status::InternalError("unknown index id, key={}",
_key.to_string());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19436: [Bugfix](Outfile) fix that export data to parquet and orc file format
github-actions[bot] commented on PR #19436: URL: https://github.com/apache/doris/pull/19436#issuecomment-1539679324 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
luozenglin commented on PR #19256: URL: https://github.com/apache/doris/pull/19256#issuecomment-1539680020 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 opened a new pull request, #19447: [chore](workflows) Disable PCH in GitHub workflows by default
adonis0147 opened a new pull request, #19447: URL: https://github.com/apache/doris/pull/19447 # Proposed changes ~~Issue Number: close #xxx~~ ## Problem summary PCH slows the BE UT workflows down. Disable it by default in workflows. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19256: [enhancement](memory) MemCounter supports lock-free thread safety
github-actions[bot] commented on PR #19256: URL: https://github.com/apache/doris/pull/19256#issuecomment-1539683581 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Bingandbing commented on pull request #18747: [Enhancement](Nereids)Add nereids minidump
Bingandbing commented on PR #18747: URL: https://github.com/apache/doris/pull/18747#issuecomment-1539684570 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #19447: [chore](workflows) Disable PCH in GitHub workflows by default
adonis0147 commented on PR #19447: URL: https://github.com/apache/doris/pull/19447#issuecomment-1539686537 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lsy3993 opened a new pull request, #19448: [typo](docs) add comment of partition and key/value column
lsy3993 opened a new pull request, #19448: URL: https://github.com/apache/doris/pull/19448 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [x] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk opened a new pull request, #19449: [typo](docs) Add an open page cache hint to the benchmark
zy-kkk opened a new pull request, #19449: URL: https://github.com/apache/doris/pull/19449 # Proposed changes Issue Number: close #19364 ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #19449: [typo](docs) Add an open page cache hint to the benchmark
zy-kkk commented on PR #19449: URL: https://github.com/apache/doris/pull/19449#issuecomment-1539691511 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #19288: [feature](nereids) support subquery combine
morrySnow commented on code in PR #19288:
URL: https://github.com/apache/doris/pull/19288#discussion_r1188234618
##
fe/fe-core/src/main/java/org/apache/doris/nereids/util/PlanTypeUtils.java:
##
@@ -0,0 +1,151 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.util;
+
+import org.apache.doris.nereids.trees.plans.logical.LogicalAggregate;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.trees.plans.logical.LogicalHaving;
+import org.apache.doris.nereids.trees.plans.logical.LogicalJoin;
+import org.apache.doris.nereids.trees.plans.logical.LogicalLimit;
+import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+import org.apache.doris.nereids.trees.plans.logical.LogicalRelation;
+import org.apache.doris.nereids.trees.plans.logical.LogicalSetOperation;
+import org.apache.doris.nereids.trees.plans.logical.LogicalSort;
+import org.apache.doris.nereids.trees.plans.logical.LogicalSubQueryAlias;
+import org.apache.doris.nereids.trees.plans.logical.LogicalWindow;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Lists;
+
+import java.util.List;
+import java.util.Set;
+
+/**
+ * Judgment for plan tree pattern, such as spj plan, etc.
+ */
+public class PlanTypeUtils {
+
+private static final Set> SPJ_PLAN =
ImmutableSet.of(
+LogicalRelation.class,
+LogicalJoin.class,
+LogicalFilter.class,
+LogicalProject.class,
+LogicalSubQueryAlias.class // FIXME
Review Comment:
add more comments to explain fix what
##
fe/fe-core/src/main/java/org/apache/doris/nereids/util/PlanTypeUtils.java:
##
@@ -0,0 +1,151 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.util;
+
+import org.apache.doris.nereids.trees.plans.logical.LogicalAggregate;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.trees.plans.logical.LogicalHaving;
+import org.apache.doris.nereids.trees.plans.logical.LogicalJoin;
+import org.apache.doris.nereids.trees.plans.logical.LogicalLimit;
+import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+import org.apache.doris.nereids.trees.plans.logical.LogicalRelation;
+import org.apache.doris.nereids.trees.plans.logical.LogicalSetOperation;
+import org.apache.doris.nereids.trees.plans.logical.LogicalSort;
+import org.apache.doris.nereids.trees.plans.logical.LogicalSubQueryAlias;
+import org.apache.doris.nereids.trees.plans.logical.LogicalWindow;
+
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Lists;
+
+import java.util.List;
+import java.util.Set;
+
+/**
+ * Judgment for plan tree pattern, such as spj plan, etc.
+ */
+public class PlanTypeUtils {
+
+private static final Set> SPJ_PLAN =
ImmutableSet.of(
+LogicalRelation.class,
+LogicalJoin.class,
+LogicalFilter.class,
+LogicalProject.class,
+LogicalSubQueryAlias.class // FIXME
+);
+
+private static final Set> SUPPORTED_PLAN =
ImmutableSet.of(
+// TODO: Set related ops
+LogicalRelation.class,
+LogicalJoin.class,
+LogicalFilter.class,
+Logica
[GitHub] [doris] xiaojunjie commented on pull request #19369: [feature](system) support decommission disk on backend
xiaojunjie commented on PR #19369: URL: https://github.com/apache/doris/pull/19369#issuecomment-1539696775 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19271: [Feature](block-rule) Support qps for sql block rule
hello-stephen commented on PR #19271: URL: https://github.com/apache/doris/pull/19271#issuecomment-1539700263 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.6 seconds stream load tsv: 432 seconds loaded 74807831229 Bytes, about 165 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230509084142_clickbench_pr_140807.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19369: [feature](system) support decommission disk on backend
github-actions[bot] commented on PR #19369: URL: https://github.com/apache/doris/pull/19369#issuecomment-1539701643 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie closed pull request #19406: [Improvement] Enhance show data types stmt
ZashJie closed pull request #19406: [Improvement] Enhance show data types stmt URL: https://github.com/apache/doris/pull/19406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] amorynan opened a new pull request, #19450: [Refact](serde) refact mysql serde for data type
amorynan opened a new pull request, #19450: URL: https://github.com/apache/doris/pull/19450 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zzzzzzzs opened a new pull request, #19451: [typo](doc) Fixed typos in variables.md
zzzs opened a new pull request, #19451: URL: https://github.com/apache/doris/pull/19451 # Proposed changes Fixed typos in variables.md ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [x] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19450: [Refact](serde) refact mysql serde for data type
github-actions[bot] commented on PR #19450: URL: https://github.com/apache/doris/pull/19450#issuecomment-1539706863 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #19318: [fix](nereids)dphyper join reorder may lost some join conjuncts
starocean999 commented on PR #19318: URL: https://github.com/apache/doris/pull/19318#issuecomment-1539708157 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #19325: [Chore](build) update some doc about build enviroment
adonis0147 commented on code in PR #19325: URL: https://github.com/apache/doris/pull/19325#discussion_r1188230291 ## be/CMakeLists.txt: ## @@ -503,6 +503,10 @@ if (COMPILER_CLANG) message(FATAL_ERROR "Need Clang version at least 13") endif() +if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS "16") +message(WARNING "Doris recommended to use Clang-16 to build backend") +endif() + Review Comment: I think we should retain one of these `if` statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #19396: [fix](nereids)fix bug of two phase limit
starocean999 commented on PR #19396: URL: https://github.com/apache/doris/pull/19396#issuecomment-1539711820 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BePPPower opened a new pull request, #19452: [BugFix](table-value-function) Fix backends() tvf
BePPPower opened a new pull request, #19452: URL: https://github.com/apache/doris/pull/19452 # Proposed changes Issue Number: close #xxx ## Problem summary Change the `Alive/SystemDecommissioned/ClusterDecommissioned` field type of the `backends()`tvf to bool ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #19449: [typo](docs) Add an open page cache hint to the benchmark
zy-kkk commented on PR #19449: URL: https://github.com/apache/doris/pull/19449#issuecomment-1539715095 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] qidaye merged pull request #19375: [chore](simdjson reader) default enable simdjson for json reader
qidaye merged PR #19375: URL: https://github.com/apache/doris/pull/19375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (aeb3450151 -> b07053f47d)
This is an automated email from the ASF dual-hosted git repository. jianliangqi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from aeb3450151 [feature](graph)Support querying data from the Nebula graph database (#19209) add b07053f47d [chore](simdjson reader) default enable simdjson for json reader (#19375) No new revisions were added by this update. Summary of changes: be/src/common/config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19452: [BugFix](table-value-function) Fix backends() tvf
github-actions[bot] commented on PR #19452: URL: https://github.com/apache/doris/pull/19452#issuecomment-1539721766 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18209: [Feature](Nereids)add executable function to support fold constant for functions.
github-actions[bot] commented on PR #18209: URL: https://github.com/apache/doris/pull/18209#issuecomment-1539722479 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on a diff in pull request #18874: [enhancement](load) lazy-open necessary partitions when load
platoneko commented on code in PR #18874:
URL: https://github.com/apache/doris/pull/18874#discussion_r1188338754
##
be/src/vec/sink/vtablet_sink.cpp:
##
@@ -1062,6 +1102,22 @@ Status VOlapTableSink::open(RuntimeState* state) {
return Status::OK();
}
+void VOlapTableSink::_open_partition(const VOlapTablePartition* partition) {
+const auto& id = partition->id;
+auto it = _opened_partitions.find(id);
+if (it == _opened_partitions.end()) {
+_opened_partitions.insert(id);
+for (int j = 0; j < partition->indexes.size(); ++j) {
Review Comment:
`for (auto& index : partition->indexes)` is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19447: [chore](workflows) Disable PCH in GitHub workflows by default
github-actions[bot] commented on PR #19447: URL: https://github.com/apache/doris/pull/19447#issuecomment-1539738509 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19447: [chore](workflows) Disable PCH in GitHub workflows by default
github-actions[bot] commented on PR #19447: URL: https://github.com/apache/doris/pull/19447#issuecomment-1539738581 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hqx871 commented on pull request #19371: [feature](array-type) Unique table support array value (#17024)
hqx871 commented on PR #19371: URL: https://github.com/apache/doris/pull/19371#issuecomment-1539739696 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-flink-connector] big-doudou commented on issue #136: [Bug]
big-doudou commented on issue #136: URL: https://github.com/apache/doris-flink-connector/issues/136#issuecomment-1539739842 我理解Doirs Schema Not Null是一种约束，约定当前字段非null，如果插入数据为null，说明这是一条错误数据。不应该 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #19122: [optimization](be) optimization for ColumnConst when writing mysql result
zclllyybb commented on PR #19122: URL: https://github.com/apache/doris/pull/19122#issuecomment-1539743736 run build all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19436: [Bugfix](Outfile) fix that export data to parquet and orc file format
github-actions[bot] commented on PR #19436: URL: https://github.com/apache/doris/pull/19436#issuecomment-1539744628 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] figurant opened a new pull request, #19453: optimize docker image building script and document
figurant opened a new pull request, #19453: URL: https://github.com/apache/doris/pull/19453 1. print init_be.log in entry_point.sh 2.optimize document of docker image build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xinyiZzz closed pull request #19435: [Only-Test] The commit that can run in the past, try now
xinyiZzz closed pull request #19435: [Only-Test] The commit that can run in the past, try now URL: https://github.com/apache/doris/pull/19435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #19442: [Only-Test] The commit that can run in the past, try now, no pipeline
xinyiZzz commented on PR #19442: URL: https://github.com/apache/doris/pull/19442#issuecomment-1539747151 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
