platoneko commented on code in PR #18874:
URL: https://github.com/apache/doris/pull/18874#discussion_r1188303741
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -281,9 +292,7 @@ Status TabletsChannel::_open_all_writers(const
PTabletWriterOpenRequest& request
}
}
if (index_slots == nullptr) {
- std::stringstream ss;
- ss << "unknown index id, key=" << _key;
- return Status::InternalError(ss.str());
+ return Status::InternalError("unknown index id, key=" +
_key.to_string());
Review Comment:
Recommend to use `Status::InternalError("unknown index id, key={}",
_key.to_string());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
