github-actions[bot] commented on code in PR #19443:
URL: https://github.com/apache/doris/pull/19443#discussion_r1188228479
##########
be/src/vec/exec/scan/pip_scanner_context.h:
##########
@@ -169,19 +173,87 @@ class PipScannerContext : public
vectorized::ScannerContext {
}
}
+ vectorized::BlockUPtr get_free_block(bool* has_free_block, bool
get_not_empty_block = false,
+ int id = -1) override {
+ id = id % _free_block_queue_len;
+ {
+ std::unique_lock<std::mutex> l(*_free_block_queue_mutexs[id]);
+ if (auto& free_blocks = _free_blocks_queues[id];
!free_blocks.empty()) {
+ if (!get_not_empty_block || free_blocks.back()->mem_reuse()) {
+ auto block = std::move(free_blocks.back());
+ free_blocks.pop_back();
+ _total_free_block_num--;
+ _free_blocks_memory_usage->add(-block->allocated_bytes());
+ return block;
+ }
+ }
+ }
+ *has_free_block = false;
+
+ COUNTER_UPDATE(_newly_create_free_blocks_num, 1);
+ return vectorized::Block::create_unique(_real_tuple_desc->slots(),
_batch_size,
+ true /*ignore invalid slots*/);
+ }
+
+ void return_free_block(std::unique_ptr<vectorized::Block> block, int id)
override {
+ id = id % _free_block_queue_len;
+ block->clear_column_data();
+ _free_blocks_memory_usage->add(block->allocated_bytes());
+ std::unique_lock<std::mutex> l(*_free_block_queue_mutexs[id]);
+ _free_blocks_queues[id].emplace_back(std::move(block));
+ _total_free_block_num++;
+ }
+
+ void _init_free_block(int pre_alloc_block_count, int real_block_size)
override {
+ // The free blocks is used for final output block of scanners.
+ // So use _output_tuple_desc;
+ int64_t free_blocks_memory_usage = 0;
+ for (int i = 0, j = 0; i < pre_alloc_block_count; ++i, j++) {
+ auto block = vectorized::Block::create_unique(
+ _output_tuple_desc->slots(), real_block_size, true
/*ignore invalid slots*/);
+ free_blocks_memory_usage += block->allocated_bytes();
+ _free_blocks_queues[j].emplace_back(std::move(block));
+ if (j == _free_block_queue_len - 1) j = -1;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (j == _free_block_queue_len - 1) { j = -1;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
