github-actions[bot] commented on code in PR #19185:
URL: https://github.com/apache/doris/pull/19185#discussion_r1188291061
##########
be/src/util/jsonb_document.h:
##########
@@ -213,6 +226,83 @@ class JsonbDocument {
char payload_[0];
};
+/// A simple input stream class for the JSON path parser.
+class Stream {
+public:
+ /// Creates an input stream reading from a character string.
+ /// @param string the input string
+ /// @param length the length of the input string
+ Stream(const char* string, size_t length) : m_position(string),
m_end(string + length), leg() {}
Review Comment:
warning: initializer for member 'leg' is redundant
[readability-redundant-member-init]
```suggestion
Stream(const char* string, size_t length) : m_position(string),
m_end(string + length), {}
```
##########
be/src/util/jsonb_document.h:
##########
@@ -394,14 +484,12 @@
const char* getValuePtr() const;
// find the JSONB value by a key path string (null terminated)
- JsonbValue* findPath(const char* key_path, const char* delim = ".",
- hDictFind handler = nullptr) {
- return findPath(key_path, (unsigned int)strlen(key_path), delim,
handler);
+ JsonbValue* findPath(const char* key_path, hDictFind handler = nullptr) {
+ return findPath(key_path, (unsigned int)strlen(key_path), handler);
Review Comment:
warning: use of undeclared identifier 'strlen' [clang-diagnostic-error]
```cpp
return findPath(key_path, (unsigned int)strlen(key_path), handler);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
