platoneko commented on code in PR #18874: URL: https://github.com/apache/doris/pull/18874#discussion_r1188338754
########## be/src/vec/sink/vtablet_sink.cpp: ########## @@ -1062,6 +1102,22 @@ Status VOlapTableSink::open(RuntimeState* state) { return Status::OK(); } +void VOlapTableSink::_open_partition(const VOlapTablePartition* partition) { + const auto& id = partition->id; + auto it = _opened_partitions.find(id); + if (it == _opened_partitions.end()) { + _opened_partitions.insert(id); + for (int j = 0; j < partition->indexes.size(); ++j) { Review Comment: `for (auto& index : partition->indexes)` is better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org