[jira] [Commented] (LUCENE-10307) Add sanity checks for the distribution

[ https://issues.apache.org/jira/browse/LUCENE-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464349#comment-17464349 ] Dawid Weiss commented on LUCENE-10307: -- We want the binary distribution to include

[jira] [Commented] (LUCENE-10338) Scan for tests only by convention file name pattern (Test*)

[ https://issues.apache.org/jira/browse/LUCENE-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464379#comment-17464379 ] Uwe Schindler commented on LUCENE-10338: Yes. You can merge the test detection

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464380#comment-17464380 ] Feng Guo commented on LUCENE-10334: --- Hi all! Since all existing luceneutil tasks look

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464380#comment-17464380 ] Feng Guo edited comment on LUCENE-10334 at 12/23/21, 9:14 AM: ---

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464380#comment-17464380 ] Feng Guo edited comment on LUCENE-10334 at 12/23/21, 9:15 AM: ---

[GitHub] [lucene] mocobeta opened a new pull request #566: LUCENE-10301: Place test-framework into separated modules folder.

mocobeta opened a new pull request #566: URL: https://github.com/apache/lucene/pull/566 test-framework module has to be placed in a separate folder in the binary distribution in order to run the Luke application. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] uschindler commented on a change in pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

uschindler commented on a change in pull request #565: URL: https://github.com/apache/lucene/pull/565#discussion_r774436595 ## File path: gradle/testing/defaults-tests.gradle ## @@ -161,6 +161,14 @@ allprojects { showStandardStreams false } + // Disable a

[GitHub] [lucene] uschindler commented on pull request #566: LUCENE-10301: Place test-framework into separated modules folder.

uschindler commented on pull request #566: URL: https://github.com/apache/lucene/pull/566#issuecomment-1000168184 +1 I was already wondering why it was moved to the modules folder because although it is a real module now, it should not leak into production code. You're right:

[GitHub] [lucene] gf2121 commented on a change in pull request #562: LUCENE-10334: Introduce a BlockReader based on ForUtil and use it for NumericDocValues

gf2121 commented on a change in pull request #562: URL: https://github.com/apache/lucene/pull/562#discussion_r774440982 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/ForUtil.java ## @@ -0,0 +1,3311 @@ +// This file has been automatically generated, DO NOT EDI

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464394#comment-17464394 ] Tomoko Uchida commented on LUCENE-10301: The test-framework module has several

[GitHub] [lucene] mocobeta commented on pull request #566: LUCENE-10301: Place test-framework into separated modules folder.

mocobeta commented on pull request #566: URL: https://github.com/apache/lucene/pull/566#issuecomment-1000170764 @uschindler Thanks for your quick reply. @dweiss Could you take a look at this, please? -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464452#comment-17464452 ] Uwe Schindler commented on LUCENE-10335: Hi Dawid, thanks for the patch. Actual

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #562: LUCENE-10334: Introduce a BlockReader based on ForUtil and use it for NumericDocValues

sonatype-lift[bot] commented on a change in pull request #562: URL: https://github.com/apache/lucene/pull/562#discussion_r774484808 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/ForUtil.java ## @@ -0,0 +1,3329 @@ +// This file has been automatically generated

[GitHub] [lucene] uschindler opened a new pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler opened a new pull request #567: URL: https://github.com/apache/lucene/pull/567 See: https://issues.apache.org/jira/browse/LUCENE-10335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000244112 I have not yet checked Luke's image loading, as I touched this while reviewing all calls to getResource()/getResourceAsStream(). -- This is an automated message from the Apac

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464494#comment-17464494 ] Dawid Weiss commented on LUCENE-10335: -- +1. Thanks Uwe. > IOUtils.getDecodingRead

[GitHub] [lucene] dweiss commented on a change in pull request #566: LUCENE-10301: Place test-framework into separated modules folder.

dweiss commented on a change in pull request #566: URL: https://github.com/apache/lucene/pull/566#discussion_r774515076 ## File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestModularLayer.java ## @@ -101,7 +109,7 @@ public static void checkModulePa

[GitHub] [lucene] dweiss commented on a change in pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

dweiss commented on a change in pull request #565: URL: https://github.com/apache/lucene/pull/565#discussion_r774515953 ## File path: gradle/testing/defaults-tests.gradle ## @@ -161,6 +161,14 @@ allprojects { showStandardStreams false } + // Disable autom

[GitHub] [lucene] dweiss commented on a change in pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

dweiss commented on a change in pull request #565: URL: https://github.com/apache/lucene/pull/565#discussion_r774516325 ## File path: lucene/queryparser/src/test/org/apache/lucene/queryparser/surround/query/BooleanQueryTestFacade.java ## @@ -28,7 +28,7 @@ import org.apache.lu

[GitHub] [lucene] dweiss commented on a change in pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

dweiss commented on a change in pull request #565: URL: https://github.com/apache/lucene/pull/565#discussion_r774517300 ## File path: gradle/testing/defaults-tests.gradle ## @@ -161,6 +161,14 @@ allprojects { showStandardStreams false } + // Disable autom

[GitHub] [lucene] dweiss commented on a change in pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

dweiss commented on a change in pull request #565: URL: https://github.com/apache/lucene/pull/565#discussion_r774519046 ## File path: gradle/testing/defaults-tests.gradle ## @@ -161,6 +161,14 @@ allprojects { showStandardStreams false } + // Disable autom

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000252195 I fixed Luke. I will now check for other places that do getClassLoader().getResource... -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [lucene] dweiss commented on a change in pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

dweiss commented on a change in pull request #565: URL: https://github.com/apache/lucene/pull/565#discussion_r774520790 ## File path: gradle/testing/defaults-tests.gradle ## @@ -161,6 +161,14 @@ allprojects { showStandardStreams false } + // Disable autom

[GitHub] [lucene] dweiss commented on a change in pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

dweiss commented on a change in pull request #565: URL: https://github.com/apache/lucene/pull/565#discussion_r774520790 ## File path: gradle/testing/defaults-tests.gradle ## @@ -161,6 +161,14 @@ allprojects { showStandardStreams false } + // Disable autom

[GitHub] [lucene] dweiss commented on a change in pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

dweiss commented on a change in pull request #565: URL: https://github.com/apache/lucene/pull/565#discussion_r774522117 ## File path: gradle/testing/defaults-tests.gradle ## @@ -161,6 +161,14 @@ allprojects { showStandardStreams false } + // Disable autom

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000255235 We have some more in Benchmark module and tests of Spatial module. We may need to fix those and move resources to exported packages (not a root folder called "data/"). -- Th

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464500#comment-17464500 ] Uwe Schindler commented on LUCENE-10335: Hi [~dweiss], I did this (and more) i

[GitHub] [lucene] dweiss commented on pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

dweiss commented on pull request #565: URL: https://github.com/apache/lucene/pull/565#issuecomment-1000257251 I've removed TestBase* exclusion - anything starting with Test* must in fact be a test. Those two classes I had to rename - I'm not sure how they work for you on panama branch, the

[GitHub] [lucene] mocobeta commented on a change in pull request #566: LUCENE-10301: Place test-framework into separated modules folder.

mocobeta commented on a change in pull request #566: URL: https://github.com/apache/lucene/pull/566#discussion_r774524778 ## File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestModularLayer.java ## @@ -101,7 +109,7 @@ public static void checkModule

[GitHub] [lucene] gf2121 commented on a change in pull request #562: LUCENE-10334: Introduce a BlockReader based on ForUtil and use it for NumericDocValues

gf2121 commented on a change in pull request #562: URL: https://github.com/apache/lucene/pull/562#discussion_r774526889 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/ForUtil.java ## @@ -0,0 +1,3311 @@ +// This file has been automatically generated, DO NOT EDI

[GitHub] [lucene] dweiss commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

dweiss commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r774530196 ## File path: lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java ## @@ -2060,18 +2061,14 @@ protected Path getDataPath(String na

[GitHub] [lucene] dweiss commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

dweiss commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r774530775 ## File path: lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java ## @@ -2060,18 +2061,14 @@ protected Path getDataPath(String na

[GitHub] [lucene] mocobeta merged pull request #566: LUCENE-10301: Place test-framework into separated modules folder.

mocobeta merged pull request #566: URL: https://github.com/apache/lucene/pull/566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464514#comment-17464514 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463911#comment-17463911 ] Feng Guo edited comment on LUCENE-10334 at 12/23/21, 12:22 PM: --

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000279111 I found another problematic one: loadStopwordSet in StopAnalyzerBase. This does not work from inside nor/kuromoji and others. I will deprecated in same way. I would like

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464531#comment-17464531 ] Robert Muir commented on LUCENE-10334: -- I think you took a good approach: small st

[GitHub] [lucene] uschindler commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r774546832 ## File path: lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java ## @@ -2060,18 +2061,14 @@ protected Path getDataPath(Strin

[GitHub] [lucene] uschindler commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r774547308 ## File path: lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java ## @@ -2060,18 +2061,14 @@ protected Path getDataPath(Strin

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000280027 How can we have failing tests for these problems? We need a test-driven approach to fixing this stuff. `gradlew check` is totally happy for me. -- This is an automated message fro

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000280448 > How can we have failing tests for these problems? We need a test-driven approach to fixing this stuff. `gradlew check` is totally happy for me. This is preparatory. We

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000280448 > How can we have failing tests for these problems? We need a test-driven approach to fixing this stuff. `gradlew check` is totally happy for me. This is preparato

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000280448 > How can we have failing tests for these problems? We need a test-driven approach to fixing this stuff. `gradlew check` is totally happy for me. This is preparato

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000280448 > How can we have failing tests for these problems? We need a test-driven approach to fixing this stuff. `gradlew check` is totally happy for me. This is preparato

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000280448 > How can we have failing tests for these problems? We need a test-driven approach to fixing this stuff. `gradlew check` is totally happy for me. This is preparato

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000283219 To explain: We need to go away with a public static helper class that calls `Class#getResourceAsStream()` on behalf of somebody else. -- This is an automated message from the

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000283590 I understand why the method doesnt work for modules: I just don't care. I am only asking about failing tests. -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000284297 > I understand why the method doesnt work for modules: I just don't care. > > I am only asking about failing tests. For now I can only make sure I don't break the s

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000283961 @rmuir we will have a test-driven approach soon after xmas when Dawid finishes the conversion to module system. But all work that can be done before should be done before, as i

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000285508 Also, are we sure this stuff isn't bugs in the JDK? Seems like a design flaw in modules. I have the feeling this is going to break the analysis module left and right. I am co

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000285949 > The problem is that getResourceAsStream() and getResource() are caller-sensitive and check who calls it. That's openjdk internal bullshit and not in the public java docs. we

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464539#comment-17464539 ] Feng Guo commented on LUCENE-10334: --- Thanks [~rcmuir] for reply! No hurry here, feel

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000286691 Sorry, I have to say I am -1 at the moment to "gutting" all the analysis code, without tests, before first even trying to report these bugs to openjdk (it is THEIR FAULT). We should

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000288771 > Also, are we sure this stuff isn't bugs in the JDK? Seems like a design flaw in modules. I was in the discussion before Java 9 came out. It was a mess and I argued sev

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000288771 > Also, are we sure this stuff isn't bugs in the JDK? Seems like a design flaw in modules. I was in the discussion before Java 9 came out. It was a mess and I argu

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000289938 Where is it clearly documented? I don't see any such documentation: BUG. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000290825 Robert, please let me finish this, otherwise I will trash down everything and stop working anymore on module system. If you want modules (and looks like you want) let us do our

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000292034 My problem is that the justification for fixing this stuff is that, "this code is buggy, it calls a CallerSensitive method". CallerSensitive isn't even publicly documented. T

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000292571 (https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Class.html#getResourceAsStream(java.lang.String)): > Finds a resource with a given name. > If t

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000292571 (https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Class.html#getResourceAsStream(java.lang.String)): > Finds a resource with a given name.

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-1000293345 Could I merge the main into this branch to fetch https://github.com/apache/lucene/commit/54ebf3c73b72bafc414f834a15b8a3e81fd75ad8 just to see how Github Actions behave? There is

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000292571 Hi, see the bold text and especially the italic one: (https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Class.html#getResourceAsStream(java.lang.Stri

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000295132 Thanks Uwe. I suppose "caller" there is enough to justify their shitty CallerSensitive shenanigans. This really sucks though, they screwed up. Please proceed, sorry for noise.

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000295957 > Thanks Uwe. I suppose "caller" there is enough to justify their shitty CallerSensitive shenanigans. This really sucks though, they screwed up. I was angry about that 4

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000300518 I am thinking about a small solution to still use `StopAnalyzerBase#loadStopwordSet(...,Class,...)` and not duplicate code everywhere like in current patch. -- This is an au

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000306918 > I am thinking about a small solution to still use `StopAnalyzerBase#loadStopwordSet(...,Class,...)` and not duplicate code everywhere like in current patch. But how will we

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000312182 Maybe, we should just go back to hacky code to unzip jar file, open file on filesystem. after all, "resources" are practically always there on the filesystem anyway. We can just ope

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000312397 > > I am thinking about a small solution to still use `StopAnalyzerBase#loadStopwordSet(...,Class,...)` and not duplicate code everywhere like in current patch. > > But

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000312397 > > I am thinking about a small solution to still use `StopAnalyzerBase#loadStopwordSet(...,Class,...)` and not duplicate code everywhere like in current patch. >

[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-1000317547 Please, feel free to do anything you like, @mocobeta ! Like I said, I just left it as an example. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000312397 > > I am thinking about a small solution to still use `StopAnalyzerBase#loadStopwordSet(...,Class,...)` and not duplicate code everywhere like in current patch. >

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000319417 StackOverflow is full of this shit, just search for it: https://www.google.com/search?q=getresourceasstream+java+11 -- This is an automated message from the Apache Git Servic

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000312397 > > I am thinking about a small solution to still use `StopAnalyzerBase#loadStopwordSet(...,Class,...)` and not duplicate code everywhere like in current patch. >

[GitHub] [lucene] dweiss commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

dweiss commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000320538 I know everyone is busy, so keeping it short. @rmuir - I do have tests that fail because of this. These tests are on a branch where I'm trying to fix classpath vs. module-pat

[GitHub] [lucene] uschindler edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000312397 > > I am thinking about a small solution to still use `StopAnalyzerBase#loadStopwordSet(...,Class,...)` and not duplicate code everywhere like in current patch. >

[GitHub] [lucene] dweiss commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

dweiss commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000321303 The code Uwe provided in the patch is fixing a true bug - it's just masked by the tests running in classpath only. In other words: if the tests pass after applying this patch, noth

[GitHub] [lucene] uschindler commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000328063 I am giving up for today, have to think about it a bit more. @dweiss you can take my current PR for further testing. From checking the code it looks like we need a

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464587#comment-17464587 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000337322 > IMHO, it's a pain that so much reflection specific stuff is now caller sensitive (since Java 9), this makes utility methods impossible to expose. It is not only getResource, also

[GitHub] [lucene] dweiss commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

dweiss commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000338704 Thanks Uwe. I will integrate this patch into my working branch with gradle changes. I don't think I can fix everything related to module vs. classpath but I think it's close to bei

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000339877 > @rmuir - I do have tests that fail because of this. These tests are on a branch where I'm trying to fix classpath vs. module-path issues - the compilation and tests currently use

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464619#comment-17464619 ] Feng Guo commented on LUCENE-10334: --- I'm so sorry to say that there is something wron

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464619#comment-17464619 ] Feng Guo edited comment on LUCENE-10334 at 12/23/21, 2:34 PM: ---

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000346720 > The code Uwe provided in the patch is fixing a true bug - it's just masked by the tests running in classpath only. In other words: if the tests pass after applying this patch, not

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464619#comment-17464619 ] Feng Guo edited comment on LUCENE-10334 at 12/23/21, 2:37 PM: ---

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464619#comment-17464619 ] Feng Guo edited comment on LUCENE-10334 at 12/23/21, 2:37 PM: ---

[GitHub] [lucene] gf2121 edited a comment on pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

gf2121 edited a comment on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999516790 Hi @rmuir @jpountz , Thanks a lot for all talking about this! ~~I think we **probably** find out a better way there:~~ There is something wrong with this benchmark and

[GitHub] [lucene] gf2121 edited a comment on pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

gf2121 edited a comment on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999516790 Hi @rmuir @jpountz , Thanks a lot for all talking about this! ~~I think we **probably** find out a better way there:~~ -- This is an automated message from the Apache Git

[GitHub] [lucene] dweiss commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

dweiss commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000364229 bq. But If i revert his commit or otherwise introduce regression, tests keep passing :) That's my point. Yeah, I know. It's a vicious cycle though - I can't really progress

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464619#comment-17464619 ] Feng Guo edited comment on LUCENE-10334 at 12/23/21, 4:11 PM: ---

[GitHub] [lucene] uschindler commented on a change in pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

uschindler commented on a change in pull request #565: URL: https://github.com/apache/lucene/pull/565#discussion_r774723713 ## File path: lucene/queryparser/src/test/org/apache/lucene/queryparser/surround/query/BooleanQueryTestFacade.java ## @@ -28,7 +28,7 @@ import org.apach

[GitHub] [lucene] uschindler commented on pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

uschindler commented on pull request #565: URL: https://github.com/apache/lucene/pull/565#issuecomment-1000464970 > I've removed TestBase* exclusion - anything starting with Test* must in fact be a test. Those two classes I had to rename - I'm not sure how they work for you on panama branc

[GitHub] [lucene] rmuir commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000482712 Well, it does seem this particular method signature "can't work", unless any code that uses this helper explicitly opens up their module to lucene-core... and that's too confusing.

[GitHub] [lucene] dweiss commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

dweiss commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000484883 > how can we test this? This is a problem because the code and tests can effectively run in many combinations. I don't have a clear picture of how this can be all reasonably

[jira] [Commented] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16

[ https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464782#comment-17464782 ] Mike Drob commented on LUCENE-9650: --- We incidentally opened up some internal java modu

[jira] [Comment Edited] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16

[ https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464782#comment-17464782 ] Mike Drob edited comment on LUCENE-9650 at 12/23/21, 8:25 PM:

[jira] [Comment Edited] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16

[ https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464782#comment-17464782 ] Mike Drob edited comment on LUCENE-9650 at 12/23/21, 8:27 PM: