rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000339877
> @rmuir - I do have tests that fail because of this. These tests are on a branch where I'm trying to fix classpath vs. module-path issues - the compilation and tests currently use classpath only; once you make them run with true modules, things start to break. It is very messy conceptually - the conventions gradle has predate the module system and they're not always compatible. Every time I think I've solved something, two other things emerge. It is difficult. I am making progress though. Thanks Dawid. I didn't mean to complain, I was just confused at the sudden issues and wondering about the larger strategy to fix stuff. At this point I'm not even sure tests will be enough, due to the fact lucene is an API (see my example above about RSLP, first one i looked into). So I'm trying to think of other ways to make the build fail when our APIs do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
