uschindler commented on a change in pull request #565:
URL: https://github.com/apache/lucene/pull/565#discussion_r774436595
##########
File path: gradle/testing/defaults-tests.gradle
##########
@@ -161,6 +161,14 @@ allprojects {
showStandardStreams false
}
+ // Disable automatic test class detection, rely on class names only.
This is needed for testing
+ // against JDKs where the bytecode is unparseable by Gradle, for example.
+ // We require all tests to start with Test*, this simplifies include
patterns greatly.
+ scanForTestClasses = false
+ include '**/Test*'
Review comment:
This no longer adds files ending on Test. At Ant times we had this, did
we rename all tests?
##########
File path: gradle/testing/defaults-tests.gradle
##########
@@ -161,6 +161,14 @@ allprojects {
showStandardStreams false
}
+ // Disable automatic test class detection, rely on class names only.
This is needed for testing
+ // against JDKs where the bytecode is unparseable by Gradle, for example.
+ // We require all tests to start with Test*, this simplifies include
patterns greatly.
+ scanForTestClasses = false
+ include '**/Test*'
Review comment:
I would add ".class" to not add resources files.
##########
File path:
lucene/queryparser/src/test/org/apache/lucene/queryparser/surround/query/BooleanQueryTestFacade.java
##########
@@ -28,7 +28,7 @@
import org.apache.lucene.search.SimpleCollector;
import org.junit.Assert;
-public class TestBooleanQuery {
+public class BooleanQueryTestFacade {
Review comment:
I don't think this rename is needed because it is on the exclusion list
above (the dollar one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
