uschindler commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000312397
> > I am thinking about a small solution to still use `StopAnalyzerBase#loadStopwordSet(...,Class,...)` and not duplicate code everywhere like in current patch. > > But how will we fix analyzer factories (ClasspathResourceLoader) ? This seems like the biggest issue. The class will work well in ClassPath mode, of course. But we should deprecate the constructor that takes a class. The one taking a ClassLoader can be initialized by an app like a modularized Elasticsearch or Solr using a ClassLoader retrieved from the module. We did this inside Luke already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
