rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000337322
> IMHO, it's a pain that so much reflection specific stuff is now caller sensitive (since Java 9), this makes utility methods impossible to expose. It is not only getResource, also a lot of other shit like classloader access and also Class.forName() is now caller sensitive! Yes, I just did a quick `git grep` and immediately start finding bugs. first hit is `RSLPStemmerBase.parse()`. The class is public/abstract, so the code should be fixed. We can't reduce visibility of the class, it is needed by both Portuguese and Galician (separate packages). So we have to fix signatures etc. No tests will fail, but its a lurking "API bug", if someone tries to use it from the outside. I am trying to think on some ideas to statically identify this stuff. Maybe we just need to use forbidden apis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
