dweiss commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r534851417
##
File path: lucene/misc/native/build.gradle
##
@@ -51,11 +47,7 @@ tasks.withType(CppCompile).configureEach {
// is present.
systemIncludes.from
Dawid Weiss created LUCENE-9631:
---
Summary: Properly override slice() on subclasses of OffsetRange
Key: LUCENE-9631
URL: https://issues.apache.org/jira/browse/LUCENE-9631
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243064#comment-17243064
]
ASF subversion and git services commented on LUCENE-9631:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9631.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> Properly override slice() on subclasses o
[
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243094#comment-17243094
]
Ignacio Vera commented on LUCENE-9619:
--
{quote}
my thinking was that this API could
[
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243094#comment-17243094
]
Ignacio Vera edited comment on LUCENE-9619 at 12/3/20, 10:34 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243094#comment-17243094
]
Ignacio Vera edited comment on LUCENE-9619 at 12/3/20, 10:35 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243107#comment-17243107
]
Adrien Grand commented on LUCENE-9619:
--
The difference between what I'm proposing a
[
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243129#comment-17243129
]
Ignacio Vera commented on LUCENE-9619:
--
I see, yes DocIdSetIterator is not an optio
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki updated SOLR-14613:
Fix Version/s: master (9.0)
> Provide a clean API for pluggable replica assignment implemen
[
https://issues.apache.org/jira/browse/LUCENE-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243150#comment-17243150
]
Mayya Sharipova commented on LUCENE-9628:
-
[~jtibshirani] Thank you for raising
Jan Høydahl created SOLR-15030:
--
Summary: Make score available as pseudo field in Function Queries
Key: SOLR-15030
URL: https://issues.apache.org/jira/browse/SOLR-15030
Project: Solr
Issue Type:
mayya-sharipova commented on pull request #2075:
URL: https://github.com/apache/lucene-solr/pull/2075#issuecomment-738000448
I've chatted with @jimczi offline, and we have decided to rename
`usesIndexSort()` to a more general `disableSkipping` for
future use cases where `TopFieldCollect
mayya-sharipova edited a comment on pull request #2075:
URL: https://github.com/apache/lucene-solr/pull/2075#issuecomment-738000448
I've chatted with @jimczi offline, and we have decided to rename
`usesIndexSort()` to a more general `disableSkipping` for
future use cases where `TopField
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243194#comment-17243194
]
Erick Erickson commented on SOLR-14992:
---
See, if I delay long enough, I have less w
Pieter created SOLR-15031:
-
Summary: NPE caused by FunctionQParser returning a null ValueSource
Key: SOLR-15031
URL: https://issues.apache.org/jira/browse/SOLR-15031
Project: Solr
Issue Type: Bug
jimczi commented on a change in pull request #2075:
URL: https://github.com/apache/lucene-solr/pull/2075#discussion_r535253273
##
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##
@@ -360,8 +352,8 @@ protected void updateMinCompetitiveScore(Scor
[
https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pieter updated SOLR-15031:
--
Description:
When parsing a sub query in a function query,
{{FunctionQParser#parseValueSource}} does not check
[
https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pieter updated SOLR-15031:
--
Description:
When parsing a sub query in a function query,
{{FunctionQParser#parseValueSource}} does not check
[
https://issues.apache.org/jira/browse/LUCENE-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-9629:
-
Priority: Minor (was: Major)
> Use computed mask values in ForUtil
> --
mikemccand merged pull request #2095:
URL: https://github.com/apache/lucene-solr/pull/2095
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243253#comment-17243253
]
ASF subversion and git services commented on LUCENE-9618:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243254#comment-17243254
]
ASF subversion and git services commented on LUCENE-9618:
-
Commi
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r53592
##
File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java
##
@@ -239,8 +238,7 @@ private static String getActualPath(ApiInfo
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243283#comment-17243283
]
Erick Erickson commented on SOLR-14992:
---
OK, 100 iterations later on 8x (BTW, I tes
thelabdude commented on pull request #2067:
URL: https://github.com/apache/lucene-solr/pull/2067#issuecomment-738084590
Plan to merge this into master later today.
This is an automated message from the Apache Git Service.
To
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535346975
##
File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java
##
@@ -422,7 +421,10 @@ public static Class getConfigClass(Configu
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535354318
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/PlacementPluginFactory.java
##
@@ -17,15 +17,37 @@
package org.apache.solr.clu
sigram commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535356233
##
File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java
##
@@ -422,7 +421,10 @@ public static Class getConfigClass(Configura
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535359225
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/impl/CollectionsRepairEventListener.java
##
@@ -76,10 +78,12 @@
private int waitF
sigram commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535359830
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/impl/CollectionsRepairEventListener.java
##
@@ -76,10 +78,12 @@
private int waitFor
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535360258
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -2180,6 +2188,10 @@ public ClusterEventProducer getClusterEventProduce
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535361197
##
File path:
solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
##
@@ -109,4 +132,108 @@ public void tes
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535361621
##
File path:
solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
##
@@ -109,4 +132,108 @@ public void tes
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535361621
##
File path:
solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
##
@@ -109,4 +132,108 @@ public void tes
mikemccand commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r535354667
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -51,16 +50,9 @@
* to the provided Directory instanc
[
https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-9618.
Resolution: Fixed
Thanks [~zhai7631]!
> Improve IntervalIterator.nextInterval's b
saatchibhalla commented on pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#issuecomment-738118886
> Saatchi; could you please comment here what this change in the config is
about? Did you blend two metrics into one, and if so why? Maybe could you share
a snippet of
sigram commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535404901
##
File path:
solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
##
@@ -109,4 +132,108 @@ public void testM
sigram commented on a change in pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#discussion_r535413902
##
File path: solr/core/src/java/org/apache/solr/cloud/Overseer.java
##
@@ -185,6 +190,9 @@ public ClusterStateUpdater(final ZkStateReader reader,
fin
mayya-sharipova merged pull request #2075:
URL: https://github.com/apache/lucene-solr/pull/2075
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/LUCENE-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243362#comment-17243362
]
ASF subversion and git services commented on LUCENE-9599:
-
Commi
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243396#comment-17243396
]
Timothy Potter commented on SOLR-15026:
---
I've been all over this code recently, so
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter reassigned SOLR-15026:
-
Assignee: Timothy Potter
> MiniSolrCloudCluster can inconsistently get confused about wh
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243399#comment-17243399
]
Chris M. Hostetter commented on SOLR-15026:
---
I have not started digging into th
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535497621
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/ClusterEventProducer.java
##
@@ -26,7 +26,7 @@
public interface ClusterEventProduce
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535506478
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/impl/ClusterEventProducerFactory.java
##
@@ -128,13 +128,17 @@ public void added(Con
[
https://issues.apache.org/jira/browse/LUCENE-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243456#comment-17243456
]
Nick Knize commented on LUCENE-9552:
Note [~ivera], [Reproducible
failure|https://c
murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535520411
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/impl/ClusterEventProducerFactory.java
##
@@ -149,21 +153,25 @@ public void deleted(C
sigram commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535525525
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/ClusterEventProducer.java
##
@@ -26,7 +26,7 @@
public interface ClusterEventProducer
sigram commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r535527148
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/impl/ClusterEventProducerFactory.java
##
@@ -149,21 +153,25 @@ public void deleted(Con
mayya-sharipova opened a new pull request #2117:
URL: https://github.com/apache/lucene-solr/pull/2117
Disable sort optimization in comparators on index sort.
Currently, if search sort is equal or a part of the index sort, we have
an early termination in TopFieldCollector.
But co
[
https://issues.apache.org/jira/browse/LUCENE-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243520#comment-17243520
]
Adrien Grand commented on LUCENE-9629:
--
+1 the arrays make it look better. I'll mer
dweiss commented on pull request #2113:
URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-738329601
I wonder if the difference in performance is observable since final long
values would be inlined at compile time (and easily optimized for hotspot)
whereas array accesses, ev
dsmiley commented on pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#issuecomment-738410528
Looks good now Saatchi! I'll merge tomorrow with the following CHANGES.txt
note under "Improvements":
SOLR-14965: metrics: Adds two metrics to the SolrCloud Overs
[
https://issues.apache.org/jira/browse/SOLR-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243575#comment-17243575
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-15029:
--
+1. While th
[
https://issues.apache.org/jira/browse/LUCENE-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243576#comment-17243576
]
Julie Tibshirani commented on LUCENE-9628:
--
bq. I think it'd be helpful if we i
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243589#comment-17243589
]
Erick Erickson commented on SOLR-14992:
---
650 more iterations and this failure is go
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243589#comment-17243589
]
Erick Erickson edited comment on SOLR-14992 at 12/3/20, 11:48 PM:
-
madrob merged pull request #2115:
URL: https://github.com/apache/lucene-solr/pull/2115
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
madrob commented on a change in pull request #2115:
URL: https://github.com/apache/lucene-solr/pull/2115#discussion_r535747625
##
File path:
solr/core/src/test/org/apache/solr/cloud/TestPullReplicaErrorHandling.java
##
@@ -236,8 +237,9 @@ public void testCloseHooksDeletedOnRec
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243603#comment-17243603
]
ASF subversion and git services commented on SOLR-14992:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243613#comment-17243613
]
ASF subversion and git services commented on SOLR-14992:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-14992.
--
Fix Version/s: master (9.0)
8.8
Resolution: Fixed
> TestPullReplicaErrorHandl
Mike Drob created SOLR-15032:
Summary: Race condition in TestPullReplicaErrorHandling
Key: SOLR-15032
URL: https://issues.apache.org/jira/browse/SOLR-15032
Project: Solr
Issue Type: Test
Se
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r535812210
##
File path: lucene/misc/native/build.gradle
##
@@ -51,11 +47,7 @@ tasks.withType(CppCompile).configureEach {
// is present.
systemIncludes
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r535812509
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -51,16 +50,9 @@
* to the provided Directory instan
[
https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243740#comment-17243740
]
hu commented on LUCENE-8757:
I have a questions,when multi-user query search method , the sl
[
https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hu updated LUCENE-8757:
---
Attachment: image-2020-12-04-14-09-22-924.png
> Better Segment To Thread Mapping Algorithm
> ---
gf2121 commented on pull request #2113:
URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-738594982
Thank you for your reply @dweiss ! This is indeed something to worry about,
so a silly benchmark between const values and const arrays had been run before
i submited this com
dweiss commented on pull request #2113:
URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-738597267
Microbenchmarks can be tricky... here I think the optimizer can remove a lot
of the code because the results of those computations are not stored anywhere.
A JMH benchmark wo
71 matches
Mail list logo
