zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r535812509
##########
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##########
@@ -51,16 +50,9 @@
* to the provided Directory instance.
*
* <p>See <a
- * href="{@docRoot}/overview-summary.html#NativeUnixDirectory">Overview</a>
+ * href="{@docRoot}/overview-summary.html#DirectIODirectory">Overview</a>
* for more details.
*
- * <p>To use this you must compile
- * NativePosixUtil.cpp (exposes Linux-specific APIs through
- * JNI) for your platform, by running <code>./gradlew build</code>, and then
putting the resulting
- * <code>libLuceneNativeIO.so</code> or <code>libLuceneNativeIO.dylib</code>
- * (from <code>lucene/misc/native/build/lib/release/platform/</code>) onto
your dynamic
- * linker search path.
- *
* <p><b>WARNING</b>: this code is very new and quite easily
* could contain horrible bugs. For example, here's one
* known issue: if you use seek in <code>IndexOutput</code>, and then
Review comment:
Ah good catch! I updated this as well as surrounding docs to also
include Window compatibility.
One thing I wasn't sure though and feel like asking is, shall I also remove
this line :D
> * <p><b>WARNING</b>: this code is very new and quite easily could contain
horrible bugs.
As it's been around for some time now (although not used by many yet?), and
being pure-java means it's less error prone.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
