madrob commented on a change in pull request #2115:
URL: https://github.com/apache/lucene-solr/pull/2115#discussion_r535747625
##########
File path:
solr/core/src/test/org/apache/solr/cloud/TestPullReplicaErrorHandling.java
##########
@@ -236,8 +237,9 @@ public void testCloseHooksDeletedOnReconnect() throws
Exception {
JettySolrRunner jetty =
getJettyForReplica(s.getReplicas(EnumSet.of(Replica.Type.PULL)).get(0));
SolrCore core = jetty.getCoreContainer().getCores().iterator().next();
- for (int i = 0; i < 5; i++) {
+ for (int i = 0; i < (TEST_NIGHTLY ? 5 : 2); i++) {
cluster.expireZkSession(jetty);
+ waitForState("Expecting node to be disconnected", collectionName,
activeReplicaCount(1, 0, 0));
Review comment:
I think you're technically correct, but I'd rather leave that as a
future improvement since we do it in several places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
