noblepaul commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-673330445
I don't really know what purpose is solved by this annotation. If it is for
documentation purpose, this may make sense. But, there are a million other
places where the cla
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176864#comment-17176864
]
Tomoko Uchida commented on LUCENE-9448:
---
Fix for this issue (merged): [https://git
Andrzej Bialecki created SOLR-14749:
---
Summary: Provide a clean API for cluster-level event processing
Key: SOLR-14749
URL: https://issues.apache.org/jira/browse/SOLR-14749
Project: Solr
Iss
[
https://issues.apache.org/jira/browse/SOLR-14687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176922#comment-17176922
]
Jan Høydahl commented on SOLR-14687:
Agree, this is super complex and trappy and this
Erick Erickson created SOLR-14750:
-
Summary: Harden TestBulkSchemaConcurrent
Key: SOLR-14750
URL: https://issues.apache.org/jira/browse/SOLR-14750
Project: Solr
Issue Type: Improvement
markharwood commented on pull request #1708:
URL: https://github.com/apache/lucene-solr/pull/1708#issuecomment-673437428
Progress update - I'm struggling a bit with how to make the parser stricter
i.e. ensuring there's a space between `/Foo/i` and the next search term. I'd
also need to al
[
https://issues.apache.org/jira/browse/SOLR-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14750:
--
Attachment: SOLR-14750.patch
Status: Open (was: Open)
> Harden TestBulkSchemaConcurren
[
https://issues.apache.org/jira/browse/LUCENE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176951#comment-17176951
]
Adrien Grand commented on LUCENE-9447:
--
Indeed larger blocks make retrieval slower.
Jan Høydahl created SOLR-14751:
--
Summary: Zookeeper Admin screen not working for old ZK versions
Key: SOLR-14751
URL: https://issues.apache.org/jira/browse/SOLR-14751
Project: Solr
Issue Type: B
janhoy opened a new pull request #1747:
URL: https://github.com/apache/lucene-solr/pull/1747
See https://issues.apache.org/jira/browse/SOLR-14751
Solution is to treat `NoNodeException` not as an unrecoverable exception,
but as expected for older ZK versions and return empty string.
[
https://issues.apache.org/jira/browse/LUCENE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176951#comment-17176951
]
Adrien Grand edited comment on LUCENE-9447 at 8/13/20, 12:36 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-14751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176969#comment-17176969
]
Jan Høydahl commented on SOLR-14751:
See PR [https://github.com/apache/lucene-solr/pu
[
https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176968#comment-17176968
]
Andrzej Bialecki commented on SOLR-14680:
-
Was this change really intended for 8x
[
https://issues.apache.org/jira/browse/SOLR-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176973#comment-17176973
]
Jan Høydahl commented on SOLR-14669:
I'm fixing another ZK admin ui bug in SOLR-14751
[
https://issues.apache.org/jira/browse/SOLR-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176980#comment-17176980
]
Jan Høydahl commented on SOLR-14669:
Can you dump your /zookeeper/config content? I s
madrob commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-673461640
Rome was not built in one day, so too our code documentation Is in not
finished in one PR
This is an automat
[
https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176999#comment-17176999
]
Uwe Schindler commented on SOLR-14680:
--
Why was the "make java 8 compatible" committ
[
https://issues.apache.org/jira/browse/SOLR-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177009#comment-17177009
]
David Smiley commented on SOLR-5986:
Maybe you're right. I was thinking of them being
[
https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177021#comment-17177021
]
Noble Paul commented on SOLR-14680:
---
{quote}Why was the "make java 8 compatible" commit
[
https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177024#comment-17177024
]
ASF subversion and git services commented on SOLR-14680:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177029#comment-17177029
]
Noble Paul commented on SOLR-14749:
---
In general my suggestions are as foloows.
* we sh
mikemccand commented on pull request #1733:
URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-673498515
Woohoo, tests all pass now? What a tiny change it turned out to be :)
Can you try to run `luceneutil` benchmarks? Let's see if this is net/net
faster. Even if it
mikemccand commented on a change in pull request #1733:
URL: https://github.com/apache/lucene-solr/pull/1733#discussion_r469977297
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
##
@@ -322,9 +324,14 @@ public FacetLa
[
https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177047#comment-17177047
]
Michael McCandless commented on LUCENE-8776:
{quote}*But* then there's some
[
https://issues.apache.org/jira/browse/SOLR-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177051#comment-17177051
]
Jörn Franke commented on SOLR-14669:
sorry yes I will get it as soon as possible. tha
jpountz opened a new pull request #1748:
URL: https://github.com/apache/lucene-solr/pull/1748
BEST_SPEED and BEST_COMPRESSION keep the same compression algorithms but
increase their respective block sizes from 16kB and 60kB to 64kB and
256kB.
I disabled the per-thread caching of
[
https://issues.apache.org/jira/browse/LUCENE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177074#comment-17177074
]
Adrien Grand commented on LUCENE-9447:
--
I opened a pull request with these changes:
[
https://issues.apache.org/jira/browse/SOLR-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-14706.
---
Fix Version/s: 8.7
Resolution: Fixed
> Upgrading 8.6.0 to 8.6.1 causes collection crea
sigram closed pull request #1637:
URL: https://github.com/apache/lucene-solr/pull/1637
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sigram closed pull request #1506:
URL: https://github.com/apache/lucene-solr/pull/1506
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sigram closed pull request #1486:
URL: https://github.com/apache/lucene-solr/pull/1486
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sigram closed pull request #1417:
URL: https://github.com/apache/lucene-solr/pull/1417
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
munendrasn merged pull request #1746:
URL: https://github.com/apache/lucene-solr/pull/1746
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
munendrasn commented on pull request #1746:
URL: https://github.com/apache/lucene-solr/pull/1746#issuecomment-673555398
@janhoy
Thanks for the review
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/SOLR-13807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177108#comment-17177108
]
Michael Gibney commented on SOLR-13807:
---
Quick follow-up: regarding skg on master v
[
https://issues.apache.org/jira/browse/SOLR-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177114#comment-17177114
]
David Smiley commented on SOLR-14750:
-
Use PRs please?
> Harden TestBulkSchemaConcur
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177121#comment-17177121
]
Mark Robert Miller commented on SOLR-14636:
---
Okay, I’m getting close to comfort
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177221#comment-17177221
]
Ilan Ginzburg commented on SOLR-14749:
--
if there’s an abstraction layer between Solr
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177245#comment-17177245
]
Mark Robert Miller commented on SOLR-14636:
---
It may be Monday rather than Frida
gautamworah96 commented on a change in pull request #1733:
URL: https://github.com/apache/lucene-solr/pull/1733#discussion_r470160799
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java
##
@@ -494,6 +496,7 @@ private int
dsmiley commented on pull request #1740:
URL: https://github.com/apache/lucene-solr/pull/1740#issuecomment-673640254
> I wonder if this is something that we should enforce somewhere. It seems
that you only want the original term to come first so maybe we can mark it with
a special flag ?
dsmiley commented on a change in pull request #1740:
URL: https://github.com/apache/lucene-solr/pull/1740#discussion_r470163319
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/WordDelimiterFilter.java
##
@@ -398,10 +399,20 @@ public void
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177290#comment-17177290
]
Ilan Ginzburg commented on SOLR-14749:
--
Not all plugins need to execute on one desig
Gautam Worah created LUCENE-9460:
Summary: getPath in DirectoryTaxonomyReader should throw an
exception
Key: LUCENE-9460
URL: https://issues.apache.org/jira/browse/LUCENE-9460
Project: Lucene - Core
gautamworah96 commented on a change in pull request #1733:
URL: https://github.com/apache/lucene-solr/pull/1733#discussion_r470204070
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
##
@@ -322,9 +324,14 @@ public Face
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9448.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> Make an equivalent to Ant's "run" target
[
https://issues.apache.org/jira/browse/SOLR-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-14711.
Resolution: Duplicate
Hey Mark, closing this out as a duplicate of a separate issue I'd cre
yuriy-b-koval commented on pull request #1713:
URL: https://github.com/apache/lucene-solr/pull/1713#issuecomment-673719711
> Hey @yuriy-b-koval , it took me awhile to understand it, but I spent some
time brushing up on edismax and am confident enough to say this LGTM now.
>
> That sa
mikemccand commented on pull request #1623:
URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-673725282
> I kicked off beasting of all Lucene (core + modules) tests with this
change ... no failures yet after 31 iterations.
OK, it has run 1061 iterations now of all Luc
mikemccand commented on pull request #1743:
URL: https://github.com/apache/lucene-solr/pull/1743#issuecomment-673726633
Another few, not sure if these also fail on mainline (though prolly we have
seed shifting?):
```
[junit4:pickseed] Seed property 'tests.seed' already defined:
B
mikemccand commented on pull request #1743:
URL: https://github.com/apache/lucene-solr/pull/1743#issuecomment-673726880
Ugh sorry wrong PR!
This is an automated message from the Apache Git Service.
To respond to the message,
mikemccand commented on pull request #1623:
URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-673727019
Ugh, also these test failures that I put onto the wrong PR:
https://github.com/apache/lucene-solr/pull/1743#issuecomment-673726633
--
msfroh commented on pull request #1623:
URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-673730625
I went through the code yesterday to try to understand what's going on.
I'm not familiar with the pooled reader stuff, but it seems reasonable to
me. I trust the tests
msfroh commented on a change in pull request #1623:
URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r470274067
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -3321,8 +3395,11 @@ private long prepareCommitInternal() throws IOExc
[
https://issues.apache.org/jira/browse/SOLR-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177355#comment-17177355
]
Jörn Franke commented on SOLR-14669:
server.1=serverA:2888:3888:participant
server.2=
[
https://issues.apache.org/jira/browse/SOLR-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177363#comment-17177363
]
Jan Høydahl commented on SOLR-14669:
Hmm, you are also missing client port (e.g. {{;2
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177369#comment-17177369
]
Mark Robert Miller commented on SOLR-14636:
---
Yeah, Monday will be the big day.
janhoy commented on pull request #1747:
URL: https://github.com/apache/lucene-solr/pull/1747#issuecomment-673759242
SOLR-14751
This is an automated message from the Apache Git Service.
To respond to the message, please log on
janhoy merged pull request #1747:
URL: https://github.com/apache/lucene-solr/pull/1747
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177379#comment-17177379
]
ASF subversion and git services commented on SOLR-14751:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-14751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177381#comment-17177381
]
ASF subversion and git services commented on SOLR-14751:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-14751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-14751:
---
Fix Version/s: 8.7
> Zookeeper Admin screen not working for old ZK versions
> ---
[
https://issues.apache.org/jira/browse/SOLR-14751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-14751.
Resolution: Fixed
> Zookeeper Admin screen not working for old ZK versions
> --
gerlowskija commented on pull request #1713:
URL: https://github.com/apache/lucene-solr/pull/1713#issuecomment-673764351
Thanks Yuriy, this LGTM. Just need to run the test suite on it locally and
I'll merge.
This is an
gerlowskija merged pull request #1741:
URL: https://github.com/apache/lucene-solr/pull/1741
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/SOLR-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177412#comment-17177412
]
ASF subversion and git services commented on SOLR-14677:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177445#comment-17177445
]
Mark Robert Miller commented on SOLR-14636:
---
I’ll make internal zk work again F
[
https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177466#comment-17177466
]
David Smiley commented on SOLR-13998:
-
When filing an issue that creates two interfac
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177472#comment-17177472
]
Mark Robert Miller commented on SOLR-14636:
---
Well I can’t believe it, I’m fixin
[
https://issues.apache.org/jira/browse/SOLR-14596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177474#comment-17177474
]
David Smiley commented on SOLR-14596:
-
At least for CollectionAdminRequest but maybe
[
https://issues.apache.org/jira/browse/LUCENE-9427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-9427:
-
Component/s: modules/highlighter
> Unified highlighter can fail to highlight fuzzy query
> -
[
https://issues.apache.org/jira/browse/SOLR-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177483#comment-17177483
]
David Smiley commented on SOLR-14713:
-
Would a better async API be another path that
[
https://issues.apache.org/jira/browse/SOLR-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177511#comment-17177511
]
David Smiley commented on SOLR-14639:
-
This is a depressing discovery. I really appr
73 matches
Mail list logo
