gautamworah96 commented on a change in pull request #1733:
URL: https://github.com/apache/lucene-solr/pull/1733#discussion_r470160799
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java
##########
@@ -494,6 +496,7 @@ private int addCategoryDocument(FacetLabel categoryPath,
int parent) throws IOEx
fullPathField.setStringValue(FacetsConfig.pathToString(categoryPath.components,
categoryPath.length));
d.add(fullPathField);
+ d.add(new BinaryDocValuesField(Consts.FULL, new
BytesRef(FacetsConfig.pathToString(categoryPath.components,
categoryPath.length))));
Review comment:
Yep, this could be cleaner. Extracted out in the next commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
