[
https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176999#comment-17176999
]
Uwe Schindler commented on SOLR-14680:
--------------------------------------
Why was the "make java 8 compatible" committed to master? Makes no sense to me,
master is on Java 11, so it should be compatible.
In addition, this caused a build failure on master and 8.x in Solrj:
{noformat}
common.compile-core:
[mkdir] Created dir:
/Users/jenkins/workspace/Lucene-Solr-8.x-MacOSX/solr/build/solr-solrj/classes/java
[javac] Compiling 780 source files to
/Users/jenkins/workspace/Lucene-Solr-8.x-MacOSX/solr/build/solr-solrj/classes/java
[javac]
/Users/jenkins/workspace/Lucene-Solr-8.x-MacOSX/solr/solrj/src/java/org/apache/solr/common/util/Utils.java:740:
error: incompatible types: Charset cannot be converted to String
[javac] final String path = URLDecoder.decode(nodeName.substring(1 +
_offset), UTF_8);
[javac]
^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note:
/Users/jenkins/workspace/Lucene-Solr-8.x-MacOSX/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Variable.java
uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Note: Some messages have been simplified; recompile with
-Xdiags:verbose to get full output
[javac] 1 error
{noformat}
There's no URLDecoder taking nio.Charset.
In addition I would be careful to use URLDecoder, as this is not fully
compliant with general URL decoding (it has special handling for "+", which is
only applicable for form-encoded stuff, real URL decoding should be done with
e.g. jetty classes or the implementation in RequestParsers).
> Provide simple interfaces to our concrete SolrCloud classes
> -----------------------------------------------------------
>
> Key: SOLR-14680
> URL: https://issues.apache.org/jira/browse/SOLR-14680
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Minor
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> All our current implementations of SolrCloud such as
> # ClusterState
> # DocCollection
> # Slice
> # Replica
> etc are concrete classes. Providing alternate implementations or wrappers is
> extremely difficult.
> SOLR-14613 is attempting to create such interfaces to make their sdk simpler
> The objective is not to have a comprehensive set of methods in these
> interfaces. We will start out with a subset of required interfaces. We
> guarantee is that signatures of methods in these interfaces will not be
> deleted/changed . But we may add more methods as and when it suits us
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
