[ 
https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177021#comment-17177021
 ] 

Noble Paul commented on SOLR-14680:
-----------------------------------

{quote}Why was the "make java 8 compatible" committed to master? Makes no sense 
to me, master is on Java 11, so it should be compatible.

{quote}

I want the same code to be on both master and 8x so that , any future changes 
can be easily cherry-picked

{quote}
Was this change really intended for 8x? I expected this to be applicable only 
to 9.0 because it still requires a lot of refactoring to use the new APIs.
{quote}

This was not necessarily going to meet 100% the requirements of any new API. We 
can always add new things if the new API demands it. My objective was to keep 
parity between master/8x. There is no point in having divergence between the 
branches

> Provide simple interfaces to our concrete SolrCloud classes
> -----------------------------------------------------------
>
>                 Key: SOLR-14680
>                 URL: https://issues.apache.org/jira/browse/SOLR-14680
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Minor
>          Time Spent: 10.5h
>  Remaining Estimate: 0h
>
> All our current implementations of SolrCloud such as 
> # ClusterState
> # DocCollection
> # Slice
> # Replica
> etc are concrete classes. Providing alternate implementations or wrappers is 
> extremely difficult. 
> SOLR-14613 is attempting to create  such interfaces to make their sdk simpler
> The objective is not to have a comprehensive set of methods in these 
> interfaces. We will start out with a subset of required interfaces. We 
> guarantee is that signatures of methods in these interfaces will not be 
> deleted/changed . But we may add more methods as and when it suits us



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to