[PATCH] D144961: [NVPTX] Add f16 and v2f16 ldg builtins

jchlanda updated this revision to Diff 501392. jchlanda added a comment. Add more verbose test names. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144961/new/ https://reviews.llvm.org/D144961 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/CGBuiltin.cpp clan

[PATCH] D144961: [NVPTX] Add f16 and v2f16 ldg builtins

jchlanda added inline comments. Comment at: llvm/test/CodeGen/NVPTX/ldu-ldg.ll:5-6 declare i8 @llvm.nvvm.ldu.global.i.i8.p1(ptr addrspace(1) %ptr, i32 %align) declare i32 @llvm.nvvm.ldu.global.i.i32.p1(ptr addrspace(1) %ptr, i32 %align) + tra wrote: > Do we w

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

mstorsjo added reviewers: akhuang, hans, thakis, zahen, pkasting. mstorsjo added a comment. Looks reasonable to me, adding a few others for opinions. Should we have some tests for this? I guess testing these is somewhat environment reliant though, so it's probably not so easy... Repository:

[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 added a comment. In D144454#4142253 , @rjmccall wrote: > New builtins should be documented in the user manual. > > There are standard pragmas for changing the rounding mode, right? What's the > interaction between the ability to set this dynam

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. A more generic version might be to have a list of variables to (not) passthrough. First option is to remove `{C,CXX}_COMPILER_LAUNCHER` from `_BOOTSTRAP_DEFAULT_PASSTHROUGH` and then include it as needed by setting something like `CLANG_BOOTSTRAP_EXTRA_PASSTHROUGH=C_CO

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. @beanz @smeenai do you have any preferences/other ideas? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144603/new/ https://reviews.llvm.org/D144603 ___ cfe-commits mailing list cf

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143480/new/ https://reviews.llvm.org/D143480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143466/new/ https://reviews.llvm.org/D143466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

donat.nagy added a comment. Basically LGTM (assuming that the TC passes), I added two minor suggestions, but I'm not opposed to merging this in its current state. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8142-8150 + R"( + template + struct A; +

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143334/new/ https://reviews.llvm.org/D143334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142617/new/ https://reviews.llvm.org/D142617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1486 bool IsBeingCompiled = Func && !Func->isFullyCompiled(); - bool WasNotDefined = Func && !Func->hasBody(); + bool WasNotDefined = Func && !Func->isConstexpr() && !Func->hasBody(); -

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.org/D141472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] feba033 - [clang][ASTImporter] Improve import of InjectedClassNameType.

Author: Balázs Kéri Date: 2023-03-01T09:26:10+01:00 New Revision: feba03340cf3a1690e75ede75ca4603acb9dc2a6 URL: https://github.com/llvm/llvm-project/commit/feba03340cf3a1690e75ede75ca4603acb9dc2a6 DIFF: https://github.com/llvm/llvm-project/commit/feba03340cf3a1690e75ede75ca4603acb9dc2a6.diff L

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfeba03340cf3: [clang][ASTImporter] Improve import of InjectedClassNameType. (authored by balazske). Changed prior to commit: https://reviews.llvm.

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay added a comment. As tests currently fail can you set it to "planned changes" until they pass [ FAILED ] 5 tests, listed below: [ FAILED ] QualifierFixerTest.RightQualifier [ FAILED ] QualifierFixerTest.LeftQualifier [ FAILED ] QualifierFixerTest.ConstVolatileQualifi

[PATCH] D145031: [clang-tidy] use isConvertingConstructor to simplify code

thyecust updated this revision to Diff 501407. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145031/new/ https://reviews.llvm.org/D145031 Files: clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.cpp Index: clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.cpp ==

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 501420. AlexanderHederstaf added a comment. Distinguish configured qualifiers from other qualifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 Files:

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. This code from llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp failed with **Right** but without a full list of specifiers. As **static** was not configured, the } was not discovered by **IsRightQualifier**. Changed some of the qualifier tests to chec

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. In D144709#4160820 , @MyDeveloperDay wrote: > As tests currently fail can you set it to "planned changes" until they pass > > [ FAILED ] 5 tests, listed below: > [ FAILED ] QualifierFixerTest.RightQualifier >

[PATCH] D145047: Fix broken link on Clang documentation page

tupaschoal created this revision. tupaschoal added reviewers: vhscampos, brenoguim. Herald added a project: All. tupaschoal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While browsing the latest clang manual

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 501428. jolanta.jensen added a comment. Test adjustment for Windows. Disabling read permissions using chmod does not seem to work on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ ht

[PATCH] D145047: Fix broken link on Clang documentation page

tupaschoal added a subscriber: royjacobson. tupaschoal added a comment. Btw seems to have been broken recently by https://github.com/llvm/llvm-project/commit/f5aa8d191a5b5ea118281bfa410bdb2ee961c704, so tagging @royjacobson too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145040: Add test for Flags.data_flow_trace

karapsinie updated this revision to Diff 501432. karapsinie added a comment. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. arc diff git merge-base HEAD origin --update D145040 Repository: rG LLVM Gith

[PATCH] D145031: [clang-tidy] use isConvertingConstructor to simplify code

thyecust abandoned this revision. thyecust added a comment. this change looks meaningless now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145031/new/ https://reviews.llvm.org/D145031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon added a comment. Thanks for the review @shafik . Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not

[clang] 831591b - [NFC][clang] Refine tests by adding `:` to checks

Author: Mariya Podchishchaeva Date: 2023-03-01T05:58:34-05:00 New Revision: 831591b2a075d86f7ae51d0f688af1ddcf360707 URL: https://github.com/llvm/llvm-project/commit/831591b2a075d86f7ae51d0f688af1ddcf360707 DIFF: https://github.com/llvm/llvm-project/commit/831591b2a075d86f7ae51d0f688af1ddcf3607

[PATCH] D144495: [NFC][clang] Refine tests by adding `:` to checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG831591b2a075: [NFC][clang] Refine tests by adding `:` to checks (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144495/new/ https://r

[PATCH] D145040: Add test for Flags.data_flow_trace

karapsinie updated this revision to Diff 501449. karapsinie added a comment. Attempt to restore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145040/new/ https://reviews.llvm.org/D145040 Files: compiler-rt/lib/fuzzer/FuzzerDriver.cpp Index: co

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie added a comment. I tried rebase revision, but edit other revision (https://reviews.llvm.org/D145040). We need to rebase the revision, because the tests are falling, because there is no this commit: https://reviews.llvm.org/rG24d144571dbffc6993d13fb7ca781248eed024de How do it? Repos

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders added inline comments. Comment at: clang/lib/Basic/Attributes.cpp:46 + for (auto &AttrPlugin : getAttributePluginInstances()) { +for (auto &S : AttrPlugin->Spellings) + if (S.Syntax == Syntax && S.NormalizedFullName == Name) erichkeane wrote: >

[clang] 570995e - [clang][test][RISCV] Add RISC-V to clang/test/Sema/Float16.c

Author: Alex Bradbury Date: 2023-03-01T11:33:30Z New Revision: 570995eba2f93d639e69b6b12817d44a3b26cc72 URL: https://github.com/llvm/llvm-project/commit/570995eba2f93d639e69b6b12817d44a3b26cc72 DIFF: https://github.com/llvm/llvm-project/commit/570995eba2f93d639e69b6b12817d44a3b26cc72.diff LOG:

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 501451. karapsinie added a comment. Execute "git-clang-format HEAD~1" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/TokenKinds.def

[PATCH] D142373: [Utils] Add --full-function-signature to update_cc_test_checks.py to match return type as well as args

asb abandoned this revision. asb added a comment. Abandoned in favour of https://reviews.llvm.org/D144963 which rebases this logic on top of the new `--version` support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142373/new/ https://reviews.llv

[clang] f8d10d5 - [clang-format][NFC] Refactor formatting unit tests.

Author: Manuel Klimek Date: 2023-03-01T12:36:07Z New Revision: f8d10d5ac9ab4b45b388c74357fc82fb96562e66 URL: https://github.com/llvm/llvm-project/commit/f8d10d5ac9ab4b45b388c74357fc82fb96562e66 DIFF: https://github.com/llvm/llvm-project/commit/f8d10d5ac9ab4b45b388c74357fc82fb96562e66.diff LOG:

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 created this revision. kpdev42 added reviewers: clayborg, balazske. kpdev42 added a project: LLVM. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. kpdev42 requested review of this revision. Herald added a project: clang. Herald added a subsc

[PATCH] D145059: [clangd] Add support from showing used symbols on cross ref request

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 501476. AlexanderHederstaf added a comment. Change order for typename and :: as const typename ::Bar b; is valid code. Add code for handling ::template. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 81979c3 - [clang][RISCV][test] Add further test coverage for _Float16 on RISC-V

Author: Alex Bradbury Date: 2023-03-01T13:32:49Z New Revision: 81979c3038defe8653b62ba05517ee6d6b3eb976 URL: https://github.com/llvm/llvm-project/commit/81979c3038defe8653b62ba05517ee6d6b3eb976 DIFF: https://github.com/llvm/llvm-project/commit/81979c3038defe8653b62ba05517ee6d6b3eb976.diff LOG:

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 501484. karapsinie added a comment. Duplicate code moved to "Preprocessor::processPathToFilename" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h clang/include/

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 501486. karapsinie added a comment. Execute "git-clang-format HEAD~1" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/TokenKinds.def

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

aaron.ballman added a comment. In D143415#4160550 , @vedgy wrote: > Can someone merge/land this review? I don't have commit access. I'm happy to do that for you -- what name and email address would you like me to use for patch attribution? Repository:

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136751/new/ https://reviews.llvm.org/D136751 ___ cfe-commits mailing lis

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/InterpStack.h:70-72 + template T &peek(size_t Offset) const { +return *reinterpret_cast(peek(Offset)); + } Ooofda, this only differs from `peek()` on line 97 because this function has a

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

vedgy added a comment. In D143415#4161460 , @aaron.ballman wrote: > In D143415#4160550 , @vedgy wrote: > >> Can someone merge/land this review? I don't have commit access. > > I'm happy to do that for you -- what

[clang] 8d09bd6 - [clang][Interp] This pointers are writable in de-/constructors

Author: Timm Bäder Date: 2023-03-01T15:41:10+01:00 New Revision: 8d09bd616be8e347d2769d7b17cd8e717c855c45 URL: https://github.com/llvm/llvm-project/commit/8d09bd616be8e347d2769d7b17cd8e717c855c45 DIFF: https://github.com/llvm/llvm-project/commit/8d09bd616be8e347d2769d7b17cd8e717c855c45.diff LO

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d09bd616be8: [clang][Interp] This pointers are writable in de-/constructors (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136751/new/

[clang] 3eceab9 - LibclangTest: remove libclang-test-* tmp dir reliably

Author: Igor Kushnir Date: 2023-03-01T09:45:24-05:00 New Revision: 3eceab95f314edb85ee72c047a4acd35e757d037 URL: https://github.com/llvm/llvm-project/commit/3eceab95f314edb85ee72c047a4acd35e757d037 DIFF: https://github.com/llvm/llvm-project/commit/3eceab95f314edb85ee72c047a4acd35e757d037.diff

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3eceab95f314: LibclangTest: remove libclang-test-* tmp dir reliably (authored by vedgy, committed by aaron.ballman). Repository: rG LLVM Github Mo

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

aaron.ballman added a comment. In D143415#4161495 , @vedgy wrote: > In D143415#4161460 , @aaron.ballman > wrote: > >> In D143415#4160550 , @vedgy wrote: >> >>> Can someon

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Gentle ping for review. @hubert.reinterpretcast Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mail

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

tbaeder updated this revision to Diff 501502. tbaeder added a comment. Added an `aligned()` assertion and renamed the old `peek(unsigned Offset)` returning a `void*` to `peekData()`, so both `peek` overloads are now public member functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D142630: [clang][Interp] Implement virtual function calls

aaron.ballman added a comment. (Still thinking about the implementation work here, mostly just drive-by comments at the moment. My gut instinct is that we've not got sufficient test coverage here, but that might be partially because of other parts of the interpreter not being ready yet.) ===

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

spaits created this revision. spaits added reviewers: NoQ, steakhal, Szelethus. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. spaits requested review of this revision. Her

[clang] 34b412d - [clang][RISCV][test] Add coverage for __fp16 support in arguments/returns

Author: Alex Bradbury Date: 2023-03-01T15:20:15Z New Revision: 34b412dc0efe898b18b7afcf02d9e44d7e05b5ec URL: https://github.com/llvm/llvm-project/commit/34b412dc0efe898b18b7afcf02d9e44d7e05b5ec DIFF: https://github.com/llvm/llvm-project/commit/34b412dc0efe898b18b7afcf02d9e44d7e05b5ec.diff LOG:

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder updated this revision to Diff 501506. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/C

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

compnerd added a comment. Yeah, I suspect that would be difficult. Additionally, these are aliases, so they should already have testing coverage through the existing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145007/new/ https://reviews

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

owenpan added a comment. In D141230#4054768 , @seanptmaher wrote: > I can't actually commit this -- could one of you? Or has it already been > done? I remember reading that someone had to manually push the patch upstream. Can we have the name and email

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

MaggieYi updated this revision to Diff 501509. MaggieYi added a comment. Thanks Zequan. I have added two tests following your suggestion. Kind regards, Maggie CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144371/new/ https://reviews.llvm.org/D144371 Files: clang/lib/CodeGen/Coverage

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

MaggieYi marked an inline comment as done. MaggieYi added inline comments. Comment at: clang/test/CoverageMapping/terminate-statements.cpp:335 + ( true ? void (0) : abort() ); // CHECK: Gap,File 0, [[@LINE]]:33 -> [[@LINE+1]]:3 = #1 + ( false ? void (0) : abort() ); // CHECK:

[PATCH] D143466: [clang][Interp] Fix initializing base class members

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:260 + class _C : public _B {}; + constexpr _C c{12}; +}; We should test that the initialization actually happened. Comment at: clang/test/AST/Interp/records.cp

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141591/new/ https://reviews.llvm.org/D141591 ___ cfe-commits mailing list

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

balazske updated this revision to Diff 501514. balazske added a comment. Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144273/new/ https://reviews.llvm.org/D144273 Files: clang/lib/AST/ASTImporterLookupTable.cpp clang/test/Import/c

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

zequanwu accepted this revision. zequanwu added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144371/new/ https://reviews.llvm.org/D144371 ___ cfe-commits mailing list cfe-comm

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

ashay-github updated this revision to Diff 501516. ashay-github added a comment. Rebased with main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144934/new/ https://reviews.llvm.org/D144934 Files: clang/test/ClangScanDeps/P1689.cppm In

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

balazske added a comment. A tried to find out how to add a correct test but could not check if this fails or not on AArch64 platform. The test should import the va_list declarations and then another variable `std`. I want to touch `ASTContext` only if a test failure is found on AArch64 that mak

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. In D144709#4160939 , @AlexanderHederstaf wrote: > This code from llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp failed > with **Right** but without a full list of specifiers. As **static** was not > configur

[clang] 730eca6 - [clang][Interp] Handle DecompositionDecls

Author: Timm Bäder Date: 2023-03-01T17:11:57+01:00 New Revision: 730eca6a3de85ae66bb905ee32c47332b5395226 URL: https://github.com/llvm/llvm-project/commit/730eca6a3de85ae66bb905ee32c47332b5395226 DIFF: https://github.com/llvm/llvm-project/commit/730eca6a3de85ae66bb905ee32c47332b5395226.diff LO

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG730eca6a3de8: [clang][Interp] Handle DecompositionDecls (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138802/new/ https://reviews.llv

[PATCH] D140891: [analyzer] Fix assertion failure in SMT conversion for unary operator on floats.

steakhal added a comment. I'm proposing to backport this fix to clang-16. https://github.com/llvm/llvm-project/issues/61097 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140891/new/ https://reviews.llvm.org/D140891

[PATCH] D140075: [libclang] Expose using shadow types and declarations in libclang.

aaron.ballman added inline comments. Comment at: clang/tools/libclang/CXCursor.cpp:1279-1281 + if (const UsingType *Using = Ty->getAs()) +if (const UsingShadowDecl *Shadow = Using->getFoundDecl()) + if (const auto *TD = dyn_cast_or_null(Shadow->getTargetDecl())) ---

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142617/new/ https://reviews.llvm.org/D142617 ___ cfe-commits mailing lis

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501526. francii added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/unus

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501527. francii added a comment. Merge z/OS and AIX profiling tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp c

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501529. francii added a comment. Remove old test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driv

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501530. francii added a comment. Remove old test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driv

[PATCH] D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs

asb created this revision. asb added reviewers: kito-cheng, jrtc27, reames, craig.topper. Herald added subscribers: luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogf

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501531. francii added a comment. Add test case descriptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tes

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501533. francii added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/ibm-profiling.

[PATCH] D145075: [clangd] Show used symbol on include hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcf5ad89dcc5: [ASTMatcher] Add coroutineBodyStmt matcher (authored by ccotter, committed by aaron.ballman). Repository: rG LLVM Github Monorepo C

[clang] dcf5ad8 - [ASTMatcher] Add coroutineBodyStmt matcher

Author: Chris Cotter Date: 2023-03-01T11:51:46-05:00 New Revision: dcf5ad89dcc5cc69b9df3e5dd9be71c65642f519 URL: https://github.com/llvm/llvm-project/commit/dcf5ad89dcc5cc69b9df3e5dd9be71c65642f519 DIFF: https://github.com/llvm/llvm-project/commit/dcf5ad89dcc5cc69b9df3e5dd9be71c65642f519.diff

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman added a comment. In D140794#4160358 , @ccotter wrote: > Thanks both! Assuming this passes build, would one of you mind committing > this for me? `Chris Cotter ` Happy to do so! I've landed it on your behalf in dcf5ad89dcc5cc69b9df3e5dd9be

[clang] 969ab71 - [clang] drop buggy use of `-serialize-diagnostics` flag

Author: Ashay Rane Date: 2023-03-01T10:53:39-06:00 New Revision: 969ab7134f4df52a5887a49006c703515163ee22 URL: https://github.com/llvm/llvm-project/commit/969ab7134f4df52a5887a49006c703515163ee22 DIFF: https://github.com/llvm/llvm-project/commit/969ab7134f4df52a5887a49006c703515163ee22.diff LO

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG969ab7134f4d: [clang] drop buggy use of `-serialize-diagnostics` flag (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144934/new/ https:/

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this patch, we now emit a `DW_AT_LLVM_preferred_name` for the `[cl

[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

balazske updated this revision to Diff 501539. balazske added a comment. Updated the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTI

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 __

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501540. Michael137 added a comment. - Remove redundant TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6327 } - if (Arg *A = Args.getLastArgNoClaim(options::OPT_p)) { + if (Arg *A = Args.getLastArg(options::OPT_p)) { if (TC.getTriple().isOSAIX()) { Actually, a question here

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

aaron.ballman added a comment. In D143233#4160206 , @efriedma wrote: > Maybe worth cherry-picking to 16 branch? I think someone will need to rebase > onto the branch for that, though; there was merge conflict on the > microsoft-abi-eh-cleanups.cpp chan

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501544. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/C

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 added a comment. Since the new attribute only gets attached to a structure definition, and the preferred_name attribute is currently only really used in a handful of places in libcxx, this practically doesn't affect debug-info size Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie marked an inline comment as done. karapsinie added a comment. If all is well, approve and merge the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 ___ cfe-commits mailing list cfe

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc added inline comments. Comment at: clang/include/clang/Basic/arm_sme.td:103 +def NAME # _H : SInst<"svwrite_hor_" # n_suffix # "[_{d}]", "vimiPd", t, MergeOp1, + "aarch64_sme_write" # !cond(!eq(n_suffix, "za128") : "q", true: "") # "_horiz"

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy updated this revision to Diff 501559. vedgy added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143418/new/ https://reviews.llvm.org/D143418 Files: clang-tools-extra/clangd/Preamble.cpp clang/docs/Relea

[PATCH] D144603: Add option to disable compiler launcher on external projects

smeenai added a comment. Hmm, what cache key does ccache use for compilers? Is it the `--version` output string, the path, or some combination? If the path is involved then I don't see any value in using ccache for configuring anything past stage1, since the compiler will (presumably) be instal

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy marked 2 inline comments as done. vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:329 + * CXIndexOptions Opts = { sizeof(CXIndexOptions), + * clang_getDefaultGlobalOptions() }; + * \endcode When I almost finish

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I originally was hoping we wouldn't have to introduce a new attribute for this, but it looks like there are legitimate concerns about the alternatives, so in that sense this looks good! Re

  1   2   >