xiongji90 added a comment. In D144454#4142253 <https://reviews.llvm.org/D144454#4142253>, @rjmccall wrote:
> New builtins should be documented in the user manual. > > There are standard pragmas for changing the rounding mode, right? What's the > interaction between the ability to set this dynamically with a builtin call > and those pragmas? Hi, @rjmccall I didn't find appropriate place to document this new added builtin in https://github.com/llvm/llvm-project/blob/main/clang/docs/UsersManual.rst and didn't find a specific doc for builtins, so could you provide advice on where should document builtins newly added? Thanks very much. ================ Comment at: clang/test/CodeGen/builtins.c:283 + res = __builtin_flt_rounds_set(1); + // CHECK: call void @llvm.set.rounding( } ---------------- rjmccall wrote: > Just for completeness, please test that this gets the result of the > expression. Hi, @rjmccall I updated the test to check "llvm.set.rounding" string with input, does it meet your requirement? Thanks very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144454/new/ https://reviews.llvm.org/D144454 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
