Author: Ashay Rane Date: 2023-03-01T10:53:39-06:00 New Revision: 969ab7134f4df52a5887a49006c703515163ee22
URL: https://github.com/llvm/llvm-project/commit/969ab7134f4df52a5887a49006c703515163ee22 DIFF: https://github.com/llvm/llvm-project/commit/969ab7134f4df52a5887a49006c703515163ee22.diff LOG: [clang] drop buggy use of `-serialize-diagnostics` flag The `-serialize-diagnostics` flag requires a filename to be passed immediately after it, but the filename argument was skipped in the P1689.cppm clang test. This caused the code to incorrectly consume the argument that followed as the dignostics file. Since the `-serialize-diagnostics` flag isn't needed for this test to work, this patch removes it instead of passing a file argument. Differential Revision: https://reviews.llvm.org/D144934 Added: Modified: clang/test/ClangScanDeps/P1689.cppm Removed: ################################################################################ diff --git a/clang/test/ClangScanDeps/P1689.cppm b/clang/test/ClangScanDeps/P1689.cppm index bbe9cc3b2d332..dffb16974a3e4 100644 --- a/clang/test/ClangScanDeps/P1689.cppm +++ b/clang/test/ClangScanDeps/P1689.cppm @@ -40,7 +40,7 @@ // // Check that we can mix the use of -format=p1689 and -fmodules. // RUN: clang-scan-deps -format=p1689 \ -// RUN: -- %clang++ -std=c++20 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache -serialize-diagnostics -c %t/impl_part.cppm -o %t/impl_part.o \ +// RUN: -- %clang++ -std=c++20 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache -c %t/impl_part.cppm -o %t/impl_part.o \ // RUN: | FileCheck %t/impl_part.cppm -DPREFIX=%/t //--- P1689.json.in _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
