balazske added a comment.

A tried to find out how to add a correct test but could not check if this fails 
or not on AArch64 platform. The test should import the va_list declarations and 
then another variable `std`. I want to touch `ASTContext` only if a test 
failure is found on AArch64 that makes it necessary. In that case I would add a 
non-modifying function `getVaListTagDeclIfExists`, another option is to change 
all other simiar get functions to "getOrCreate" form to have consistent API.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144273/new/

https://reviews.llvm.org/D144273

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to