donat.nagy added a comment.
Basically LGTM (assuming that the TC passes), I added two minor suggestions,
but I'm not opposed to merging this in its current state.
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:8142-8150
+ R"(
+ template <class T>
+ struct A;
+ template <class T>
+ struct A {};
+ template <template<class> class T = A>
+ struct B {};
----------------
Nitpick: consider saving this string in a constant instead of repeating it
twice.
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:8201-8202
+ ->getAsRecordDecl());
+ EXPECT_TRUE(Spec1->getPreviousDecl() == Spec2 ||
+ Spec2->getPreviousDecl() == Spec1);
+ TemplateDecl *Templ1 =
----------------
For clarity, perhaps also assert that Spec1 != Spec2.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144622/new/
https://reviews.llvm.org/D144622
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
