[PATCH] D83914: [clangd] Plan features for FoldingRanges

hokein added a comment. just some random comments from my side. > At least for the AST-based folds, I'd like some formalism like: +1. I think we need some general rules (mental model) to guide us how the folding works. Some editors (e.g. VSCode) have their builtin folding-range, it is worth to

[clang-tools-extra] 82dbb1b - Fix the clang-tidy build after get/isIntegerConstantExpression

Author: Haojian Wu Date: 2020-07-22T09:38:56+02:00 New Revision: 82dbb1b2b4f1e70ca453cca60a4ba5b856058fc0 URL: https://github.com/llvm/llvm-project/commit/82dbb1b2b4f1e70ca453cca60a4ba5b856058fc0 DIFF: https://github.com/llvm/llvm-project/commit/82dbb1b2b4f1e70ca453cca60a4ba5b856058fc0.diff LO

[PATCH] D84222: [AST][RecoveryExpr] Error-dependent expression should not be treat as a nullptr pointer constant.

hokein updated this revision to Diff 279715. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84222/new/ https://reviews.llvm.org/D84222 Files: clang/lib/AST/Expr.cpp

[PATCH] D84222: [AST][RecoveryExpr] Error-dependent expression should not be treat as a nullptr pointer constant.

hokein added inline comments. Comment at: clang/lib/AST/Expr.cpp:3747 case NPC_ValueDependentIsNull: - if (isTypeDependent() || getType()->isIntegralType(Ctx)) + if ((!containsErrors() && isTypeDependent()) || + getType()->isIntegralType(Ctx))

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet added a comment. In D83759#2165974 , @ArcsinX wrote: > Seem the problem is in `-i` option. > According with OSX man: > `sed [-Ealn] command [file ... ]` > `sed [-Ealn] [-e command] [-f command_file] [-i extension] [file ...]`. > > Seems on macO

[clang] 706a435 - [AST][RecoveryExpr] Error-dependent expression should not be treat as a nullptr pointer constant.

Author: Haojian Wu Date: 2020-07-22T10:03:51+02:00 New Revision: 706a4353e87b1127446db7daf5e3e95fcb408924 URL: https://github.com/llvm/llvm-project/commit/706a4353e87b1127446db7daf5e3e95fcb408924 DIFF: https://github.com/llvm/llvm-project/commit/706a4353e87b1127446db7daf5e3e95fcb408924.diff LO

[PATCH] D84222: [AST][RecoveryExpr] Error-dependent expression should not be treat as a nullptr pointer constant.

This revision was automatically updated to reflect the committed changes. Closed by commit rG706a4353e87b: [AST][RecoveryExpr] Error-dependent expression should not be treat as a nullptr… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:476 +// -mfpu=none, -march=armvX+nofp or -mcpu=X+nofp is *very* similar to +// -mfloat-abi=soft, only that it should not disable MVE-I. Features.insert(Features.end(), -

[PATCH] D84291: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation

rzurob accepted this revision. rzurob added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84291/new/ https://reviews.llvm.org/D84291 ___

[clang] 3895466 - accept 'clang++ -c a.pch -o a.o' to create PCH's object file

Author: Luboš Luňák Date: 2020-07-22T10:21:23+02:00 New Revision: 3895466e2c336c0797710ae35150ba1ce6bc0b96 URL: https://github.com/llvm/llvm-project/commit/3895466e2c336c0797710ae35150ba1ce6bc0b96 DIFF: https://github.com/llvm/llvm-project/commit/3895466e2c336c0797710ae35150ba1ce6bc0b96.diff L

[PATCH] D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG54eea6127c4d: add -fpch-codegen/debuginfo mapping to -fmodules-codegen/debuginfo (authored by llunak). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: htt

[clang] 54eea61 - add -fpch-codegen/debuginfo mapping to -fmodules-codegen/debuginfo

Author: Luboš Luňák Date: 2020-07-22T10:21:53+02:00 New Revision: 54eea6127c4d77db03787b7c55765632fb9a6f1c URL: https://github.com/llvm/llvm-project/commit/54eea6127c4d77db03787b7c55765632fb9a6f1c DIFF: https://github.com/llvm/llvm-project/commit/54eea6127c4d77db03787b7c55765632fb9a6f1c.diff L

[Differential] D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG54eea6127c4d: add -fpch-codegen/debuginfo mapping to -fmodules-codegen/debuginfo (authored by llunak). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: htt

[PATCH] D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file

This revision was automatically updated to reflect the committed changes. Closed by commit rG3895466e2c33: accept 'clang++ -c a.pch -o a.o' to create PCH's object file (authored by llunak). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[Differential] D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file

This revision was automatically updated to reflect the committed changes. Closed by commit rG3895466e2c33: accept 'clang++ -c a.pch -o a.o' to create PCH's object file (authored by llunak). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://r

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

chill added a comment. In D75044#2165496 , @chill wrote: > The issue is that the definition of the instructions `XPAC{D,I}` is > incorrect: it does not mention at all the operand to those insns. Err, they do mention the operand, but only as an input one

[PATCH] D84297: [clangd] Fix Origin and MainFileOnly-ness for macros

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This was resulting in macros coming from preambles vanishing when user have opened the source header. For

[clang] 5567c62 - [Matrix] Add LowerMatrixIntrinsics to the NPM

Author: Sjoerd Meijer Date: 2020-07-22T09:47:53+01:00 New Revision: 5567c62afa559dc2f2604601ec9269f1e3fbfdab URL: https://github.com/llvm/llvm-project/commit/5567c62afa559dc2f2604601ec9269f1e3fbfdab DIFF: https://github.com/llvm/llvm-project/commit/5567c62afa559dc2f2604601ec9269f1e3fbfdab.diff

[PATCH] D84180: [Matrix] Add LowerMatrixIntrinsics to the NPM

This revision was automatically updated to reflect the committed changes. Closed by commit rG5567c62afa55: [Matrix] Add LowerMatrixIntrinsics to the NPM (authored by SjoerdMeijer). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.ll

[PATCH] D83296: [clang-format] Add a MacroExpander.

sammccall added a comment. Sorry for the long delay, I've made up for it with extra comments :-\ This looks really well-thought-out and I'm rationalizing my pickiness as: - this is conceptually complicated - I expect this code to live a long time and be read and "modified around" by lots of peo

Re: [clang-tools-extra] 82dbb1b - Fix the clang-tidy build after get/isIntegerConstantExpression

Thanks for that! Sorry I was a bit slow to get that cleaned up. On Wed, Jul 22, 2020 at 12:41 AM Haojian Wu via cfe-commits wrote: > > > Author: Haojian Wu > Date: 2020-07-22T09:38:56+02:00 > New Revision: 82dbb1b2b4f1e70ca453cca60a4ba5b856058fc0 > > URL: > https://github.com/llvm/llvm-project/c

[PATCH] D84277: [PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments.

rzurob accepted this revision. rzurob added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84277/new/ https://reviews.llvm.org/D84277 ___

[PATCH] D84291: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation

nemanjai accepted this revision. nemanjai added a comment. LGTM. The test case addition can be done on the commit. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py ; RUN: llc -verify-m

[PATCH] D84297: [clangd] Fix Origin and MainFileOnly-ness for macros

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! the test.h in the patch description is missing a `#define X`. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:383 + !isHeaderFile(SM.getFileEntry

[PATCH] D84297: [clangd] Fix Origin and MainFileOnly-ness for macros

kadircet updated this revision to Diff 279731. kadircet marked 2 inline comments as done. kadircet added a comment. - Move declarations closer to use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84297/new/ https://reviews.llvm.org/D84297 Files:

[clang-tools-extra] a69f9a8 - [clangd] Fix Origin and MainFileOnly-ness for macros

Author: Kadir Cetinkaya Date: 2020-07-22T11:24:31+02:00 New Revision: a69f9a8584f2a090b5fe6235a112f9b68c324863 URL: https://github.com/llvm/llvm-project/commit/a69f9a8584f2a090b5fe6235a112f9b68c324863 DIFF: https://github.com/llvm/llvm-project/commit/a69f9a8584f2a090b5fe6235a112f9b68c324863.dif

[PATCH] D84297: [clangd] Fix Origin and MainFileOnly-ness for macros

kadircet added a comment. > the test.h in the patch description is missing a #define X. ah right, git descriptions omitting lines starting with `#` fixed it for include, but missed the define :face_palm: Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:383 +

[PATCH] D84297: [clangd] Fix Origin and MainFileOnly-ness for macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGa69f9a8584f2: [clangd] Fix Origin and MainFileOnly-ness for macros (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84297/new/ https://

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. @sammccall sorry for bothering you, could you please land this for me? Ilya Golovenko Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84172/new/ https://reviews.llvm.org/D84172

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

vsavchenko updated this revision to Diff 279738. vsavchenko added a comment. Make --projects and --max-size compatible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83942/new/ https://reviews.llvm.org/D83942 Files: clang/utils/analyzer/ProjectMa

[clang] e63b488 - [analyzer][solver] Track symbol disequalities

Author: Valeriy Savchenko Date: 2020-07-22T13:02:39+03:00 New Revision: e63b488f2755f91e8147fd678ed525cf6ba007cc URL: https://github.com/llvm/llvm-project/commit/e63b488f2755f91e8147fd678ed525cf6ba007cc DIFF: https://github.com/llvm/llvm-project/commit/e63b488f2755f91e8147fd678ed525cf6ba007cc.d

[Differential] D82381: [analyzer] Introduce small improvements to the solver infra

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf531c1c7c0d5: [analyzer] Introduce small improvements to the solver infra (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES S

[clang] b13d987 - [analyzer][solver] Track symbol equivalence

Author: Valeriy Savchenko Date: 2020-07-22T13:02:39+03:00 New Revision: b13d9878b8dcef4354ddfc86f382ca9b537e65aa URL: https://github.com/llvm/llvm-project/commit/b13d9878b8dcef4354ddfc86f382ca9b537e65aa DIFF: https://github.com/llvm/llvm-project/commit/b13d9878b8dcef4354ddfc86f382ca9b537e65aa.d

[clang] f531c1c - [analyzer] Introduce small improvements to the solver infra

Author: Valeriy Savchenko Date: 2020-07-22T13:02:39+03:00 New Revision: f531c1c7c0d5850c824333518ff32708730d775b URL: https://github.com/llvm/llvm-project/commit/f531c1c7c0d5850c824333518ff32708730d775b DIFF: https://github.com/llvm/llvm-project/commit/f531c1c7c0d5850c824333518ff32708730d775b.d

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

This revision was automatically updated to reflect the committed changes. Closed by commit rGf531c1c7c0d5: [analyzer] Introduce small improvements to the solver infra (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82381/new/

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

This revision was automatically updated to reflect the committed changes. Closed by commit rGb13d9878b8dc: [analyzer][solver] Track symbol equivalence (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D82445?vs=275981&id=279746#toc Repository: rG LLVM Github Monorep

[Differential] D83286: [analyzer][solver] Track symbol disequalities

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe63b488f2755: [analyzer][solver] Track symbol disequalities (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D83286?vs=

[Differential] D82445: [analyzer][solver] Track symbol equivalence

This revision was automatically updated to reflect the committed changes. Closed by commit rGb13d9878b8dc: [analyzer][solver] Track symbol equivalence (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D82445?vs=275981&id=279081#toc Repository: rG LLVM Github Monorep

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

This revision was automatically updated to reflect the committed changes. Closed by commit rGe63b488f2755: [analyzer][solver] Track symbol disequalities (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D83286?vs=276729&id=279747#toc Repository: rG LLVM Github Monor

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added a comment. The features refers to the code completion signals in https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/Quality.h These signals are currently used to map the code completion candidates to a relevance score using hand-coded heuristics. We intend

[clang-tools-extra] 3975c3b - [clangd] Fix conversion from Windows UNC paths to file URI format.

Author: Ilya Golovenko Date: 2020-07-22T12:13:09+02:00 New Revision: 3975c3be80412bb6b1376bcef53ebce53984ddd7 URL: https://github.com/llvm/llvm-project/commit/3975c3be80412bb6b1376bcef53ebce53984ddd7 DIFF: https://github.com/llvm/llvm-project/commit/3975c3be80412bb6b1376bcef53ebce53984ddd7.diff

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3975c3be8041: [clangd] Fix conversion from Windows UNC paths to file URI format. (authored by walrus, committed by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D84226: [AST][RecoveryExpr] Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 279751. hokein added a comment. Herald added a subscriber: dang. Add a cc1 flag to enable building dependent nodes in C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226

[PATCH] D84180: [Matrix] Add LowerMatrixIntrinsics to the NPM

fhahn added a comment. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84180/new/ https://reviews.llvm.org/D84180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX updated this revision to Diff 279754. ArcsinX added a comment. [macOS] Fix `background-index.test` failure, don't create `*-e` files during `background-index.test` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.ll

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX added a comment. I believe it's okay now on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D84303: [analyzer][tests] Fix SATest update functionality

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Not all projects in the p

[PATCH] D84304: [AST][RecoveryExpr] Build dependent callexpr in C for error-recovery.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84304 Files: clang/lib/Sema/SemaExpr.cpp clang/test/AST/ast-dump-recovery.c clang/test/Sema/error-dependence.c Index: clang/tes

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

riccibruno created this revision. riccibruno added a reviewer: MyDeveloperDay. riccibruno added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. The underlying ABI forces `FormatToken` to have a lot of padding. Currently (on x86-64 linux) `sizeof(For

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a subscriber: walrus. ilya-golovenko added a comment. @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is my not-used-anymore account... By the way, do you know is it possible to delete my unused account @walrus to avoid such confusions in future?

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:6 +# RUN: sed -e "s|DIRECTORY|%/t|" %/t/definition.jsonrpc > %/t/definition.jsonrpc.1 +# RUN: sed -i.bak -e "s|DIRECTORY|%/t|" %/t/compile_commands.json +# On Windows, we need the URI

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

protze.joachim added a comment. Starting with the commit of this patch, the libomptarget test `llvm-project/openmp/libomptarget/test/offloading/target_depend_nowait.cpp` fails. Here is a stacktrace of the segfault: $ gdb target_depend_nowait.cpp.tmp-x86_64-pc-linux-gnu (gdb) run ... Pro

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

kbobyrev added a comment. In D84172#2166448 , @ilya-golovenko wrote: > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is > my not-used-anymore account... > By the way, do you know is it possible to delete my unused account @w

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:6 +# RUN: sed -e "s|DIRECTORY|%/t|" %/t/definition.jsonrpc > %/t/definition.jsonrpc.1 +# RUN: sed -i.bak -e "s|DIRECTORY|%/t|" %/t/compile_com

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

walrus added a comment. In D84172#2166496 , @kbobyrev wrote: > In D84172#2166448 , @ilya-golovenko > wrote: > > > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus > > is my not-used-anymo

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. In D84172#2166496 , @kbobyrev wrote: > In D84172#2166448 , @ilya-golovenko > wrote: > > > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus > > is my not-us

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:6 +# RUN: sed -e "s|DIRECTORY|%/t|" %/t/definition.jsonrpc > %/t/definition.jsonrpc.1 +# RUN: sed -i.bak -e "s|DIRECTORY|%/t|" %/t/compile_commands.json +# On Windows, we need the URI

[PATCH] D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

ro added a comment. This patch introduced a couple of failures on the Solaris buildbots (Solaris/sparcv9 and Solaris/x86 ). E.g. FAIL: Clang :: Driver/env.c (12768 of 69452)

[PATCH] D84310: [libTooling] Add assorted `EditGenerator` combinators.

ymandel created this revision. ymandel added reviewers: asoffer, gribozavr2. Herald added a project: clang. This patch adds various combinators that help in constructing `EditGenerator`s: - `noEdits` - `ifBound`, specialized to `ASTEdit` - `flatten` and `flattenVector` which allow for easy constr

[PATCH] D84310: [libTooling] Add assorted `EditGenerator` combinators.

ymandel updated this revision to Diff 279771. ymandel added a comment. revert unrelated change in `RangeSelector.h` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84310/new/ https://reviews.llvm.org/D84310 Files: clang/include/clang/Tooling/Trans

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX updated this revision to Diff 279781. ArcsinX added a comment. Get rid of `-i` `sed` option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 Files: clang-tools-extra/clangd/test/Inputs/background-i

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:6 +# RUN: sed -e "s|DIRECTORY|%/t|" %/t/definition.jsonrpc > %/t/definition.jsonrpc.1 +# RUN: sed -i.bak -e "s|DIRECTORY|%/t|" %/t/compile_com

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

kbobyrev added a comment. In D84172#2166503 , @ilya-golovenko wrote: > In D84172#2166496 , @kbobyrev wrote: > > > In D84172#2166448 , > > @ilya-golovenko wrote: > > > > > @

[PATCH] D84315: [libTooling] Add a `between` range-selector combinator.

ymandel created this revision. ymandel added reviewers: asoffer, gribozavr2. Herald added a project: clang. Adds the `between` combinator and registers it with the parser. As a driveby, updates some deprecated names to their current versions. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus added a comment. Ouch. Let me know how severe this is, because this is a big milestone in my project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82598/new/ https://reviews.llvm.org/D82598 ___

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet accepted this revision. kadircet added a comment. thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 ___ cfe-commits mailing list cfe-commit

[PATCH] D83759: [clangd] Fixes in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG98b56c09be00: [clangd] Fixes in lit tests (authored by ArcsinX). Changed prior to commit: https://reviews.llvm.org/D83759?vs=279781&id=279789#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang-tools-extra] 98b56c0 - [clangd] Fixes in lit tests

Author: Aleksandr Platonov Date: 2020-07-22T16:00:34+03:00 New Revision: 98b56c09be002855df18dada7debdb1322aad7d9 URL: https://github.com/llvm/llvm-project/commit/98b56c09be002855df18dada7debdb1322aad7d9 DIFF: https://github.com/llvm/llvm-project/commit/98b56c09be002855df18dada7debdb1322aad7d9.

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

Meinersbur added a comment. In D83261#2162561 , @ABataev wrote: > 1. OMPChildren class uses standard TrailingObjects harness instead of manual > calculation. Note that that having a separate object defeats the purpose of `TrailingObjects` of having jus

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

ABataev added a comment. In D83261#2166766 , @Meinersbur wrote: > In D83261#2162561 , @ABataev wrote: > > > 1. OMPChildren class uses standard TrailingObjects harness instead of > > manual calculation. > > > Note t

[PATCH] D84322: [AST][RecoveryExpr] Suppress spurious "typecheck_cond_expect_scalar" diagnostic

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84322 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/error-dependence.c Index: clang/test/Sema/error-dependence.c ===

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/malloc-plist.c:137-139 if (y) -y++; -}//expected-warning{{Potential leak}} + y++; //expected-warning{{Potential leak}} +} NoQ wrote: > Thi

[PATCH] D84322: [AST][RecoveryExpr] Suppress spurious "typecheck_cond_expect_scalar" diagnostic

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:8076 + (Cond.get()->isTypeDependent() || LHS.get()->isTypeDependent() || + RHS.get()->isTypeDependent())) { +assert(!getLangOpts().CPlusPlus); ---

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. In D67833#2166478 , @protze.joachim wrote: > Starting with the commit of this patch, the libomptarget test > `llvm-project/openmp/libomptarget/test/offloading/target_depend_nowait.cpp` > fails. Here is a stacktrace of the segfaul

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I'd like to see some testcases for the C++ side of this. The following things all seem like they might be interesting: passing and returning classes and unions, especially ones that

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2110 + DetermineNoUndef(RetTy, getTypes(), DL, RetAI)) { +RetAttrs.addAttribute(llvm::Attribute::NoUndef); + } rsmith wrote: > This only applies in C++. In C, it's valid for a functi

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske added a comment. Every other test failure comes from RetainCount checker except //malloc-plist.c//. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83961/new/ https://reviews.llvm.org/D83961 __

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Although I'm not the most experienced one here, I think it's good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83660/new/ https://re

[clang] b99898c - Fix target specific InstCombine

Author: Sebastian Neubauer Date: 2020-07-22T17:00:46+02:00 New Revision: b99898c1e9c5d8bade1d898e84604d3241b0087c URL: https://github.com/llvm/llvm-project/commit/b99898c1e9c5d8bade1d898e84604d3241b0087c DIFF: https://github.com/llvm/llvm-project/commit/b99898c1e9c5d8bade1d898e84604d3241b0087c.

[clang] 238bbd4 - Revert abd45154b "[Coverage] Add comment to skipped regions"

Author: Hans Wennborg Date: 2020-07-22T17:09:20+02:00 New Revision: 238bbd48c5a5f84deca36e5df980241578f7c1df URL: https://github.com/llvm/llvm-project/commit/238bbd48c5a5f84deca36e5df980241578f7c1df DIFF: https://github.com/llvm/llvm-project/commit/238bbd48c5a5f84deca36e5df980241578f7c1df.diff

[PATCH] D83592: [Coverage] Add comment to skipped regions

hans added a comment. This caused asserts in Chromium's coverage builds: https://bugs.chromium.org/p/chromium/issues/detail?id=1108352 I've reverted it in the meantime (238bbd48c5a5f84deca36e5df980241578f7c1df ). It also looks

[clang] 89e61e7 - [Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

Author: Cullen Rhodes Date: 2020-07-22T16:26:23Z New Revision: 89e61e782b7366083efc6a3c8c54602ddf2dfe8b URL: https://github.com/llvm/llvm-project/commit/89e61e782b7366083efc6a3c8c54602ddf2dfe8b DIFF: https://github.com/llvm/llvm-project/commit/89e61e782b7366083efc6a3c8c54602ddf2dfe8b.diff LOG:

[Differential] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG89e61e782b73: [Sema][AArch64] Add semantics for arm_sve_vector_bits attribute (authored by c-rhodes). Changed prior to co

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG89e61e782b73: [Sema][AArch64] Add semantics for arm_sve_vector_bits attribute (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83551/new

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane updated this revision to Diff 279847. erichkeane marked an inline comment as done. erichkeane added a comment. As CWG seems unmoved by my argument as to why CWG2303 should change, I've opted to implement it as worded. As you can see, the implementation is somewhat more complicated, b

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

arichardson updated this revision to Diff 279861. arichardson added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78491/new/ https://reviews.llvm.org/D78491 Files: clang/lib/CodeGen/CGOpenMPRuntime.h llvm/include/llvm/Analys

[PATCH] D84341: Implement __builtin_eh_return_data_regno for SystemZ

slavek-kucera created this revision. slavek-kucera added a reviewer: uweigand. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement __builtin_eh_return_data_regno for SystemZ. Match behavior of GCC. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8434

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

sepavloff created this revision. sepavloff added reviewers: rjmccall, mibintc. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: clang. This change allow a CallExpr to have optional FPOptionsOverride object, stored in trailing storage. The implementaion i

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

riccibruno added inline comments. Comment at: clang/test/AST/ast-dump-fpfeatures.cpp:1 +// RUN: %clang_cc1 -fsyntax-only %s -std=c++11 -ast-dump | FileCheck %s + Can you also test the serialization by round-tripping through a PCH (see the other AST dump tests fo

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson created this revision. arichardson added a reviewer: arsenm. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. Herald added projects: clang, LLVM. This will ensure that passes that add new global

[PATCH] D84341: Implement __builtin_eh_return_data_regno for SystemZ

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM with the format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84341/new/ https://reviews.llvm.org/D84341

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arsenm added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); I would expect datalayout upg

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

NoQ added a comment. In D83660#2149470 , @OikawaKirie wrote: > It seems to be better to write a checker to report assertion failures. No no no. No no no no no. Assertions don't say "the program crashes if this happens", assertions say "this doesn't happ

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

NoQ added a comment. In D83660#2166917 , @steakhal wrote: > Although I'm not the most experienced one here, I think it's good to go. Let's wait for the test to be added, sounds like it's close. (@OikawaKirie, you can use delta debugging tools like `cred

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson marked an inline comment as done. arichardson added a subscriber: akhuang. arichardson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empt

[clang-tools-extra] 1c7037a - [clangd] Disable -Wsuggest-override for unittests/

Author: Logan Smith Date: 2020-07-22T10:49:09-07:00 New Revision: 1c7037a2a5576d0bb083db10ad947a8308e61f65 URL: https://github.com/llvm/llvm-project/commit/1c7037a2a5576d0bb083db10ad947a8308e61f65 DIFF: https://github.com/llvm/llvm-project/commit/1c7037a2a5576d0bb083db10ad947a8308e61f65.diff L

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84348 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

vsavchenko added a comment. In D83660#2167391 , @NoQ wrote: > In D83660#2166917 , @steakhal wrote: > > > Although I'm not the most experienced one here, I think it's good to go. > > > Let's wait for the test to be a

[clang] 3eec657 - Revert "Enable -Wsuggest-override in the LLVM build" and the follow-ups.

Author: Hans Wennborg Date: 2020-07-22T20:23:58+02:00 New Revision: 3eec65782575a1284391e447142fd004dd5de4a9 URL: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9 DIFF: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9.diff

[clang-tools-extra] 3eec657 - Revert "Enable -Wsuggest-override in the LLVM build" and the follow-ups.

Author: Hans Wennborg Date: 2020-07-22T20:23:58+02:00 New Revision: 3eec65782575a1284391e447142fd004dd5de4a9 URL: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9 DIFF: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9.diff

  1   2   >