kadircet added a comment. In D83759#2165974 <https://reviews.llvm.org/D83759#2165974>, @ArcsinX wrote:
> Seem the problem is in `-i` option. > According with OSX man: > `sed [-Ealn] command [file ... ]` > `sed [-Ealn] [-e command] [-f command_file] [-i extension] [file ...]`. > > Seems on macOS `-E` is treated as an argument for `-i` in command like `sed > -i -E -e ...` . > > Also, seems commands like `sed -i -e ...` are unsafe on macOS. Such commands > will create backup with name `<filename>-e`, but I do not have macOS to check > it. > @thakis could you please verify that after tests you have extra > `<filename>-e` files in > `/Users/thakis/src/llvm-project/out/gn/obj/clang-tools-extra/clangd/test/Output/background-index.test.tmp/` > ? > > I think we could avoid `-i` usage to fix this problem. your diagnosis seems correct. in addition to avoiding -i altogether, you can try passing a value to it. e.g. `sed -i.bak` then both linux and macos should hopefully pick it up and the following `-e` should be interpreted correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
