vsavchenko added a comment. In D83660#2167391 <https://reviews.llvm.org/D83660#2167391>, @NoQ wrote:
> In D83660#2166917 <https://reviews.llvm.org/D83660#2166917>, @steakhal wrote: > > > Although I'm not the most experienced one here, I think it's good to go. > > > Let's wait for the test to be added, sounds like it's close. > > (@OikawaKirie, you can use delta debugging tools like `creduce` or `delta` to > automatically write test cases for crashes) +1 for the test. It's not like we don't trust the fix, it is pretty obvious. However, it would be good to cover it for the future because it might help with tests around this area of code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83660/new/ https://reviews.llvm.org/D83660 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
