kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/test/background-index.test:6 +# RUN: sed -e "s|DIRECTORY|%/t|" %/t/definition.jsonrpc > %/t/definition.jsonrpc.1 +# RUN: sed -i.bak -e "s|DIRECTORY|%/t|" %/t/compile_commands.json +# On Windows, we need the URI in didOpen to look like "uri":"file:///C:/..." ---------------- i don't think there's much point in dropping `-i` from only some commands. I would suggest either: - dropping it from all, by changing the original files to have a `.tmpl` suffix, and dropping the suffix in sed'd versions - keeping it for all comments by adding a `-i.bak` to all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
